syzbot


BUG: unable to handle kernel NULL pointer dereference in tc_bind_tclass

Status: fixed on 2019/10/09 10:54
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+21b29db13c065852f64b@syzkaller.appspotmail.com
Fix commit: 8b142a00edcf net_sched: check cops->tcf_block in tc_bind_tclass()
First crash: 1725d, last: 1715d
Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: divide error in red_change (log)
Repro: C syz .config
  
Discussions (5)
Title Replies (including bot) Last reply
[PATCH 4.14 00/95] 4.14.152-stable review 102 (102) 2019/11/05 23:37
[PATCH 4.19 00/63] 4.19.76-stable review 83 (83) 2019/10/02 13:16
[PATCH 5.2 00/45] 5.2.18-stable review 54 (54) 2019/10/01 22:58
[Patch net] net_sched: check cops->tcf_block in tc_bind_tclass() 2 (2) 2019/09/10 17:29
BUG: unable to handle kernel NULL pointer dereference in tc_bind_tclass 0 (1) 2019/09/08 06:08
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 BUG: unable to handle kernel NULL pointer dereference in tc_bind_tclass C done 14 1684d 1724d 1/1 fixed on 2019/12/12 17:16
linux-4.19 BUG: unable to handle kernel NULL pointer dereference in tc_bind_tclass C done 18 1706d 1725d 1/1 fixed on 2019/12/09 13:28

Sample crash report:
8021q: adding VLAN 0 to HW filter on device batadv0
BUG: kernel NULL pointer dereference, address: 0000000000000000
#PF: supervisor instruction fetch in kernel mode
#PF: error_code(0x0010) - not-present page
PGD a9ba0067 P4D a9ba0067 PUD a7851067 PMD 0 
Oops: 0010 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 8672 Comm: syz-executor994 Not tainted 5.3.0-rc7+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:0x0
Code: Bad RIP value.
RSP: 0018:ffff888097fb74d8 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: ffffffff884a7740 RCX: ffffffff85b55676
RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff8880a4cd7400
RBP: ffff888097fb75d0 R08: ffff88808dc2e440 R09: ffff888097fb7658
R10: ffffed1012ff6ed9 R11: ffff888097fb76cf R12: ffff8880a4cd7400
R13: 0000000000000001 R14: ffff888097fb75a8 R15: ffffffff884a7740
FS:  0000555556952880(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 000000009c578000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 tc_bind_tclass+0x13e/0x2f0 net/sched/sch_api.c:1923
 tc_ctl_tclass+0xadb/0xcd0 net/sched/sch_api.c:2059
 rtnetlink_rcv_msg+0x463/0xb00 net/core/rtnetlink.c:5223
 netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477
 rtnetlink_rcv+0x1d/0x30 net/core/rtnetlink.c:5241
 netlink_unicast_kernel net/netlink/af_netlink.c:1302 [inline]
 netlink_unicast+0x531/0x710 net/netlink/af_netlink.c:1328
 netlink_sendmsg+0x8a5/0xd60 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:637 [inline]
 sock_sendmsg+0xd7/0x130 net/socket.c:657
 ___sys_sendmsg+0x803/0x920 net/socket.c:2311
 __sys_sendmsg+0x105/0x1d0 net/socket.c:2356
 __do_sys_sendmsg net/socket.c:2365 [inline]
 __se_sys_sendmsg net/socket.c:2363 [inline]
 __x64_sys_sendmsg+0x78/0xb0 net/socket.c:2363
 do_syscall_64+0xfd/0x6a0 arch/x86/entry/common.c:296
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x441cd9
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 10 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffc9938bcf8 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000315f6576616c RCX: 0000000000441cd9
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000005
RBP: 735f656764697262 R08: 0000000001bbbbbb R09: 0000000001bbbbbb
R10: 0000000001bbbbbb R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000403270 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
CR2: 0000000000000000
---[ end trace d5605e2bdb92fab7 ]---
RIP: 0010:0x0
Code: Bad RIP value.
RSP: 0018:ffff888097fb74d8 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: ffffffff884a7740 RCX: ffffffff85b55676
RDX: 0000000000000000 RSI: 0000000000000001 RDI: ffff8880a4cd7400
RBP: ffff888097fb75d0 R08: ffff88808dc2e440 R09: ffff888097fb7658
R10: ffffed1012ff6ed9 R11: ffff888097fb76cf R12: ffff8880a4cd7400
R13: 0000000000000001 R14: ffff888097fb75a8 R15: ffffffff884a7740
FS:  0000555556952880(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffffffffd6 CR3: 000000009c578000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (61):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/09/06 14:24 net-next-old 0e5b36bc4c1f 040fda58 .config console log report syz C ci-upstream-net-kasan-gce
2019/09/07 13:15 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-root
2019/09/07 12:44 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-root
2019/09/07 12:42 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce
2019/09/07 12:08 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce
2019/09/07 11:56 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-root
2019/09/07 11:18 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce
2019/09/07 10:43 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce
2019/09/07 10:06 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce
2019/09/07 06:30 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-root
2019/09/07 03:34 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-smack-root
2019/09/07 03:30 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/09/07 02:46 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-smack-root
2019/09/07 02:41 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/09/07 02:17 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-smack-root
2019/09/07 02:11 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/09/07 01:42 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-smack-root
2019/09/07 01:24 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-selinux-root
2019/09/06 14:00 upstream 3b47fd5ca9ea 040fda58 .config console log report syz ci-upstream-kasan-gce
2019/09/07 10:01 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-386
2019/09/07 09:23 upstream 1e3778cb223e a60cb4cd .config console log report syz ci-upstream-kasan-gce-386
2019/09/07 03:11 upstream 044597100037 a60cb4cd .config console log report syz ci-upstream-kasan-gce-386
2019/09/07 16:41 net-old 0c04eb72d332 a60cb4cd .config console log report syz ci-upstream-net-this-kasan-gce
2019/09/07 16:09 net-old 0c04eb72d332 a60cb4cd .config console log report syz ci-upstream-net-this-kasan-gce
2019/09/07 15:22 net-old 0c04eb72d332 a60cb4cd .config console log report syz ci-upstream-net-this-kasan-gce
2019/09/07 14:53 net-old 0c04eb72d332 a60cb4cd .config console log report syz ci-upstream-net-this-kasan-gce
2019/09/07 11:30 net-next-old 1e46c09ec100 a60cb4cd .config console log report syz ci-upstream-net-kasan-gce
2019/09/07 10:41 net-next-old 1e46c09ec100 a60cb4cd .config console log report syz ci-upstream-net-kasan-gce
2019/09/07 10:09 net-next-old 1e46c09ec100 a60cb4cd .config console log report syz ci-upstream-net-kasan-gce
2019/09/07 22:32 linux-next 6d028043b55e a60cb4cd .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/07 21:12 linux-next 6d028043b55e a60cb4cd .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/07 20:16 linux-next 6d028043b55e a60cb4cd .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/07 19:46 linux-next 6d028043b55e a60cb4cd .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/07 19:16 linux-next 6d028043b55e a60cb4cd .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/06 14:13 linux-next 6d028043b55e 040fda58 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2019/09/14 08:25 upstream a7f89616b737 32d59357 .config console log report ci-upstream-kasan-gce-root
2019/09/12 12:52 upstream 3120b9a6a3f7 f4e53c10 .config console log report ci-upstream-kasan-gce
2019/09/07 23:59 upstream 1e3778cb223e a60cb4cd .config console log report ci-upstream-kasan-gce
2019/09/06 13:08 upstream 3b47fd5ca9ea 040fda58 .config console log report ci-upstream-kasan-gce-smack-root
2019/09/06 13:01 upstream 3b47fd5ca9ea 040fda58 .config console log report ci-upstream-kasan-gce
2019/09/06 13:15 net-old 7bdf4de12677 040fda58 .config console log report ci-upstream-net-this-kasan-gce
2019/09/06 13:00 net-old 7bdf4de12677 040fda58 .config console log report ci-upstream-net-this-kasan-gce
2019/09/16 02:37 net-next-old a3d3c74da49c 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/16 02:03 net-next-old a3d3c74da49c 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/15 07:05 net-next-old 1ba569fc2250 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/15 05:51 net-next-old 1ba569fc2250 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/15 04:46 net-next-old 1ba569fc2250 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/14 21:37 net-next-old 1ba569fc2250 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/14 13:25 net-next-old 1ba569fc2250 32d59357 .config console log report ci-upstream-net-kasan-gce
2019/09/13 12:24 net-next-old 172ca8308b05 40fa42bc .config console log report ci-upstream-net-kasan-gce
2019/09/12 22:53 net-next-old 172ca8308b05 0b7672ee .config console log report ci-upstream-net-kasan-gce
2019/09/09 02:06 net-next-old 6703a605b5ab a60cb4cd .config console log report ci-upstream-net-kasan-gce
2019/09/08 21:42 net-next-old 6703a605b5ab a60cb4cd .config console log report ci-upstream-net-kasan-gce
2019/09/08 16:04 net-next-old 6703a605b5ab a60cb4cd .config console log report ci-upstream-net-kasan-gce
2019/09/07 20:00 net-next-old 742ca7812bcc a60cb4cd .config console log report ci-upstream-net-kasan-gce
2019/09/07 19:39 net-next-old 742ca7812bcc a60cb4cd .config console log report ci-upstream-net-kasan-gce
2019/09/06 13:02 net-next-old 0e5b36bc4c1f 040fda58 .config console log report ci-upstream-net-kasan-gce
2019/09/06 13:17 linux-next 6d028043b55e 040fda58 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.