KASAN: use-after-free Read in tls_wait_data

Status: fixed on 2019/08/27 17:15
Subsystems: net
[Documentation on labels]
Fix commit: 5d92e631b8be net/tls: partially revert fix transition through disconnect with close
First crash: 1590d, last: 1590d
Discussions (1)
Title Replies (including bot) Last reply
KASAN: use-after-free Read in tls_wait_data 1 (2) 2019/08/09 00:20

Sample crash report:
BUG: KASAN: use-after-free in tls_wait_data+0x884/0x980 net/tls/tls_sw.c:1261
Read of size 8 at addr ffff88808ea9f890 by task syz-executor.2/31898

CPU: 1 PID: 31898 Comm: syz-executor.2 Not tainted 5.3.0-rc2-next-20190802 #58
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 print_address_description.cold+0xd4/0x306 mm/kasan/report.c:351
 __kasan_report.cold+0x1b/0x36 mm/kasan/report.c:482
 kasan_report+0x12/0x17 mm/kasan/common.c:610
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/generic_report.c:132
 tls_wait_data+0x884/0x980 net/tls/tls_sw.c:1261
 tls_sw_recvmsg+0x57d/0x17c0 net/tls/tls_sw.c:1730
 inet_recvmsg+0x136/0x620 net/ipv4/af_inet.c:838
 sock_recvmsg_nosec+0x89/0xb0 net/socket.c:871
 ___sys_recvmsg+0x271/0x5a0 net/socket.c:2480
 do_recvmmsg+0x27e/0x7a0 net/socket.c:2601
 __sys_recvmmsg+0x259/0x270 net/socket.c:2680
 __do_sys_recvmmsg net/socket.c:2703 [inline]
 __se_sys_recvmmsg net/socket.c:2696 [inline]
 __x64_sys_recvmmsg+0xe6/0x140 net/socket.c:2696
 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290
RIP: 0033:0x459829
Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f6093e3ec78 EFLAGS: 00000246 ORIG_RAX: 000000000000012b
RAX: ffffffffffffffda RBX: 0000000000000005 RCX: 0000000000459829
RDX: 0000000000000004 RSI: 00000000200031c0 RDI: 0000000000000003
RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f6093e3f6d4
R13: 00000000004c6d67 R14: 00000000004dc0a8 R15: 00000000ffffffff

Allocated by task 31898:
 save_stack+0x23/0x90 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_kmalloc mm/kasan/common.c:486 [inline]
 __kasan_kmalloc.constprop.0+0xcf/0xe0 mm/kasan/common.c:459
 kasan_kmalloc+0x9/0x10 mm/kasan/common.c:500
 kmem_cache_alloc_trace+0x158/0x790 mm/slab.c:3550
 kmalloc include/linux/slab.h:552 [inline]
 kzalloc include/linux/slab.h:686 [inline]
 tls_set_sw_offload+0x110a/0x1567 net/tls/tls_sw.c:2243
 do_tls_setsockopt_conf net/tls/tls_main.c:594 [inline]
 do_tls_setsockopt net/tls/tls_main.c:630 [inline]
 tls_setsockopt+0x68d/0x8d0 net/tls/tls_main.c:649
 sock_common_setsockopt+0x94/0xd0 net/core/sock.c:3130
 __sys_setsockopt+0x261/0x4c0 net/socket.c:2084
 __do_sys_setsockopt net/socket.c:2100 [inline]
 __se_sys_setsockopt net/socket.c:2097 [inline]
 __x64_sys_setsockopt+0xbe/0x150 net/socket.c:2097
 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290

Freed by task 17:
 save_stack+0x23/0x90 mm/kasan/common.c:69
 set_track mm/kasan/common.c:77 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/common.c:448
 kasan_slab_free+0xe/0x10 mm/kasan/common.c:456
 __cache_free mm/slab.c:3425 [inline]
 kfree+0x10a/0x2c0 mm/slab.c:3756
 tls_sw_free_ctx_rx+0x31/0x40 net/tls/tls_sw.c:2145
 tls_ctx_free_deferred+0xc4/0x130 net/tls/tls_main.c:279
 process_one_work+0x9af/0x1740 kernel/workqueue.c:2269
 worker_thread+0x98/0xe40 kernel/workqueue.c:2415
 kthread+0x361/0x430 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352

The buggy address belongs to the object at ffff88808ea9f680
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 528 bytes inside of
 1024-byte region [ffff88808ea9f680, ffff88808ea9fa80)
The buggy address belongs to the page:
page:ffffea00023aa780 refcount:1 mapcount:0 mapping:ffff8880aa400c40 index:0x0 compound_mapcount: 0
flags: 0x1fffc0000010200(slab|head)
raw: 01fffc0000010200 ffffea000295f888 ffffea00021f7908 ffff8880aa400c40
raw: 0000000000000000 ffff88808ea9e000 0000000100000007 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88808ea9f780: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808ea9f800: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88808ea9f880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808ea9f900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808ea9f980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/08/02 07:27 linux-next 7b4980e0bcf4 835dffe7 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.