syzbot

loop0: detected capacity change from 0 to 1024
hfsplus: inconsistency in B*Tree (1792,1,255,1,0)
hfsplus: xattr searching failed
hfsplus: inconsistency in B*Tree (1792,1,255,1,0)
hfsplus: xattr searching failed
hfsplus: inconsistency in B*Tree (1792,1,255,1,0)
======================================================
WARNING: possible circular locking dependency detected
5.15.131-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor139/3503 is trying to acquire lock:
ffff8880745e0e88 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457

but task is already holding lock:
ffff8880745ea0b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&tree->tree_lock/2){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_find_init+0x146/0x1c0
       hfsplus_attr_exists+0xfb/0x1c0 fs/hfsplus/attributes.c:178
       __hfsplus_setxattr+0x453/0x22c0 fs/hfsplus/xattr.c:336
       hfsplus_setxattr+0xac/0xe0 fs/hfsplus/xattr.c:434
       hfsplus_trusted_setxattr+0x3c/0x50 fs/hfsplus/xattr_trusted.c:30
       __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x21d/0x420 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x27e/0x2e0 fs/xattr.c:611
       path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_file_truncate+0x864/0xb80 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x1b9/0x280 fs/hfsplus/inode.c:267
       notify_change+0xd4d/0x1000 fs/attr.c:489
       do_truncate+0x21c/0x300 fs/open.c:65
       handle_truncate fs/namei.c:3195 [inline]
       do_open fs/namei.c:3542 [inline]
       path_openat+0x28a0/0x2f20 fs/namei.c:3672
       do_filp_open+0x21c/0x460 fs/namei.c:3699
       do_sys_openat2+0x13b/0x500 fs/open.c:1211
       do_sys_open fs/open.c:1227 [inline]
       __do_sys_openat fs/open.c:1243 [inline]
       __se_sys_openat fs/open.c:1238 [inline]
       __x64_sys_openat+0x243/0x290 fs/open.c:1238
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357
       hfsplus_create_attr+0x1c4/0x630 fs/hfsplus/attributes.c:221
       __hfsplus_setxattr+0x6ed/0x22c0 fs/hfsplus/xattr.c:354
       hfsplus_setxattr+0xac/0xe0 fs/hfsplus/xattr.c:434
       hfsplus_trusted_setxattr+0x3c/0x50 fs/hfsplus/xattr_trusted.c:30
       __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
       __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
       vfs_setxattr+0x21d/0x420 fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x27e/0x2e0 fs/xattr.c:611
       path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
       __do_sys_lsetxattr fs/xattr.c:653 [inline]
       __se_sys_lsetxattr fs/xattr.c:649 [inline]
       __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

Chain exists of:
  &HFSPLUS_I(inode)->extents_lock --> &tree->tree_lock --> &tree->tree_lock/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock/2);
                               lock(&tree->tree_lock);
                               lock(&tree->tree_lock/2);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz-executor139/3503:
 #0: ffff88807862e460 (sb_writers#9){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377
 #1: ffff888078021080 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff888078021080 (&sb->s_type->i_mutex_key#15){+.+.}-{3:3}, at: vfs_setxattr+0x1dd/0x420 fs/xattr.c:302
 #2: ffff88807800c0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0
 #3: ffff8880745ea0b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x146/0x1c0

stack backtrace:
CPU: 0 PID: 3503 Comm: syz-executor139 Not tainted 5.15.131-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/04/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x101/0x4e0 fs/hfsplus/btree.c:357
 hfsplus_create_attr+0x1c4/0x630 fs/hfsplus/attributes.c:221
 __hfsplus_setxattr+0x6ed/0x22c0 fs/hfsplus/xattr.c:354
 hfsplus_setxattr+0xac/0xe0 fs/hfsplus/xattr.c:434
 hfsplus_trusted_setxattr+0x3c/0x50 fs/hfsplus/xattr_trusted.c:30
 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182
 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216
 vfs_setxattr+0x21d/0x420 fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x27e/0x2e0 fs/xattr.c:611
 path_setxattr+0x1bc/0x2a0 fs/xattr.c:630
 __do_sys_lsetxattr fs/xattr.c:653 [inline]
 __se_sys_lsetxattr fs/xattr.c:649 [inline]
 __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:649
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f8a88541a99
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc6e8bb0d8 EFLAGS: 00000246 ORIG_RAX: 00000000000000bd
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f8a88541a99
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000020000040
RBP: 00007f8a885b55f0 R08: 0000000000000000 R09: 000055555634d4c0
R10: 0000000000000000 R11: 0000000000000246 R12: 00007ffc6e8bb100
R13: 00007ffc6e8bb328 R14: 431bde82d7b634db R15: 00007f8a8858a03b
 </TASK>
hfsplus: inconsistency in B*Tree (2,0,1,0,1)