syzbot


possible deadlock in hfsplus_file_extend

Status: upstream: reported C repro on 2022/11/26 10:00
Subsystems: hfsplus
[Documentation on labels]
Reported-by: syzbot+3a4301a9b1b8b62c34e3@syzkaller.appspotmail.com
First crash: 503d, last: 403d
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_file_extend origin:upstream C 1037 7m 396d 0/3 upstream: reported C repro on 2023/03/13 14:24
linux-4.14 possible deadlock in hfsplus_file_extend hfsplus C 3 404d 470d 0/1 upstream: reported C repro on 2022/12/29 06:07
linux-5.15 possible deadlock in hfsplus_file_extend missing-backport origin:lts-only C 1042 8m 397d 0/3 upstream: reported C repro on 2023/03/11 17:12
upstream possible deadlock in hfsplus_file_extend hfs C error 11863 9m 503d 0/26 upstream: reported C repro on 2022/11/26 08:07

Sample crash report:
======================================================
WARNING: the mand mount option is being deprecated and
         will be removed in v5.15!
======================================================
============================================
WARNING: possible recursive locking detected
4.19.211-syzkaller #0 Not tainted
--------------------------------------------
syz-executor237/8096 is trying to acquire lock:
00000000c332e86b (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457

but task is already holding lock:
0000000086464514 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

4 locks held by syz-executor237/8096:
 #0: 00000000bbc7cafe (sb_writers#11){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline]
 #0: 00000000bbc7cafe (sb_writers#11){.+.+}, at: do_sys_ftruncate+0x297/0x560 fs/open.c:189
 #1: 00000000ff4bafdd (&sb->s_type->i_mutex_key#17){+.+.}, at: inode_lock include/linux/fs.h:748 [inline]
 #1: 00000000ff4bafdd (&sb->s_type->i_mutex_key#17){+.+.}, at: do_truncate+0x125/0x1f0 fs/open.c:61
 #2: 0000000086464514 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
 #3: 00000000f5e68561 (&tree->tree_lock/1){+.+.}, at: hfsplus_find_init+0x170/0x220 fs/hfsplus/bfind.c:33

stack backtrace:
CPU: 0 PID: 8096 Comm: syz-executor237 Not tainted 4.19.211-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_deadlock_bug kernel/locking/lockdep.c:1764 [inline]
 check_deadlock kernel/locking/lockdep.c:1808 [inline]
 validate_chain kernel/locking/lockdep.c:2404 [inline]
 __lock_acquire.cold+0x121/0x57e kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 __mutex_lock_common kernel/locking/mutex.c:937 [inline]
 __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078
 hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0x298/0x440 fs/hfsplus/btree.c:357
 __hfsplus_ext_write_extent+0x45b/0x5a0 fs/hfsplus/extents.c:104
 __hfsplus_ext_cache_extent fs/hfsplus/extents.c:186 [inline]
 hfsplus_ext_read_extent+0x910/0xab0 fs/hfsplus/extents.c:218
 hfsplus_file_extend+0x672/0xf40 fs/hfsplus/extents.c:461
 hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978
 __block_write_begin fs/buffer.c:2028 [inline]
 block_write_begin+0x58/0x2e0 fs/buffer.c:2087
 cont_write_begin+0x55a/0x820 fs/buffer.c:2440
 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52
 cont_expand_zero fs/buffer.c:2367 [inline]
 cont_write_begin+0x2ee/0x820 fs/buffer.c:2430
 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52
 generic_cont_expand_simple+0x106/0x170 fs/buffer.c:2331
 hfsplus_setattr+0x18b/0x310 fs/hfsplus/inode.c:257
 notify_change+0x70b/0xfc0 fs/attr.c:334
 do_truncate+0x134/0x1f0 fs/open.c:63
 do_sys_ftruncate+0x492/0x560 fs/open.c:194
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x7f159ab94799
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 51 14 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff6d5329f8 EFLAGS: 00000246 ORIG_RAX: 000000000000004d
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f159ab94799
RDX: 0000000000000000 RSI: 0000000002007ffb RDI: 0000000000000004

Crashes (258):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2022/12/31 09:12 linux-4.19.y 3f8a27f9e27b ab32d508 .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2022/12/03 16:45 linux-4.19.y 3f8a27f9e27b e080de16 .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2022/12/02 07:16 linux-4.19.y 3f8a27f9e27b e080de16 .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2022/11/26 09:59 linux-4.19.y 3f8a27f9e27b f4470a7b .config console log report syz C [disk image] [vmlinux] [mounted in repro] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/06 08:23 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/06 05:00 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/06 01:20 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/05 19:13 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/05 15:23 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/05 06:56 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/05 02:53 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/04 20:42 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/03 11:51 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/03 09:06 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/01 22:49 linux-4.19.y 3f8a27f9e27b f8902b57 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/01 06:32 linux-4.19.y 3f8a27f9e27b 95aee97a .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/03/01 03:48 linux-4.19.y 3f8a27f9e27b 95aee97a .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/28 08:48 linux-4.19.y 3f8a27f9e27b 95aee97a .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/26 09:00 linux-4.19.y 3f8a27f9e27b ee50e71c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/25 17:43 linux-4.19.y 3f8a27f9e27b ee50e71c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/25 02:15 linux-4.19.y 3f8a27f9e27b ee50e71c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/24 21:51 linux-4.19.y 3f8a27f9e27b ee50e71c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/23 07:14 linux-4.19.y 3f8a27f9e27b 9f1e2cb3 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/22 06:15 linux-4.19.y 3f8a27f9e27b 42a4d508 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/22 04:49 linux-4.19.y 3f8a27f9e27b 42a4d508 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/21 02:02 linux-4.19.y 3f8a27f9e27b 2414209c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/20 20:00 linux-4.19.y 3f8a27f9e27b 2414209c .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/20 13:48 linux-4.19.y 3f8a27f9e27b bcdf85f8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/20 08:18 linux-4.19.y 3f8a27f9e27b bcdf85f8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/20 02:06 linux-4.19.y 3f8a27f9e27b bcdf85f8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/19 12:44 linux-4.19.y 3f8a27f9e27b bcdf85f8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/19 07:12 linux-4.19.y 3f8a27f9e27b bcdf85f8 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/18 13:13 linux-4.19.y 3f8a27f9e27b d02e9a70 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/17 20:36 linux-4.19.y 3f8a27f9e27b cf8c2d39 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/16 20:47 linux-4.19.y 3f8a27f9e27b 38b317a7 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/16 09:01 linux-4.19.y 3f8a27f9e27b 6be0f1f5 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/15 09:27 linux-4.19.y 3f8a27f9e27b e62ba3c1 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/15 06:05 linux-4.19.y 3f8a27f9e27b e62ba3c1 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/15 04:28 linux-4.19.y 3f8a27f9e27b e62ba3c1 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/13 18:44 linux-4.19.y 3f8a27f9e27b 957959cb .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/13 16:29 linux-4.19.y 3f8a27f9e27b 957959cb .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/13 11:44 linux-4.19.y 3f8a27f9e27b 957959cb .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/13 08:39 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/13 03:52 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/12 15:30 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/12 12:51 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/12 10:07 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/12 02:31 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/11 23:46 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/11 16:23 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/11 01:30 linux-4.19.y 3f8a27f9e27b 93e26d60 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/10 23:05 linux-4.19.y 3f8a27f9e27b e29a17f5 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
2023/02/10 21:20 linux-4.19.y 3f8a27f9e27b e29a17f5 .config console log report info [disk image] [vmlinux] ci2-linux-4-19 possible deadlock in hfsplus_file_extend
* Struck through repros no longer work on HEAD.