syzbot


possible deadlock in hfsplus_file_extend (2)

Status: upstream: reported C repro on 2024/11/11 11:50
Subsystems: hfs
[Documentation on labels]
Reported-by: syzbot+4cba2fd444e9a16ae758@syzkaller.appspotmail.com
First crash: 168d, last: 1d04h
Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: possible deadlock in hfsplus_file_extend (log)
Repro: C syz .config
  
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [hfs?] possible deadlock in hfsplus_file_extend (2) 3 (7) 2024/11/12 05:59
Similar bugs (7)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in hfsplus_file_extend origin:upstream missing-backport C done 2760 265d 773d 3/3 fixed on 2024/09/08 06:54
linux-5.15 possible deadlock in hfsplus_file_extend (2) 7 143d 193d 0/3 auto-obsoleted due to no activity on 2025/03/13 03:31
linux-4.14 possible deadlock in hfsplus_file_extend hfsplus C 3 782d 848d 0/1 upstream: reported C repro on 2022/12/29 06:07
linux-5.15 possible deadlock in hfsplus_file_extend missing-backport origin:lts-only C done 3439 249d 775d 3/3 fixed on 2024/09/23 09:27
linux-4.19 possible deadlock in hfsplus_file_extend hfsplus C 258 781d 880d 0/1 upstream: reported C repro on 2022/11/26 10:00
linux-6.1 possible deadlock in hfsplus_file_extend (2) 2 102d 102d 0/3 auto-obsoleted due to no activity on 2025/04/22 11:08
upstream possible deadlock in hfsplus_file_extend hfs C error done 31659 192d 881d 28/28 fixed on 2024/10/21 12:45
Last patch testing requests (4)
Created Duration User Patch Repo Result
2024/11/21 15:35 13m retest repro upstream report log
2024/11/12 05:39 19m eadavis@qq.com patch upstream OK log
2024/11/11 13:11 13m eadavis@qq.com patch upstream report log
2024/11/11 12:35 14m eadavis@qq.com patch upstream report log

Sample crash report:
hfsplus: xattr searching failed
hfsplus: xattr searching failed
hfsplus: xattr searching failed
hfsplus: xattr searching failed
hfsplus: xattr searching failed
============================================
WARNING: possible recursive locking detected
6.13.0-rc7-syzkaller-00043-g619f0b6fad52 #0 Not tainted
--------------------------------------------
syz-executor794/5820 is trying to acquire lock:
ffff88807f090108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458

but task is already holding lock:
ffff88807f0922c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&HFSPLUS_I(inode)->extents_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

4 locks held by syz-executor794/5820:
 #0: ffff88807f980420 (sb_writers#9){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2964 [inline]
 #0: ffff88807f980420 (sb_writers#9){.+.+}-{0:0}, at: vfs_writev+0x2d1/0xba0 fs/read_write.c:1048
 #1: ffff88807f0924b8 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
 #1: ffff88807f0924b8 (&sb->s_type->i_mutex_key#14){+.+.}-{4:4}, at: generic_file_write_iter+0x82/0x310 mm/filemap.c:4170
 #2: ffff88807f0922c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{4:4}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458
 #3: ffff88807f0140b0 (&tree->tree_lock/1){+.+.}-{4:4}, at: hfsplus_find_init+0x14a/0x1c0 fs/hfsplus/bfind.c:28

stack backtrace:
CPU: 1 UID: 0 PID: 5820 Comm: syz-executor794 Not tainted 6.13.0-rc7-syzkaller-00043-g619f0b6fad52 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_deadlock_bug+0x483/0x620 kernel/locking/lockdep.c:3037
 check_deadlock kernel/locking/lockdep.c:3089 [inline]
 validate_chain+0x15e2/0x5920 kernel/locking/lockdep.c:3891
 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
 __mutex_lock_common kernel/locking/mutex.c:585 [inline]
 __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735
 hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:458
 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358
 __hfsplus_ext_write_extent+0x2a4/0x5c0 fs/hfsplus/extents.c:104
 __hfsplus_ext_cache_extent+0x84/0xe10 fs/hfsplus/extents.c:186
 hfsplus_ext_read_extent fs/hfsplus/extents.c:218 [inline]
 hfsplus_file_extend+0x48c/0x1b70 fs/hfsplus/extents.c:462
 hfsplus_get_block+0x406/0x14f0 fs/hfsplus/extents.c:245
 __block_write_begin_int+0x692/0x19a0 fs/buffer.c:2116
 block_write_begin fs/buffer.c:2226 [inline]
 cont_write_begin+0x77f/0xb40 fs/buffer.c:2577
 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46
 cont_expand_zero fs/buffer.c:2504 [inline]
 cont_write_begin+0x32b/0xb40 fs/buffer.c:2567
 hfsplus_write_begin+0x68/0xb0 fs/hfsplus/inode.c:46
 generic_perform_write+0x346/0x990 mm/filemap.c:4046
 generic_file_write_iter+0xae/0x310 mm/filemap.c:4173
 do_iter_readv_writev+0x600/0x880
 vfs_writev+0x376/0xba0 fs/read_write.c:1050
 do_pwritev fs/read_write.c:1146 [inline]
 __do_sys_pwritev2 fs/read_write.c:1204 [inline]
 __se_sys_pwritev2+0x196/0x2b0 fs/read_write.c:1195
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7349063ad9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc9fcbafb8 EFLAGS: 00000246 ORIG_RAX: 0000000000000148
RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f7349063ad9
RDX: 0000000000000001 RSI: 00000000200002c0 RDI: 0000000000000004
RBP: 00007f73490d75f0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000047fff R11: 0000000000000246 R12: 00007ffc9fcbaff0
R13: 00007ffc9fcbb218 R14: 431bde82d7b634db R15: 00007f73490ac03b
 </TASK>

Crashes (219):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/01/15 11:33 upstream 619f0b6fad52 7315a7cf .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-upstream-fs possible deadlock in hfsplus_file_extend
2024/11/26 12:39 upstream 7eef7e306d3c e9a9a9f2 .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2024/11/07 15:33 upstream ff7afaeca1a1 867e44df .config console log report syz / log C [disk image (non-bootable)] [vmlinux] [kernel image] [mounted in repro] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/01 13:22 upstream 1e7857b28020 36d76a97 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-fs possible deadlock in hfsplus_file_extend
2025/01/12 12:05 upstream b62cef9a5c67 6dbc6a9b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in hfsplus_file_extend
2025/04/24 04:34 upstream a79be02bba5c 9882047a .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/23 00:06 upstream bc3372351d0c 53a8b9bd .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/22 20:24 upstream a33b5a08cbbd 53a8b9bd .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/21 16:43 upstream 9d7a0577c9db 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/21 00:48 upstream 6fea5fabd332 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/20 19:15 upstream 6fea5fabd332 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/19 19:48 upstream 8560697b23dc 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/19 07:01 upstream 3088d26962e8 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/18 07:30 upstream b5c6891b2c5b 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/18 04:56 upstream b5c6891b2c5b 2a20f901 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/17 01:49 upstream c62f4b82d571 a95239b1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/15 12:08 upstream 834a4a689699 85125322 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/14 18:02 upstream 8ffd015db85f 0bd6db41 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/13 18:54 upstream 5aaaedb0cb54 0bd6db41 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/12 09:24 upstream e618ee89561b 0bd6db41 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/11 17:03 upstream 900241a5cc15 12ba9c21 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/11 08:22 upstream 0c7cae12f67c 94486846 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/09 14:43 upstream a24588245776 47d015b1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/09 13:10 upstream a24588245776 47d015b1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/08 04:42 upstream 0af2f6be1b42 a2ada0e7 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/07 16:15 upstream 0af2f6be1b42 2f0c9720 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/07 05:52 upstream 0af2f6be1b42 1c65791e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/05 13:29 upstream a8662bcd2ff1 1c65791e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/05 09:08 upstream a8662bcd2ff1 1c65791e .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/04 00:15 upstream a2cc6ff5ec8f d7ae3a11 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/03 12:14 upstream a1b5bd45d4ee 996a9618 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/01 21:55 upstream 08733088b566 b8645499 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/04/01 18:16 upstream 08733088b566 b8645499 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/31 22:24 upstream 609706855d90 36d76a97 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/30 21:11 upstream 7f2ff7b62617 d3999433 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/30 13:57 upstream 93d52288679e d3999433 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/30 12:01 upstream 93d52288679e d3999433 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/30 09:32 upstream 93d52288679e d3999433 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/29 17:15 upstream 7d06015d936c d3999433 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/25 10:58 upstream 2f2d52945852 875573af .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/24 12:16 upstream 586de92313fc 875573af .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/23 13:18 upstream 183601b78a9b 4e8d3850 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/22 15:58 upstream 88d324e69ea9 c6512ef7 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/19 15:27 upstream 81e4f8d68c66 8d0a2921 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/18 22:55 upstream 76b6905c11fd 22a6c2b1 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/17 06:49 upstream 4701f33a1070 948c34e4 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/16 05:10 upstream eb88e6bfbc0a e2826670 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/15 09:28 upstream 83158b21ae9a e2826670 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/15 02:04 upstream 83158b21ae9a e2826670 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/14 20:17 upstream e3a854b577cb e2826670 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/13 14:00 upstream b7f94fcf5546 44be8b44 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/12 23:12 upstream 0fed89a961ea 1a5d9317 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/12 20:53 upstream 0fed89a961ea 1a5d9317 .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/12 03:39 upstream 0b46b049d6ec ee70e6db .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2025/03/12 02:12 upstream 0b46b049d6ec ee70e6db .config console log report [disk image (non-bootable)] [vmlinux] [kernel image] ci-snapshot-upstream-root possible deadlock in hfsplus_file_extend
2024/11/30 05:19 linux-next f486c8aa16b8 68914665 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in hfsplus_file_extend
2025/02/24 09:32 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci a1c24ab82279 d34966d1 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-gce-arm64 possible deadlock in hfsplus_file_extend
* Struck through repros no longer work on HEAD.