syzbot


possible deadlock in hfsplus_file_extend

Status: upstream: reported C repro on 2023/03/13 14:24
Bug presence: origin:upstream
[Documentation on labels]
Reported-by: syzbot+a9b05956c6ee2e5563cb@syzkaller.appspotmail.com
First crash: 202d, last: 2d01h
Bug presence (1)
Date Name Commit Repro Result
2023/08/11 upstream (ToT) 25aa0bebba72 C [report] possible deadlock in hfsplus_file_extend
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-4.14 possible deadlock in hfsplus_file_extend hfsplus C 3 210d 276d 0/1 upstream: reported C repro on 2022/12/29 06:07
linux-5.15 possible deadlock in hfsplus_file_extend missing-backport origin:lts-only C 256 3d00h 204d 0/3 upstream: reported C repro on 2023/03/11 17:12
linux-4.19 possible deadlock in hfsplus_file_extend hfsplus C 258 209d 309d 0/1 upstream: reported C repro on 2022/11/26 10:00
upstream possible deadlock in hfsplus_file_extend hfs C error 4962 2h29m 309d 0/25 upstream: reported C repro on 2022/11/26 08:07

Sample crash report:
loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.1.44-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor205/4218 is trying to acquire lock:
ffff0000de1107c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457

but task is already holding lock:
ffff0000de0dc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x18c/0x25c fs/hfsplus/inode.c:269
       notify_change+0xc24/0xec0 fs/attr.c:482
       do_truncate+0x1c0/0x28c fs/open.c:65
       handle_truncate fs/namei.c:3216 [inline]
       do_open fs/namei.c:3561 [inline]
       path_openat+0x1fa0/0x2548 fs/namei.c:3714
       do_filp_open+0x1bc/0x3cc fs/namei.c:3741
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       __do_sys_openat2 fs/open.c:1375 [inline]
       __se_sys_openat2 fs/open.c:1353 [inline]
       __arm64_sys_openat2+0x308/0x3b8 fs/open.c:1353
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
       vfs_rename+0x8b8/0xd04 fs/namei.c:4785
       do_renameat2+0x980/0x1040 fs/namei.c:4935
       __do_sys_renameat2 fs/namei.c:4968 [inline]
       __se_sys_renameat2 fs/namei.c:4965 [inline]
       __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz-executor205/4218:
 #0: ffff0000de0d8460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
 #1: ffff0000de111e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #1: ffff0000de111e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename+0xdc/0x198 fs/namei.c:2990
 #2: ffff0000de1124c0 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #2: ffff0000de1124c0 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: lock_two_inodes+0xdc/0x158 fs/inode.c:1143
 #3: ffff0000de0dc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc

stack backtrace:
CPU: 1 PID: 4218 Comm: syz-executor205 Not tainted 6.1.44-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
 vfs_rename+0x8b8/0xd04 fs/namei.c:4785
 do_renameat2+0x980/0x1040 fs/namei.c:4935
 __do_sys_renameat2 fs/namei.c:4968 [inline]
 __se_sys_renameat2 fs/namei.c:4965 [inline]
 __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

Crashes (216):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/08/11 07:32 linux-6.1.y 0a4a7855302d da3c3ef8 .config console log report syz C [disk image] [vmlinux] [kernel image] [mounted in repro] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/29 18:13 linux-6.1.y d23900f974e0 8e26a358 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/29 02:07 linux-6.1.y d23900f974e0 d265efd8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/27 21:10 linux-6.1.y d23900f974e0 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/23 18:10 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/22 19:44 linux-6.1.y a356197db198 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/19 23:37 linux-6.1.y a356197db198 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/19 15:07 linux-6.1.y a356197db198 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/18 11:34 linux-6.1.y 09045dae0d90 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/15 12:17 linux-6.1.y 09045dae0d90 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/13 12:02 linux-6.1.y 09045dae0d90 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/08 21:21 linux-6.1.y 59b13c2b647e 6654cf89 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/07 23:53 linux-6.1.y 59b13c2b647e 72324844 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/06 08:17 linux-6.1.y c2cbfe5f5122 0b6286dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/05 10:38 linux-6.1.y c2cbfe5f5122 0b6286dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/05 06:16 linux-6.1.y c2cbfe5f5122 0b6286dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/03 09:35 linux-6.1.y c2cbfe5f5122 696ea0d2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/01 07:38 linux-6.1.y a2943d2d9a00 696ea0d2 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/09/29 19:44 linux-6.1.y d23900f974e0 8e26a358 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/27 20:01 linux-6.1.y d23900f974e0 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/27 16:16 linux-6.1.y d23900f974e0 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/27 14:37 linux-6.1.y d23900f974e0 2895a507 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/26 22:32 linux-6.1.y d23900f974e0 0b6a67ac .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/11 14:51 linux-6.1.y 59b13c2b647e 59da8366 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/05 16:51 linux-6.1.y c2cbfe5f5122 0b6286dc .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/09/04 16:46 linux-6.1.y c2cbfe5f5122 db3306a6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/30 13:53 linux-6.1.y 024f76bca9d0 84803932 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/25 00:20 linux-6.1.y 802aacbbffe2 49be837e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/22 21:34 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/22 18:53 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/22 01:29 linux-6.1.y 6c44e13dc284 6b415825 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/17 04:14 linux-6.1.y 6c44e13dc284 74b106b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/09 23:04 linux-6.1.y 0a4a7855302d 13ca4cd6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/09 09:10 linux-6.1.y 0a4a7855302d 8ad1a287 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/09 04:41 linux-6.1.y 0a4a7855302d 8ad1a287 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/08 05:52 linux-6.1.y 52a953d0934b b1b6ae3d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan possible deadlock in hfsplus_file_extend
2023/08/29 21:16 linux-6.1.y 024f76bca9d0 ce731e62 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/28 12:52 linux-6.1.y 024f76bca9d0 7ba13a15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/25 13:41 linux-6.1.y 802aacbbffe2 03d9c195 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/23 14:30 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/22 17:31 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/22 14:54 linux-6.1.y 6c44e13dc284 b81ca3f6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/18 23:00 linux-6.1.y 6c44e13dc284 d216d8a0 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/18 14:56 linux-6.1.y 6c44e13dc284 acb1ba71 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/16 22:30 linux-6.1.y 6c44e13dc284 74b106b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/10 10:24 linux-6.1.y 0a4a7855302d 13ca4cd6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/09 01:20 linux-6.1.y 0a4a7855302d 9552ae77 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/08 21:15 linux-6.1.y 0a4a7855302d 9552ae77 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/08/07 19:36 linux-6.1.y 52a953d0934b b1b6ae3d .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
2023/03/13 14:24 linux-6.1.y 6449a0ba6843 026e2200 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-6-1-kasan-arm64 possible deadlock in hfsplus_file_extend
* Struck through repros no longer work on HEAD.