syzbot

loop0: detected capacity change from 0 to 1024
======================================================
WARNING: possible circular locking dependency detected
6.1.44-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor205/4218 is trying to acquire lock:
ffff0000de1107c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457

but task is already holding lock:
ffff0000de0dc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595
       hfsplus_setattr+0x18c/0x25c fs/hfsplus/inode.c:269
       notify_change+0xc24/0xec0 fs/attr.c:482
       do_truncate+0x1c0/0x28c fs/open.c:65
       handle_truncate fs/namei.c:3216 [inline]
       do_open fs/namei.c:3561 [inline]
       path_openat+0x1fa0/0x2548 fs/namei.c:3714
       do_filp_open+0x1bc/0x3cc fs/namei.c:3741
       do_sys_openat2+0x128/0x3d8 fs/open.c:1318
       __do_sys_openat2 fs/open.c:1375 [inline]
       __se_sys_openat2 fs/open.c:1353 [inline]
       __arm64_sys_openat2+0x308/0x3b8 fs/open.c:1353
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

-> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457
       hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
       hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
       hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
       vfs_rename+0x8b8/0xd04 fs/namei.c:4785
       do_renameat2+0x980/0x1040 fs/namei.c:4935
       __do_sys_renameat2 fs/namei.c:4968 [inline]
       __se_sys_renameat2 fs/namei.c:4965 [inline]
       __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock);
                               lock(&HFSPLUS_I(inode)->extents_lock);
                               lock(&tree->tree_lock);
  lock(&HFSPLUS_I(inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz-executor205/4218:
 #0: ffff0000de0d8460 (sb_writers#8){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393
 #1: ffff0000de111e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #1: ffff0000de111e00 (&type->i_mutex_dir_key#6/1){+.+.}-{3:3}, at: lock_rename+0xdc/0x198 fs/namei.c:2990
 #2: ffff0000de1124c0 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline]
 #2: ffff0000de1124c0 (&type->i_mutex_dir_key#6){++++}-{3:3}, at: lock_two_inodes+0xdc/0x158 fs/inode.c:1143
 #3: ffff0000de0dc0b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x144/0x1bc

stack backtrace:
CPU: 1 PID: 4218 Comm: syz-executor205 Not tainted 6.1.44-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/12/2023
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669
 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
 __mutex_lock kernel/locking/mutex.c:747 [inline]
 mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
 hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457
 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358
 hfsplus_rename_cat+0x1ac/0xf30 fs/hfsplus/catalog.c:456
 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552
 vfs_rename+0x8b8/0xd04 fs/namei.c:4785
 do_renameat2+0x980/0x1040 fs/namei.c:4935
 __do_sys_renameat2 fs/namei.c:4968 [inline]
 __se_sys_renameat2 fs/namei.c:4965 [inline]
 __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:4965
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581