syzbot


BUG: corrupted list in hsr_add_node

Status: fixed on 2020/02/14 01:19
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+3924327f9ad5f4d2b343@syzkaller.appspotmail.com
Fix commit: 92a35678ec07 hsr: fix a race condition in node list insertion and deletion
First crash: 1687d, last: 1687d
Discussions (3)
Title Replies (including bot) Last reply
[PATCH 5.4 000/191] 5.4.9-stable review 204 (204) 2020/01/08 18:26
[PATCH net 5/6] hsr: fix a race condition in node list insertion and deletion 1 (1) 2019/12/22 11:26
BUG: corrupted list in hsr_add_node 0 (1) 2019/11/05 08:12

Sample crash report:
list_add corruption. next->prev should be prev (ffff88809a7ba700), but was ffff88808b433c00. (next=ffff88809c320b60).
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:23!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.4.0-rc5+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__list_add_valid.cold+0xf/0x3c lib/list_debug.c:23
Code: 67 fe eb d5 4c 89 e7 e8 ea 4b 67 fe eb a3 4c 89 f7 e8 e0 4b 67 fe e9 56 ff ff ff 4c 89 e1 48 c7 c7 e0 fd e6 87 e8 50 27 15 fe <0f> 0b 48 89 f2 4c 89 e1 4c 89 ee 48 c7 c7 20 ff e6 87 e8 39 27 15
RSP: 0018:ffff8880a98ae848 EFLAGS: 00010286
RAX: 0000000000000075 RBX: 000000010002e000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff815ccbc6 RDI: ffffed1015315cfb
RBP: ffff8880a98ae860 R08: 0000000000000075 R09: ffffed1015d06159
R10: ffffed1015d06158 R11: ffff8880ae830ac7 R12: ffff88809c320b60
R13: ffff8880a79fdb00 R14: ffff88809c320b60 R15: ffff88809a7ba700
FS:  0000000000000000(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000d43ea0 CR3: 000000008e786000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __list_add_rcu include/linux/rculist.h:70 [inline]
 list_add_tail_rcu include/linux/rculist.h:119 [inline]
 hsr_add_node+0x330/0x4d0 net/hsr/hsr_framereg.c:155
 hsr_get_node+0x3db/0x530 net/hsr/hsr_framereg.c:199
 hsr_fill_frame_info net/hsr/hsr_forward.c:315 [inline]
 hsr_forward_skb+0x3d0/0x1d30 net/hsr/hsr_forward.c:358
 hsr_dev_xmit+0x72/0xa0 net/hsr/hsr_device.c:231
 __netdev_start_xmit include/linux/netdevice.h:4425 [inline]
 netdev_start_xmit include/linux/netdevice.h:4439 [inline]
 xmit_one net/core/dev.c:3420 [inline]
 dev_hard_start_xmit+0x1a3/0x9b0 net/core/dev.c:3436
 __dev_queue_xmit+0x2c6c/0x3720 net/core/dev.c:4013
 dev_queue_xmit+0x18/0x20 net/core/dev.c:4046
 br_dev_queue_push_xmit+0x3f3/0x5e0 net/bridge/br_forward.c:52
 br_nf_dev_queue_xmit+0x34e/0x14b0 net/bridge/br_netfilter_hooks.c:800
 NF_HOOK include/linux/netfilter.h:307 [inline]
 NF_HOOK include/linux/netfilter.h:301 [inline]
 br_nf_post_routing+0x1502/0x1d30 net/bridge/br_netfilter_hooks.c:848
 nf_hook_entry_hookfn include/linux/netfilter.h:135 [inline]
 nf_hook_slow+0xbc/0x1e0 net/netfilter/core.c:512
 nf_hook include/linux/netfilter.h:262 [inline]
 NF_HOOK include/linux/netfilter.h:305 [inline]
 br_forward_finish+0x215/0x400 net/bridge/br_forward.c:65
 br_nf_hook_thresh+0x2e9/0x370 net/bridge/br_netfilter_hooks.c:1019
 br_nf_forward_finish+0x66c/0xa90 net/bridge/br_netfilter_hooks.c:564
 NF_HOOK include/linux/netfilter.h:307 [inline]
 NF_HOOK include/linux/netfilter.h:301 [inline]
 br_nf_forward_ip net/bridge/br_netfilter_hooks.c:634 [inline]
 br_nf_forward_ip+0xc74/0x21e0 net/bridge/br_netfilter_hooks.c:575
 nf_hook_entry_hookfn include/linux/netfilter.h:135 [inline]
 nf_hook_slow+0xbc/0x1e0 net/netfilter/core.c:512
 nf_hook include/linux/netfilter.h:262 [inline]
 NF_HOOK include/linux/netfilter.h:305 [inline]
 __br_forward+0x393/0xb00 net/bridge/br_forward.c:109
 deliver_clone+0x61/0xc0 net/bridge/br_forward.c:125
 maybe_deliver+0x2c7/0x390 net/bridge/br_forward.c:181
 br_flood+0x13a/0x3d0 net/bridge/br_forward.c:223
 br_handle_frame_finish+0xb46/0x1670 net/bridge/br_input.c:162
 br_nf_hook_thresh+0x2e9/0x370 net/bridge/br_netfilter_hooks.c:1019
 br_nf_pre_routing_finish_ipv6+0x6fa/0xdb0 net/bridge/br_netfilter_ipv6.c:206
 NF_HOOK include/linux/netfilter.h:307 [inline]
 br_nf_pre_routing_ipv6+0x456/0x840 net/bridge/br_netfilter_ipv6.c:236
 br_nf_pre_routing+0x18af/0x22d1 net/bridge/br_netfilter_hooks.c:505
 nf_hook_entry_hookfn include/linux/netfilter.h:135 [inline]
 nf_hook_bridge_pre net/bridge/br_input.c:223 [inline]
 br_handle_frame+0x806/0x1340 net/bridge/br_input.c:348
 __netif_receive_skb_core+0x10ad/0x3450 net/core/dev.c:5051
 __netif_receive_skb_one_core+0xa8/0x1a0 net/core/dev.c:5148
 __netif_receive_skb+0x2c/0x1d0 net/core/dev.c:5264
 process_backlog+0x206/0x750 net/core/dev.c:6096
 napi_poll net/core/dev.c:6533 [inline]
 net_rx_action+0x508/0x1120 net/core/dev.c:6601
 __do_softirq+0x262/0x98c kernel/softirq.c:292
 run_ksoftirqd kernel/softirq.c:603 [inline]
 run_ksoftirqd+0x8e/0x110 kernel/softirq.c:595
 smpboot_thread_fn+0x6a3/0xa40 kernel/smpboot.c:165
 kthread+0x361/0x430 kernel/kthread.c:255
 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace 580ee54eb1827b06 ]---
RIP: 0010:__list_add_valid.cold+0xf/0x3c lib/list_debug.c:23
Code: 67 fe eb d5 4c 89 e7 e8 ea 4b 67 fe eb a3 4c 89 f7 e8 e0 4b 67 fe e9 56 ff ff ff 4c 89 e1 48 c7 c7 e0 fd e6 87 e8 50 27 15 fe <0f> 0b 48 89 f2 4c 89 e1 4c 89 ee 48 c7 c7 20 ff e6 87 e8 39 27 15
RSP: 0018:ffff8880a98ae848 EFLAGS: 00010286
RAX: 0000000000000075 RBX: 000000010002e000 RCX: 0000000000000000
RDX: 0000000000000000 RSI: ffffffff815ccbc6 RDI: ffffed1015315cfb
RBP: ffff8880a98ae860 R08: 0000000000000075 R09: ffffed1015d06159
R10: ffffed1015d06158 R11: ffff8880ae830ac7 R12: ffff88809c320b60
R13: ffff8880a79fdb00 R14: ffff88809c320b60 R15: ffff88809a7ba700
FS:  0000000000000000(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000d43ea0 CR3: 000000008e786000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/11/04 01:00 net-next-old ae8a76fb8b5d b35fad31 .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.