syzbot

BTRFS info (device loop9): enabling auto defrag
BTRFS info (device loop9): force zstd compression, level 3
BTRFS info (device loop9): max_inline set to 0
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.9.809/12806 is trying to acquire lock:
ffff88804045a2e8 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}, at: btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063

but task is already holding lock:
ffff88804045b140 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x164/0xc90 fs/btrfs/transaction.c:322

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (btrfs_trans_num_extwriters){++++}-{0:0}:
       join_transaction+0x1a4/0xc90 fs/btrfs/transaction.c:323
       start_transaction+0x6b9/0x1650 fs/btrfs/transaction.c:708
       btrfs_fileattr_set+0x613/0xd20 fs/btrfs/ioctl.c:372
       vfs_fileattr_set+0x9f6/0xc90 fs/file_attr.c:301
       ioctl_setflags+0x189/0x1f0 fs/file_attr.c:337
       do_vfs_ioctl+0x9f4/0x1540 fs/ioctl.c:560
       __do_sys_ioctl fs/ioctl.c:595 [inline]
       __se_sys_ioctl+0x82/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (btrfs_trans_num_writers){++++}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5574 [inline]
       lock_release+0x199/0x3d0 kernel/locking/lockdep.c:5889
       percpu_up_read include/linux/percpu-rwsem.h:112 [inline]
       __sb_end_write include/linux/fs/super.h:14 [inline]
       sb_end_intwrite+0x26/0x1c0 include/linux/fs/super.h:101
       __btrfs_end_transaction+0x248/0x640 fs/btrfs/transaction.c:1085
       btrfs_dirty_inode+0x14c/0x190 fs/btrfs/inode.c:6428
       file_update_time_flags+0x2d5/0x4b0 fs/inode.c:2426
       btrfs_page_mkwrite+0x5df/0x1b10 fs/btrfs/file.c:1914
       do_page_mkwrite+0x150/0x310 mm/memory.c:3589
       do_shared_fault mm/memory.c:5874 [inline]
       do_fault mm/memory.c:5936 [inline]
       do_pte_missing+0x729/0x2d30 mm/memory.c:4477
       handle_pte_fault mm/memory.c:6316 [inline]
       __handle_mm_fault mm/memory.c:6454 [inline]
       handle_mm_fault+0xd0a/0x13c0 mm/memory.c:6623
       do_user_addr_fault+0x75b/0x1340 arch/x86/mm/fault.c:1385
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618

-> #3 (sb_pagefaults#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_pagefault include/linux/fs/super.h:159 [inline]
       btrfs_page_mkwrite+0x329/0x1b10 fs/btrfs/file.c:1873
       do_page_mkwrite+0x150/0x310 mm/memory.c:3589
       do_shared_fault mm/memory.c:5874 [inline]
       do_fault mm/memory.c:5936 [inline]
       do_pte_missing+0x729/0x2d30 mm/memory.c:4477
       handle_pte_fault mm/memory.c:6316 [inline]
       __handle_mm_fault mm/memory.c:6454 [inline]
       handle_mm_fault+0xd0a/0x13c0 mm/memory.c:6623
       do_user_addr_fault+0x75b/0x1340 arch/x86/mm/fault.c:1385
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618

-> #2 (&mm->mmap_lock){++++}-{4:4}:
       down_read_killable+0xa4/0x220 kernel/locking/rwsem.c:1560
       mmap_read_lock_killable+0x1d/0x70 include/linux/mmap_lock.h:601
       get_mmap_lock_carefully mm/mmap_lock.c:450 [inline]
       lock_mm_and_find_vma+0x2d7/0x340 mm/mmap_lock.c:501
       do_user_addr_fault+0x330/0x1340 arch/x86/mm/fault.c:1357
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618
       filldir+0x2b5/0x690 fs/readdir.c:295
       dir_emit include/linux/fs.h:3566 [inline]
       kernfs_fop_readdir+0x57e/0x8d0 fs/kernfs/dir.c:1915
       iterate_dir+0x3a5/0x580 fs/readdir.c:108
       __do_sys_getdents fs/readdir.c:327 [inline]
       __se_sys_getdents+0xf1/0x270 fs/readdir.c:312
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x3a/0x50 kernel/locking/rwsem.c:1590
       kernfs_add_one+0x41/0x5c0 fs/kernfs/dir.c:796
       kernfs_create_dir_ns+0xde/0x130 fs/kernfs/dir.c:1098
       sysfs_create_dir_ns+0x12f/0x2a0 fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x631/0xd10 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x12b/0x1a0 lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x116/0x2e0 fs/btrfs/sysfs.c:2604
       btrfs_quota_enable+0x282/0x2850 fs/btrfs/qgroup.c:1034
       btrfs_ioctl_quota_ctl+0x186/0x1c0 fs/btrfs/ioctl.c:3533
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/rtmutex_api.c:533 [inline]
       mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:552
       btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063
       btrfs_ioctl_quota_ctl+0x186/0x1c0 fs/btrfs/ioctl.c:3533
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &fs_info->qgroup_ioctl_lock --> btrfs_trans_num_writers --> btrfs_trans_num_extwriters

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(btrfs_trans_num_extwriters);
                               lock(btrfs_trans_num_writers);
                               lock(btrfs_trans_num_extwriters);
  lock(&fs_info->qgroup_ioctl_lock);

 *** DEADLOCK ***

5 locks held by syz.9.809/12806:
 #0: ffff88805ea34480 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write_file+0x63/0x210 fs/namespace.c:537
 #1: ffff8880404591b8 (&fs_info->subvol_sem){+.+.}-{4:4}, at: btrfs_ioctl_quota_ctl+0x17b/0x1c0 fs/btrfs/ioctl.c:3532
 #2: ffff88805ea34770 (sb_internal#2){.+.+}-{0:0}, at: btrfs_quota_enable+0x2b9/0x2850 fs/btrfs/qgroup.c:1061
 #3: ffff88804045b118 (btrfs_trans_num_writers){++++}-{0:0}, at: join_transaction+0x164/0xc90 fs/btrfs/transaction.c:322
 #4: ffff88804045b140 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x164/0xc90 fs/btrfs/transaction.c:322

stack backtrace:
CPU: 1 UID: 0 PID: 12806 Comm: syz.9.809 Not tainted syzkaller #0 PREEMPT_{RT,(full)} 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 __mutex_lock_common kernel/locking/rtmutex_api.c:533 [inline]
 mutex_lock_nested+0x5a/0x1d0 kernel/locking/rtmutex_api.c:552
 btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063
 btrfs_ioctl_quota_ctl+0x186/0x1c0 fs/btrfs/ioctl.c:3533
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:597 [inline]
 __se_sys_ioctl+0xff/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fd184cec629
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fd182f46028 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007fd184f65fa0 RCX: 00007fd184cec629
RDX: 0000200000000000 RSI: 00000000c0109428 RDI: 0000000000000003
RBP: 00007fd184d82b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fd184f66038 R14: 00007fd184f65fa0 R15: 00007ffc945b7de8
 </TASK>