syzbot

BTRFS info (device loop3): enabling ssd optimizations
BTRFS info (device loop3): turning on async discard
BTRFS info (device loop3): enabling free space tree
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Tainted: G             L     
------------------------------------------------------
syz.3.5903/29274 is trying to acquire lock:
ffff88802ae81a98 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}, at: btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063

but task is already holding lock:
ffff88802ae82720 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x164/0xd60 fs/btrfs/transaction.c:322

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (btrfs_trans_num_extwriters){++++}-{0:0}:
       join_transaction+0x1a4/0xd60 fs/btrfs/transaction.c:323
       start_transaction+0x6b9/0x1650 fs/btrfs/transaction.c:708
       btrfs_finish_one_ordered+0x7e1/0x2520 fs/btrfs/inode.c:3257
       btrfs_work_helper+0x38c/0xc80 fs/btrfs/async-thread.c:312
       process_one_work kernel/workqueue.c:3276 [inline]
       process_scheduled_works+0xb6e/0x18c0 kernel/workqueue.c:3359
       worker_thread+0xa53/0xfc0 kernel/workqueue.c:3440
       kthread+0x388/0x470 kernel/kthread.c:436
       ret_from_fork+0x51e/0xb90 arch/x86/kernel/process.c:158
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

-> #4 (btrfs_trans_num_writers){++++}-{0:0}:
       __lock_release kernel/locking/lockdep.c:5574 [inline]
       lock_release+0x199/0x3d0 kernel/locking/lockdep.c:5889
       percpu_up_read include/linux/percpu-rwsem.h:112 [inline]
       __sb_end_write include/linux/fs/super.h:14 [inline]
       sb_end_intwrite+0x26/0x1c0 include/linux/fs/super.h:101
       __btrfs_end_transaction+0x248/0x640 fs/btrfs/transaction.c:1085
       btrfs_dirty_inode+0x14c/0x190 fs/btrfs/inode.c:6457
       file_update_time_flags+0x2cf/0x4a0 fs/inode.c:2426
       btrfs_page_mkwrite+0x5cf/0x1b00 fs/btrfs/file.c:1914
       do_page_mkwrite+0x14d/0x310 mm/memory.c:3589
       wp_page_shared mm/memory.c:3990 [inline]
       do_wp_page+0x1a4b/0x5a00 mm/memory.c:4209
       handle_pte_fault mm/memory.c:6333 [inline]
       __handle_mm_fault mm/memory.c:6455 [inline]
       handle_mm_fault+0x1520/0x3310 mm/memory.c:6624
       do_user_addr_fault+0xa73/0x1340 arch/x86/mm/fault.c:1334
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618

-> #3 (sb_pagefaults#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs/super.h:19 [inline]
       sb_start_pagefault include/linux/fs/super.h:159 [inline]
       btrfs_page_mkwrite+0x319/0x1b00 fs/btrfs/file.c:1873
       do_page_mkwrite+0x14d/0x310 mm/memory.c:3589
       do_shared_fault mm/memory.c:5875 [inline]
       do_fault mm/memory.c:5937 [inline]
       do_pte_missing+0x69d/0x3490 mm/memory.c:4477
       handle_pte_fault mm/memory.c:6317 [inline]
       __handle_mm_fault mm/memory.c:6455 [inline]
       handle_mm_fault+0x1bec/0x3310 mm/memory.c:6624
       do_user_addr_fault+0x75b/0x1340 arch/x86/mm/fault.c:1385
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618

-> #2 (&mm->mmap_lock){++++}-{4:4}:
       down_write_killable+0xa6/0x240 kernel/locking/rwsem.c:1601
       mmap_write_lock_killable include/linux/mmap_lock.h:554 [inline]
       upgrade_mmap_lock_carefully+0xba/0x1b0 mm/mmap_lock.c:474
       lock_mm_and_find_vma+0x12b/0x340 mm/mmap_lock.c:527
       do_user_addr_fault+0x330/0x1340 arch/x86/mm/fault.c:1357
       handle_page_fault arch/x86/mm/fault.c:1474 [inline]
       exc_page_fault+0x6a/0xc0 arch/x86/mm/fault.c:1527
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:618
       filldir64+0x2c0/0x670 fs/readdir.c:-1
       dir_emit include/linux/fs.h:3566 [inline]
       kernfs_fop_readdir+0x575/0x950 fs/kernfs/dir.c:1943
       iterate_dir+0x399/0x570 fs/readdir.c:108
       __do_sys_getdents64 fs/readdir.c:412 [inline]
       __se_sys_getdents64+0xf1/0x280 fs/readdir.c:397
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x96/0x200 kernel/locking/rwsem.c:1590
       kernfs_add_one+0x41/0x5c0 fs/kernfs/dir.c:813
       kernfs_create_dir_ns+0xde/0x130 fs/kernfs/dir.c:1118
       sysfs_create_dir_ns+0x12f/0x2a0 fs/sysfs/dir.c:59
       create_dir lib/kobject.c:73 [inline]
       kobject_add_internal+0x62b/0xd00 lib/kobject.c:240
       kobject_add_varg lib/kobject.c:374 [inline]
       kobject_init_and_add+0x12b/0x1a0 lib/kobject.c:457
       btrfs_sysfs_add_qgroups+0x116/0x2e0 fs/btrfs/sysfs.c:2604
       btrfs_quota_enable+0x282/0x2850 fs/btrfs/qgroup.c:1034
       btrfs_ioctl_quota_ctl+0x183/0x1c0 fs/btrfs/ioctl.c:3540
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&fs_info->qgroup_ioctl_lock){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
       lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
       __mutex_lock_common kernel/locking/mutex.c:614 [inline]
       __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776
       btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063
       btrfs_ioctl_quota_ctl+0x183/0x1c0 fs/btrfs/ioctl.c:3540
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:597 [inline]
       __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:583
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &fs_info->qgroup_ioctl_lock --> btrfs_trans_num_writers --> btrfs_trans_num_extwriters

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(btrfs_trans_num_extwriters);
                               lock(btrfs_trans_num_writers);
                               lock(btrfs_trans_num_extwriters);
  lock(&fs_info->qgroup_ioctl_lock);

 *** DEADLOCK ***

5 locks held by syz.3.5903/29274:
 #0: ffff88803537c420 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write_file+0x60/0x200 fs/namespace.c:537
 #1: ffff88802ae80d68 (&fs_info->subvol_sem){++++}-{4:4}, at: btrfs_ioctl_quota_ctl+0x178/0x1c0 fs/btrfs/ioctl.c:3539
 #2: ffff88803537c610 (sb_internal#2){.+.+}-{0:0}, at: btrfs_quota_enable+0x2b9/0x2850 fs/btrfs/qgroup.c:1061
 #3: ffff88802ae826f8 (btrfs_trans_num_writers){++++}-{0:0}, at: join_transaction+0x164/0xd60 fs/btrfs/transaction.c:322
 #4: ffff88802ae82720 (btrfs_trans_num_extwriters){++++}-{0:0}, at: join_transaction+0x164/0xd60 fs/btrfs/transaction.c:322

stack backtrace:
CPU: 0 UID: 0 PID: 29274 Comm: syz.3.5903 Tainted: G             L      syzkaller #0 PREEMPT(full) 
Tainted: [L]=SOFTLOCKUP
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/18/2026
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043
 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237
 lock_acquire+0xf0/0x2e0 kernel/locking/lockdep.c:5868
 __mutex_lock_common kernel/locking/mutex.c:614 [inline]
 __mutex_lock+0x19f/0x1300 kernel/locking/mutex.c:776
 btrfs_quota_enable+0x2c6/0x2850 fs/btrfs/qgroup.c:1063
 btrfs_ioctl_quota_ctl+0x183/0x1c0 fs/btrfs/ioctl.c:3540
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:597 [inline]
 __se_sys_ioctl+0xfc/0x170 fs/ioctl.c:583
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0x14d/0xf80 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f001cd9c819
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f001dce1028 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f001d015fa0 RCX: 00007f001cd9c819
RDX: 00002000000000c0 RSI: 00000000c0109428 RDI: 0000000000000004
RBP: 00007f001ce32c91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f001d016038 R14: 00007f001d015fa0 R15: 00007ffd3388bb58
 </TASK>
BTRFS info (device loop3): setting incompat feature flag for SIMPLE_QUOTA (0x10000)