syzbot


KASAN: invalid-free in dev_free

Status: upstream: reported C repro on 2024/08/16 20:25
Subsystems: usb
[Documentation on labels]
Reported-by: syzbot+3e563d99e70973c0755c@syzkaller.appspotmail.com
First crash: 63d, last: 1h05m
Duplicate bugs (5)
duplicates (5):
Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
KASAN: slab-use-after-free Read in raw_queue_event usb 1 99d 52d 0/28 closed as dup on 2024/09/21 21:01
KASAN: slab-use-after-free Read in raw_ioctl_ep_set_clear_halt_wedge usb 12 1d02h 23d 0/28 closed as dup on 2024/09/21 21:02
KASAN: invalid-free in raw_release usb 18 1d02h 59d 0/28 closed as dup on 2024/09/21 21:01
KASAN: invalid-free in raw_ioctl usb 8 9h57m 51d 0/28 closed as dup on 2024/09/21 21:01
KASAN: slab-use-after-free Read in raw_process_ep_io usb 15 2d05h 28d 0/28 closed as dup on 2024/09/21 21:02
Discussions (2)
Title Replies (including bot) Last reply
[syzbot] Monthly usb report (Oct 2024) 0 (1) 2024/10/15 08:33
[syzbot] [usb?] KASAN: invalid-free in dev_free 0 (2) 2024/09/16 01:24

Sample crash report:
==================================================================
BUG: KASAN: double-free in dev_free+0x446/0x700 drivers/usb/gadget/legacy/raw_gadget.c:225
Free of addr ffff8881066f9240 by task syz-executor254/3953

CPU: 1 UID: 0 PID: 3953 Comm: syz-executor254 Not tainted 6.11.0-rc7-syzkaller-00152-g68d4209158f4 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:93 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:119
 print_address_description mm/kasan/report.c:377 [inline]
 print_report+0xc3/0x620 mm/kasan/report.c:488
 kasan_report_invalid_free+0xaa/0xd0 mm/kasan/report.c:563
 poison_slab_object+0x135/0x160 mm/kasan/common.c:232
 __kasan_slab_free+0x14/0x30 mm/kasan/common.c:256
 kasan_slab_free include/linux/kasan.h:184 [inline]
 slab_free_hook mm/slub.c:2256 [inline]
 slab_free mm/slub.c:4477 [inline]
 kfree+0x10b/0x380 mm/slub.c:4598
 dev_free+0x446/0x700 drivers/usb/gadget/legacy/raw_gadget.c:225
 kref_put include/linux/kref.h:65 [inline]
 raw_release+0x16e/0x2c0 drivers/usb/gadget/legacy/raw_gadget.c:473
 __fput+0x408/0xbb0 fs/file_table.c:422
 task_work_run+0x14e/0x250 kernel/task_work.c:228
 exit_task_work include/linux/task_work.h:40 [inline]
 do_exit+0xaa3/0x2b30 kernel/exit.c:882
 do_group_exit+0xd3/0x2a0 kernel/exit.c:1031
 __do_sys_exit_group kernel/exit.c:1042 [inline]
 __se_sys_exit_group kernel/exit.c:1040 [inline]
 __x64_sys_exit_group+0x3e/0x50 kernel/exit.c:1040
 x64_sys_call+0x14a9/0x16a0 arch/x86/include/generated/asm/syscalls_64.h:232
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ffa254cedf9
Code: Unable to access opcode bytes at 0x7ffa254cedcf.
RSP: 002b:00007fffc9f7d918 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ffa254cedf9
RDX: 000000000000003c RSI: 00000000000000e7 RDI: 0000000000000000
RBP: 00007ffa255583b0 R08: ffffffffffffffb0 R09: 00007fffc9f7d9a0
R10: 00007fffc9f7d9a0 R11: 0000000000000246 R12: 00007ffa255583b0
R13: 0000000000000000 R14: 00007ffa2555c1e0 R15: 00007ffa25499680
 </TASK>

Allocated by task 3955:
 kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
 kasan_save_track+0x14/0x30 mm/kasan/common.c:68
 poison_kmalloc_redzone mm/kasan/common.c:370 [inline]
 __kasan_kmalloc+0x8f/0xa0 mm/kasan/common.c:387
 kasan_kmalloc include/linux/kasan.h:211 [inline]
 __do_kmalloc_node mm/slub.c:4162 [inline]
 __kmalloc_node_track_caller_noprof+0x1ff/0x3e0 mm/slub.c:4181
 memdup_user+0x2a/0xd0 mm/util.c:226
 raw_ioctl_ep_enable drivers/usb/gadget/legacy/raw_gadget.c:847 [inline]
 raw_ioctl+0xbca/0x2b90 drivers/usb/gadget/legacy/raw_gadget.c:1318
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:907 [inline]
 __se_sys_ioctl fs/ioctl.c:893 [inline]
 __x64_sys_ioctl+0x193/0x220 fs/ioctl.c:893
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

Freed by task 3954:
 kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
 kasan_save_track+0x14/0x30 mm/kasan/common.c:68
 kasan_save_free_info+0x3b/0x60 mm/kasan/generic.c:579
 poison_slab_object+0xf7/0x160 mm/kasan/common.c:240
 __kasan_slab_free+0x14/0x30 mm/kasan/common.c:256
 kasan_slab_free include/linux/kasan.h:184 [inline]
 slab_free_hook mm/slub.c:2256 [inline]
 slab_free mm/slub.c:4477 [inline]
 kfree+0x10b/0x380 mm/slub.c:4598
 dev_free+0x446/0x700 drivers/usb/gadget/legacy/raw_gadget.c:225
 kref_put include/linux/kref.h:65 [inline]
 raw_release+0x16e/0x2c0 drivers/usb/gadget/legacy/raw_gadget.c:473
 __fput+0x408/0xbb0 fs/file_table.c:422
 __fput_sync+0x47/0x50 fs/file_table.c:507
 __do_sys_close fs/open.c:1566 [inline]
 __se_sys_close fs/open.c:1551 [inline]
 __x64_sys_close+0x86/0x100 fs/open.c:1551
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

The buggy address belongs to the object at ffff8881066f9240
 which belongs to the cache kmalloc-16 of size 16
The buggy address is located 0 bytes inside of
 16-byte region [ffff8881066f9240, ffff8881066f9250)

The buggy address belongs to the physical page:
page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1066f9
anon flags: 0x200000000000000(node=0|zone=2)
page_type: 0xfdffffff(slab)
raw: 0200000000000000 ffff888100041640 0000000000000000 dead000000000001
raw: 0000000000000000 0000000000800080 00000001fdffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0xd2cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 1, tgid 1 (swapper/0), ts 4772382410, free_ts 0
 create_dummy_stack mm/page_owner.c:94 [inline]
 register_dummy_stack+0x8a/0xd0 mm/page_owner.c:100
 init_page_owner+0x48/0xbe0 mm/page_owner.c:118
 invoke_init_callbacks mm/page_ext.c:148 [inline]
 page_ext_init+0x725/0xbf0 mm/page_ext.c:497
 mm_core_init+0x202/0x240 mm/mm_init.c:2673
page_owner free stack trace missing

Memory state around the buggy address:
 ffff8881066f9100: 00 05 fc fc 00 00 fc fc 00 00 fc fc 00 00 fc fc
 ffff8881066f9180: 00 00 fc fc 00 00 fc fc 00 00 fc fc fa fb fc fc
>ffff8881066f9200: 00 00 fc fc fa fb fc fc fa fb fc fc 00 00 fc fc
                                           ^
 ffff8881066f9280: 00 00 fc fc fa fb fc fc fa fb fc fc 00 00 fc fc
 ffff8881066f9300: 00 00 fc fc 00 05 fc fc fa fb fc fc 00 00 fc fc
==================================================================

Crashes (810):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/16 01:24 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 68d4209158f4 08d8a733 .config console log report syz / log C [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/02 09:06 upstream e32cde8d2bd7 ea2b66a6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root KASAN: invalid-free in dev_free
2024/09/17 04:15 upstream a430d95c5efa c673ca06 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root KASAN: invalid-free in dev_free
2024/10/15 06:54 upstream eca631b8fe80 b01b6661 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KASAN: invalid-free in dev_free
2024/10/13 07:11 upstream 7234e2ea0edd 084d8178 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KASAN: invalid-free in dev_free
2024/10/12 20:50 upstream 09f6b0c8904b 084d8178 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KASAN: invalid-free in dev_free
2024/10/11 17:47 upstream 1d227fcc7222 5e7b4bca .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KASAN: invalid-free in dev_free
2024/08/14 13:12 upstream 6b0f8db921ab 890d2dda .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KASAN: invalid-free in dev_free
2024/10/02 06:00 upstream e32cde8d2bd7 ea2b66a6 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 KASAN: invalid-free in dev_free
2024/10/15 11:38 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 7eb57b4a .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/15 08:40 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 b01b6661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/15 05:31 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 b01b6661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 23:20 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 b01b6661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 21:02 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 b01b6661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 19:07 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 18:49 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 17:41 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 16:24 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 14:52 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 11:43 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 10:27 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 07:25 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 64f3b5a6bc49 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 05:21 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 02:17 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/14 00:30 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 22:14 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 20:23 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 18:17 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing d73dc7b182be 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 11:34 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 10:47 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 09:36 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 05:54 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 04:14 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/13 03:11 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 23:29 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 20:00 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 18:19 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 16:43 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 13:29 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 11:12 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 09:52 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 07:54 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/12 04:54 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 22:13 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 084d8178 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 20:25 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 19:14 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 15:28 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 09:17 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 08:10 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 06:02 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 cd942402 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 01:33 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 8fbfc0c8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/11 00:30 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 8fbfc0c8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/10 22:36 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 8fbfc0c8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/10 21:11 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 4a9fe2a8ac53 8fbfc0c8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/08/12 20:13 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 38343be0bf9a 842184b3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-upstream-usb KASAN: invalid-free in dev_free
2024/10/07 05:42 upstream 2a130b7e1fcd d7906eff .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream KFENCE: invalid free in dev_free
* Struck through repros no longer work on HEAD.