general protection fault in xsk_diag_dump (2)

Status: fixed on 2020/11/16 12:12
Subsystems: bpf net
[Documentation on labels]
Reported-by: syzbot+3f04d36b7336f7868066@syzkaller.appspotmail.com
Fix commit: 53ea2076d851 xsk: Fix possible segfault in xsk umem diagnostics
First crash: 2162d, last: 2144d
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
[PATCH bpf-next] xsk: fix possible segfault in xsk umem diagnostics 2 (2) 2020/09/02 14:57
general protection fault in xsk_diag_dump (2) 0 (1) 2020/09/02 07:27
▶ ▼ Similar bugs (1)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream general protection fault in xsk_diag_dump net bpf 2 syz, C 5 2704d 2709d 11/29 fixed on 2019/03/28 12:00

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
CPU: 0 PID: 6881 Comm: syz-executor775 Not tainted 5.9.0-rc1-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:xsk_diag_put_umem net/xdp/xsk_diag.c:62 [inline]
RIP: 0010:xsk_diag_fill net/xdp/xsk_diag.c:129 [inline]
RIP: 0010:xsk_diag_dump+0xe27/0x15a0 net/xdp/xsk_diag.c:165
Code: 04 28 84 c0 74 08 3c 03 0f 8e bb 06 00 00 41 8b 44 24 10 89 84 24 fc 00 00 00 48 8b 44 24 40 48 8d 78 08 48 89 f8 48 c1 e8 03 <80> 3c 28 00 0f 85 91 05 00 00 48 8b 44 24 40 48 8b 40 08 48 85 c0
RSP: 0018:ffffc90000f4f400 EFLAGS: 00010202
RAX: 0000000000000001 RBX: ffff888094348000 RCX: 0000000000000000
RDX: ffff88809023c4c0 RSI: ffffffff87f057f2 RDI: 0000000000000008
RBP: dffffc0000000000 R08: 0000000000000001 R09: ffff888094348033
R10: 0000000000000000 R11: 0000000000097f68 R12: ffff88809598f280
R13: ffff88809989b018 R14: ffff8880a60c5000 R15: 0000000000000000
FS:  0000000001e13880(0000) GS:ffff8880ae600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020000080 CR3: 000000009dec8000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 netlink_dump+0x4cd/0xf60 net/netlink/af_netlink.c:2246
 __netlink_dump_start+0x643/0x900 net/netlink/af_netlink.c:2354
 netlink_dump_start include/linux/netlink.h:246 [inline]
 xsk_diag_handler_dump+0x1a3/0x240 net/xdp/xsk_diag.c:192
 __sock_diag_cmd net/core/sock_diag.c:233 [inline]
 sock_diag_rcv_msg+0x2fe/0x3e0 net/core/sock_diag.c:264
 netlink_rcv_skb+0x15a/0x430 net/netlink/af_netlink.c:2470
 sock_diag_rcv+0x26/0x40 net/core/sock_diag.c:275
 netlink_unicast_kernel net/netlink/af_netlink.c:1304 [inline]
 netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1330
 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1919
 sock_sendmsg_nosec net/socket.c:651 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:671
 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2353
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2407
 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2440
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x440369
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffe05e8e768 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440369
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 00000000004002c8 R09: 00000000004002c8
R10: 0000000000000048 R11: 0000000000000246 R12: 0000000000401b70
R13: 0000000000401c00 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 7c46987c287e91b6 ]---
RIP: 0010:xsk_diag_put_umem net/xdp/xsk_diag.c:62 [inline]
RIP: 0010:xsk_diag_fill net/xdp/xsk_diag.c:129 [inline]
RIP: 0010:xsk_diag_dump+0xe27/0x15a0 net/xdp/xsk_diag.c:165
Code: 04 28 84 c0 74 08 3c 03 0f 8e bb 06 00 00 41 8b 44 24 10 89 84 24 fc 00 00 00 48 8b 44 24 40 48 8d 78 08 48 89 f8 48 c1 e8 03 <80> 3c 28 00 0f 85 91 05 00 00 48 8b 44 24 40 48 8b 40 08 48 85 c0
RSP: 0018:ffffc90000f4f400 EFLAGS: 00010202
RAX: 0000000000000001 RBX: ffff888094348000 RCX: 0000000000000000
RDX: ffff88809023c4c0 RSI: ffffffff87f057f2 RDI: 0000000000000008
RBP: dffffc0000000000 R08: 0000000000000001 R09: ffff888094348033
R10: 0000000000000000 R11: 0000000000097f68 R12: ffff88809598f280
R13: ffff88809989b018 R14: ffff8880a60c5000 R15: 0000000000000000
FS:  0000000001e13880(0000) GS:ffff8880ae600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f2f4414a000 CR3: 000000009dec8000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (354):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/09/02 00:48 net-next-old dc1a9bf2c816 abf9ba4f .config console log report syz C ci-upstream-net-kasan-gce
2020/09/20 17:50 net-next-old dd92f1798981 9564d2e9 .config console log report info ci-upstream-net-kasan-gce
2020/09/20 16:18 net-next-old dd92f1798981 9564d2e9 .config console log report info ci-upstream-net-kasan-gce
2020/09/14 03:58 net-next-old 068b62148255 2d3cdd63 .config console log report ci-upstream-net-kasan-gce
2020/09/13 01:42 net-next-old 5a6bd84f8154 ce441f06 .config console log report ci-upstream-net-kasan-gce
2020/09/11 05:50 net-next-old 4f6a5caf187f 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 23:04 net-next-old 4f6a5caf187f 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 22:17 net-next-old 4f6a5caf187f 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 18:16 net-next-old 4f6a5caf187f 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 16:45 net-next-old 4f6a5caf187f 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 12:42 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 08:24 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 08:10 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 05:06 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 02:51 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/10 00:29 net-next-old b599a5b9e166 409809d8 .config console log report ci-upstream-net-kasan-gce
2020/09/09 18:57 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 18:43 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 16:06 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 15:06 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 13:06 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 13:00 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 11:58 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 10:41 net-next-old f5499c67477e 0ea7a887 .config console log report ci-upstream-net-kasan-gce
2020/09/09 07:26 net-next-old c1f1f16c4de4 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/09 05:49 net-next-old c1f1f16c4de4 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/09 05:15 net-next-old c1f1f16c4de4 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/09 02:13 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/09 00:06 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 22:27 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 21:17 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 21:05 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 19:36 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 17:13 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 15:38 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 14:30 net-next-old 4349abdb409b abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 07:33 net-next-old bb1416adb8a0 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 01:53 net-next-old bb1416adb8a0 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/08 00:51 net-next-old bb1416adb8a0 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/07 19:55 net-next-old 02a20d4fef3d abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/07 17:55 net-next-old 02a20d4fef3d abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/07 13:39 net-next-old 02a20d4fef3d abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/07 11:01 net-next-old 02a20d4fef3d abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/07 10:58 net-next-old 02a20d4fef3d abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/01 23:10 net-next-old dc1a9bf2c816 abf9ba4f .config console log report ci-upstream-net-kasan-gce
2020/09/03 07:43 linux-next 4442749a2031 abf9ba4f .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.