syzbot


general protection fault in tls_merge_open_record

Status: fixed on 2024/01/20 21:18
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+40d43509a099ea756317@syzkaller.appspotmail.com
Fix commit: 53f2cb491b50 tls: fix NULL deref on tls_sw_splice_eof() with empty record
First crash: 276d, last: 211d
Cause bisection: introduced by (bisect log) [merge ignored commit]:
commit bd6c11bc43c496cddfc6cf603b5d45365606dbd5
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Tue Aug 29 18:33:01 2023 +0000

  Merge tag 'net-next-6.6' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next

Crash: general protection fault in tls_merge_open_record (log)
Repro: syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[syzbot] [net?] general protection fault in tls_merge_open_record 1 (2) 2023/11/22 21:46
[PATCH net] tls: fix NULL deref on tls_sw_splice_eof() with empty record 1 (1) 2023/11/22 21:44
Last patch testing requests (1)
Created Duration User Patch Repo Result
2023/11/14 02:52 26m retest repro linux-next OK log

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000001: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000008-0x000000000000000f]
CPU: 1 PID: 12569 Comm: syz-executor.0 Not tainted 6.6.0-rc7-next-20231027-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023
RIP: 0010:_compound_head include/linux/page-flags.h:247 [inline]
RIP: 0010:put_page include/linux/mm.h:1544 [inline]
RIP: 0010:tls_merge_open_record+0x4b9/0x7f0 net/tls/tls_sw.c:669
Code: 85 e4 0f 85 b6 02 00 00 e8 54 62 67 f8 4d 89 f4 48 b8 00 00 00 00 00 fc ff df 49 83 e4 fc 49 8d 7c 24 08 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 ed 02 00 00 4d 8b 6c 24 08 31 ff 4d 89 ef 41 83
RSP: 0018:ffffc9000ae9f498 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff888068caa000 RCX: ffffffff89219a8e
RDX: 0000000000000001 RSI: ffffffff89219a9c RDI: 0000000000000008
RBP: ffff888068cab000 R08: 0000000000000007 R09: 0000000000000000
R10: 0000000000000000 R11: ffffffff81dfefa3 R12: 0000000000000000
R13: 0000000000000020 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fa3e0ea76c0(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020173000 CR3: 00000000279dd000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 tls_push_record+0x290f/0x3070 net/tls/tls_sw.c:726
 bpf_exec_tx_verdict+0xdee/0x1230 net/tls/tls_sw.c:819
 tls_sw_splice_eof+0x194/0x470 net/tls/tls_sw.c:1242
 sock_splice_eof+0x86/0xb0 net/socket.c:1116
 direct_file_splice_eof+0x86/0xb0 fs/splice.c:1151
 do_splice_eof fs/splice.c:944 [inline]
 splice_direct_to_actor+0x710/0xa30 fs/splice.c:1117
 do_splice_direct+0x1af/0x280 fs/splice.c:1194
 do_sendfile+0xb3a/0x1310 fs/read_write.c:1254
 __do_sys_sendfile64 fs/read_write.c:1322 [inline]
 __se_sys_sendfile64 fs/read_write.c:1308 [inline]
 __x64_sys_sendfile64+0x1d6/0x220 fs/read_write.c:1308
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:82
 entry_SYSCALL_64_after_hwframe+0x62/0x6a
RIP: 0033:0x7fa3e007cae9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa3e0ea70c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00007fa3e019c050 RCX: 00007fa3e007cae9
RDX: 0000000000000000 RSI: 0000000000000004 RDI: 0000000000000003
RBP: 00007fa3e00c847a R08: 0000000000000000 R09: 0000000000000000
R10: 00000000f2090293 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007fa3e019c050 R15: 00007ffcc0dbba98
 </TASK>
Modules linked in:
---[ end trace 0000000000000000 ]---
RIP: 0010:_compound_head include/linux/page-flags.h:247 [inline]
RIP: 0010:put_page include/linux/mm.h:1544 [inline]
RIP: 0010:tls_merge_open_record+0x4b9/0x7f0 net/tls/tls_sw.c:669
Code: 85 e4 0f 85 b6 02 00 00 e8 54 62 67 f8 4d 89 f4 48 b8 00 00 00 00 00 fc ff df 49 83 e4 fc 49 8d 7c 24 08 48 89 fa 48 c1 ea 03 <80> 3c 02 00 0f 85 ed 02 00 00 4d 8b 6c 24 08 31 ff 4d 89 ef 41 83
RSP: 0018:ffffc9000ae9f498 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: ffff888068caa000 RCX: ffffffff89219a8e
RDX: 0000000000000001 RSI: ffffffff89219a9c RDI: 0000000000000008
RBP: ffff888068cab000 R08: 0000000000000007 R09: 0000000000000000
R10: 0000000000000000 R11: ffffffff81dfefa3 R12: 0000000000000000
R13: 0000000000000020 R14: 0000000000000000 R15: 0000000000000000
FS:  00007fa3e0ea76c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000020347000 CR3: 00000000279dd000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	85 e4                	test   %esp,%esp
   2:	0f 85 b6 02 00 00    	jne    0x2be
   8:	e8 54 62 67 f8       	call   0xf8676261
   d:	4d 89 f4             	mov    %r14,%r12
  10:	48 b8 00 00 00 00 00 	movabs $0xdffffc0000000000,%rax
  17:	fc ff df
  1a:	49 83 e4 fc          	and    $0xfffffffffffffffc,%r12
  1e:	49 8d 7c 24 08       	lea    0x8(%r12),%rdi
  23:	48 89 fa             	mov    %rdi,%rdx
  26:	48 c1 ea 03          	shr    $0x3,%rdx
* 2a:	80 3c 02 00          	cmpb   $0x0,(%rdx,%rax,1) <-- trapping instruction
  2e:	0f 85 ed 02 00 00    	jne    0x321
  34:	4d 8b 6c 24 08       	mov    0x8(%r12),%r13
  39:	31 ff                	xor    %edi,%edi
  3b:	4d 89 ef             	mov    %r13,%r15
  3e:	41                   	rex.B
  3f:	83                   	.byte 0x83

Crashes (5):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/10/30 05:51 linux-next 66f1e1ea3548 3c418d72 .config console log report syz [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root general protection fault in tls_merge_open_record
2023/09/09 06:21 upstream a48fa7efaf11 6654cf89 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root general protection fault in tls_merge_open_record
2023/08/26 22:16 upstream 7d2f353b2682 03d9c195 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce general protection fault in tls_merge_open_record
2023/10/19 23:55 net-next b91f2e13c972 42e1d524 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce general protection fault in tls_merge_open_record
2023/10/29 20:25 linux-next 66f1e1ea3548 3c418d72 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root general protection fault in tls_merge_open_record
* Struck through repros no longer work on HEAD.