syzbot


possible deadlock in ext4_truncate

Status: closed as dup on 2024/12/12 23:40
Subsystems: ext4
[Documentation on labels]
Reported-by: syzbot+449c80b8f4946f26184b@syzkaller.appspotmail.com
First crash: 48d, last: 23d
Duplicate of
Title Repro Cause bisect Fix bisect Count Last Reported
possible deadlock in xfs_vn_update_time block 1 42d 38d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ext4?] possible deadlock in ext4_truncate 1 (2) 2024/12/12 23:40

Sample crash report:
ext4 filesystem being mounted at /4/file0 supports timestamps until 2038-01-19 (0x7fffffff)
======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc4-syzkaller-00069-g8379578b11d5 #0 Not tainted
------------------------------------------------------
syz.7.932/10708 is trying to acquire lock:
ffff88805887dbb0 (&ei->i_data_sem
){++++}-{4:4}, at: ext4_truncate+0xdd5/0x1270 fs/ext4/inode.c:4212

but task is already holding lock:
ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:863 [inline]
ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: ext4_truncate_failed_write fs/ext4/truncate.h:20 [inline]
ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: ext4_write_begin+0x8d0/0x1140 fs/ext4/inode.c:1243

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (mapping.invalidate_lock){++++}-{4:4}:
       down_read+0x9a/0x330 kernel/locking/rwsem.c:1524
       filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
       page_cache_ra_unbounded+0x173/0x750 mm/readahead.c:226
       do_page_cache_ra mm/readahead.c:325 [inline]
       page_cache_ra_order+0x8f2/0xc80 mm/readahead.c:524
       page_cache_async_ra+0x5cb/0x820 mm/readahead.c:674
       do_async_mmap_readahead mm/filemap.c:3231 [inline]
       filemap_fault+0xd69/0x2820 mm/filemap.c:3330
       __do_fault+0x10d/0x490 mm/memory.c:4907
       do_read_fault mm/memory.c:5322 [inline]
       do_fault mm/memory.c:5456 [inline]
       do_pte_missing+0xebd/0x3e00 mm/memory.c:3979
       handle_pte_fault mm/memory.c:5801 [inline]
       __handle_mm_fault+0x103c/0x2a40 mm/memory.c:5944
       handle_mm_fault+0x3fa/0xaa0 mm/memory.c:6112
       faultin_page mm/gup.c:1196 [inline]
       __get_user_pages+0x8d9/0x3b50 mm/gup.c:1494
       __get_user_pages_locked mm/gup.c:1760 [inline]
       get_dump_page+0xff/0x230 mm/gup.c:2278
       dump_user_range+0x135/0x8c0 fs/coredump.c:943
       elf_core_dump+0x287c/0x3a50 fs/binfmt_elf.c:2129
       do_coredump+0x3ada/0x49e0 fs/coredump.c:758
       get_signal+0x230b/0x26c0 kernel/signal.c:3002
       arch_do_signal_or_restart+0x90/0x7e0 arch/x86/kernel/signal.c:337
       exit_to_user_mode_loop kernel/entry/common.c:111 [inline]
       exit_to_user_mode_prepare include/linux/entry-common.h:329 [inline]
       irqentry_exit_to_user_mode+0x13f/0x280 kernel/entry/common.c:231
       asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #6 (&mm->mmap_lock){++++}-{4:4}:
       __might_fault mm/memory.c:6751 [inline]
       __might_fault+0x11b/0x190 mm/memory.c:6744
       _inline_copy_from_user include/linux/uaccess.h:162 [inline]
       _copy_from_user+0x29/0xd0 lib/usercopy.c:18
       copy_from_user include/linux/uaccess.h:212 [inline]
       __blk_trace_setup+0xa8/0x180 kernel/trace/blktrace.c:626
       blk_trace_ioctl+0x163/0x290 kernel/trace/blktrace.c:740
       blkdev_ioctl+0x109/0x6d0 block/ioctl.c:682
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&q->debugfs_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       blk_mq_init_sched+0x42b/0x640 block/blk-mq-sched.c:473
       elevator_init_mq+0x2cd/0x420 block/elevator.c:610
       add_disk_fwnode+0x113/0x1300 block/genhd.c:413
       sd_probe+0xa86/0x1000 drivers/scsi/sd.c:4024
       call_driver_probe drivers/base/dd.c:579 [inline]
       really_probe+0x241/0xa90 drivers/base/dd.c:658
       __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
       driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
       __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
       bus_for_each_drv+0x15a/0x1e0 drivers/base/bus.c:459
       __device_attach_async_helper+0x1d3/0x290 drivers/base/dd.c:987
       async_run_entry_fn+0x9f/0x530 kernel/async.c:129
       process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3229
       process_scheduled_works kernel/workqueue.c:3310 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #4 (&q->q_usage_counter(queue)#50){++++}-{0:0}:
       blk_queue_enter+0x50f/0x640 block/blk-core.c:328
       blk_mq_alloc_request+0x59b/0x950 block/blk-mq.c:652
       scsi_alloc_request drivers/scsi/scsi_lib.c:1222 [inline]
       scsi_execute_cmd+0x1eb/0xf40 drivers/scsi/scsi_lib.c:304
       read_capacity_16+0x213/0xe10 drivers/scsi/sd.c:2655
       sd_read_capacity drivers/scsi/sd.c:2824 [inline]
       sd_revalidate_disk.isra.0+0x1a06/0xa8d0 drivers/scsi/sd.c:3734
       sd_probe+0x904/0x1000 drivers/scsi/sd.c:4010
       call_driver_probe drivers/base/dd.c:579 [inline]
       really_probe+0x241/0xa90 drivers/base/dd.c:658
       __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
       driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
       __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
       bus_for_each_drv+0x15a/0x1e0 drivers/base/bus.c:459
       __device_attach_async_helper+0x1d3/0x290 drivers/base/dd.c:987
       async_run_entry_fn+0x9f/0x530 kernel/async.c:129
       process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3229
       process_scheduled_works kernel/workqueue.c:3310 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #3 (&q->limits_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       queue_limits_start_update include/linux/blkdev.h:947 [inline]
       loop_reconfigure_limits+0x407/0x8c0 drivers/block/loop.c:998
       loop_set_block_size drivers/block/loop.c:1473 [inline]
       lo_simple_ioctl drivers/block/loop.c:1496 [inline]
       lo_ioctl+0x901/0x18b0 drivers/block/loop.c:1559
       blkdev_ioctl+0x279/0x6d0 block/ioctl.c:693
       vfs_ioctl fs/ioctl.c:51 [inline]
       __do_sys_ioctl fs/ioctl.c:906 [inline]
       __se_sys_ioctl fs/ioctl.c:892 [inline]
       __x64_sys_ioctl+0x193/0x200 fs/ioctl.c:892
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&q->q_usage_counter(io)#17){++++}-{0:0}:
       bio_queue_enter block/blk.h:75 [inline]
       blk_mq_submit_bio+0x1fb6/0x24c0 block/blk-mq.c:3090
       __submit_bio+0x384/0x540 block/blk-core.c:629
       __submit_bio_noacct_mq block/blk-core.c:710 [inline]
       submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739
       submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868
       __ext4_read_bh fs/ext4/super.c:181 [inline]
       ext4_read_bh_nowait+0x199/0x250 fs/ext4/super.c:193
       ext4_read_block_bitmap_nowait+0xeac/0x1810 fs/ext4/balloc.c:551
       ext4_mb_prefetch+0x292/0x370 fs/ext4/mballoc.c:2749
       ext4_mb_regular_allocator+0x18d8/0x3f90 fs/ext4/mballoc.c:2898
       ext4_mb_new_blocks+0x287f/0x4e30 fs/ext4/mballoc.c:6217
       ext4_ext_map_blocks+0x1b80/0x5aa0 fs/ext4/extents.c:4379
       ext4_map_create_blocks fs/ext4/inode.c:516 [inline]
       ext4_map_blocks+0x457/0x1370 fs/ext4/inode.c:702
       ext4_getblk+0x17f/0x890 fs/ext4/inode.c:849
       ext4_bread+0x2c/0x190 fs/ext4/inode.c:912
       ext4_quota_write+0x219/0x610 fs/ext4/super.c:7285
       write_blk+0x131/0x220 fs/quota/quota_tree.c:70
       do_insert_tree+0xddd/0x1a10 fs/quota/quota_tree.c:407
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       do_insert_tree+0x1410/0x1a10 fs/quota/quota_tree.c:402
       dq_insert_tree fs/quota/quota_tree.c:432 [inline]
       qtree_write_dquot+0x248/0x660 fs/quota/quota_tree.c:451
       v2_write_dquot+0x1b1/0x2a0 fs/quota/quota_v2.c:372
       dquot_acquire+0x3a4/0x6f0 fs/quota/dquot.c:470
       ext4_acquire_dquot+0x27f/0x4e0 fs/ext4/super.c:6934
       dqget+0x694/0x1160 fs/quota/dquot.c:977
       __dquot_initialize+0x588/0xd50 fs/quota/dquot.c:1505
       ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x742/0x1210 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5610 [inline]
       ext4_fill_super+0x9631/0xaab0 fs/ext4/super.c:5733
       get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636
       vfs_get_tree+0x92/0x380 fs/super.c:1814
       do_new_mount fs/namespace.c:3507 [inline]
       path_mount+0x14e6/0x1f20 fs/namespace.c:3834
       do_mount fs/namespace.c:3847 [inline]
       __do_sys_mount fs/namespace.c:4057 [inline]
       __se_sys_mount fs/namespace.c:4034 [inline]
       __x64_sys_mount+0x294/0x320 fs/namespace.c:4034
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&lg->lg_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       ext4_mb_group_or_file fs/ext4/mballoc.c:5786 [inline]
       ext4_mb_initialize_context+0x814/0xdf0 fs/ext4/mballoc.c:5830
       ext4_mb_new_blocks+0x963/0x4e30 fs/ext4/mballoc.c:6204
       ext4_ext_map_blocks+0x1b80/0x5aa0 fs/ext4/extents.c:4379
       ext4_map_create_blocks fs/ext4/inode.c:516 [inline]
       ext4_map_blocks+0x457/0x1370 fs/ext4/inode.c:702
       mpage_map_one_extent fs/ext4/inode.c:2219 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2272 [inline]
       ext4_do_writepages+0x198d/0x32d0 fs/ext4/inode.c:2735
       ext4_writepages+0x303/0x730 fs/ext4/inode.c:2824
       do_writepages+0x1b6/0x820 mm/page-writeback.c:2702
       __writeback_single_inode+0x166/0xfa0 fs/fs-writeback.c:1680
       writeback_sb_inodes+0x606/0xfa0 fs/fs-writeback.c:1976
       __writeback_inodes_wb+0xff/0x2e0 fs/fs-writeback.c:2047
       wb_writeback+0x803/0xb80 fs/fs-writeback.c:2158
       wb_check_background_flush fs/fs-writeback.c:2228 [inline]
       wb_do_writeback fs/fs-writeback.c:2316 [inline]
       wb_workfn+0x730/0xbc0 fs/fs-writeback.c:2343
       process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3229
       process_scheduled_works kernel/workqueue.c:3310 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3391
       kthread+0x2c4/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #0 (&ei->i_data_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
       down_write+0x93/0x200 kernel/locking/rwsem.c:1577
       ext4_truncate+0xdd5/0x1270 fs/ext4/inode.c:4212
       ext4_truncate_failed_write fs/ext4/truncate.h:22 [inline]
       ext4_write_begin+0x8f3/0x1140 fs/ext4/inode.c:1243
       generic_perform_write+0x2bd/0x920 mm/filemap.c:4055
       ext4_buffered_write_iter+0x119/0x3c0 fs/ext4/file.c:299
       ext4_file_write_iter+0x9e1/0x1be0 fs/ext4/file.c:717
       new_sync_write fs/read_write.c:586 [inline]
       vfs_write+0x5b1/0x1150 fs/read_write.c:679
       ksys_write+0x12b/0x250 fs/read_write.c:731
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ei->i_data_sem --> &mm->mmap_lock --> mapping.invalidate_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(mapping.invalidate_lock);
                               lock(&mm->mmap_lock);
                               lock(mapping.invalidate_lock);
  lock(&ei->i_data_sem);

 *** DEADLOCK ***

4 locks held by syz.7.932/10708:
 #0: ffff88807dfb2478 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x267/0x390 fs/file.c:1191
 #1: ffff88807dca8420 (sb_writers#4){.+.+}-{0:0}, at: ksys_write+0x12b/0x250 fs/read_write.c:731
 #2: ffff88805887dd20 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline]
 #2: ffff88805887dd20 (&sb->s_type->i_mutex_key#8){++++}-{4:4}, at: ext4_buffered_write_iter+0xaa/0x3c0 fs/ext4/file.c:294
 #3: ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: filemap_invalidate_lock include/linux/fs.h:863 [inline]
 #3: ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: ext4_truncate_failed_write fs/ext4/truncate.h:20 [inline]
 #3: ffff88805887dec0 (mapping.invalidate_lock){++++}-{4:4}, at: ext4_write_begin+0x8d0/0x1140 fs/ext4/inode.c:1243

stack backtrace:
CPU: 0 UID: 0 PID: 10708 Comm: syz.7.932 Not tainted 6.13.0-rc4-syzkaller-00069-g8379578b11d5 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x419/0x5d0 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
 down_write+0x93/0x200 kernel/locking/rwsem.c:1577
 ext4_truncate+0xdd5/0x1270 fs/ext4/inode.c:4212
 ext4_truncate_failed_write fs/ext4/truncate.h:22 [inline]
 ext4_write_begin+0x8f3/0x1140 fs/ext4/inode.c:1243
 generic_perform_write+0x2bd/0x920 mm/filemap.c:4055
 ext4_buffered_write_iter+0x119/0x3c0 fs/ext4/file.c:299
 ext4_file_write_iter+0x9e1/0x1be0 fs/ext4/file.c:717
 new_sync_write fs/read_write.c:586 [inline]
 vfs_write+0x5b1/0x1150 fs/read_write.c:679
 ksys_write+0x12b/0x250 fs/read_write.c:731
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f5995d85d29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5996c19038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f5995f75fa0 RCX: 00007f5995d85d29
RDX: 000000000208e24b RSI: 0000000020000040 RDI: 0000000000000004
RBP: 00007f5995e01b08 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f5995f75fa0 R15: 00007fff55421168
 </TASK>

Crashes (4):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/12/28 05:14 upstream 8379578b11d5 d3ccff63 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root possible deadlock in ext4_truncate
2024/12/14 08:50 upstream a446e965a188 7cbfbb3a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ext4_truncate
2024/12/03 07:15 upstream cdd30ebb1b9f 578925bc .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in ext4_truncate
2024/12/03 05:37 linux-next f486c8aa16b8 578925bc .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in ext4_truncate
* Struck through repros no longer work on HEAD.