syzbot


WARNING in cgroup_apply_control_enable

Status: fixed on 2020/02/18 14:31
Subsystems: cgroups
[Documentation on labels]
Reported-by: syzbot+5493b2a54d31d6aea629@syzkaller.appspotmail.com
Fix commit: 3bc0bb36fa30 cgroup: Prevent double killing of css when enabling threaded cgroup
First crash: 2286d, last: 1733d
Cause bisection: introduced by (bisect log) :
commit 0d5936344f30aba0f6ddb92b030cb6a05168efe6
Author: Tejun Heo <tj@kernel.org>
Date: Mon Sep 25 16:00:19 2017 +0000

  sched: Implement interface for cgroup unified hierarchy

Crash: WARNING in cgroup_apply_control_enable (log)
Repro: C syz .config
  
Discussions (8)
Title Replies (including bot) Last reply
[PATCH 5.5 00/23] 5.5.2-stable review 31 (31) 2020/02/08 16:13
[PATCH 5.4 00/90] 5.4.18-stable review 107 (107) 2020/02/05 21:21
[PATCH 4.19 00/70] 4.19.102-stable review 77 (77) 2020/02/05 14:42
[PATCH 4.14 00/89] 4.14.170-stable review 93 (93) 2020/02/04 17:19
[PATCH] cgroup: Prevent double killing of css when enabling threaded cgroup 2 (2) 2020/01/15 16:07
WARNING in cgroup_apply_control_enable 0 (3) 2019/11/23 15:29
Reminder: 1 open syzbot bug in "kernel/cgroup" subsystem 1 (1) 2019/07/24 02:59
Reminder: 1 open syzbot bug in "kernel/cgroup" subsystem 1 (1) 2019/07/09 19:13
Fix bisection attempts (2)
Created Duration User Patch Repo Result
2020/01/13 03:39 19m bisect fix upstream OK (0) job log log
2019/12/11 09:24 19m bisect fix upstream OK (0) job log log

Sample crash report:
audit: type=1800 audit(1539513380.003:30): pid=5233 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="startpar" name="rmnologin" dev="sda1" ino=2423 res=0
IPVS: ftp: loaded support on port[0] = 21
WARNING: CPU: 1 PID: 5393 at kernel/cgroup/cgroup.c:2935 cgroup_apply_control_enable+0x22c/0xea0 kernel/cgroup/cgroup.c:2935
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 5393 Comm: syz-executor877 Not tainted 4.19.0-rc7+ #283
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1c4/0x2b4 lib/dump_stack.c:113
 panic+0x238/0x4e7 kernel/panic.c:184
 __warn.cold.8+0x163/0x1ba kernel/panic.c:536
 report_bug+0x254/0x2d0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 do_error_trap+0x1fc/0x4d0 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:316
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:993
RIP: 0010:cgroup_apply_control_enable+0x22c/0xea0 kernel/cgroup/cgroup.c:2935
Code: 48 c1 e8 03 42 80 3c 28 00 0f 85 18 0a 00 00 49 8b 5f 18 31 ff 83 e3 02 48 89 de e8 0e 64 07 00 48 85 db 74 07 e8 d4 62 07 00 <0f> 0b e8 cd 62 07 00 48 8b 85 a0 fe ff ff 48 c1 e8 03 42 80 3c 28
RSP: 0018:ffff8801d8b3f7f0 EFLAGS: 00010293
RAX: ffff8801bb6da040 RBX: 0000000000000002 RCX: ffffffff81774672
RDX: 0000000000000000 RSI: ffffffff8177467c RDI: 0000000000000007
RBP: ffff8801d8b3f9a0 R08: ffff8801bb6da040 R09: 1ffffffff1273955
R10: ffffed003b5e4732 R11: ffff8801daf23993 R12: ffffffff893c5020
R13: dffffc0000000000 R14: 000000000000000b R15: ffff8801bf291d00
 cgroup_apply_control+0x1f/0x50 kernel/cgroup/cgroup.c:3021
 cgroup_enable_threaded kernel/cgroup/cgroup.c:3238 [inline]
 cgroup_type_write+0x54b/0x710 kernel/cgroup/cgroup.c:3277
 cgroup_file_write+0x2f7/0x7e0 kernel/cgroup/cgroup.c:3457
 kernfs_fop_write+0x2ba/0x480 fs/kernfs/file.c:316
 __vfs_write+0x119/0x9f0 fs/read_write.c:485
 vfs_write+0x1fc/0x560 fs/read_write.c:549
 ksys_write+0x101/0x260 fs/read_write.c:598
 __do_sys_write fs/read_write.c:610 [inline]
 __se_sys_write fs/read_write.c:607 [inline]
 __x64_sys_write+0x73/0xb0 fs/read_write.c:607
 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x441c19
Code: e8 cc b2 02 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 eb 08 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffd82682168 EFLAGS: 00000213 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000441c19
RDX: 0000000000000009 RSI: 0000000020000140 RDI: 0000000000000006
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000213 R12: 0000000000000001
R13: 0000000000009895 R14: 0000000000000000 R15: 0000000000000000
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (178):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/10/14 10:39 upstream 3a27203102eb caf12900 .config console log report syz C ci-upstream-kasan-gce-root
2018/10/14 01:20 upstream 7ec21823634d caf12900 .config console log report syz C ci-upstream-kasan-gce
2018/10/14 00:44 upstream 7ec21823634d caf12900 .config console log report syz C ci-upstream-kasan-gce-smack-root
2018/10/14 00:45 upstream 7ec21823634d caf12900 .config console log report syz C ci-upstream-kasan-gce-386
2018/10/14 00:45 net-old bab5c80b2110 caf12900 .config console log report syz C ci-upstream-net-this-kasan-gce
2018/10/14 00:34 bpf cee271678d0e caf12900 .config console log report syz C ci-upstream-bpf-kasan-gce
2018/10/14 01:01 net-next-old d864991b220b caf12900 .config console log report syz C ci-upstream-net-kasan-gce
2018/10/14 00:10 bpf-next 1ae80cf31938 caf12900 .config console log report syz C ci-upstream-bpf-next-kasan-gce
2018/10/14 12:00 linux-next 774ea0551a29 caf12900 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2019/09/02 00:54 bpf ede7c460b1da bad3cce2 .config console log report ci-upstream-bpf-kasan-gce
2019/09/01 20:07 bpf ede7c460b1da bad3cce2 .config console log report ci-upstream-bpf-kasan-gce
2019/08/31 11:00 bpf ede7c460b1da fd37b39e .config console log report ci-upstream-bpf-kasan-gce
2019/08/27 00:04 bpf f53a7ad18959 d21c5d9d .config console log report ci-upstream-bpf-kasan-gce
2019/08/26 12:02 bpf 2c238177bd7f d21c5d9d .config console log report ci-upstream-bpf-kasan-gce
2019/08/20 00:42 bpf d34b044038bf ee12860b .config console log report ci-upstream-bpf-kasan-gce
2019/08/19 00:49 bpf d34b044038bf 55bf8926 .config console log report ci-upstream-bpf-kasan-gce
2019/08/17 01:25 bpf d34b044038bf 8fd428a1 .config console log report ci-upstream-bpf-kasan-gce
2019/08/16 17:07 bpf d34b044038bf 8fd428a1 .config console log report ci-upstream-bpf-kasan-gce
2019/08/16 06:25 bpf 27df5c7068bf 8fd428a1 .config console log report ci-upstream-bpf-kasan-gce
2019/08/10 06:49 bpf cb8ffde5694a acb51638 .config console log report ci-upstream-bpf-kasan-gce
2019/07/25 13:48 bpf decb705e01a5 32329ceb .config console log report ci-upstream-bpf-kasan-gce
2019/07/01 05:11 bpf 0472301a28f6 699d6448 .config console log report ci-upstream-bpf-kasan-gce
2019/06/16 12:47 bpf fe8d9571dc50 442206d7 .config console log report ci-upstream-bpf-kasan-gce
2019/05/29 08:49 bpf bd95e678e0f6 6bd61501 .config console log report ci-upstream-bpf-kasan-gce
2019/05/28 14:23 bpf bd95e678e0f6 6bd61501 .config console log report ci-upstream-bpf-kasan-gce
2019/05/27 19:08 bpf bd95e678e0f6 562efd79 .config console log report ci-upstream-bpf-kasan-gce
2019/05/27 17:30 bpf bd95e678e0f6 562efd79 .config console log report ci-upstream-bpf-kasan-gce
2019/05/27 16:13 bpf bd95e678e0f6 562efd79 .config console log report ci-upstream-bpf-kasan-gce
2019/05/27 06:52 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/27 03:16 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/26 23:11 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/26 22:10 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/26 18:16 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/26 08:35 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/26 04:12 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 22:28 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 20:44 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 15:59 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 14:38 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 07:23 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/25 05:19 bpf bd95e678e0f6 85c57315 .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 18:07 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 15:40 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 13:34 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 05:07 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 03:17 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/24 01:49 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/23 23:15 bpf 186bcc3dcd10 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/23 11:57 bpf a195cefff49f 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/23 09:10 bpf a195cefff49f 0dadcd9d .config console log report ci-upstream-bpf-kasan-gce
2019/05/23 02:42 bpf a195cefff49f 84b9d384 .config console log report ci-upstream-bpf-kasan-gce
2019/05/22 20:43 bpf a195cefff49f 84b9d384 .config console log report ci-upstream-bpf-kasan-gce
2019/05/22 15:23 bpf a195cefff49f 84b9d384 .config console log report ci-upstream-bpf-kasan-gce
2019/05/22 14:41 bpf a195cefff49f 84b9d384 .config console log report ci-upstream-bpf-kasan-gce
2018/07/09 06:02 bpf 7f93d1295131 f25e5770 .config console log report ci-upstream-bpf-kasan-gce
2019/07/28 14:09 bpf-next 192f0f8e9db7 c85e1c5b .config console log report ci-upstream-bpf-next-kasan-gce
2019/07/19 11:47 bpf-next 192f0f8e9db7 7bb222f7 .config console log report ci-upstream-bpf-next-kasan-gce
2019/06/23 05:36 bpf-next dca73a65a683 34bf9440 .config console log report ci-upstream-bpf-next-kasan-gce
2019/06/05 21:00 bpf-next 6685699e4ef5 bfb4a51e .config console log report ci-upstream-bpf-next-kasan-gce
* Struck through repros no longer work on HEAD.