syzbot


possible deadlock in sk_psock_drop

Status: upstream: reported on 2024/03/26 19:01
Subsystems: bpf net
[Documentation on labels]
Reported-by: syzbot+59286e53e6c7d1921164@syzkaller.appspotmail.com
First crash: 32d, last: 6d15h
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [bpf?] [net?] possible deadlock in sk_psock_drop 0 (1) 2024/03/26 19:01
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 possible deadlock in sk_psock_drop 1 22h49m 22h48m 0/3 upstream: reported on 2024/04/26 12:58

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.8.0-syzkaller-05271-gf99c5f563c17 #0 Not tainted
------------------------------------------------------
syz-executor.2/9635 is trying to acquire lock:
ffff888078ebf3f0 (clock-AF_INET6){++--}-{2:2}, at: sk_psock_drop+0x34/0x500 net/core/skmsg.c:837

but task is already holding lock:
ffff888077eac820 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff888077eac820 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_elem+0xb0/0x300 net/core/sock_map.c:939

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&htab->buckets[i].lock){+.-.}-{2:2}:
       lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       sock_hash_delete_elem+0xb0/0x300 net/core/sock_map.c:939
       0xffffffffa000213c
       bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
       __bpf_prog_run include/linux/filter.h:657 [inline]
       bpf_prog_run include/linux/filter.h:664 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
       bpf_trace_run2+0x204/0x420 kernel/trace/bpf_trace.c:2420
       trace_kfree include/trace/events/kmem.h:94 [inline]
       kfree+0x291/0x380 mm/slub.c:4396
       rds_send_remove_from_sock+0x66e/0x800 net/rds/send.c:666
       rds_send_path_drop_acked+0x36b/0x3b0 net/rds/send.c:709
       rds_tcp_write_space+0x196/0x5f0 net/rds/tcp_send.c:199
       tcp_new_space net/ipv4/tcp_input.c:5626 [inline]
       tcp_check_space+0x65e/0xb00 net/ipv4/tcp_input.c:5645
       tcp_data_snd_check net/ipv4/tcp_input.c:5654 [inline]
       tcp_rcv_established+0x10f9/0x1fd0 net/ipv4/tcp_input.c:6081
       tcp_v6_do_rcv+0xa09/0x1300 net/ipv6/tcp_ipv6.c:1644
       sk_backlog_rcv include/net/sock.h:1106 [inline]
       __release_sock+0x1c8/0x350 net/core/sock.c:2984
       release_sock+0x61/0x1f0 net/core/sock.c:3550
       rds_send_xmit+0x1d3d/0x25b0 net/rds/send.c:421
       rds_send_worker+0x7d/0x2b0 net/rds/threads.c:200
       process_one_work kernel/workqueue.c:3254 [inline]
       process_scheduled_works+0xa00/0x1770 kernel/workqueue.c:3335
       worker_thread+0x86d/0xd70 kernel/workqueue.c:3416
       kthread+0x2f0/0x390 kernel/kthread.c:388
       ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:243

-> #0 (clock-AF_INET6){++--}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
       __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
       lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754
       __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline]
       _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334
       sk_psock_drop+0x34/0x500 net/core/skmsg.c:837
       sock_hash_delete_elem+0x27e/0x300 net/core/sock_map.c:943
       bpf_prog_2c29ac5cdc6b1842+0x42/0x46
       bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
       __bpf_prog_run include/linux/filter.h:657 [inline]
       bpf_prog_run include/linux/filter.h:664 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
       bpf_trace_run6+0x29f/0x4d0 kernel/trace/bpf_trace.c:2424
       __bpf_trace_ext4_ext_remove_space_done+0x43/0x60 include/trace/events/ext4.h:2128
       trace_ext4_ext_remove_space_done include/trace/events/ext4.h:2128 [inline]
       ext4_ext_remove_space+0x4b84/0x4db0 fs/ext4/extents.c:3007
       ext4_punch_hole+0x798/0xbf0 fs/ext4/inode.c:3994
       ext4_fallocate+0x322/0x1fa0 fs/ext4/extents.c:4741
       vfs_fallocate+0x564/0x6c0 fs/open.c:331
       do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:883
       __do_sys_ioctl fs/ioctl.c:902 [inline]
       __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
       do_syscall_64+0xfb/0x240
       entry_SYSCALL_64_after_hwframe+0x6d/0x75

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&htab->buckets[i].lock);
                               lock(clock-AF_INET6);
                               lock(&htab->buckets[i].lock);
  lock(clock-AF_INET6);

 *** DEADLOCK ***

7 locks held by syz-executor.2/9635:
 #0: ffff88805b98a420 (sb_writers#4){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2853 [inline]
 #0: ffff88805b98a420 (sb_writers#4){.+.+}-{0:0}, at: vfs_fallocate+0x4d3/0x6c0 fs/open.c:330
 #1: ffff88805c9bf200 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:793 [inline]
 #1: ffff88805c9bf200 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_punch_hole+0x1dd/0xbf0 fs/ext4/inode.c:3899
 #2: ffff88805c9bf3a0 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:838 [inline]
 #2: ffff88805c9bf3a0 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_punch_hole+0x3c3/0xbf0 fs/ext4/inode.c:3946
 #3: ffff88805b98e950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1faa/0x2200 fs/jbd2/transaction.c:463
 #4: ffff88805c9bf088 (&ei->i_data_sem){++++}-{3:3}, at: ext4_punch_hole+0x6fb/0xbf0 fs/ext4/inode.c:3988
 #5: ffffffff8e131920 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
 #5: ffffffff8e131920 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:781 [inline]
 #5: ffffffff8e131920 (rcu_read_lock){....}-{1:2}, at: __bpf_trace_run kernel/trace/bpf_trace.c:2380 [inline]
 #5: ffffffff8e131920 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run6+0x1b3/0x4d0 kernel/trace/bpf_trace.c:2424
 #6: ffff888077eac820 (&htab->buckets[i].lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
 #6: ffff888077eac820 (&htab->buckets[i].lock){+.-.}-{2:2}, at: sock_hash_delete_elem+0xb0/0x300 net/core/sock_map.c:939

stack backtrace:
CPU: 1 PID: 9635 Comm: syz-executor.2 Not tainted 6.8.0-syzkaller-05271-gf99c5f563c17 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2e0 lib/dump_stack.c:106
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
 lock_acquire+0x1e4/0x530 kernel/locking/lockdep.c:5754
 __raw_write_lock_bh include/linux/rwlock_api_smp.h:202 [inline]
 _raw_write_lock_bh+0x35/0x50 kernel/locking/spinlock.c:334
 sk_psock_drop+0x34/0x500 net/core/skmsg.c:837
 sock_hash_delete_elem+0x27e/0x300 net/core/sock_map.c:943
 bpf_prog_2c29ac5cdc6b1842+0x42/0x46
 bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
 __bpf_prog_run include/linux/filter.h:657 [inline]
 bpf_prog_run include/linux/filter.h:664 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
 bpf_trace_run6+0x29f/0x4d0 kernel/trace/bpf_trace.c:2424
 __bpf_trace_ext4_ext_remove_space_done+0x43/0x60 include/trace/events/ext4.h:2128
 trace_ext4_ext_remove_space_done include/trace/events/ext4.h:2128 [inline]
 ext4_ext_remove_space+0x4b84/0x4db0 fs/ext4/extents.c:3007
 ext4_punch_hole+0x798/0xbf0 fs/ext4/inode.c:3994
 ext4_fallocate+0x322/0x1fa0 fs/ext4/extents.c:4741
 vfs_fallocate+0x564/0x6c0 fs/open.c:331
 do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:883
 __do_sys_ioctl fs/ioctl.c:902 [inline]
 __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
 do_syscall_64+0xfb/0x240
 entry_SYSCALL_64_after_hwframe+0x6d/0x75
RIP: 0033:0x7f1c51c7dea9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f1c517de0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f1c51dac050 RCX: 00007f1c51c7dea9
RDX: 0000000020000280 RSI: 000000004030582b RDI: 0000000000000009
RBP: 00007f1c51cca4a4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000006e R14: 00007f1c51dac050 R15: 00007fffca3c74e8
 </TASK>

Crashes (8):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/04/20 20:38 net f99c5f563c17 af24b050 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in sk_psock_drop
2024/04/06 09:55 net f99c5f563c17 ca620dd8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in sk_psock_drop
2024/04/04 11:26 net f99c5f563c17 51c4dcff .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in sk_psock_drop
2024/03/25 16:35 net f99c5f563c17 0ea90952 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in sk_psock_drop
2024/04/18 03:40 linux-next 4eab35893071 bd38b692 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in sk_psock_drop
2024/04/13 09:14 linux-next 9ed46da14b9b c8349e48 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in sk_psock_drop
2024/04/12 23:06 linux-next 9ed46da14b9b c8349e48 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in sk_psock_drop
2024/04/12 08:11 linux-next 4118d9533ff3 27de0a5c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in sk_psock_drop
* Struck through repros no longer work on HEAD.