syzbot


possible deadlock in pipe_lock (6)

Status: upstream: reported on 2024/11/08 04:47
Subsystems: overlayfs
[Documentation on labels]
Reported-by: syzbot+603e6f91a1f6c5af8c02@syzkaller.appspotmail.com
First crash: 17d, last: 12d
Discussions (2)
Title Replies (including bot) Last reply
[syzbot] Monthly overlayfs report (Nov 2024) 0 (1) 2024/11/20 13:31
[syzbot] [overlayfs?] possible deadlock in pipe_lock (6) 0 (1) 2024/11/08 04:47
Similar bugs (9)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in pipe_lock fs 50806 2529d 2577d 0/28 closed as invalid on 2018/02/14 14:20
upstream possible deadlock in pipe_lock (4) overlayfs 1 1296d 1292d 0/28 auto-closed as invalid on 2021/07/03 13:02
upstream possible deadlock in pipe_lock (2) overlayfs 3 2040d 2110d 0/28 auto-closed as invalid on 2019/10/18 15:02
linux-4.19 possible deadlock in pipe_lock (2) C error 155 625d 1791d 0/1 upstream: reported C repro on 2019/12/26 07:17
upstream possible deadlock in pipe_lock (5) overlayfs C done 5 1215d 1215d 20/28 fixed on 2021/11/10 00:50
android-49 possible deadlock in pipe_lock 5 1854d 2047d 0/3 auto-closed as invalid on 2020/02/21 12:40
linux-4.19 possible deadlock in pipe_lock C done 2 2033d 2037d 1/1 fixed on 2019/11/29 10:34
android-44 possible deadlock in pipe_lock C 82 1814d 2047d 0/2 public: reported C repro on 2019/04/14 08:51
upstream possible deadlock in pipe_lock (3) overlayfs C inconclusive done 4 1754d 1791d 15/28 fixed on 2020/08/18 22:40

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc6-syzkaller-00169-g906bd684e4b1 #0 Not tainted
------------------------------------------------------
syz.1.1936/13111 is trying to acquire lock:
ffff888049d13068 (&pipe->mutex){+.+.}-{3:3}, at: pipe_lock fs/pipe.c:92 [inline]
ffff888049d13068 (&pipe->mutex){+.+.}-{3:3}, at: pipe_lock+0x64/0x80 fs/pipe.c:89

but task is already holding lock:
ffff888104f76420 (sb_writers#6){.+.+}-{0:0}, at: ovl_splice_write+0x22f/0x2a0 fs/overlayfs/file.c:383

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (sb_writers#6){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1716 [inline]
       sb_start_write include/linux/fs.h:1852 [inline]
       mnt_want_write+0x6f/0x450 fs/namespace.c:515
       ovl_create_object+0x12e/0x300 fs/overlayfs/dir.c:642
       lookup_open.isra.0+0x1174/0x14c0 fs/namei.c:3595
       open_last_lookups fs/namei.c:3694 [inline]
       path_openat+0x904/0x2d60 fs/namei.c:3930
       do_filp_open+0x1dc/0x430 fs/namei.c:3960
       do_sys_openat2+0x17a/0x1e0 fs/open.c:1415
       do_sys_open fs/open.c:1430 [inline]
       __do_sys_openat fs/open.c:1446 [inline]
       __se_sys_openat fs/open.c:1441 [inline]
       __x64_sys_openat+0x175/0x210 fs/open.c:1441
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ovl_i_mutex_dir_key[depth]#2){++++}-{3:3}:
       down_read+0x9a/0x330 kernel/locking/rwsem.c:1524
       inode_lock_shared include/linux/fs.h:825 [inline]
       lookup_slow fs/namei.c:1748 [inline]
       walk_component+0x342/0x5b0 fs/namei.c:2053
       lookup_last fs/namei.c:2556 [inline]
       path_lookupat+0x17f/0x770 fs/namei.c:2580
       filename_lookup+0x1e5/0x5b0 fs/namei.c:2609
       kern_path+0x35/0x50 fs/namei.c:2717
       lookup_bdev+0xd9/0x280 block/bdev.c:1164
       resume_store+0x1d8/0x460 kernel/power/hibernate.c:1239
       kobj_attr_store+0x55/0x80 lib/kobject.c:840
       sysfs_kf_write+0x117/0x170 fs/sysfs/file.c:136
       kernfs_fop_write_iter+0x33d/0x500 fs/kernfs/file.c:334
       new_sync_write fs/read_write.c:590 [inline]
       vfs_write+0x5ae/0x1150 fs/read_write.c:683
       ksys_write+0x12f/0x260 fs/read_write.c:736
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&of->mutex){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       kernfs_fop_write_iter+0x27b/0x500 fs/kernfs/file.c:325
       iter_file_splice_write+0x90f/0x10b0 fs/splice.c:743
       do_splice_from fs/splice.c:941 [inline]
       do_splice+0x145c/0x1f60 fs/splice.c:1354
       __do_splice+0x327/0x360 fs/splice.c:1436
       __do_sys_splice fs/splice.c:1652 [inline]
       __se_sys_splice fs/splice.c:1634 [inline]
       __x64_sys_splice+0x1cd/0x270 fs/splice.c:1634
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&pipe->mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825
       __mutex_lock_common kernel/locking/mutex.c:608 [inline]
       __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
       pipe_lock fs/pipe.c:92 [inline]
       pipe_lock+0x64/0x80 fs/pipe.c:89
       iter_file_splice_write+0x1eb/0x10b0 fs/splice.c:687
       backing_file_splice_write+0x22e/0x890 fs/backing-file.c:315
       ovl_splice_write+0x22f/0x2a0 fs/overlayfs/file.c:383
       do_splice_from fs/splice.c:941 [inline]
       do_splice+0x145c/0x1f60 fs/splice.c:1354
       __do_splice+0x327/0x360 fs/splice.c:1436
       __do_sys_splice fs/splice.c:1652 [inline]
       __se_sys_splice fs/splice.c:1634 [inline]
       __x64_sys_splice+0x1cd/0x270 fs/splice.c:1634
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &pipe->mutex --> &ovl_i_mutex_dir_key[depth]#2 --> sb_writers#6

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(sb_writers#6);
                               lock(&ovl_i_mutex_dir_key[depth]#2);
                               lock(sb_writers#6);
  lock(&pipe->mutex);

 *** DEADLOCK ***

3 locks held by syz.1.1936/13111:
 #0: ffff88802ab88420 (sb_writers#16){.+.+}-{0:0}, at: __do_splice+0x327/0x360 fs/splice.c:1436
 #1: ffff88804d73d258 (&ovl_i_mutex_key[depth]){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:815 [inline]
 #1: ffff88804d73d258 (&ovl_i_mutex_key[depth]){+.+.}-{3:3}, at: ovl_splice_write+0x177/0x2a0 fs/overlayfs/file.c:375
 #2: ffff888104f76420 (sb_writers#6){.+.+}-{0:0}, at: ovl_splice_write+0x22f/0x2a0 fs/overlayfs/file.c:383

stack backtrace:
CPU: 2 UID: 0 PID: 13111 Comm: syz.1.1936 Not tainted 6.12.0-rc6-syzkaller-00169-g906bd684e4b1 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x41c/0x610 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x250b/0x3ce0 kernel/locking/lockdep.c:5202
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5825
 __mutex_lock_common kernel/locking/mutex.c:608 [inline]
 __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752
 pipe_lock fs/pipe.c:92 [inline]
 pipe_lock+0x64/0x80 fs/pipe.c:89
 iter_file_splice_write+0x1eb/0x10b0 fs/splice.c:687
 backing_file_splice_write+0x22e/0x890 fs/backing-file.c:315
 ovl_splice_write+0x22f/0x2a0 fs/overlayfs/file.c:383
 do_splice_from fs/splice.c:941 [inline]
 do_splice+0x145c/0x1f60 fs/splice.c:1354
 __do_splice+0x327/0x360 fs/splice.c:1436
 __do_sys_splice fs/splice.c:1652 [inline]
 __se_sys_splice fs/splice.c:1634 [inline]
 __x64_sys_splice+0x1cd/0x270 fs/splice.c:1634
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fa08837e719
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fa0891df038 EFLAGS: 00000246 ORIG_RAX: 0000000000000113
RAX: ffffffffffffffda RBX: 00007fa088535f80 RCX: 00007fa08837e719
RDX: 0000000000000008 RSI: 0000000000000000 RDI: 0000000000000006
RBP: 00007fa0883f139e R08: 0010000000000016 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fa088535f80 R15: 00007ffde7aea6d8
 </TASK>

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/11/08 06:26 upstream 906bd684e4b1 179b040e .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in pipe_lock
2024/11/04 04:35 upstream a33ab3f94f51 f00eed24 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in pipe_lock
* Struck through repros no longer work on HEAD.