syzbot


KASAN: null-ptr-deref Read in phy_disconnect

Status: fixed on 2021/11/10 00:50
Subsystems: net usb
[Documentation on labels]
Reported-by: syzbot+6a916267d9bc5fa2d9a6@syzkaller.appspotmail.com
Fix commit: 1406e8cb4b05 net: usb: asix: do not call phy_disconnect() for ax88178
First crash: 1014d, last: 989d
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] KASAN: null-ptr-deref Read in phy_disconnect 4 (5) 2021/08/31 15:34

Sample crash report:
asix 1-1:0.0 eth1: register 'asix' at usb-dummy_hcd.0-1, ASIX AX88178 USB 2.0 Ethernet, 8a:c0:d1:1e:27:4c
usb 1-1: USB disconnect, device number 2
asix 1-1:0.0 eth1: unregister 'asix' usb-dummy_hcd.0-1, ASIX AX88178 USB 2.0 Ethernet
general protection fault, probably for non-canonical address 0xdffffc00000000c3: 0000 [#1] SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000618-0x000000000000061f]
CPU: 1 PID: 32 Comm: kworker/1:1 Not tainted 5.14.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: usb_hub_wq hub_event
RIP: 0010:phy_is_started include/linux/phy.h:947 [inline]
RIP: 0010:phy_disconnect+0x22/0x110 drivers/net/phy/phy_device.c:1097
Code: 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 e8 46 33 68 fe 48 8d bd 18 06 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e c5 00 00 00 8b 9d 18 06 00 00
RSP: 0018:ffffc900001a7780 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff88811a410bc0 RCX: 0000000000000000
RDX: 00000000000000c3 RSI: ffffffff82d9305a RDI: 0000000000000618
RBP: 0000000000000000 R08: 0000000000000055 R09: 0000000000000000
R10: ffffffff814c05fb R11: 0000000000000000 R12: ffff8881063cc300
R13: ffffffff83870d90 R14: ffffffff86805a20 R15: ffffffff868059e0
FS:  0000000000000000(0000) GS:ffff8881f6900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb4c30b3008 CR3: 00000001021e1000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 ax88772_unbind+0x51/0x90 drivers/net/usb/asix_devices.c:816
 usbnet_disconnect+0x103/0x270 drivers/net/usb/usbnet.c:1618
 usb_unbind_interface+0x1d8/0x8d0 drivers/usb/core/driver.c:458
 __device_release_driver+0x3bd/0x6f0 drivers/base/dd.c:1201
 device_release_driver_internal drivers/base/dd.c:1232 [inline]
 device_release_driver+0x26/0x40 drivers/base/dd.c:1255
 bus_remove_device+0x2eb/0x5a0 drivers/base/bus.c:529
 device_del+0x502/0xd40 drivers/base/core.c:3543
 usb_disable_device+0x35b/0x7b0 drivers/usb/core/message.c:1419
 usb_disconnect.cold+0x27a/0x78e drivers/usb/core/hub.c:2225
 hub_port_connect drivers/usb/core/hub.c:5199 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5488 [inline]
 port_event drivers/usb/core/hub.c:5634 [inline]
 hub_event+0x1c9c/0x4330 drivers/usb/core/hub.c:5716
 process_one_work+0x98d/0x15b0 kernel/workqueue.c:2276
 process_scheduled_works kernel/workqueue.c:2338 [inline]
 worker_thread+0x85c/0x11f0 kernel/workqueue.c:2424
 kthread+0x3c0/0x4a0 kernel/kthread.c:319
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
Modules linked in:
---[ end trace d08c08ba92f8f06f ]---
RIP: 0010:phy_is_started include/linux/phy.h:947 [inline]
RIP: 0010:phy_disconnect+0x22/0x110 drivers/net/phy/phy_device.c:1097
Code: 0f 1f 84 00 00 00 00 00 55 48 89 fd 53 e8 46 33 68 fe 48 8d bd 18 06 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa 48 c1 ea 03 <0f> b6 04 02 84 c0 74 08 3c 03 0f 8e c5 00 00 00 8b 9d 18 06 00 00
RSP: 0018:ffffc900001a7780 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: ffff88811a410bc0 RCX: 0000000000000000
RDX: 00000000000000c3 RSI: ffffffff82d9305a RDI: 0000000000000618
RBP: 0000000000000000 R08: 0000000000000055 R09: 0000000000000000
R10: ffffffff814c05fb R11: 0000000000000000 R12: ffff8881063cc300
R13: ffffffff83870d90 R14: ffffffff86805a20 R15: ffffffff868059e0
FS:  0000000000000000(0000) GS:ffff8881f6900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fb4c30b3008 CR3: 00000001021e1000 CR4: 00000000001506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
----------------
Code disassembly (best guess):
   0:	0f 1f 84 00 00 00 00 	nopl   0x0(%rax,%rax,1)
   7:	00
   8:	55                   	push   %rbp
   9:	48 89 fd             	mov    %rdi,%rbp
   c:	53                   	push   %rbx
   d:	e8 46 33 68 fe       	callq  0xfe683358
  12:	48 8d bd 18 06 00 00 	lea    0x618(%rbp),%rdi
  19:	48 b8 00 00 00 00 00 	movabs $0xdffffc0000000000,%rax
  20:	fc ff df
  23:	48 89 fa             	mov    %rdi,%rdx
  26:	48 c1 ea 03          	shr    $0x3,%rdx
* 2a:	0f b6 04 02          	movzbl (%rdx,%rax,1),%eax <-- trapping instruction
  2e:	84 c0                	test   %al,%al
  30:	74 08                	je     0x3a
  32:	3c 03                	cmp    $0x3,%al
  34:	0f 8e c5 00 00 00    	jle    0xff
  3a:	8b 9d 18 06 00 00    	mov    0x618(%rbp),%ebx

Crashes (255):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/08/28 22:41 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 be2c130d .config console log report syz C ci2-upstream-usb general protection fault in phy_disconnect
2021/09/04 07:54 git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes 417166ddec02 d236a457 .config console log report info ci-qemu2-riscv64 KASAN: null-ptr-deref Read in phy_disconnect
2021/08/23 16:15 git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes aa3e1ba32e55 b599f2fc .config console log report info ci-qemu2-riscv64 KASAN: null-ptr-deref Read in phy_disconnect
2021/08/15 03:35 git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes fdf3a7a1e0a6 2489ab88 .config console log report info ci-qemu2-riscv64 KASAN: null-ptr-deref Read in phy_disconnect
2021/08/10 12:45 git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes 867432bec1c6 6972b106 .config console log report info ci-qemu2-riscv64 KASAN: null-ptr-deref Read in phy_disconnect
2021/09/01 17:49 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 16:29 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 15:03 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 12:42 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 11:18 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 10:53 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 09:39 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 08:16 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 07:06 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 05:49 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 05:02 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 03:26 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 02:11 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 00:51 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/09/01 00:15 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 23:04 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 21:38 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 21:30 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 20:28 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 19:27 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 18:15 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 17:34 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 16:18 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 15:14 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 7eb7e152 .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 13:20 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 12:01 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 11:22 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 10:21 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 09:10 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 08:05 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 06:57 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 05:31 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 04:01 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 02:51 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 01:44 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/31 00:15 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 23:49 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 22:44 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 21:23 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 20:22 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 20:05 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 19:03 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
2021/08/30 17:59 https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing 9c1587d99f93 8f58a0ef .config console log report info ci2-upstream-usb general protection fault in phy_disconnect
* Struck through repros no longer work on HEAD.