memory leak in pppoe_sendmsg

Status: fixed on 2024/03/28 13:35
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+6bdfd184eac7709e5cc9@syzkaller.appspotmail.com
Fix commit: dc34ebd5c018 pppoe: Fix memory leak in pppoe_sendmsg()
First crash: 2614d, last: 941d
▶ ▼ Discussions (7)
Title Replies (including bot) Last reply
[PATCH 6.6/6.1 1/1] pppoe: Fix memory leak in pppoe_sendmsg() 1 (1) 2024/04/15 11:51
[PATCH 5.15/5.10/5.4/4.19 1/1] pppoe: Fix memory leak in pppoe_sendmsg() 1 (1) 2024/04/15 11:50
[PATCH 5.15/5.10/5.4/4.19 1/1] pppoe: Fix memory leak in pppoe_sendmsg() 1 (1) 2024/03/21 09:12
[PATCH 6.6/6.1 1/1] pppoe: Fix memory leak in pppoe_sendmsg() 1 (1) 2024/03/20 14:36
[PATCH net] pppoe: Fix memory leak in pppoe_sendmsg() 3 (3) 2024/02/15 16:00
Reminder: 1 open syzbot bug in "net/ppp" subsystem 1 (1) 2019/07/24 02:52
memory leak in pppoe_sendmsg 0 (2) 2019/06/28 18:58
▶ ▼ Last patch testing requests (15)
Created Duration User Patch Repo Result
2024/02/05 17:08 11m retest repro upstream report log
2024/01/27 11:40 1h21m retest repro upstream report log
2024/01/27 11:40 47m retest repro upstream report log
2024/01/12 15:40 3h12m retest repro upstream report log
2024/01/12 15:40 17m retest repro upstream report log
2024/01/12 15:40 10m retest repro upstream report log
2023/12/26 09:22 18m retest repro upstream report log
2023/12/26 09:22 10m retest repro upstream report log
2023/12/12 07:33 14m retest repro upstream report log
2023/12/12 07:33 22m retest repro upstream report log
2023/02/21 14:33 8m phind.uet@gmail.com linux-next report log
2021/07/19 03:58 15m phind.uet@gmail.com upstream OK
2021/07/19 03:14 15m phind.uet@gmail.com upstream OK
2021/07/19 02:21 15m phind.uet@gmail.com upstream report log
2020/10/16 23:45 15m anant.thazhemadam@gmail.com upstream report log

Sample crash report:
executing program
executing program
executing program
executing program
executing program
BUG: memory leak
unreferenced object 0xffff88810b949800 (size 240):
  comm "syz-executor228", pid 5076, jiffies 4294950439 (age 19.670s)
  hex dump (first 32 bytes):
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
    00 00 00 00 00 00 00 00 00 a4 79 10 81 88 ff ff  ..........y.....
  backtrace:
    [<ffffffff81632167>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff81632167>] slab_post_alloc_hook mm/slab.h:766 [inline]
    [<ffffffff81632167>] slab_alloc_node mm/slub.c:3478 [inline]
    [<ffffffff81632167>] kmem_cache_alloc_node+0x2c7/0x450 mm/slub.c:3523
    [<ffffffff83edc57f>] __alloc_skb+0x1ef/0x230 net/core/skbuff.c:641
    [<ffffffff83ed0283>] alloc_skb include/linux/skbuff.h:1286 [inline]
    [<ffffffff83ed0283>] sock_wmalloc+0x63/0x90 net/core/sock.c:2629
    [<ffffffff8304e1fc>] pppoe_sendmsg+0x10c/0x2d0 drivers/net/ppp/pppoe.c:867
    [<ffffffff83ec66c2>] sock_sendmsg_nosec net/socket.c:730 [inline]
    [<ffffffff83ec66c2>] __sock_sendmsg+0x52/0xa0 net/socket.c:745
    [<ffffffff83ec680b>] sock_write_iter+0xfb/0x180 net/socket.c:1158
    [<ffffffff81696ad7>] call_write_iter include/linux/fs.h:2020 [inline]
    [<ffffffff81696ad7>] new_sync_write fs/read_write.c:491 [inline]
    [<ffffffff81696ad7>] vfs_write+0x327/0x590 fs/read_write.c:584
    [<ffffffff8169702b>] ksys_write+0x13b/0x170 fs/read_write.c:637
    [<ffffffff84b71ebf>] do_syscall_x64 arch/x86/entry/common.c:52 [inline]
    [<ffffffff84b71ebf>] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:83
    [<ffffffff84c0008b>] entry_SYSCALL_64_after_hwframe+0x63/0x6b

BUG: memory leak
unreferenced object 0xffff888109371900 (size 640):
  comm "syz-executor228", pid 5076, jiffies 4294950439 (age 19.670s)
  hex dump (first 32 bytes):
    00 00 aa aa aa aa aa 0a aa aa aa aa aa 0a 88 64  ...............d
    11 00 04 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<ffffffff81632167>] kmemleak_alloc_recursive include/linux/kmemleak.h:42 [inline]
    [<ffffffff81632167>] slab_post_alloc_hook mm/slab.h:766 [inline]
    [<ffffffff81632167>] slab_alloc_node mm/slub.c:3478 [inline]
    [<ffffffff81632167>] kmem_cache_alloc_node+0x2c7/0x450 mm/slub.c:3523
    [<ffffffff83ed88d2>] kmalloc_reserve+0xe2/0x170 net/core/skbuff.c:560
    [<ffffffff83edc465>] __alloc_skb+0xd5/0x230 net/core/skbuff.c:651
    [<ffffffff83ed0283>] alloc_skb include/linux/skbuff.h:1286 [inline]
    [<ffffffff83ed0283>] sock_wmalloc+0x63/0x90 net/core/sock.c:2629
    [<ffffffff8304e1fc>] pppoe_sendmsg+0x10c/0x2d0 drivers/net/ppp/pppoe.c:867
    [<ffffffff83ec66c2>] sock_sendmsg_nosec net/socket.c:730 [inline]
    [<ffffffff83ec66c2>] __sock_sendmsg+0x52/0xa0 net/socket.c:745
    [<ffffffff83ec680b>] sock_write_iter+0xfb/0x180 net/socket.c:1158
    [<ffffffff81696ad7>] call_write_iter include/linux/fs.h:2020 [inline]
    [<ffffffff81696ad7>] new_sync_write fs/read_write.c:491 [inline]
    [<ffffffff81696ad7>] vfs_write+0x327/0x590 fs/read_write.c:584
    [<ffffffff8169702b>] ksys_write+0x13b/0x170 fs/read_write.c:637
    [<ffffffff84b71ebf>] do_syscall_x64 arch/x86/entry/common.c:52 [inline]
    [<ffffffff84b71ebf>] do_syscall_64+0x3f/0x110 arch/x86/entry/common.c:83
    [<ffffffff84c0008b>] entry_SYSCALL_64_after_hwframe+0x63/0x6b

Crashes (26):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/12/28 10:16 upstream f5837722ffec fb427a07 .config console log report syz C [disk image] [vmlinux] [kernel image] ci-upstream-gce-leak memory leak in pppoe_sendmsg
2019/12/17 10:47 upstream ea200dec5128 d13d7958 .config console log report syz C ci-upstream-gce-leak
2019/11/10 17:51 upstream 00aff6836241 dc438b91 .config console log report syz C ci-upstream-gce-leak
2019/09/11 15:49 upstream 3120b9a6a3f7 a60cb4cd .config console log report syz C ci-upstream-gce-leak
2019/08/21 03:09 upstream 5f97cbe22b76 cfc9868f .config console log report syz C ci-upstream-gce-leak
2019/08/17 00:01 upstream 2d63ba3e41db 8fd428a1 .config console log report syz C ci-upstream-gce-leak
2019/06/28 18:57 upstream c84afab02c31 7509bf36 .config console log report syz C ci-upstream-gce-leak
2023/09/18 01:42 upstream e789286468a9 0b6a67ac .config console log report syz ci-upstream-gce-leak memory leak in pppoe_sendmsg
2020/07/29 03:25 upstream 6ba1b005ffc3 cb93dc6a .config console log report syz ci-upstream-gce-leak
2019/12/07 14:49 upstream eea2d5da29e3 85f26751 .config console log report syz ci-upstream-gce-leak
2019/10/27 14:53 upstream 5a1e843c66fa 25bb509e .config console log report syz ci-upstream-gce-leak
2019/06/18 03:58 upstream 9e0babf2c06c 442206d7 .config console log report syz ci-upstream-gce-leak
2019/06/15 15:07 upstream 0011572c8830 442206d7 .config console log report syz ci-upstream-gce-leak
2023/02/19 21:33 upstream 925cf0457d7e bcdf85f8 .config console log report syz ci-upstream-gce-leak memory leak in pppoe_sendmsg
2022/09/29 02:30 upstream 49c13ed0316d e2556bc3 .config console log report syz [disk image] [vmlinux] ci-upstream-gce-leak memory leak in pppoe_sendmsg
2022/05/13 04:08 upstream 0ac824f379fb 9ad6612a .config console log report syz ci-upstream-gce-leak memory leak in pppoe_sendmsg
2019/12/23 14:49 upstream 46cf053efec6 be5c2c81 .config console log report syz ci-upstream-gce-leak
2019/12/17 12:59 upstream ea200dec5128 d13d7958 .config console log report syz ci-upstream-gce-leak
2019/11/18 17:00 upstream af42d3466bdc 1daed50a .config console log report syz ci-upstream-gce-leak
2019/11/04 09:12 upstream a99d8080aaf3 b35fad31 .config console log report syz ci-upstream-gce-leak
2019/10/13 07:41 upstream 328fefadd9cf 426631dd .config console log report syz ci-upstream-gce-leak
2019/09/08 15:32 upstream b3a9964cfa69 a60cb4cd .config console log report syz ci-upstream-gce-leak
2019/07/17 19:19 upstream 0a8ad0ffa4d8 f613a7c4 .config console log report syz ci-upstream-gce-leak
2019/06/12 00:12 upstream 01ccc3ad4413 ea2f4006 .config console log report syz ci-upstream-gce-leak
2019/06/05 16:35 upstream 788a024921c4 bfb4a51e .config console log report syz ci-upstream-gce-leak
2019/05/30 11:48 upstream bec7550cca10 d9aaf3c2 .config console log report syz ci-upstream-gce-leak
* Struck through repros no longer work on HEAD.