syzbot


possible deadlock in __lock_task_sighand

Status: fixed on 2020/09/25 01:17
Subsystems: io-uring
[Documentation on labels]
Reported-by: syzbot+6e8f5b555cce8fac0423@syzkaller.appspotmail.com
Fix commit: fd7d6de22414 io_uring: don't recurse on tsk->sighand->siglock with signalfd
First crash: 1387d, last: 1381d
Cause bisection: introduced by (bisect log) :
commit 0ba9c9edcd152158a0e321a4c13ac1dfc571ff3d
Author: Jens Axboe <axboe@kernel.dk>
Date: Fri Aug 7 01:41:50 2020 +0000

  io_uring: use TWA_SIGNAL for task_work uncondtionally

Crash: possible deadlock in __lock_task_sighand (log)
Repro: C syz .config
  
Discussions (1)
Title Replies (including bot) Last reply
possible deadlock in __lock_task_sighand 1 (2) 2020/08/30 00:34
Similar bugs (4)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in __lock_task_sighand (2) bpf net C 1476 22d 86d 26/28 fixed on 2024/05/22 23:36
upstream possible deadlock in __lock_task_sighand (3) bpf C done 24 2d19h 17d 0/28 upstream: reported C repro on 2024/05/27 03:07
linux-6.1 possible deadlock in __lock_task_sighand origin:upstream C 158 7d08h 90d 0/3 upstream: reported C repro on 2024/03/14 22:46
linux-5.15 possible deadlock in __lock_task_sighand origin:upstream C 98 7h36m 90d 0/3 upstream: reported C repro on 2024/03/14 19:24

Sample crash report:
============================================
WARNING: possible recursive locking detected
5.9.0-rc2-syzkaller #0 Not tainted
--------------------------------------------
syz-executor427/6851 is trying to acquire lock:
ffff888095008098 (&sighand->siglock){....}-{2:2}, at: __lock_task_sighand+0x106/0x2d0 kernel/signal.c:1390

but task is already holding lock:
ffff888095008098 (&sighand->siglock){....}-{2:2}, at: force_sig_info_to_task+0x6c/0x3a0 kernel/signal.c:1316

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&sighand->siglock);
  lock(&sighand->siglock);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

3 locks held by syz-executor427/6851:
 #0: ffff888095008098 (&sighand->siglock){....}-{2:2}, at: force_sig_info_to_task+0x6c/0x3a0 kernel/signal.c:1316
 #1: ffff8880950080e0 (&sighand->signalfd_wqh){....}-{2:2}, at: __wake_up_common_lock+0xb4/0x130 kernel/sched/wait.c:122
 #2: ffffffff89bd6900 (rcu_read_lock){....}-{1:2}, at: __lock_task_sighand+0x0/0x2d0 kernel/signal.c:1352

stack backtrace:
CPU: 1 PID: 6851 Comm: syz-executor427 Not tainted 5.9.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x18f/0x20d lib/dump_stack.c:118
 print_deadlock_bug kernel/locking/lockdep.c:2391 [inline]
 check_deadlock kernel/locking/lockdep.c:2432 [inline]
 validate_chain kernel/locking/lockdep.c:3202 [inline]
 __lock_acquire.cold+0x115/0x396 kernel/locking/lockdep.c:4426
 lock_acquire+0x1f1/0xad0 kernel/locking/lockdep.c:5005
 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
 _raw_spin_lock_irqsave+0x8c/0xc0 kernel/locking/spinlock.c:159
 __lock_task_sighand+0x106/0x2d0 kernel/signal.c:1390
 lock_task_sighand include/linux/sched/signal.h:687 [inline]
 task_work_add+0x1d7/0x290 kernel/task_work.c:51
 io_req_task_work_add fs/io_uring.c:1765 [inline]
 __io_async_wake+0x415/0x980 fs/io_uring.c:4589
 __wake_up_common+0x147/0x650 kernel/sched/wait.c:93
 __wake_up_common_lock+0xd0/0x130 kernel/sched/wait.c:123
 signalfd_notify include/linux/signalfd.h:22 [inline]
 __send_signal+0x75b/0xf90 kernel/signal.c:1163
 force_sig_info_to_task+0x2a0/0x3a0 kernel/signal.c:1333
 force_sig_fault_to_task kernel/signal.c:1672 [inline]
 force_sig_fault+0xb0/0xf0 kernel/signal.c:1679
 __bad_area_nosemaphore+0x32a/0x480 arch/x86/mm/fault.c:778
 do_user_addr_fault+0x852/0xbf0 arch/x86/mm/fault.c:1257
 handle_page_fault arch/x86/mm/fault.c:1351 [inline]
 exc_page_fault+0xa8/0x160 arch/x86/mm/fault.c:1404
 asm_exc_page_fault+0x1e/0x30 arch/x86/include/asm/idtentry.h:538
RIP: 0033:0x400d4d
Code: 48 8b 54 24 e0 8b 86 0c 01 00 00 44 8b 86 08 01 00 00 c1 e0 04 8d b8 7f 01 00 00 83 e7 c0 45 85 c0 74 07 89 d0 31 d2 41 f7 f0 <4c> 8b 01 89 d0 c1 e0 06 4c 01 c8 4c 89 00 4c 8b 41 08 4c 89 40 08
RSP: 002b:00007ffffa7ff7c8 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 0000000000000004 RCX: 0000000000000000
RDX: 0000000000000005 RSI: 0000000020ee7000 RDI: 0000000000002140
RBP: 00000000006ca018 R08: 0000000000000100 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401d20
R13: 0000000000401db0 R14: 0000000000000000 R15: 0000000000000000

Crashes (12):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/08/26 10:53 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce-selinux-root
2020/08/26 10:40 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/08/26 10:32 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce
2020/08/26 10:03 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce-root
2020/08/26 00:23 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce
2020/08/26 10:43 upstream abb3438d69fb 344da168 .config console log report syz C ci-upstream-kasan-gce-386
2020/08/26 10:14 linux-next 3a00d3dfd4b6 344da168 .config console log report syz C ci-upstream-linux-next-kasan-gce-root
2020/08/29 10:52 upstream 96d454cd2c16 d5a3ae1f .config console log report ci-upstream-kasan-gce-root
2020/08/26 12:36 upstream 2ac69819ba9e 318430cb .config console log report ci-upstream-kasan-gce
2020/08/25 23:59 upstream abb3438d69fb 344da168 .config console log report ci-upstream-kasan-gce
2020/08/31 18:34 linux-next b36c969764ab d5a3ae1f .config console log report ci-upstream-linux-next-kasan-gce-root
2020/08/26 08:38 linux-next 3a00d3dfd4b6 344da168 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.