WARNING: ODEBUG bug in tls_sw_free_resources_tx

Status: fixed on 2019/08/27 17:15
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+70ab6a1f8151888c4ea0@syzkaller.appspotmail.com
Fix commit: f87e62d45e51 net/tls: remove close callback sock unlock/lock around TX work flush
First crash: 2825d, last: 2564d
▶ ▼ Discussions (2)
Title Replies (including bot) Last reply
WARNING: ODEBUG bug in tls_sw_free_resources_tx 1 (2) 2019/08/19 22:37
Reminder: 17 open syzbot bugs in "net/tls" subsystem 1 (1) 2019/06/25 05:50

Sample crash report:
libceph: parse_ips bad ip ':E,%
nullb'
ntfs: (device loop3): parse_options(): Unrecognized mount option fsuuid.
------------[ cut here ]------------
ODEBUG: free active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x90 kernel/workqueue.c:4939
WARNING: CPU: 1 PID: 23675 at lib/debugobjects.c:325 debug_print_object+0x16a/0x250 lib/debugobjects.c:325
Kernel panic - not syncing: panic_on_warn set ...
CPU: 1 PID: 23675 Comm: syz-executor.1 Not tainted 5.0.0-rc8+ #88
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 panic+0x2cb/0x65c kernel/panic.c:214
 __warn.cold+0x20/0x45 kernel/panic.c:571
 report_bug+0x263/0x2b0 lib/bug.c:186
 fixup_bug arch/x86/kernel/traps.c:178 [inline]
 fixup_bug arch/x86/kernel/traps.c:173 [inline]
 do_error_trap+0x11b/0x200 arch/x86/kernel/traps.c:271
 do_invalid_op+0x37/0x50 arch/x86/kernel/traps.c:290
 invalid_op+0x14/0x20 arch/x86/entry/entry_64.S:973
RIP: 0010:debug_print_object+0x16a/0x250 lib/debugobjects.c:325
Code: dd 00 4f a2 87 48 89 fa 48 c1 ea 03 80 3c 02 00 0f 85 b5 00 00 00 48 8b 14 dd 00 4f a2 87 48 c7 c7 a0 44 a2 87 e8 54 1f 18 fe <0f> 0b 83 05 c1 a0 31 06 01 48 83 c4 20 5b 41 5c 41 5d 41 5e 5d c3
RSP: 0018:ffff8880a51f7b30 EFLAGS: 00010082
RAX: 0000000000000000 RBX: 0000000000000003 RCX: 0000000000000000
RDX: 00000000000346e8 RSI: ffffffff815a9066 RDI: ffffed1014a3ef58
RBP: ffff8880a51f7b70 R08: ffff888088f46280 R09: ffffed1015d23ef9
R10: ffffed1015d23ef8 R11: ffff8880ae91f7c7 R12: 0000000000000001
R13: ffffffff889add20 R14: ffffffff815fc040 R15: ffff88808d4418a0
 __debug_check_no_obj_freed lib/debugobjects.c:785 [inline]
 debug_check_no_obj_freed+0x29f/0x464 lib/debugobjects.c:817
 kfree+0xbd/0x230 mm/slab.c:3810
 tls_sw_free_resources_tx+0x664/0xa20 net/tls/tls_sw.c:1838
 tls_sk_proto_close+0x66c/0x760 net/tls/tls_main.c:280
 inet_release+0x105/0x1f0 net/ipv4/af_inet.c:428
 inet6_release+0x53/0x80 net/ipv6/af_inet6.c:473
 __sock_release+0xd3/0x250 net/socket.c:579
 sock_close+0x1b/0x30 net/socket.c:1139
 __fput+0x2df/0x8d0 fs/file_table.c:278
 ____fput+0x16/0x20 fs/file_table.c:309
 task_work_run+0x14a/0x1c0 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:188 [inline]
 exit_to_usermode_loop+0x273/0x2c0 arch/x86/entry/common.c:166
 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:268 [inline]
 do_syscall_64+0x52d/0x610 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x457e29
Code: ad b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b8 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f46f2cbcc78 EFLAGS: 00000246 ORIG_RAX: 0000000000000003
RAX: 0000000000000000 RBX: 0000000000000001 RCX: 0000000000457e29
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 000000000073bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f46f2cbd6d4
R13: 00000000004f4d52 R14: 00000000004ce8f8 R15: 00000000ffffffff

======================================================

Crashes (23):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/02/27 08:31 upstream 7d762d69145a f2468c12 .config console log report ci-upstream-kasan-gce-smack-root
2019/02/16 11:22 upstream 5ded5871030e f42dee6d .config console log report ci-upstream-kasan-gce-selinux-root
2019/02/12 21:45 upstream aa0c38cf39de 6ecc6d0f .config console log report ci-upstream-kasan-gce-smack-root
2019/01/31 23:01 upstream 9f789567142c 0e8ea0a3 .config console log report ci-upstream-kasan-gce-smack-root
2019/01/30 07:51 upstream 62967898789d aa432daf .config console log report ci-upstream-kasan-gce
2019/06/17 23:13 net-old 6be8e297f9bc 442206d7 .config console log report ci-upstream-net-this-kasan-gce
2019/04/30 16:00 net-old 6c0afef5fb0c 20f16bef .config console log report ci-upstream-net-this-kasan-gce
2019/04/11 03:56 net-old f8d49bee4a5e e955ac50 .config console log report ci-upstream-net-this-kasan-gce
2019/02/17 17:12 net-old 6e1077f51436 3e98cc30 .config console log report ci-upstream-net-this-kasan-gce
2019/02/16 11:51 net-old 24f0a48743a2 f42dee6d .config console log report ci-upstream-net-this-kasan-gce
2019/02/11 08:55 net-old 31b58ad0c327 b4f792e4 .config console log report ci-upstream-net-this-kasan-gce
2019/07/23 16:20 net-next-old 31cc088a4f5d de453f34 .config console log report ci-upstream-net-kasan-gce
2019/05/22 19:25 net-next-old f49aa1de9836 84b9d384 .config console log report ci-upstream-net-kasan-gce
2019/05/20 09:04 net-next-old 35c99ffa20ed 5a4461b0 .config console log report ci-upstream-net-kasan-gce
2019/05/19 10:28 net-next-old 35c99ffa20ed 5a4461b0 .config console log report ci-upstream-net-kasan-gce
2019/05/12 04:11 net-next-old b970afcfcabd 0637a7f0 .config console log report ci-upstream-net-kasan-gce
2019/04/29 21:37 net-next-old 88d6272acaaa b617407b .config console log report ci-upstream-net-kasan-gce
2019/04/25 13:34 net-next-old c049d56eb219 8e3c52b1 .config console log report ci-upstream-net-kasan-gce
2019/04/20 12:03 net-next-old d7cc399e1227 b0e8efcb .config console log report ci-upstream-net-kasan-gce
2019/04/08 08:58 net-next-old 1e045a62eea6 c34fde03 .config console log report ci-upstream-net-kasan-gce
2019/03/03 03:04 net-next-old cf29576fee60 1c0e457a .config console log report ci-upstream-net-kasan-gce
2018/11/04 10:55 net-next-old 7c6c54b505b8 8bd6bd63 .config console log report ci-upstream-net-kasan-gce
2019/06/25 23:20 linux-next 902031767aec 0a8d1a96 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.