syzbot


possible deadlock in run_unpack_ex

Status: upstream: reported on 2024/11/08 07:38
Subsystems: ntfs3
[Documentation on labels]
Reported-by: syzbot+731b27ee9413ba859499@syzkaller.appspotmail.com
First crash: 5d15h, last: 13h58m
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [ntfs3?] possible deadlock in run_unpack_ex 0 (1) 2024/11/08 07:38

Sample crash report:
loop5: detected capacity change from 0 to 4096
ntfs3(loop5): failed to convert "0080" to cp737
ntfs3(loop5): Mark volume as dirty due to NTFS errors
======================================================
WARNING: possible circular locking dependency detected
6.12.0-rc6-next-20241108-syzkaller #0 Not tainted
------------------------------------------------------
syz.5.2396/16280 is trying to acquire lock:
ffff88805f2f1060 (&ni->file.run_lock#2){++++}-{4:4}, at: run_unpack_ex+0x55e/0x9e0 fs/ntfs3/run.c:1119

but task is already holding lock:
ffff88805994a270 (&wnd->rw_lock){++++}-{4:4}, at: run_unpack_ex+0x47a/0x9e0 fs/ntfs3/run.c:1100

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&wnd->rw_lock){++++}-{4:4}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
       down_write_nested+0xa2/0x220 kernel/locking/rwsem.c:1693
       ntfs_look_for_free_space+0x100/0x690 fs/ntfs3/fsntfs.c:362
       attr_allocate_clusters+0x1d6/0x990 fs/ntfs3/attrib.c:159
       attr_set_size+0x2053/0x4300 fs/ntfs3/attrib.c:574
       ntfs_extend_mft+0x188/0x4b0 fs/ntfs3/fsntfs.c:512
       ntfs_look_free_mft+0x77c/0x10c0 fs/ntfs3/fsntfs.c:709
       ntfs_create_inode+0x581/0x3760 fs/ntfs3/inode.c:1305
       ntfs_create+0x3d/0x50 fs/ntfs3/namei.c:110
       lookup_open fs/namei.c:3649 [inline]
       open_last_lookups fs/namei.c:3748 [inline]
       path_openat+0x1c03/0x3590 fs/namei.c:3984
       do_filp_open+0x27f/0x4e0 fs/namei.c:4014
       do_sys_openat2+0x13e/0x1d0 fs/open.c:1402
       do_sys_open fs/open.c:1417 [inline]
       __do_sys_creat fs/open.c:1495 [inline]
       __se_sys_creat fs/open.c:1489 [inline]
       __x64_sys_creat+0x123/0x170 fs/open.c:1489
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ni->file.run_lock#2){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
       __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
       down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
       run_unpack_ex+0x55e/0x9e0 fs/ntfs3/run.c:1119
       ntfs_read_mft fs/ntfs3/inode.c:401 [inline]
       ntfs_iget5+0x1f9a/0x37b0 fs/ntfs3/inode.c:537
       ntfs_dir_emit fs/ntfs3/dir.c:335 [inline]
       ntfs_read_hdr+0x700/0xb80 fs/ntfs3/dir.c:383
       ntfs_readdir+0x91f/0xf00 fs/ntfs3/dir.c:494
       iterate_dir+0x571/0x800 fs/readdir.c:108
       get_name fs/exportfs/expfs.c:325 [inline]
       exportfs_get_name+0x5b7/0x720 fs/exportfs/expfs.c:36
       reconnect_one fs/exportfs/expfs.c:142 [inline]
       reconnect_path+0x267/0x750 fs/exportfs/expfs.c:222
       exportfs_decode_fh_raw+0x308/0x6a0 fs/exportfs/expfs.c:485
       do_handle_to_path+0xbc/0x1c0 fs/fhandle.c:267
       handle_to_path fs/fhandle.c:387 [inline]
       do_handle_open+0x800/0x9d0 fs/fhandle.c:405
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&wnd->rw_lock);
                               lock(&ni->file.run_lock#2);
                               lock(&wnd->rw_lock);
  rlock(&ni->file.run_lock#2);

 *** DEADLOCK ***

2 locks held by syz.5.2396/16280:
 #0: ffff88805a1a4d08 (&type->i_mutex_dir_key#18){++++}-{4:4}, at: iterate_dir+0x20c/0x800 fs/readdir.c:101
 #1: ffff88805994a270 (&wnd->rw_lock){++++}-{4:4}, at: run_unpack_ex+0x47a/0x9e0 fs/ntfs3/run.c:1100

stack backtrace:
CPU: 1 UID: 0 PID: 16280 Comm: syz.5.2396 Not tainted 6.12.0-rc6-next-20241108-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/30/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904
 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849
 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524
 run_unpack_ex+0x55e/0x9e0 fs/ntfs3/run.c:1119
 ntfs_read_mft fs/ntfs3/inode.c:401 [inline]
 ntfs_iget5+0x1f9a/0x37b0 fs/ntfs3/inode.c:537
 ntfs_dir_emit fs/ntfs3/dir.c:335 [inline]
 ntfs_read_hdr+0x700/0xb80 fs/ntfs3/dir.c:383
 ntfs_readdir+0x91f/0xf00 fs/ntfs3/dir.c:494
 iterate_dir+0x571/0x800 fs/readdir.c:108
 get_name fs/exportfs/expfs.c:325 [inline]
 exportfs_get_name+0x5b7/0x720 fs/exportfs/expfs.c:36
 reconnect_one fs/exportfs/expfs.c:142 [inline]
 reconnect_path+0x267/0x750 fs/exportfs/expfs.c:222
 exportfs_decode_fh_raw+0x308/0x6a0 fs/exportfs/expfs.c:485
 do_handle_to_path+0xbc/0x1c0 fs/fhandle.c:267
 handle_to_path fs/fhandle.c:387 [inline]
 do_handle_open+0x800/0x9d0 fs/fhandle.c:405
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fae7db7e719
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fae7e940038 EFLAGS: 00000246 ORIG_RAX: 0000000000000130
RAX: ffffffffffffffda RBX: 00007fae7dd35f80 RCX: 00007fae7db7e719
RDX: 0000000000000000 RSI: 0000000020000240 RDI: 0000000000000004
RBP: 00007fae7dbf139e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007fae7dd35f80 R15: 00007ffc5353b218
 </TASK>
ntfs3(loop5): failed to convert name for inode 1e.

Crashes (96):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/11/09 09:18 linux-next 929beafbe7ac 6b856513 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 23:30 linux-next 929beafbe7ac 6b856513 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 20:34 linux-next 929beafbe7ac 179b040e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 09:28 linux-next 929beafbe7ac 179b040e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 06:43 linux-next 74741a050b79 179b040e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 02:06 linux-next 74741a050b79 c069283c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/08 01:05 linux-next 74741a050b79 c069283c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 16:31 linux-next 74741a050b79 c069283c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 14:07 linux-next 74741a050b79 c069283c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 12:10 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 11:03 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 09:01 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 03:51 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/07 00:00 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/06 23:42 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/06 22:23 linux-next 5b913f5d7d7f df3dc63b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/06 10:42 linux-next 5b913f5d7d7f 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/06 09:09 linux-next 5b913f5d7d7f 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 21:28 linux-next 850f22c42f4b 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 21:28 linux-next 850f22c42f4b 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 20:51 linux-next 850f22c42f4b 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 20:51 linux-next 850f22c42f4b 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 20:50 linux-next 850f22c42f4b 3a465482 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:58 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:58 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:32 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:32 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:29 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 09:29 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 08:44 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 08:44 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 08:38 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 08:36 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 08:35 linux-next 850f22c42f4b 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/05 05:43 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 20:44 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 20:44 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 19:55 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 18:40 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 17:27 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 17:07 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 17:07 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 17:02 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 17:02 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 16:43 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 16:43 linux-next 1ffec08567f4 509da429 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 11:01 linux-next 1ffec08567f4 f00eed24 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 09:10 linux-next 1ffec08567f4 f00eed24 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
2024/11/04 07:29 linux-next 1ffec08567f4 f00eed24 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in run_unpack_ex
* Struck through repros no longer work on HEAD.