syzbot


WARNING in __dev_set_promiscuity

Status: fixed on 2022/03/08 16:11
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+7a2ab2cdc14d134de553@syzkaller.appspotmail.com
Fix commit: a5b8fd657881 net: dev_addr_list: handle first address in __hw_addr_add_ex
First crash: 1026d, last: 996d
Cause bisection: introduced by (bisect log) :
commit 406f42fa0d3cbcea3766c3111d79ac5afe711c5b
Author: Gilad Naaman <gnaaman@drivenets.com>
Date: Thu Aug 19 07:17:27 2021 +0000

  net-next: When a bond have a massive amount of VLANs with IPv6 addresses, performance of changing link state, attaching a VRF, changing an IPv6 address, etc. go down dramtically.

Crash: WARNING in __dev_set_promiscuity (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH net] net: dev_addr_list: handle first address in __hw_addr_add_ex 2 (2) 2021/09/30 12:40
[syzbot] WARNING in __dev_set_promiscuity 0 (1) 2021/09/25 00:17
Last patch testing requests (1)
Created Duration User Patch Repo Result
2021/09/29 15:23 18m kuba@kernel.org git://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux.git 88ab3cb013bcae3e39356793fa4a6c31a67a08b5 OK

Sample crash report:
------------[ cut here ]------------
RTNL: assertion failed at net/core/dev.c (8535)
WARNING: CPU: 0 PID: 6862 at net/core/dev.c:8535 __dev_set_promiscuity+0x1dd/0x210 net/core/dev.c:8535
Modules linked in:
CPU: 0 PID: 6862 Comm: syz-executor088 Not tainted 5.15.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__dev_set_promiscuity+0x1dd/0x210 net/core/dev.c:8535
Code: 0f 85 ab fe ff ff e8 d2 53 55 fa ba 57 21 00 00 48 c7 c6 00 bd 8b 8a 48 c7 c7 40 bd 8b 8a c6 05 cb 1f 39 06 01 e8 d0 a9 d1 01 <0f> 0b e9 80 fe ff ff 4c 89 f7 e8 84 af 9c fa e9 99 fe ff ff 4c 89
RSP: 0018:ffffc9000366f258 EFLAGS: 00010282
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88801c0e0000 RSI: ffffffff815dbd68 RDI: fffff520006cde3d
RBP: ffff888077c40000 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815d5b0e R11: 0000000000000000 R12: 00000000ffffffff
R13: 0000000000001103 R14: ffff888077c400c0 R15: 0000000000000000
FS:  0000555556bae300(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000200002c0 CR3: 0000000072f75000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __dev_set_rx_mode+0x256/0x2e0 net/core/dev.c:8678
 dev_uc_sync_multiple+0x155/0x190 net/core/dev_addr_lists.c:732
 team_set_rx_mode+0xb5/0x230 drivers/net/team/team.c:1779
 __dev_set_rx_mode+0x1e2/0x2e0 net/core/dev.c:8684
 __dev_mc_add net/core/dev_addr_lists.c:830 [inline]
 dev_mc_add+0xf4/0x110 net/core/dev_addr_lists.c:844
 clusterip_config_init net/ipv4/netfilter/ipt_CLUSTERIP.c:265 [inline]
 clusterip_tg_check+0x1263/0x2300 net/ipv4/netfilter/ipt_CLUSTERIP.c:517
 xt_check_target+0x26c/0x9e0 net/netfilter/x_tables.c:1038
 check_target net/ipv4/netfilter/ip_tables.c:511 [inline]
 find_check_entry.constprop.0+0x7a9/0x9a0 net/ipv4/netfilter/ip_tables.c:553
 translate_table+0xc26/0x16a0 net/ipv4/netfilter/ip_tables.c:717
 do_replace net/ipv4/netfilter/ip_tables.c:1135 [inline]
 do_ipt_set_ctl+0x56e/0xb80 net/ipv4/netfilter/ip_tables.c:1629
 nf_setsockopt+0x83/0xe0 net/netfilter/nf_sockopt.c:101
 ip_setsockopt+0x3c3/0x3a60 net/ipv4/ip_sockglue.c:1435
 tcp_setsockopt+0x136/0x2530 net/ipv4/tcp.c:3632
 __sys_setsockopt+0x2db/0x610 net/socket.c:2176
 __do_sys_setsockopt net/socket.c:2187 [inline]
 __se_sys_setsockopt net/socket.c:2184 [inline]
 __x64_sys_setsockopt+0xba/0x150 net/socket.c:2184
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x7f4369c97549
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 41 15 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffda4bb7e08 EFLAGS: 00000246 ORIG_RAX: 0000000000000036
RAX: ffffffffffffffda RBX: 00000000000f4240 RCX: 00007f4369c97549
RDX: 0000000000000040 RSI: 0000000000000000 RDI: 0000000000000003
RBP: 0000000000000000 R08: 0000000000000298 R09: 0000000000f0b5ff
R10: 00000000200002c0 R11: 0000000000000246 R12: 000000000001236e
R13: 00007ffda4bb7e30 R14: 00007ffda4bb7e20 R15: 00007ffda4bb7e14

Crashes (11):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2021/09/24 23:12 net-next-old acde891c243c 8cac236e .config console log report syz C ci-upstream-net-kasan-gce WARNING in __dev_set_promiscuity
2021/09/24 16:45 net-next-old 2fcd14d0f780 8cac236e .config console log report syz C ci-upstream-net-kasan-gce WARNING in __dev_set_promiscuity
2021/09/28 02:08 upstream 0513e464f900 78494d16 .config console log report info ci-upstream-kasan-gce WARNING in __dev_set_promiscuity
2021/09/28 00:06 upstream 0513e464f900 78494d16 .config console log report info ci-upstream-kasan-gce WARNING in __dev_set_promiscuity
2021/09/23 15:19 upstream 58e2cf5d7946 8cac236e .config console log report info ci-upstream-kasan-gce WARNING in __dev_set_promiscuity
2021/09/12 10:17 upstream 78e709522d2c 5ae8508a .config console log report info ci-upstream-kasan-gce-smack-root WARNING in __dev_set_promiscuity
2021/09/21 13:10 net-old 3e95cfa24e24 169724fe .config console log report info ci-upstream-net-this-kasan-gce WARNING in __dev_set_promiscuity
2021/09/09 15:19 net-old e011912651bd e2776ee4 .config console log report info ci-upstream-net-this-kasan-gce WARNING in __dev_set_promiscuity
2021/09/24 14:19 net-next-old 2fcd14d0f780 8cac236e .config console log report info ci-upstream-net-kasan-gce WARNING in __dev_set_promiscuity
2021/09/02 08:07 net-next-old 29ce8f970107 7eb7e152 .config console log report info ci-upstream-net-kasan-gce WARNING in __dev_set_promiscuity
2021/08/29 07:47 net-next-old c77225119daa be2c130d .config console log report info ci-upstream-net-kasan-gce WARNING in __dev_set_promiscuity
* Struck through repros no longer work on HEAD.