syzbot


possible deadlock in __netdev_update_features

Status: upstream: reported on 2025/06/02 08:57
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+7e0f89fb6cae5d002de0@syzkaller.appspotmail.com
First crash: 52d, last: 11h31m
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [net?] possible deadlock in __netdev_update_features 3 (4) 2025/06/03 18:25

Sample crash report:
netdevsim netdevsim1 netdevsim0: unset [1, 0] type 2 family 0 port 6081 - 0
============================================
WARNING: possible recursive locking detected
6.16.0-rc6-syzkaller-00279-gbf61759db409 #0 Not tainted
--------------------------------------------
syz.1.94/6325 is trying to acquire lock:
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2756 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock_ops include/net/netdev_lock.h:42 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_sync_lower_features net/core/dev.c:10550 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: __netdev_update_features+0xcb1/0x1a20 net/core/dev.c:10720

but task is already holding lock:
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2756 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock_ops include/net/netdev_lock.h:42 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: __dev_ethtool net/ethtool/ioctl.c:3228 [inline]
ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: dev_ethtool+0x716/0x1990 net/ethtool/ioctl.c:3491
and the lock comparison function returns 0:

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&dev_instance_lock_key#20);
  lock(&dev_instance_lock_key#20);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

2 locks held by syz.1.94/6325:
 #0: ffffffff8f51c108 (rtnl_mutex){+.+.}-{4:4}, at: dev_ethtool+0x1d0/0x1990 net/ethtool/ioctl.c:3490
 #1: ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2756 [inline]
 #1: ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: netdev_lock_ops include/net/netdev_lock.h:42 [inline]
 #1: ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: __dev_ethtool net/ethtool/ioctl.c:3228 [inline]
 #1: ffff88805a508d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: dev_ethtool+0x716/0x1990 net/ethtool/ioctl.c:3491

stack backtrace:
CPU: 0 UID: 0 PID: 6325 Comm: syz.1.94 Not tainted 6.16.0-rc6-syzkaller-00279-gbf61759db409 #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250 lib/dump_stack.c:120
 print_deadlock_bug+0x28b/0x2a0 kernel/locking/lockdep.c:3044
 check_deadlock kernel/locking/lockdep.c:3096 [inline]
 validate_chain+0x1a3f/0x2140 kernel/locking/lockdep.c:3898
 __lock_acquire+0xab9/0xd20 kernel/locking/lockdep.c:5240
 lock_acquire+0x120/0x360 kernel/locking/lockdep.c:5871
 __mutex_lock_common kernel/locking/mutex.c:602 [inline]
 __mutex_lock+0x182/0xe80 kernel/locking/mutex.c:747
 netdev_lock include/linux/netdevice.h:2756 [inline]
 netdev_lock_ops include/net/netdev_lock.h:42 [inline]
 netdev_sync_lower_features net/core/dev.c:10550 [inline]
 __netdev_update_features+0xcb1/0x1a20 net/core/dev.c:10720
 netdev_update_features+0x6d/0xe0 net/core/dev.c:10775
 macsec_notify+0x2f5/0x660 drivers/net/macsec.c:4533
 notifier_call_chain+0x1b3/0x3e0 kernel/notifier.c:85
 call_netdevice_notifiers_extack net/core/dev.c:2268 [inline]
 call_netdevice_notifiers net/core/dev.c:2282 [inline]
 netdev_features_change+0x85/0xc0 net/core/dev.c:1571
 __dev_ethtool net/ethtool/ioctl.c:3458 [inline]
 dev_ethtool+0x1520/0x1990 net/ethtool/ioctl.c:3491
 dev_ioctl+0x392/0x1150 net/core/dev_ioctl.c:758
 sock_do_ioctl+0x22c/0x300 net/socket.c:1204
 sock_ioctl+0x576/0x790 net/socket.c:1311
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:907 [inline]
 __se_sys_ioctl+0xf9/0x170 fs/ioctl.c:893
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xfa/0x3b0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f909e38e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f909f1c2038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f909e5b6240 RCX: 00007f909e38e9a9
RDX: 0000200000000080 RSI: 0000000000008946 RDI: 000000000000000b
RBP: 00007f909e410d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f909e5b6240 R15: 00007f909e6dfa28
 </TASK>

Crashes (67):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/07/20 06:49 upstream bf61759db409 7117feec .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/16 20:37 upstream 155a3c003e55 c118d736 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/13 19:27 upstream 3f31a806a62e 3cda49cf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in __netdev_update_features
2025/07/12 09:34 upstream 40f92e79b0aa 3cda49cf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/10 12:36 upstream 8c2e52ebbe88 19d4829f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/10 09:07 upstream 8c2e52ebbe88 956bd956 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/10 00:47 upstream 8c2e52ebbe88 f4e5e155 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/09 04:00 upstream d006330be3f7 abade794 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/05 19:41 upstream a79a588fc176 4f67c4ae .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/02 06:32 upstream 66701750d556 ffe4b334 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in __netdev_update_features
2025/06/29 11:53 upstream dfba48a70cb6 fc9d8ee5 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/29 11:53 upstream dfba48a70cb6 fc9d8ee5 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/28 03:42 upstream 35e261cd95dd 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/25 09:02 upstream 7595b66ae9de 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/22 15:01 upstream 739a6c93cc75 d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/20 10:58 upstream 41687a5c6f8b ed3e87f7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/16 06:04 upstream 08215f5486ec 5f4b362d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-smack-root possible deadlock in __netdev_update_features
2025/06/14 07:05 upstream 02adc1490e6d 0e8da31f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/12 11:39 upstream 2c4a1f3fe03e 98683f8f .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/10 23:08 upstream f09079bd04a9 5d7e17ca .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/10 22:38 upstream f09079bd04a9 5d7e17ca .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/09 23:12 upstream 19272b37aa4f 4826c28e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/07 13:25 upstream 7a912d04415b 4826c28e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 11:54 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 11:36 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 10:14 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 09:42 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 09:25 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 09:25 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 08:51 upstream 64980441d269 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/04 10:31 upstream 5abc7438f1e9 a30356b7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/03 11:53 upstream 7f9039c524a3 b396b4bf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/03 11:30 upstream 7f9039c524a3 b396b4bf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/02 20:57 upstream cd2e103d57e5 b396b4bf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/01 17:33 upstream 7d4e49a77d99 3d2f584d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/06/01 16:03 upstream 7d4e49a77d99 3d2f584d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in __netdev_update_features
2025/07/09 12:34 upstream 733923397fd9 abade794 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/07/05 00:04 upstream 4c06e63b9203 d869b261 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/06/27 09:59 upstream e34a79b96ab9 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/06/27 09:25 upstream e34a79b96ab9 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/06/27 06:57 upstream e34a79b96ab9 803ce19b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/05/30 05:21 upstream 90b83efa6701 3d2f584d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in __netdev_update_features
2025/06/09 11:38 upstream 19272b37aa4f 4826c28e .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in __netdev_update_features
2025/05/29 08:52 upstream 90b83efa6701 3d2f584d .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in __netdev_update_features
2025/07/07 09:17 net b9fd9888a565 4f67c4ae .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/24 14:02 net 7544f3f5b0b5 e2f27c35 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/23 04:06 net 302251f1fdfd d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/21 17:40 net 714db279942b d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/21 11:33 net e0fca6f2cebf d6cdfb8a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/15 04:38 net 5466491c9e33 5f4b362d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/06/05 07:32 net 12c331b29c73 6b6b5f21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in __netdev_update_features
2025/07/16 13:56 net-next c3886ccaadf8 c118d736 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in __netdev_update_features
2025/07/15 13:21 net-next 08a305b2a5b8 03fcfc4b .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in __netdev_update_features
2025/07/11 03:28 net-next 96698d1898bc 3cda49cf .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in __netdev_update_features
2025/07/05 09:25 net-next 6b9fd8857b9f 4f67c4ae .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in __netdev_update_features
2025/06/25 18:57 net-next ab4eb6a25de2 26d77996 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in __netdev_update_features
2025/07/20 12:25 linux-next d086c886ceb9 7117feec .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in __netdev_update_features
2025/07/20 09:34 linux-next d086c886ceb9 7117feec .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in __netdev_update_features
2025/07/20 06:00 linux-next d086c886ceb9 7117feec .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in __netdev_update_features
2025/07/03 14:51 linux-next 8d6c58332c7a 115ceea7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in __netdev_update_features
* Struck through repros no longer work on HEAD.