WARNING: kobject bug in netdev_queue_update_kobjects

Status: fixed on 2018/05/08 18:30
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+7fb6d9525a4528104e05@syzkaller.appspotmail.com
Fix commit: 3e14c6abbfb5 kobject: don't use WARN for registration failures
First crash: 3073d, last: 3010d
▶ ▼ Discussions (7)
Title Replies (including bot) Last reply
[PATCH 4.16 000/113] 4.16.7-stable review 120 (120) 2018/05/01 19:26
[PATCH 4.4 00/44] 4.4.131-stable review 53 (53) 2018/05/01 19:08
[PATCH 4.9 00/61] 4.9.98-stable review 66 (66) 2018/05/01 19:07
[PATCH 4.14 00/91] 4.14.39-stable review 97 (97) 2018/05/01 19:06
[PATCH 3.18 00/25] 3.18.108-stable review 32 (32) 2018/05/01 19:04
[PATCH] kobject: don't use WARN for registration failures 1 (1) 2018/04/11 15:22
WARNING: kobject bug in netdev_queue_update_kobjects 1 (2) 2018/03/05 18:21

Sample crash report:
RBP: 00007ffd67c73e10 R08: 0000000000000001 R09: 00007ffd67c70032
R10: 0000000000000000 R11: 0000000000000246 R12: 74656e2f7665642f
R13: ffffffffffffffff R14: 0000000000000008 R15: 0000000000000000
------------[ cut here ]------------
kobject_add_internal failed for tx-3 (error: -12 parent: queues)
WARNING: CPU: 1 PID: 4119 at lib/kobject.c:242 kobject_add_internal+0x3f6/0xbc0 lib/kobject.c:240
Kernel panic - not syncing: panic_on_warn set ...

CPU: 1 PID: 4119 Comm: syzkaller952529 Not tainted 4.16.0-rc4+ #341
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x194/0x24d lib/dump_stack.c:53
 panic+0x1e4/0x41c kernel/panic.c:183
 __warn+0x1dc/0x200 kernel/panic.c:547
 report_bug+0x211/0x2d0 lib/bug.c:184
 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178
 fixup_bug arch/x86/kernel/traps.c:247 [inline]
 do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:986
RIP: 0010:kobject_add_internal+0x3f6/0xbc0 lib/kobject.c:240
RSP: 0018:ffff8801d2d9f488 EFLAGS: 00010286
RAX: dffffc0000000008 RBX: ffff8801d1ec0618 RCX: ffffffff815abb7e
RDX: 0000000000000000 RSI: 1ffff1003a5b3e41 RDI: 1ffff1003a5b3e16
RBP: ffff8801d2d9f580 R08: 1ffff1003a5b3dd8 R09: 0000000000000000
R10: ffff8801d2d9f248 R11: 0000000000000000 R12: 1ffff1003a5b3e97
R13: 00000000fffffff4 R14: ffff8801d0ce8d48 R15: ffffffff8684c720
 kobject_add_varg lib/kobject.c:364 [inline]
 kobject_init_and_add+0xf9/0x150 lib/kobject.c:436
 netdev_queue_add_kobject net/core/net-sysfs.c:1332 [inline]
 netdev_queue_update_kobjects+0x148/0x480 net/core/net-sysfs.c:1360
 netif_set_real_num_tx_queues+0x185/0x790 net/core/dev.c:2397
 tun_set_real_num_queues drivers/net/tun.c:638 [inline]
 tun_attach+0x7bd/0x1220 drivers/net/tun.c:863
 tun_set_queue drivers/net/tun.c:2750 [inline]
 __tun_chr_ioctl+0x8f5/0x40d0 drivers/net/tun.c:2814
 tun_chr_ioctl+0x2a/0x40 drivers/net/tun.c:3084
 vfs_ioctl fs/ioctl.c:46 [inline]
 do_vfs_ioctl+0x1b1/0x1520 fs/ioctl.c:686
 SYSC_ioctl fs/ioctl.c:701 [inline]
 SyS_ioctl+0x8f/0xc0 fs/ioctl.c:692
 do_syscall_64+0x281/0x940 arch/x86/entry/common.c:287
 entry_SYSCALL_64_after_hwframe+0x42/0xb7
RIP: 0033:0x444229
RSP: 002b:00007ffd67c73e08 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 0000000000444229
RDX: 0000000020000200 RSI: 00000000400454d9 RDI: 0000000000000006
RBP: 00007ffd67c73e10 R08: 0000000000000001 R09: 00007ffd67c70032
R10: 0000000000000000 R11: 0000000000000246 R12: 74656e2f7665642f
R13: ffffffffffffffff R14: 0000000000000008 R15: 0000000000000000
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (27):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/03/05 14:25 upstream 661e50bc8532 bbd5104f .config console log report syz C ci-upstream-kasan-gce
2018/04/23 22:09 upstream 6d08b06e67cd 0d8e591c .config console log report ci-upstream-kasan-gce-root
2018/04/23 22:08 upstream 6d08b06e67cd 0d8e591c .config console log report ci-upstream-kasan-gce
2018/04/21 15:46 upstream 83beed7b2b26 d23fcf6c .config console log report ci-upstream-kasan-gce
2018/04/15 05:37 upstream 18b7fd1c93e5 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/14 11:38 upstream 48023102b707 7a67784c .config console log report ci-upstream-kasan-gce
2018/04/11 10:08 upstream b284d4d5a678 8b8de427 .config console log report ci-upstream-kasan-gce
2018/04/09 21:14 upstream fd40ffc72e2f b9f65507 .config console log report ci-upstream-kasan-gce
2018/04/09 14:06 upstream 3fd14cdcc05a f13fb445 .config console log report ci-upstream-kasan-gce-root
2018/04/05 15:29 upstream 06dd3dfeea60 5e1ccffc .config console log report ci-upstream-kasan-gce-root
2018/04/05 00:32 upstream 3e968c9f1401 676bd07e .config console log report ci-upstream-kasan-gce
2018/04/04 00:27 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/03 22:20 upstream f2d285669aae 676bd07e .config console log report ci-upstream-kasan-gce-root
2018/04/02 01:09 upstream 0adb32858b0b dc889257 .config console log report ci-upstream-kasan-gce-root
2018/04/01 17:57 upstream 10b84daddbec dc889257 .config console log report ci-upstream-kasan-gce
2018/03/25 13:28 upstream bcfc1f455466 e033c1f1 .config console log report ci-upstream-kasan-gce-root
2018/03/19 11:28 upstream c698ca527893 7e7d7ed2 .config console log report ci-upstream-kasan-gce
2018/03/05 14:07 upstream 661e50bc8532 bbd5104f .config console log report ci-upstream-kasan-gce
2018/04/05 10:47 upstream f2d285669aae 5e1ccffc .config console log report ci-upstream-kasan-gce-386
2018/04/01 17:57 upstream 10b84daddbec dc889257 .config console log report ci-upstream-kasan-gce-386
2018/03/25 22:45 upstream cb6416592bc2 e033c1f1 .config console log report ci-upstream-kasan-gce-386
2018/03/22 00:49 upstream 3215b9d57a2c 95c88d7a .config console log report ci-upstream-kasan-gce-386
2018/03/17 05:52 upstream 8f5fd927c3a7 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/03/09 21:50 upstream 719ea86151f3 36d1c454 .config console log report ci-upstream-kasan-gce-386
2018/03/05 21:16 upstream 661e50bc8532 bbd5104f .config console log report ci-upstream-kasan-gce-386
2018/05/06 16:29 https://github.com/google/kmsan.git master d2d741e5d189 6c18ddb0 .config console log report ci-upstream-kmsan-gce
2018/04/25 22:57 https://github.com/google/kmsan.git master d2d741e5d189 73417389 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.