syzbot


WARNING in devlink_free

Status: fixed on 2023/06/08 14:41
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+9f0dd863b87113935acf@syzkaller.appspotmail.com
Fix commit: 93e71edfd90c devlink: keep the instance mutex alive until references are gone
First crash: 415d, last: 398d
Discussions (2)
Title Replies (including bot) Last reply
[PATCH net-next] devlink: keep the instance mutex alive until references are gone 5 (5) 2023/01/12 05:00
[syzbot] WARNING in devlink_free 1 (2) 2023/01/11 09:25

Sample crash report:
netdevsim netdevsim2 netdevsim1 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
netdevsim netdevsim2 netdevsim0 (unregistering): unset [1, 0] type 2 family 0 port 6081 - 0
------------[ cut here ]------------
DEBUG_LOCKS_WARN_ON(mutex_is_locked(lock))
WARNING: CPU: 1 PID: 28207 at kernel/locking/mutex-debug.c:102 mutex_destroy+0xc1/0x100 kernel/locking/mutex-debug.c:102
Modules linked in:
CPU: 1 PID: 28207 Comm: syz-executor.2 Not tainted 6.2.0-rc2-syzkaller-00382-g74d23931f409 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023
RIP: 0010:mutex_destroy+0xc1/0x100 kernel/locking/mutex-debug.c:102
Code: 03 0f b6 14 11 38 d0 7c 04 84 d2 75 3f 8b 05 6e 29 10 0d 85 c0 75 92 48 c7 c6 00 47 4c 8a 48 c7 c7 40 47 4c 8a e8 ef a0 5c 08 <0f> 0b e9 78 ff ff ff 48 c7 c7 00 9a c0 91 e8 cc 87 6c 00 e9 5d ff
RSP: 0018:ffffc9000317fa20 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffff8880753cc2d0 RCX: 0000000000000000
RDX: ffff88801f1eba80 RSI: ffffffff8166710c RDI: fffff5200062ff36
RBP: ffff8880753cc000 R08: 0000000000000005 R09: 0000000000000000
R10: 0000000080000000 R11: 0000000000000001 R12: ffff8880753cb000
R13: ffff8880753cb078 R14: ffffffff8d7af7e0 R15: 0000000000000000
FS:  000055555731c400(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007ff9bc721300 CR3: 000000007c558000 CR4: 00000000003506e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 <TASK>
 devlink_free+0x83/0x510 net/devlink/core.c:262
 nsim_drv_remove+0x158/0x1d0 drivers/net/netdevsim/dev.c:1688
 device_remove+0xc8/0x170 drivers/base/dd.c:548
 __device_release_driver drivers/base/dd.c:1253 [inline]
 device_release_driver_internal+0x4a5/0x700 drivers/base/dd.c:1279
 bus_remove_device+0x2e7/0x5a0 drivers/base/bus.c:529
 device_del+0x4f7/0xc80 drivers/base/core.c:3666
 device_unregister+0x1e/0xc0 drivers/base/core.c:3698
 nsim_bus_dev_del drivers/net/netdevsim/bus.c:310 [inline]
 del_device_store+0x34e/0x470 drivers/net/netdevsim/bus.c:219
 bus_attr_store+0x76/0xa0 drivers/base/bus.c:122
 sysfs_kf_write+0x114/0x170 fs/sysfs/file.c:136
 kernfs_fop_write_iter+0x3f1/0x600 fs/kernfs/file.c:334
 call_write_iter include/linux/fs.h:2186 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x9ed/0xdd0 fs/read_write.c:584
 ksys_write+0x12b/0x250 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f293683de4f
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007ffd1133e0c0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000001 RCX: 00007f293683de4f
RDX: 0000000000000001 RSI: 00007ffd1133e110 RDI: 0000000000000005
RBP: 0000000000000005 R08: 0000000000000000 R09: 00007ffd1133e060
R10: 0000000000000000 R11: 0000000000000293 R12: 00007f29368e76fe
R13: 00007ffd1133e110 R14: 0000000000000000 R15: 00007ffd1133e7e0
 </TASK>

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/01/24 09:35 bpf-next 74d23931f409 9dfcf09c .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/21 06:17 bpf-next 84150795a49a 559a440a .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/19 00:00 bpf-next 92afc5329a5b 42660d9e .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/18 08:48 bpf-next c0f264e4edb6 42660d9e .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/17 19:23 bpf-next c1177979af9c aedf5331 .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/14 18:36 bpf-next 1c48391bc673 a63719e7 .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/13 17:24 bpf-next 878625e1c7a1 529798b0 .config console log report info ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/10 23:49 bpf-next 6d0c4b11e743 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/08 12:56 bpf-next 6d0c4b11e743 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
2023/01/07 07:35 bpf-next 6d0c4b11e743 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce WARNING in devlink_free
* Struck through repros no longer work on HEAD.