syzbot


general protection fault in vsock_poll

Status: fixed on 2020/09/16 22:51
Subsystems: net virt
[Documentation on labels]
Reported-by: syzbot+a61bac2fcc1a7c6623fe@syzkaller.appspotmail.com
Fix commit: 1980c0584483 vsock: fix potential null pointer dereference in vsock_poll()
First crash: 1597d, last: 1581d
Cause bisection: introduced by (bisect log) :
commit 408624af4c89989117bb2c6517bd50b7708a2fcd
Author: Stefano Garzarella <sgarzare@redhat.com>
Date: Tue Dec 10 10:43:06 2019 +0000

  vsock: use local transport when it is loaded

Crash: general protection fault in virtio_transport_send_pkt_info (log)
Repro: syz .config
  
Discussions (5)
Title Replies (including bot) Last reply
[PATCH 5.8 000/464] 5.8.2-rc1 review 475 (475) 2020/08/19 06:11
[PATCH 5.7 000/393] 5.7.16-rc1 review 398 (398) 2020/08/18 22:36
[PATCH net v2] vsock: fix potential null pointer dereference in vsock_poll() 3 (3) 2020/08/12 20:08
[PATCH net 0/2] vsock: fix null pointer dereference and cleanup in vsock_poll() 5 (5) 2020/08/12 07:17
general protection fault in vsock_poll 1 (3) 2020/07/29 09:40
Last patch testing requests (4)
Created Duration User Patch Repo Result
2020/08/12 07:56 16m sgarzare@redhat.com https://github.com/stefano-garzarella/linux.git vsock-fix-poll-null-transport OK
2020/08/11 07:59 16m sgarzare@redhat.com https://github.com/stefano-garzarella/linux.git vsock-fix-poll-null-transport OK
2020/08/07 17:40 16m sgarzare@redhat.com https://github.com/stefano-garzarella/linux.git vsock-fix-poll-null-transport OK
2020/08/07 13:04 16m sgarzare@redhat.com https://github.com/stefano-garzarella/linux.git vsock-fix-poll-null-transport OK

Sample crash report:
general protection fault, probably for non-canonical address 0xdffffc0000000012: 0000 [#1] PREEMPT SMP KASAN
KASAN: null-ptr-deref in range [0x0000000000000090-0x0000000000000097]
CPU: 0 PID: 8227 Comm: syz-executor.2 Not tainted 5.8.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:vsock_poll+0x75a/0x8e0 net/vmw_vsock/af_vsock.c:1038
Code: 84 ed 0f 85 c4 00 00 00 e8 b3 03 99 f9 48 8d bb 90 00 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa c6 44 24 30 00 48 c1 ea 03 <80> 3c 02 00 0f 85 3f 01 00 00 48 8d 54 24 30 be 01 00 00 00 48 89
RSP: 0018:ffffc90004ff7868 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff87dab90f
RDX: 0000000000000012 RSI: ffffffff87dab91d RDI: 0000000000000090
RBP: ffff88807b4e8800 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: ffff88807b4e8c2a R15: 0000000000000001
FS:  00007f65ae726700(0000) GS:ffff8880ae600000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000b90004 CR3: 0000000092ba1000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 sock_poll+0x159/0x460 net/socket.c:1266
 vfs_poll include/linux/poll.h:90 [inline]
 do_pollfd fs/select.c:869 [inline]
 do_poll fs/select.c:917 [inline]
 do_sys_poll+0x607/0xd40 fs/select.c:1011
 __do_sys_poll fs/select.c:1069 [inline]
 __se_sys_poll fs/select.c:1057 [inline]
 __x64_sys_poll+0x18c/0x440 fs/select.c:1057
 do_syscall_64+0x60/0xe0 arch/x86/entry/common.c:384
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x45c369
Code: 8d b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 5b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f65ae725c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000007
RAX: ffffffffffffffda RBX: 0000000000023400 RCX: 000000000045c369
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000020000140
RBP: 000000000078bfe0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000078bfac
R13: 00007ffe3b463cff R14: 00007f65ae7269c0 R15: 000000000078bfac
Modules linked in:
---[ end trace de4b7dd70e3266e6 ]---
RIP: 0010:vsock_poll+0x75a/0x8e0 net/vmw_vsock/af_vsock.c:1038
Code: 84 ed 0f 85 c4 00 00 00 e8 b3 03 99 f9 48 8d bb 90 00 00 00 48 b8 00 00 00 00 00 fc ff df 48 89 fa c6 44 24 30 00 48 c1 ea 03 <80> 3c 02 00 0f 85 3f 01 00 00 48 8d 54 24 30 be 01 00 00 00 48 89
RSP: 0018:ffffc90004ff7868 EFLAGS: 00010206
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff87dab90f
RDX: 0000000000000012 RSI: ffffffff87dab91d RDI: 0000000000000090
RBP: ffff88807b4e8800 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: ffff88807b4e8c2a R15: 0000000000000001
FS:  00007f65ae726700(0000) GS:ffff8880ae700000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f3d6d5bb000 CR3: 0000000092ba1000 CR4: 00000000001406e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (15):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/07/27 07:39 upstream 92ed30191993 51265195 .config console log report syz ci-upstream-kasan-gce-root
2020/07/26 14:30 upstream 04300d66f0a0 51265195 .config console log report syz ci-upstream-kasan-gce-selinux-root
2020/07/24 18:59 upstream f37e99aca03f 554af388 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/07/18 15:38 upstream 6a70f89cc58f 9c812472 .config console log report syz ci-upstream-kasan-gce-selinux-root
2020/07/18 09:12 upstream 8882572675c1 9c812472 .config console log report syz ci-upstream-kasan-gce-root
2020/07/18 02:10 upstream 8882572675c1 9c812472 .config console log report syz ci-upstream-kasan-gce-smack-root
2020/07/23 05:03 net-old 2c4dc3148603 340ea530 .config console log report syz ci-upstream-net-this-kasan-gce
2020/07/17 23:33 net-old 473309fb8372 9c812472 .config console log report syz ci-upstream-net-this-kasan-gce
2020/07/23 04:35 net-next-old a6c0d0934f0d 340ea530 .config console log report syz ci-upstream-net-kasan-gce
2020/07/18 05:57 net-next-old 4291dc1a5608 9c812472 .config console log report syz ci-upstream-net-kasan-gce
2020/07/26 08:20 linux-next 26027945c94a 1f7cc1ca .config console log report syz ci-upstream-linux-next-kasan-gce-root
2020/07/18 08:10 linux-next 4c43049f19a2 9c812472 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2020/08/03 08:35 upstream 5a30a78924ec 196277c4 .config console log report ci-upstream-kasan-gce-selinux-root
2020/07/17 22:40 net-old 473309fb8372 9c812472 .config console log report ci-upstream-net-this-kasan-gce
2020/07/23 03:44 net-next-old a6c0d0934f0d 340ea530 .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.