syzbot

netlink: 'syz-executor675': attribute type 10 has an invalid length.
team0: Port device wlan1 added
======================================================
WARNING: possible circular locking dependency detected
6.1.123-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor675/4254 is trying to acquire lock:
ffff888073b54d00 (team->team_lock_key){+.+.}-{3:3}, at: team_del_slave+0x2e/0x1c0 drivers/net/team/team.c:2002

but task is already holding lock:
ffff88807dac07c8 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x112/0x130 net/wireless/nl80211.c:4363

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}:
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       wiphy_lock include/net/cfg80211.h:5639 [inline]
       ieee80211_open+0x13a/0x1f0 net/mac80211/iface.c:458
       __dev_open+0x377/0x510 net/core/dev.c:1457
       dev_open+0xa9/0x260 net/core/dev.c:1493
       team_port_add drivers/net/team/team.c:1218 [inline]
       team_add_slave+0x96e/0x2760 drivers/net/team/team.c:1988
       do_set_master net/core/rtnetlink.c:2627 [inline]
       do_setlink+0xe99/0x3de0 net/core/rtnetlink.c:2837
       __rtnl_newlink net/core/rtnetlink.c:3605 [inline]
       rtnl_newlink+0x172c/0x2050 net/core/rtnetlink.c:3652
       rtnetlink_rcv_msg+0x818/0xff0 net/core/rtnetlink.c:6150
       netlink_rcv_skb+0x1cd/0x410 net/netlink/af_netlink.c:2493
       netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
       netlink_unicast+0x7d8/0x970 net/netlink/af_netlink.c:1337
       netlink_sendmsg+0xa26/0xd60 net/netlink/af_netlink.c:1859
       sock_sendmsg_nosec net/socket.c:718 [inline]
       __sock_sendmsg net/socket.c:730 [inline]
       ____sys_sendmsg+0x5a5/0x8f0 net/socket.c:2519
       ___sys_sendmsg net/socket.c:2573 [inline]
       __sys_sendmsg+0x2a9/0x390 net/socket.c:2602
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

-> #0 (team->team_lock_key){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
       __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
       lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
       team_del_slave+0x2e/0x1c0 drivers/net/team/team.c:2002
       team_device_event+0x269/0x570 drivers/net/team/team.c:3045
       notifier_call_chain kernel/notifier.c:87 [inline]
       raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:455
       call_netdevice_notifiers_info net/core/dev.c:1970 [inline]
       call_netdevice_notifiers_extack net/core/dev.c:2008 [inline]
       call_netdevice_notifiers net/core/dev.c:2022 [inline]
       unregister_netdevice_many+0xebf/0x17a0 net/core/dev.c:10945
       unregister_netdevice_queue+0x2e6/0x350 net/core/dev.c:10876
       unregister_netdevice include/linux/netdevice.h:3067 [inline]
       _cfg80211_unregister_wdev+0x175/0x590 net/wireless/core.c:1205
       ieee80211_if_remove+0x1cc/0x2d0 net/mac80211/iface.c:2327
       ieee80211_del_iface+0x15/0x20 net/mac80211/cfg.c:202
       rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline]
       cfg80211_remove_virtual_intf+0x270/0x490 net/wireless/util.c:2584
       genl_family_rcv_msg_doit net/netlink/genetlink.c:756 [inline]
       genl_family_rcv_msg net/netlink/genetlink.c:833 [inline]
       genl_rcv_msg+0xc1a/0xf70 net/netlink/genetlink.c:850
       netlink_rcv_skb+0x1cd/0x410 net/netlink/af_netlink.c:2493
       genl_rcv+0x24/0x40 net/netlink/genetlink.c:861
       netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
       netlink_unicast+0x7d8/0x970 net/netlink/af_netlink.c:1337
       netlink_sendmsg+0xa26/0xd60 net/netlink/af_netlink.c:1859
       sock_sendmsg_nosec net/socket.c:718 [inline]
       __sock_sendmsg net/socket.c:730 [inline]
       ____sys_sendmsg+0x5a5/0x8f0 net/socket.c:2519
       ___sys_sendmsg net/socket.c:2573 [inline]
       __sys_sendmsg+0x2a9/0x390 net/socket.c:2602
       do_syscall_x64 arch/x86/entry/common.c:51 [inline]
       do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
       entry_SYSCALL_64_after_hwframe+0x68/0xd2

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rdev->wiphy.mtx);
                               lock(team->team_lock_key);
                               lock(&rdev->wiphy.mtx);
  lock(team->team_lock_key);

 *** DEADLOCK ***

3 locks held by syz-executor675/4254:
 #0: ffffffff8e56a290 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40 net/netlink/genetlink.c:860
 #1: ffffffff8e50b428 (rtnl_mutex){+.+.}-{3:3}, at: nl80211_pre_doit+0x5b/0x8a0 net/wireless/nl80211.c:16230
 #2: ffff88807dac07c8 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x112/0x130 net/wireless/nl80211.c:4363

stack backtrace:
CPU: 1 PID: 4254 Comm: syz-executor675 Not tainted 6.1.123-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825
 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049
 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747
 team_del_slave+0x2e/0x1c0 drivers/net/team/team.c:2002
 team_device_event+0x269/0x570 drivers/net/team/team.c:3045
 notifier_call_chain kernel/notifier.c:87 [inline]
 raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:455
 call_netdevice_notifiers_info net/core/dev.c:1970 [inline]
 call_netdevice_notifiers_extack net/core/dev.c:2008 [inline]
 call_netdevice_notifiers net/core/dev.c:2022 [inline]
 unregister_netdevice_many+0xebf/0x17a0 net/core/dev.c:10945
 unregister_netdevice_queue+0x2e6/0x350 net/core/dev.c:10876
 unregister_netdevice include/linux/netdevice.h:3067 [inline]
 _cfg80211_unregister_wdev+0x175/0x590 net/wireless/core.c:1205
 ieee80211_if_remove+0x1cc/0x2d0 net/mac80211/iface.c:2327
 ieee80211_del_iface+0x15/0x20 net/mac80211/cfg.c:202
 rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline]
 cfg80211_remove_virtual_intf+0x270/0x490 net/wireless/util.c:2584
 genl_family_rcv_msg_doit net/netlink/genetlink.c:756 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:833 [inline]
 genl_rcv_msg+0xc1a/0xf70 net/netlink/genetlink.c:850
 netlink_rcv_skb+0x1cd/0x410 net/netlink/af_netlink.c:2493
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:861
 netlink_unicast_kernel net/netlink/af_netlink.c:1311 [inline]
 netlink_unicast+0x7d8/0x970 net/netlink/af_netlink.c:1337
 netlink_sendmsg+0xa26/0xd60 net/netlink/af_netlink.c:1859
 sock_sendmsg_nosec net/socket.c:718 [inline]
 __sock_sendmsg net/socket.c:730 [inline]
 ____sys_sendmsg+0x5a5/0x8f0 net/socket.c:2519
 ___sys_sendmsg net/socket.c:2573 [inline]
 __sys_sendmsg+0x2a9/0x390 net/socket.c:2602
 do_syscall_x64 arch/x86/entry/common.c:51 [inline]
 do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81
 entry_SYSCALL_64_after_hwframe+0x68/0xd2
RIP: 0033:0x7f4d91d3bbd9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 01 1a 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdae30fc98 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f4d91d3bbd9
RDX: 0000000000040040 RSI: 0000000020000400 RDI: 0000000000000004
RBP: 00000000000f4240 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f4d91d89464
R13: 00007ffdae30fcdc R14: 00007ffdae30fd10 R15: 0000000000000048
 </TASK>
team0: Port device wlan1 removed