syzbot


possible deadlock in team_del_slave (2)

Status: auto-obsoleted due to no activity on 2023/09/28 12:50
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+1c71587a1a09de7fbde3@syzkaller.appspotmail.com
First crash: 391d, last: 223d
Discussions (2)
Title Replies (including bot) Last reply
[PATCH net v2] net: team: get rid of team->lock in team module 9 (9) 2023/10/04 13:52
[syzbot] possible deadlock in team_del_slave (2) 2 (3) 2023/09/14 12:49
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in team_del_slave net 1 886d 884d 0/26 auto-closed as invalid on 2022/01/16 14:16
linux-5.15 possible deadlock in team_del_slave (2) origin:lts-only C 6 1d21h 39d 0/3 upstream: reported C repro on 2024/01/12 21:46
linux-5.15 possible deadlock in team_del_slave 1 312d 312d 0/3 auto-obsoleted due to no activity on 2023/08/13 07:03

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.3.0-syzkaller-07919-g6e98b09da931 #0 Not tainted
------------------------------------------------------
syz-executor.0/27015 is trying to acquire lock:
ffff8880720e2cf8 (team->team_lock_key#4){+.+.}-{3:3}, at: team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998

but task is already holding lock:
ffff88805bab0728 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0xfb/0x190 net/wireless/nl80211.c:4376

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}:
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       wiphy_lock include/net/cfg80211.h:5737 [inline]
       ieee80211_open net/mac80211/iface.c:437 [inline]
       ieee80211_open+0x193/0x250 net/mac80211/iface.c:424
       __dev_open+0x297/0x4d0 net/core/dev.c:1415
       dev_open net/core/dev.c:1451 [inline]
       dev_open+0xec/0x150 net/core/dev.c:1444
       team_port_add drivers/net/team/team.c:1215 [inline]
       team_add_slave+0xa92/0x2130 drivers/net/team/team.c:1984
       do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2626
       do_setlink+0x89e/0x3d30 net/core/rtnetlink.c:2829
       __rtnl_newlink+0xd69/0x1840 net/core/rtnetlink.c:3626
       rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3673
       rtnetlink_rcv_msg+0x43d/0xd50 net/core/rtnetlink.c:6395
       netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2546
       netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline]
       netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365
       netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1913
       sock_sendmsg_nosec net/socket.c:724 [inline]
       sock_sendmsg+0xde/0x190 net/socket.c:747
       ____sys_sendmsg+0x71c/0x900 net/socket.c:2503
       ___sys_sendmsg+0x110/0x1b0 net/socket.c:2557
       __sys_sendmsg+0xf7/0x1c0 net/socket.c:2586
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (team->team_lock_key#4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3108 [inline]
       check_prevs_add kernel/locking/lockdep.c:3227 [inline]
       validate_chain kernel/locking/lockdep.c:3842 [inline]
       __lock_acquire+0x2f21/0x5df0 kernel/locking/lockdep.c:5074
       lock_acquire kernel/locking/lockdep.c:5691 [inline]
       lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5656
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998
       team_device_event+0xd7/0xad0 drivers/net/team/team.c:3022
       notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
       call_netdevice_notifiers_info+0xb9/0x130 net/core/dev.c:1935
       call_netdevice_notifiers_extack net/core/dev.c:1973 [inline]
       call_netdevice_notifiers net/core/dev.c:1987 [inline]
       unregister_netdevice_many_notify+0x75f/0x18c0 net/core/dev.c:10882
       unregister_netdevice_many net/core/dev.c:10938 [inline]
       unregister_netdevice_queue+0x2e5/0x3c0 net/core/dev.c:10818
       unregister_netdevice include/linux/netdevice.h:3109 [inline]
       _cfg80211_unregister_wdev+0x64a/0x830 net/wireless/core.c:1157
       ieee80211_if_remove+0x1e3/0x390 net/mac80211/iface.c:2239
       ieee80211_del_iface+0x16/0x20 net/mac80211/cfg.c:202
       rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline]
       cfg80211_remove_virtual_intf+0xd3/0x400 net/wireless/util.c:2574
       nl80211_del_interface+0x106/0x190 net/wireless/nl80211.c:4378
       genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968
       genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline]
       genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065
       netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2546
       genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076
       netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline]
       netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365
       netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1913
       sock_sendmsg_nosec net/socket.c:724 [inline]
       sock_sendmsg+0xde/0x190 net/socket.c:747
       ____sys_sendmsg+0x71c/0x900 net/socket.c:2503
       ___sys_sendmsg+0x110/0x1b0 net/socket.c:2557
       __sys_sendmsg+0xf7/0x1c0 net/socket.c:2586
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rdev->wiphy.mtx);
                               lock(team->team_lock_key#4);
                               lock(&rdev->wiphy.mtx);
  lock(team->team_lock_key#4);

 *** DEADLOCK ***

3 locks held by syz-executor.0/27015:
 #0: ffffffff8e1816b0 (cb_lock){++++}-{3:3}, at: genl_rcv+0x19/0x40 net/netlink/genetlink.c:1075
 #1: ffffffff8e0ee928 (rtnl_mutex){+.+.}-{3:3}, at: nl80211_pre_doit+0xb4/0xab0 net/wireless/nl80211.c:16380
 #2: ffff88805bab0728 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0xfb/0x190 net/wireless/nl80211.c:4376

stack backtrace:
CPU: 3 PID: 27015 Comm: syz-executor.0 Not tainted 6.3.0-syzkaller-07919-g6e98b09da931 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2188
 check_prev_add kernel/locking/lockdep.c:3108 [inline]
 check_prevs_add kernel/locking/lockdep.c:3227 [inline]
 validate_chain kernel/locking/lockdep.c:3842 [inline]
 __lock_acquire+0x2f21/0x5df0 kernel/locking/lockdep.c:5074
 lock_acquire kernel/locking/lockdep.c:5691 [inline]
 lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5656
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
 team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998
 team_device_event+0xd7/0xad0 drivers/net/team/team.c:3022
 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
 call_netdevice_notifiers_info+0xb9/0x130 net/core/dev.c:1935
 call_netdevice_notifiers_extack net/core/dev.c:1973 [inline]
 call_netdevice_notifiers net/core/dev.c:1987 [inline]
 unregister_netdevice_many_notify+0x75f/0x18c0 net/core/dev.c:10882
 unregister_netdevice_many net/core/dev.c:10938 [inline]
 unregister_netdevice_queue+0x2e5/0x3c0 net/core/dev.c:10818
 unregister_netdevice include/linux/netdevice.h:3109 [inline]
 _cfg80211_unregister_wdev+0x64a/0x830 net/wireless/core.c:1157
 ieee80211_if_remove+0x1e3/0x390 net/mac80211/iface.c:2239
 ieee80211_del_iface+0x16/0x20 net/mac80211/cfg.c:202
 rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline]
 cfg80211_remove_virtual_intf+0xd3/0x400 net/wireless/util.c:2574
 nl80211_del_interface+0x106/0x190 net/wireless/nl80211.c:4378
 genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968
 genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline]
 genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065
 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2546
 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076
 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline]
 netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365
 netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1913
 sock_sendmsg_nosec net/socket.c:724 [inline]
 sock_sendmsg+0xde/0x190 net/socket.c:747
 ____sys_sendmsg+0x71c/0x900 net/socket.c:2503
 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2557
 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2586
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fe529a8c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fe52a8cc168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fe529babf80 RCX: 00007fe529a8c169
RDX: 0000000000000000 RSI: 0000000020000580 RDI: 0000000000000004
RBP: 00007fe529ae7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc3ca4c73f R14: 00007fe52a8cc300 R15: 0000000000022000
 </TASK>
mac80211_hwsim hwsim8 wlan0 (unregistering): left allmulticast mode
team0: Port device wlan0 removed

Crashes (35):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/04/27 13:42 upstream 6e98b09da931 6f3d6fa7 .config console log report info ci-qemu-upstream possible deadlock in team_del_slave
2023/04/23 23:41 upstream 457391b03803 2b32bd34 .config console log report info ci-qemu-upstream possible deadlock in team_del_slave
2023/04/08 23:43 upstream a79d5c76f705 71147e29 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in team_del_slave
2023/04/08 01:54 upstream aa318c48808c 71147e29 .config console log report info ci-qemu-upstream possible deadlock in team_del_slave
2023/04/08 00:26 upstream aa318c48808c f7ba566d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in team_del_slave
2023/02/24 14:01 upstream d2980d8d8265 ee50e71c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_del_slave
2023/02/17 15:33 upstream ec35307e18ba 3e7039f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_del_slave
2023/02/16 01:23 upstream 033c40a89f55 6be0f1f5 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_del_slave
2023/02/05 23:14 upstream 837c07cf68fe be607b78 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in team_del_slave
2023/02/01 22:13 upstream c0b67534c95c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_del_slave
2023/02/01 22:01 upstream c0b67534c95c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-root possible deadlock in team_del_slave
2023/01/28 02:03 upstream 83abd4d4c4be 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in team_del_slave
2023/05/11 11:25 upstream 80e62bc8487b 0fbd49f4 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/04/30 17:34 upstream 825a0714d2b3 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/04/07 11:59 upstream f2afccfefe7b f7ba566d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/04/06 10:41 upstream 99ddf2254feb 08707520 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/02/24 11:41 upstream d2980d8d8265 9e2ebb3c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/02/11 06:40 upstream 420b2d431d18 93e26d60 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/01/26 05:07 upstream 7c46948a6e9c 9dfcf09c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_del_slave
2023/02/19 16:53 net-old ec35307e18ba bcdf85f8 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in team_del_slave
2023/07/13 13:50 net-next ba2274dcfda8 86081196 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/07/02 03:24 net-next ae230642190a bfc47836 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/21 05:14 net-next 857922b16bb8 09ffe269 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/21 01:59 net-next 857922b16bb8 09ffe269 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/20 07:22 net-next 4931062492c5 09ffe269 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/20 05:26 net-next 4931062492c5 d521bc56 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/19 01:52 net-next 9a94d764e9bc f3921d4d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/18 11:15 net-next b650d953cd39 f3921d4d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/15 12:51 net-next 97c5209b3d37 757d26ed .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/13 18:03 net-next 6b5f9a87e12d d2ee9228 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/06/13 11:24 net-next c29e012eae29 749afb64 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/05/30 09:36 net-next eee2e03c8ffe 8d5c7541 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/04/30 08:13 net-next 042334a8d424 62df2017 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/03/28 19:43 net-next d8b0c963e919 48c74771 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_del_slave
2023/03/24 20:43 net-next 323fe43cf9ae 9700afae .config console log report info ci-upstream-net-kasan-gce possible deadlock in team_del_slave
* Struck through repros no longer work on HEAD.