syzbot


possible deadlock in team_del_slave (2)

Status: upstream: reported C repro on 2024/01/12 21:46
Bug presence: origin:lts-only
[Documentation on labels]
Reported-by: syzbot+f8e450120944c93ce4d3@syzkaller.appspotmail.com
First crash: 187d, last: 6d13h
Bug presence (2)
Date Name Commit Repro Result
2024/01/18 linux-5.15.y (ToT) ddcaf4999061 C [report] possible deadlock in team_del_slave
2024/01/18 upstream (ToT) b0d326da462e C Didn't crash
Similar bugs (5)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream possible deadlock in team_del_slave net 1 1034d 1031d 0/27 auto-closed as invalid on 2022/01/16 14:16
upstream possible deadlock in team_del_slave (2) net 35 371d 535d 0/27 auto-obsoleted due to no activity on 2023/09/28 12:50
linux-6.1 possible deadlock in team_del_slave origin:upstream C 29 6d19h 113d 0/3 upstream: reported C repro on 2024/03/27 10:53
upstream possible deadlock in team_del_slave (3) net C error 78919 now 83d 0/27 upstream: reported C repro on 2024/04/26 11:59
linux-5.15 possible deadlock in team_del_slave 1 460d 460d 0/3 auto-obsoleted due to no activity on 2023/08/13 07:03
Fix bisection attempts (2)
Created Duration User Patch Repo Result
2024/04/02 04:35 2h22m fix candidate upstream OK (0) job log log
2024/03/20 19:08 55m bisect fix linux-5.15.y OK (0) job log log

Sample crash report:
netlink: 60 bytes leftover after parsing attributes in process `syz-executor345'.
device wlan1 entered promiscuous mode
team0: Port device wlan1 added
======================================================
WARNING: possible circular locking dependency detected
5.15.147-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor345/3510 is trying to acquire lock:
ffff888072820d00 (team->team_lock_key){+.+.}-{3:3}, at: team_del_slave+0x2e/0x1f0 drivers/net/team/team.c:1996

but task is already holding lock:
ffff888014bf8628 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x127/0x370 net/wireless/nl80211.c:4104

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}:
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       wiphy_lock include/net/cfg80211.h:5314 [inline]
       ieee80211_open+0x13a/0x1f0 net/mac80211/iface.c:361
       __dev_open+0x36f/0x500 net/core/dev.c:1506
       dev_open+0xa9/0x260 net/core/dev.c:1542
       team_port_add drivers/net/team/team.c:1212 [inline]
       team_add_slave+0x981/0x27a0 drivers/net/team/team.c:1982
       do_set_master net/core/rtnetlink.c:2543 [inline]
       do_setlink+0xe71/0x3ae0 net/core/rtnetlink.c:2748
       __rtnl_newlink net/core/rtnetlink.c:3429 [inline]
       rtnl_newlink+0x17a4/0x2070 net/core/rtnetlink.c:3549
       rtnetlink_rcv_msg+0x993/0xee0 net/core/rtnetlink.c:5630
       netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
       netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
       netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
       netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
       sock_sendmsg_nosec net/socket.c:704 [inline]
       __sock_sendmsg net/socket.c:716 [inline]
       ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
       ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
       __sys_sendmsg net/socket.c:2514 [inline]
       __do_sys_sendmsg net/socket.c:2523 [inline]
       __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

-> #0 (team->team_lock_key){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
       __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
       lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
       team_del_slave+0x2e/0x1f0 drivers/net/team/team.c:1996
       team_device_event+0x264/0x580 drivers/net/team/team.c:3038
       notifier_call_chain kernel/notifier.c:83 [inline]
       raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:391
       call_netdevice_notifiers_info net/core/dev.c:2018 [inline]
       call_netdevice_notifiers_extack net/core/dev.c:2030 [inline]
       call_netdevice_notifiers net/core/dev.c:2044 [inline]
       unregister_netdevice_many+0xf1b/0x18f0 net/core/dev.c:11090
       unregister_netdevice_queue+0x2e6/0x350 net/core/dev.c:11023
       unregister_netdevice include/linux/netdevice.h:3012 [inline]
       _cfg80211_unregister_wdev+0x181/0x510 net/wireless/core.c:1127
       ieee80211_if_remove+0x1cc/0x2c0 net/mac80211/iface.c:2090
       ieee80211_del_iface+0x15/0x20 net/mac80211/cfg.c:145
       rdev_del_virtual_intf net/wireless/rdev-ops.h:57 [inline]
       nl80211_del_interface+0x1f5/0x370 net/wireless/nl80211.c:4106
       genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
       genl_family_rcv_msg net/netlink/genetlink.c:775 [inline]
       genl_rcv_msg+0xfbd/0x14a0 net/netlink/genetlink.c:792
       netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
       genl_rcv+0x24/0x40 net/netlink/genetlink.c:803
       netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
       netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
       netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
       sock_sendmsg_nosec net/socket.c:704 [inline]
       __sock_sendmsg net/socket.c:716 [inline]
       ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
       ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
       __sys_sendmsg net/socket.c:2514 [inline]
       __do_sys_sendmsg net/socket.c:2523 [inline]
       __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x61/0xcb

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&rdev->wiphy.mtx);
                               lock(team->team_lock_key);
                               lock(&rdev->wiphy.mtx);
  lock(team->team_lock_key);

 *** DEADLOCK ***

3 locks held by syz-executor345/3510:
 #0: ffffffff8da39c90 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40 net/netlink/genetlink.c:802
 #1: ffffffff8d9da3c8 (rtnl_mutex){+.+.}-{3:3}, at: nl80211_pre_doit+0x28/0x540 net/wireless/nl80211.c:14960
 #2: ffff888014bf8628 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0x127/0x370 net/wireless/nl80211.c:4104

stack backtrace:
CPU: 1 PID: 3510 Comm: syz-executor345 Not tainted 5.15.147-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788
 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012
 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743
 team_del_slave+0x2e/0x1f0 drivers/net/team/team.c:1996
 team_device_event+0x264/0x580 drivers/net/team/team.c:3038
 notifier_call_chain kernel/notifier.c:83 [inline]
 raw_notifier_call_chain+0xd0/0x170 kernel/notifier.c:391
 call_netdevice_notifiers_info net/core/dev.c:2018 [inline]
 call_netdevice_notifiers_extack net/core/dev.c:2030 [inline]
 call_netdevice_notifiers net/core/dev.c:2044 [inline]
 unregister_netdevice_many+0xf1b/0x18f0 net/core/dev.c:11090
 unregister_netdevice_queue+0x2e6/0x350 net/core/dev.c:11023
 unregister_netdevice include/linux/netdevice.h:3012 [inline]
 _cfg80211_unregister_wdev+0x181/0x510 net/wireless/core.c:1127
 ieee80211_if_remove+0x1cc/0x2c0 net/mac80211/iface.c:2090
 ieee80211_del_iface+0x15/0x20 net/mac80211/cfg.c:145
 rdev_del_virtual_intf net/wireless/rdev-ops.h:57 [inline]
 nl80211_del_interface+0x1f5/0x370 net/wireless/nl80211.c:4106
 genl_family_rcv_msg_doit net/netlink/genetlink.c:731 [inline]
 genl_family_rcv_msg net/netlink/genetlink.c:775 [inline]
 genl_rcv_msg+0xfbd/0x14a0 net/netlink/genetlink.c:792
 netlink_rcv_skb+0x1cf/0x410 net/netlink/af_netlink.c:2505
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:803
 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline]
 netlink_unicast+0x7b6/0x980 net/netlink/af_netlink.c:1356
 netlink_sendmsg+0xa30/0xd60 net/netlink/af_netlink.c:1924
 sock_sendmsg_nosec net/socket.c:704 [inline]
 __sock_sendmsg net/socket.c:716 [inline]
 ____sys_sendmsg+0x59e/0x8f0 net/socket.c:2431
 ___sys_sendmsg+0x252/0x2e0 net/socket.c:2485
 __sys_sendmsg net/socket.c:2514 [inline]
 __do_sys_sendmsg net/socket.c:2523 [inline]
 __se_sys_sendmsg+0x19a/0x260 net/socket.c:2521
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x61/0xcb
RIP: 0033:0x7f94f616e4a9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 d1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffcbe7b0678 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f94f616e4a9
RDX: 0000000000000000 RSI: 0000000020000280 RDI: 0000000000000007
RBP: 0000000000000000 R08: 0000000000000000 R09: 00007ffcbe7b0700
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000031
R13: 0000000000000047 R14: 0000000000050012 R15: 0000000000000003
 </TASK>
team0: Port device wlan1 removed
syz-executor345 (3510) used greatest stack depth: 19768 bytes left

Crashes (32):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/01/18 21:02 linux-5.15.y ddcaf4999061 239abf84 .config console log report syz C [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/07/12 01:25 linux-5.15.y f45bea23c39c eaeb5c15 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/07/03 09:04 linux-5.15.y 4878aadf2d15 1ecfa2d8 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/07/01 20:30 linux-5.15.y 4878aadf2d15 b294e901 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/07/01 07:33 linux-5.15.y 4878aadf2d15 757f06b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/06/28 21:27 linux-5.15.y 4878aadf2d15 757f06b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/06/28 18:24 linux-5.15.y 4878aadf2d15 757f06b1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/06/21 15:47 linux-5.15.y 4878aadf2d15 edc5149a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/06/21 04:47 linux-5.15.y 4878aadf2d15 dac2aa43 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/27 22:53 linux-5.15.y c61bd26ae81a 761766e6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/18 08:27 linux-5.15.y 83655231580b c0f1611a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/18 08:27 linux-5.15.y 83655231580b c0f1611a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/18 03:05 linux-5.15.y 83655231580b c0f1611a .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/12 23:39 linux-5.15.y 284087d4f7d5 9026e142 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/09 11:42 linux-5.15.y 284087d4f7d5 05079661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/05/09 10:21 linux-5.15.y 284087d4f7d5 05079661 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/04/27 03:49 linux-5.15.y c52b9710c83d 07b455f9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/04/27 03:49 linux-5.15.y c52b9710c83d 07b455f9 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/04/01 11:17 linux-5.15.y 9465fef4ae35 6baf5069 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in team_del_slave
2024/04/01 01:22 linux-5.15.y 9465fef4ae35 6baf5069 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in team_del_slave
2024/03/26 12:33 linux-5.15.y b95c01af2113 bcd9b39f .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-perf possible deadlock in team_del_slave
2024/02/19 18:51 linux-5.15.y 6139f2a02fe0 3af7dd65 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/02/19 15:54 linux-5.15.y 6139f2a02fe0 3af7dd65 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/01/31 14:14 linux-5.15.y 6139f2a02fe0 373b66cd .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/01/18 16:17 linux-5.15.y ddcaf4999061 239abf84 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/01/12 21:45 linux-5.15.y 26c690eff0a5 551587c1 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan possible deadlock in team_del_slave
2024/07/05 04:25 linux-5.15.y 4878aadf2d15 3f2748a3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
2024/06/19 14:26 linux-5.15.y 4878aadf2d15 41b7e219 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
2024/05/28 07:02 linux-5.15.y c61bd26ae81a f550015e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
2024/05/24 09:19 linux-5.15.y 83655231580b 8f98448e .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
2024/05/21 20:48 linux-5.15.y 83655231580b 4c0d3ee3 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
2024/03/27 10:54 linux-5.15.y 9465fef4ae35 454571b6 .config console log report info [disk image] [vmlinux] [kernel image] ci2-linux-5-15-kasan-arm64 possible deadlock in team_del_slave
* Struck through repros no longer work on HEAD.