syzbot


KASAN: slab-out-of-bounds Write in hfs_bnode_read

Status: upstream: reported C repro on 2024/11/27 09:48
Subsystems: hfs
[Documentation on labels]
Reported-by: syzbot+c6811fc2262cec1e6266@syzkaller.appspotmail.com
First crash: 10d, last: 10d
Cause bisection: the issue happens on the oldest tested release (bisect log)
Crash: KASAN: slab-out-of-bounds Write in hfs_bnode_read (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[PATCH] hfs: check key length before reading 1 (1) 2024/11/28 12:31
[syzbot] [hfs?] KASAN: slab-out-of-bounds Write in hfs_bnode_read 1 (3) 2024/11/27 14:15
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-5.15 KASAN: slab-out-of-bounds Write in hfs_bnode_read origin:upstream C error 11 1d22h 548d 0/3 upstream: reported C repro on 2023/06/04 19:50
Last patch testing requests (1)
Created Duration User Patch Repo Result
2024/11/27 13:49 24m eadavis@qq.com https://github.com/ea1davis/linux hfs/syz OK log

Sample crash report:
loop0: detected capacity change from 0 to 64
==================================================================
BUG: KASAN: slab-out-of-bounds in memcpy_from_page include/linux/highmem.h:423 [inline]
BUG: KASAN: slab-out-of-bounds in hfs_bnode_read+0xbc/0x220 fs/hfs/bnode.c:35
Write of size 94 at addr ffff888141376a80 by task syz-executor396/5845

CPU: 0 UID: 0 PID: 5845 Comm: syz-executor396 Not tainted 6.12.0-syzkaller-07834-g06afb0f36106 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_address_description mm/kasan/report.c:377 [inline]
 print_report+0xc3/0x620 mm/kasan/report.c:488
 kasan_report+0xd9/0x110 mm/kasan/report.c:601
 check_region_inline mm/kasan/generic.c:183 [inline]
 kasan_check_range+0xef/0x1a0 mm/kasan/generic.c:189
 __asan_memcpy+0x3c/0x60 mm/kasan/shadow.c:106
 memcpy_from_page include/linux/highmem.h:423 [inline]
 hfs_bnode_read+0xbc/0x220 fs/hfs/bnode.c:35
 hfs_bnode_read_key+0x14e/0x1f0 fs/hfs/bnode.c:70
 hfs_brec_insert+0x66b/0xb90 fs/hfs/brec.c:159
 hfs_cat_move+0x3f0/0x7e0 fs/hfs/catalog.c:336
 hfs_rename+0xe8/0x200 fs/hfs/dir.c:299
 vfs_rename+0xf8b/0x21f0 fs/namei.c:5067
 do_renameat2+0xc5f/0xdd0 fs/namei.c:5224
 __do_sys_renameat2 fs/namei.c:5258 [inline]
 __se_sys_renameat2 fs/namei.c:5255 [inline]
 __x64_sys_renameat2+0xe7/0x130 fs/namei.c:5255
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff2c46adad9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fff22f2dbd8 EFLAGS: 00000246 ORIG_RAX: 000000000000013c
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007ff2c46adad9
RDX: 0000000000000004 RSI: 0000000020000380 RDI: 0000000000000004
RBP: 00007ff2c47215f0 R08: 0000000000000000 R09: 000055557c7724c0
R10: 0000000020000200 R11: 0000000000000246 R12: 00007fff22f2dc00
R13: 00007fff22f2de28 R14: 431bde82d7b634db R15: 00007ff2c46f603b
 </TASK>

Allocated by task 5845:
 kasan_save_stack+0x33/0x60 mm/kasan/common.c:47
 kasan_save_track+0x14/0x30 mm/kasan/common.c:68
 poison_kmalloc_redzone mm/kasan/common.c:377 [inline]
 __kasan_kmalloc+0xaa/0xb0 mm/kasan/common.c:394
 kasan_kmalloc include/linux/kasan.h:257 [inline]
 __do_kmalloc_node mm/slub.c:4264 [inline]
 __kmalloc_noprof+0x1e8/0x400 mm/slub.c:4276
 kmalloc_noprof include/linux/slab.h:883 [inline]
 hfs_find_init+0x95/0x220 fs/hfs/bfind.c:21
 hfs_cat_move+0x15a/0x7e0 fs/hfs/catalog.c:301
 hfs_rename+0xe8/0x200 fs/hfs/dir.c:299
 vfs_rename+0xf8b/0x21f0 fs/namei.c:5067
 do_renameat2+0xc5f/0xdd0 fs/namei.c:5224
 __do_sys_renameat2 fs/namei.c:5258 [inline]
 __se_sys_renameat2 fs/namei.c:5255 [inline]
 __x64_sys_renameat2+0xe7/0x130 fs/namei.c:5255
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f

The buggy address belongs to the object at ffff888141376a80
 which belongs to the cache kmalloc-96 of size 96
The buggy address is located 0 bytes inside of
 allocated 78-byte region [ffff888141376a80, ffff888141376ace)

The buggy address belongs to the physical page:
page: refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x141376
flags: 0x57ff00000000000(node=1|zone=2|lastcpupid=0x7ff)
page_type: f5(slab)
raw: 057ff00000000000 ffff88801b041280 dead000000000100 dead000000000122
raw: 0000000000000000 0000000080200020 00000001f5000000 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 0, migratetype Unmovable, gfp_mask 0x52cc0(GFP_KERNEL|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP), pid 1, tgid 1 (swapper/0), ts 20294449508, free_ts 0
 set_page_owner include/linux/page_owner.h:32 [inline]
 post_alloc_hook+0x2d1/0x350 mm/page_alloc.c:1556
 prep_new_page mm/page_alloc.c:1564 [inline]
 get_page_from_freelist+0xfce/0x2f80 mm/page_alloc.c:3474
 __alloc_pages_noprof+0x223/0x25a0 mm/page_alloc.c:4751
 alloc_pages_mpol_noprof+0x2c9/0x610 mm/mempolicy.c:2265
 alloc_slab_page mm/slub.c:2412 [inline]
 allocate_slab mm/slub.c:2578 [inline]
 new_slab+0x2c9/0x410 mm/slub.c:2631
 ___slab_alloc+0xdac/0x1880 mm/slub.c:3818
 __slab_alloc.constprop.0+0x56/0xb0 mm/slub.c:3908
 __slab_alloc_node mm/slub.c:3961 [inline]
 slab_alloc_node mm/slub.c:4122 [inline]
 __kmalloc_cache_noprof+0x2b4/0x300 mm/slub.c:4290
 kmalloc_noprof include/linux/slab.h:879 [inline]
 kzalloc_noprof include/linux/slab.h:1015 [inline]
 dev_pm_qos_expose_flags+0x96/0x310 drivers/base/power/qos.c:783
 usb_hub_create_port_device+0x8fd/0xde0 drivers/usb/core/port.c:812
 hub_configure drivers/usb/core/hub.c:1710 [inline]
 hub_probe+0x1e1f/0x3200 drivers/usb/core/hub.c:1965
 usb_probe_interface+0x30c/0x9d0 drivers/usb/core/driver.c:399
 call_driver_probe drivers/base/dd.c:579 [inline]
 really_probe+0x241/0xa90 drivers/base/dd.c:658
 __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
 driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
 __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
page_owner free stack trace missing

Memory state around the buggy address:
 ffff888141376980: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
 ffff888141376a00: 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc
>ffff888141376a80: 00 00 00 00 00 00 00 00 00 06 fc fc fc fc fc fc
                                              ^
 ffff888141376b00: 00 00 00 00 00 00 00 00 00 fc fc fc fc fc fc fc
 ffff888141376b80: fa fb fb fb fb fb fb fb fb fb fb fb fc fc fc fc
==================================================================

Crashes (4):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/11/23 12:59 upstream 06afb0f36106 68da6d95 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-badwrites-root KASAN: slab-out-of-bounds Write in hfs_bnode_read
2024/11/23 12:09 upstream 06afb0f36106 68da6d95 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] [mounted in repro] ci-upstream-kasan-badwrites-root KASAN: slab-out-of-bounds Write in hfs_bnode_read
2024/11/23 11:34 upstream 06afb0f36106 68da6d95 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root KASAN: slab-out-of-bounds Write in hfs_bnode_read
2024/11/23 11:31 upstream 06afb0f36106 68da6d95 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-badwrites-root KASAN: slab-out-of-bounds Write in hfs_bnode_read
* Struck through repros no longer work on HEAD.