syzbot


WARNING in __local_bh_enable_ip (2)

Status: fixed on 2018/05/08 18:30
Subsystems: rds
[Documentation on labels]
Reported-by: syzbot+c68e51bb5e699d3f8d91@syzkaller.appspotmail.com
Fix commit: 53d0e83f9329 rds: tcp: must use spin_lock_irq* and not spin_lock_bh with rds_tcp_conn_lock
First crash: 2096d, last: 2085d
Discussions (3)
Title Replies (including bot) Last reply
[PATCH 4.16 00/72] 4.16.9-stable review 86 (86) 2018/05/15 06:47
[PATCH net-next] rds: tcp: must use spin_lock_irq* and not spin_lock_bh with rds_tcp_conn_lock 3 (3) 2018/03/17 21:19
Re: WARNING in __local_bh_enable_ip (2) 2 (2) 2018/03/14 21:33
Similar bugs (3)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream WARNING in __local_bh_enable_ip 22 2268d 2275d 3/25 fixed on 2017/10/24 07:07
upstream WARNING in __local_bh_enable_ip (3) mm 1 1918d 1916d 0/25 auto-closed as invalid on 2019/03/07 16:37
upstream WARNING in __local_bh_enable_ip (4) net 1 1514d 1514d 0/25 auto-closed as invalid on 2020/01/15 23:54

Sample crash report:
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=2826 sclass=netlink_route_socket pig=8208 comm=syz-executor5
SELinux: unrecognized netlink message: protocol=0 nlmsg_type=2826 sclass=netlink_route_socket pig=8213 comm=syz-executor5
------------[ cut here ]------------
IRQs not enabled as expected
WARNING: CPU: 0 PID: 8228 at kernel/softirq.c:162 __local_bh_enable_ip+0x1bb/0x230 kernel/softirq.c:162
Kernel panic - not syncing: panic_on_warn set ...

CPU: 0 PID: 8228 Comm: syz-executor4 Not tainted 4.16.0-rc6+ #275
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x194/0x24d lib/dump_stack.c:53
 panic+0x1e4/0x41c kernel/panic.c:183
 __warn+0x1dc/0x200 kernel/panic.c:547
 report_bug+0x1f4/0x2b0 lib/bug.c:186
 fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178
 fixup_bug arch/x86/kernel/traps.c:247 [inline]
 do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296
 do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315
 invalid_op+0x1b/0x40 arch/x86/entry/entry_64.S:986
RIP: 0010:__local_bh_enable_ip+0x1bb/0x230 kernel/softirq.c:162
RSP: 0018:ffff8801a90af1a0 EFLAGS: 00010082
RAX: dffffc0000000008 RBX: 0000000000000201 RCX: ffffffff815ad0de
RDX: 00000000000086bb RSI: ffffc900015de000 RDI: 1ffff10035215db9
RBP: ffff8801a90af1b8 R08: 0000000000000000 R09: 1ffff10035215d8b
R10: ffff8801a90af098 R11: 0000000000000002 R12: ffffffff85637eb4
R13: ffff8801da4f2200 R14: ffff8801a90af250 R15: 1ffff10035215e42
 __raw_spin_unlock_bh include/linux/spinlock_api_smp.h:176 [inline]
 _raw_spin_unlock_bh+0x30/0x40 kernel/locking/spinlock.c:200
 spin_unlock_bh include/linux/spinlock.h:355 [inline]
 rds_tcp_conn_free+0xa4/0x2d0 net/rds/tcp.c:284
 __rds_conn_create+0x148f/0x1b60 net/rds/connection.c:277
 rds_conn_create_outgoing+0x3f/0x50 net/rds/connection.c:309
 rds_sendmsg+0xda3/0x2390 net/rds/send.c:1126
 sock_sendmsg_nosec net/socket.c:630 [inline]
 sock_sendmsg+0xca/0x110 net/socket.c:640
 ___sys_sendmsg+0x767/0x8b0 net/socket.c:2046
 __sys_sendmsg+0xe5/0x210 net/socket.c:2080
 C_SYSC_sendmsg net/compat.c:739 [inline]
 compat_SyS_sendmsg+0x2a/0x40 net/compat.c:737
 do_syscall_32_irqs_on arch/x86/entry/common.c:330 [inline]
 do_fast_syscall_32+0x3ec/0xf9f arch/x86/entry/common.c:392
 entry_SYSENTER_compat+0x70/0x7f arch/x86/entry/entry_64_compat.S:139
RIP: 0023:0xf7fe4c99
RSP: 002b:00000000f779e09c EFLAGS: 00000286 ORIG_RAX: 0000000000000172
RAX: ffffffffffffffda RBX: 0000000000000015 RCX: 0000000020001580
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
Dumping ftrace buffer:
   (ftrace buffer empty)
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (23):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/03/25 08:07 upstream bcfc1f455466 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/25 06:42 upstream bcfc1f455466 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/24 21:35 upstream bcfc1f455466 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/24 13:37 upstream 99fec39e7725 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/24 13:02 upstream 99fec39e7725 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/24 07:57 upstream 99fec39e7725 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/23 20:14 upstream f36b7534b833 2e9d9054 .config console log report ci-upstream-kasan-gce-386
2018/03/22 00:56 upstream 3215b9d57a2c 95c88d7a .config console log report ci-upstream-kasan-gce-386
2018/03/20 19:02 upstream 1b5f3ba415fe 72c33b66 .config console log report ci-upstream-kasan-gce-386
2018/03/19 08:03 upstream 9e1909b9da04 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/03/17 10:46 upstream 8f5fd927c3a7 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/03/15 22:23 upstream e2c15aff5f35 08dacaa0 .config console log report ci-upstream-kasan-gce-386
2018/03/17 20:44 net-next-old 53794570049d 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/17 20:13 net-next-old 53794570049d 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/17 10:35 net-next-old 53794570049d 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/16 22:56 net-next-old 53794570049d 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/16 15:44 net-next-old 0aee4c259849 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/16 09:24 net-next-old 0aee4c259849 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/15 08:53 net-next-old c292566a7779 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/15 04:07 net-next-old c292566a7779 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/15 03:59 net-next-old c292566a7779 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/14 19:18 net-next-old a870a02cc963 08dacaa0 .config console log report ci-upstream-net-kasan-gce
2018/03/14 11:39 net-next-old be9fc0971a5c 08dacaa0 .config console log report ci-upstream-net-kasan-gce
* Struck through repros no longer work on HEAD.