syzbot


UBSAN: shift-out-of-bounds in xfrm_selector_match (2)

Status: fixed on 2024/11/12 23:31
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+cc39f136925517aed571@syzkaller.appspotmail.com
Fix commit: 3f0ab59e6537 xfrm: validate new SA's prefixlen using SA family when sel.family is unset
First crash: 80d, last: 63d
Cause bisection: failed (error log, bisect log)
  
Discussions (3)
Title Replies (including bot) Last reply
[PATCH 4/5] xfrm: validate new SA's prefixlen using SA family when sel.family is unset 1 (1) 2024/10/22 09:22
[PATCH ipsec] xfrm: validate new SA's prefixlen using SA family when sel.family is unset 2 (2) 2024/10/09 08:33
[syzbot] [net?] UBSAN: shift-out-of-bounds in xfrm_selector_match (2) 4 (6) 2024/10/01 17:10
Similar bugs (1)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream UBSAN: shift-out-of-bounds in xfrm_selector_match net 4 1115d 1270d 0/28 auto-closed as invalid on 2022/03/13 00:17

Sample crash report:
------------[ cut here ]------------
UBSAN: shift-out-of-bounds in ./include/net/xfrm.h:900:23
shift exponent -96 is negative
CPU: 0 UID: 0 PID: 5231 Comm: syz-executor893 Not tainted 6.11.0-syzkaller-01459-g151ac45348af #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:93 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
 ubsan_epilogue lib/ubsan.c:231 [inline]
 __ubsan_handle_shift_out_of_bounds+0x3c8/0x420 lib/ubsan.c:468
 addr4_match include/net/xfrm.h:900 [inline]
 __xfrm4_selector_match net/xfrm/xfrm_policy.c:222 [inline]
 xfrm_selector_match+0xe9b/0x1030 net/xfrm/xfrm_policy.c:247
 xfrm_state_look_at+0xe8/0x480 net/xfrm/xfrm_state.c:1172
 xfrm_state_find+0x199f/0x4d70 net/xfrm/xfrm_state.c:1280
 xfrm_tmpl_resolve_one net/xfrm/xfrm_policy.c:2481 [inline]
 xfrm_tmpl_resolve net/xfrm/xfrm_policy.c:2532 [inline]
 xfrm_resolve_and_create_bundle+0x6d2/0x2c90 net/xfrm/xfrm_policy.c:2826
 xfrm_lookup_with_ifid+0x334/0x1ee0 net/xfrm/xfrm_policy.c:3160
 xfrm_lookup net/xfrm/xfrm_policy.c:3289 [inline]
 xfrm_lookup_route+0x3c/0x1c0 net/xfrm/xfrm_policy.c:3300
 ip_route_connect include/net/route.h:333 [inline]
 __ip4_datagram_connect+0x96c/0x1260 net/ipv4/datagram.c:49
 __ip6_datagram_connect+0x194/0x1230
 ip6_datagram_connect net/ipv6/datagram.c:279 [inline]
 ip6_datagram_connect_v6_only+0x63/0xa0 net/ipv6/datagram.c:291
 __sys_connect_file net/socket.c:2067 [inline]
 __sys_connect+0x2df/0x310 net/socket.c:2084
 __do_sys_connect net/socket.c:2094 [inline]
 __se_sys_connect net/socket.c:2091 [inline]
 __x64_sys_connect+0x7a/0x90 net/socket.c:2091
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb0cdb8e8a9
Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffdce8cd648 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
RAX: ffffffffffffffda RBX: 00007ffdce8cd818 RCX: 00007fb0cdb8e8a9
RDX: 000000000000001c RSI: 0000000020000000 RDI: 0000000000000004
RBP: 00007fb0cdc01610 R08: 000000000000000a R09: 00007ffdce8cd818
R10: 00000000000000e8 R11: 0000000000000246 R12: 0000000000000001
R13: 00007ffdce8cd808 R14: 0000000000000001 R15: 0000000000000001
 </TASK>
---[ end trace ]---

Crashes (10):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/09/24 21:51 net-next 151ac45348af 5643e0e9 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/29 17:27 linux-next 40e0c9d414f5 ba29ff75 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/28 01:17 net-next c824deb1a897 2b1784d6 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/27 08:45 net-next 151ac45348af 9314348a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/24 20:38 net-next 151ac45348af 5643e0e9 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/22 18:55 net-next 9410645520e9 6f888b75 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/17 23:22 net-next 9410645520e9 c673ca06 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/17 08:58 net-next 9410645520e9 c673ca06 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/16 17:57 net-next 3561373114c8 49cf0773 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
2024/09/12 22:37 net-next 3cfb5aa10cb7 60e1a995 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce UBSAN: shift-out-of-bounds in xfrm_selector_match
* Struck through repros no longer work on HEAD.