syzbot


possible deadlock in team_vlan_rx_kill_vid

Status: upstream: reported on 2025/04/07 06:08
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+cefa9e687471ee7f359a@syzkaller.appspotmail.com
First crash: 21d, last: 8d12h
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [net?] possible deadlock in team_vlan_rx_kill_vid 0 (1) 2025/04/07 06:08

Sample crash report:
hsr_slave_0: left promiscuous mode
hsr_slave_1: left promiscuous mode
======================================================
WARNING: possible circular locking dependency detected
6.15.0-rc2-syzkaller-00087-gcfb2e2c57aef #0 Not tainted
------------------------------------------------------
kworker/u8:7/2912 is trying to acquire lock:
ffff888060068e00 (team->team_lock_key#4){+.+.}-{4:4}, at: team_vlan_rx_kill_vid+0x36/0xe0 drivers/net/team/team_core.c:1933

but task is already holding lock:
ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2751 [inline]
ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: netdev_lock_ops include/net/netdev_lock.h:42 [inline]
ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: unregister_netdevice_many_notify+0x5a1/0x2510 net/core/dev.c:11938

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_instance_lock_key#3){+.+.}-{4:4}:
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746
       netdev_lock include/linux/netdevice.h:2751 [inline]
       netdev_lock_ops include/net/netdev_lock.h:42 [inline]
       dev_set_mtu+0x11c/0x270 net/core/dev_api.c:246
       team_port_add drivers/net/team/team_core.c:1215 [inline]
       team_add_slave+0x83b/0x28b0 drivers/net/team/team_core.c:1989
       do_set_master+0x579/0x730 net/core/rtnetlink.c:2946
       do_setlink+0xf76/0x4390 net/core/rtnetlink.c:3159
       rtnl_changelink net/core/rtnetlink.c:3772 [inline]
       __rtnl_newlink net/core/rtnetlink.c:3931 [inline]
       rtnl_newlink+0x17e2/0x1fe0 net/core/rtnetlink.c:4068
       rtnetlink_rcv_msg+0x80f/0xd70 net/core/rtnetlink.c:6958
       netlink_rcv_skb+0x208/0x480 net/netlink/af_netlink.c:2534
       netlink_unicast_kernel net/netlink/af_netlink.c:1313 [inline]
       netlink_unicast+0x7f8/0x9a0 net/netlink/af_netlink.c:1339
       netlink_sendmsg+0x8c3/0xcd0 net/netlink/af_netlink.c:1883
       sock_sendmsg_nosec net/socket.c:712 [inline]
       __sock_sendmsg+0x221/0x270 net/socket.c:727
       ____sys_sendmsg+0x523/0x860 net/socket.c:2566
       ___sys_sendmsg net/socket.c:2620 [inline]
       __sys_sendmsg+0x271/0x360 net/socket.c:2652
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (team->team_lock_key#4){+.+.}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3166 [inline]
       check_prevs_add kernel/locking/lockdep.c:3285 [inline]
       validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
       __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
       lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
       __mutex_lock_common kernel/locking/mutex.c:601 [inline]
       __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746
       team_vlan_rx_kill_vid+0x36/0xe0 drivers/net/team/team_core.c:1933
       vlan_kill_rx_filter_info net/8021q/vlan_core.c:222 [inline]
       __vlan_vid_del net/8021q/vlan_core.c:362 [inline]
       vlan_vid_del+0x483/0x770 net/8021q/vlan_core.c:387
       vlan_device_event+0x23c/0x1e00 net/8021q/vlan.c:390
       notifier_call_chain+0x1a5/0x3f0 kernel/notifier.c:85
       call_netdevice_notifiers_extack net/core/dev.c:2212 [inline]
       call_netdevice_notifiers net/core/dev.c:2226 [inline]
       dev_close_many+0x33e/0x4c0 net/core/dev.c:1729
       unregister_netdevice_many_notify+0x628/0x2510 net/core/dev.c:11940
       unregister_netdevice_many net/core/dev.c:12035 [inline]
       default_device_exit_batch+0x7ff/0x880 net/core/dev.c:12527
       ops_exit_list net/core/net_namespace.c:177 [inline]
       cleanup_net+0x8af/0xd60 net/core/net_namespace.c:654
       process_one_work kernel/workqueue.c:3238 [inline]
       process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319
       worker_thread+0x870/0xd50 kernel/workqueue.c:3400
       kthread+0x7b7/0x940 kernel/kthread.c:464
       ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev_instance_lock_key#3);
                               lock(team->team_lock_key#4);
                               lock(&dev_instance_lock_key#3);
  lock(team->team_lock_key#4);

 *** DEADLOCK ***

5 locks held by kworker/u8:7/2912:
 #0: ffff88801bef6148 ((wq_completion)netns){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3213 [inline]
 #0: ffff88801bef6148 ((wq_completion)netns){+.+.}-{0:0}, at: process_scheduled_works+0x990/0x18e0 kernel/workqueue.c:3319
 #1: ffffc9000b9c7c60 (net_cleanup_work){+.+.}-{0:0}, at: process_one_work kernel/workqueue.c:3214 [inline]
 #1: ffffc9000b9c7c60 (net_cleanup_work){+.+.}-{0:0}, at: process_scheduled_works+0x9cb/0x18e0 kernel/workqueue.c:3319
 #2: ffffffff900f0a90 (pernet_ops_rwsem){++++}-{4:4}, at: cleanup_net+0x17c/0xd60 net/core/net_namespace.c:608
 #3: ffffffff900fd5c8 (rtnl_mutex){+.+.}-{4:4}, at: default_device_exit_batch+0xde/0x880 net/core/dev.c:12513
 #4: ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: netdev_lock include/linux/netdevice.h:2751 [inline]
 #4: ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: netdev_lock_ops include/net/netdev_lock.h:42 [inline]
 #4: ffff8880601c0d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: unregister_netdevice_many_notify+0x5a1/0x2510 net/core/dev.c:11938

stack backtrace:
CPU: 1 UID: 0 PID: 2912 Comm: kworker/u8:7 Not tainted 6.15.0-rc2-syzkaller-00087-gcfb2e2c57aef #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 02/12/2025
Workqueue: netns cleanup_net
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120
 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2079
 check_noncircular+0x142/0x160 kernel/locking/lockdep.c:2211
 check_prev_add kernel/locking/lockdep.c:3166 [inline]
 check_prevs_add kernel/locking/lockdep.c:3285 [inline]
 validate_chain+0xa69/0x24e0 kernel/locking/lockdep.c:3909
 __lock_acquire+0xad5/0xd80 kernel/locking/lockdep.c:5235
 lock_acquire+0x116/0x2f0 kernel/locking/lockdep.c:5866
 __mutex_lock_common kernel/locking/mutex.c:601 [inline]
 __mutex_lock+0x1a5/0x10c0 kernel/locking/mutex.c:746
 team_vlan_rx_kill_vid+0x36/0xe0 drivers/net/team/team_core.c:1933
 vlan_kill_rx_filter_info net/8021q/vlan_core.c:222 [inline]
 __vlan_vid_del net/8021q/vlan_core.c:362 [inline]
 vlan_vid_del+0x483/0x770 net/8021q/vlan_core.c:387
 vlan_device_event+0x23c/0x1e00 net/8021q/vlan.c:390
 notifier_call_chain+0x1a5/0x3f0 kernel/notifier.c:85
 call_netdevice_notifiers_extack net/core/dev.c:2212 [inline]
 call_netdevice_notifiers net/core/dev.c:2226 [inline]
 dev_close_many+0x33e/0x4c0 net/core/dev.c:1729
 unregister_netdevice_many_notify+0x628/0x2510 net/core/dev.c:11940
 unregister_netdevice_many net/core/dev.c:12035 [inline]
 default_device_exit_batch+0x7ff/0x880 net/core/dev.c:12527
 ops_exit_list net/core/net_namespace.c:177 [inline]
 cleanup_net+0x8af/0xd60 net/core/net_namespace.c:654
 process_one_work kernel/workqueue.c:3238 [inline]
 process_scheduled_works+0xac3/0x18e0 kernel/workqueue.c:3319
 worker_thread+0x870/0xd50 kernel/workqueue.c:3400
 kthread+0x7b7/0x940 kernel/kthread.c:464
 ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:153
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:245
 </TASK>

Crashes (107):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/04/17 15:20 upstream cfb2e2c57aef 2a6ededb .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/16 15:24 upstream 1a1d569a75f3 23b969b7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/12 04:38 upstream 3bde70a2c827 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 13:45 upstream 900241a5cc15 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-selinux-root possible deadlock in team_vlan_rx_kill_vid
2025/04/11 12:01 upstream 900241a5cc15 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 10:17 upstream 900241a5cc15 1bc60a19 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/10 23:53 upstream ab59a8605604 1bc60a19 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/10 13:26 upstream 3b07108ada81 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 22:26 upstream a24588245776 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 21:24 upstream a24588245776 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 14:17 upstream a24588245776 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 09:58 upstream bec7dcbc242c b133e63a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 08:37 upstream bec7dcbc242c b133e63a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 23:23 upstream bec7dcbc242c b133e63a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 21:42 upstream bec7dcbc242c a775275d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 20:12 upstream 0af2f6be1b42 a775275d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 08:44 upstream 0af2f6be1b42 a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 04:08 upstream 0af2f6be1b42 a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 21:33 upstream 0af2f6be1b42 a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 18:31 upstream 0af2f6be1b42 a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/06 18:06 upstream 16cd1c265776 1c65791e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 20:57 upstream 900241a5cc15 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-kasan-gce-386 possible deadlock in team_vlan_rx_kill_vid
2025/04/16 16:34 upstream c62f4b82d571 a95239b1 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in team_vlan_rx_kill_vid
2025/04/15 05:47 upstream 834a4a689699 0bd6db41 .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream-386 possible deadlock in team_vlan_rx_kill_vid
2025/04/13 14:30 net 8c941f14a694 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/17 20:54 net-next 4e34a840613b 2a6ededb .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/17 14:12 net-next 4e34a840613b 2a6ededb .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/16 12:12 net-next bbfc077d4572 23b969b7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/16 06:23 net-next bbfc077d4572 23b969b7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/14 12:46 net-next b65999e7238e 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/14 03:59 net-next 6a325aed130b 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/13 13:18 net-next 6a325aed130b 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/13 12:11 net-next 6a325aed130b 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/12 09:23 net-next faeefc173be4 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/12 01:09 net-next 0c49baf099ba 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 18:14 net-next 0c49baf099ba 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 14:22 net-next 0c49baf099ba 12ba9c21 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/11 03:45 net-next a9843689e2de 1bc60a19 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/10 20:09 net-next a9843689e2de 1bc60a19 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 18:27 net-next 420aabef3ab5 988b336c .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 07:09 net-next 0f681b0ecd19 b133e63a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/09 02:05 net-next 0f681b0ecd19 b133e63a .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 18:48 net-next fc2e4f4f7b5f a775275d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 17:23 net-next fc2e4f4f7b5f a775275d .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 05:44 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 03:56 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/08 02:42 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 20:53 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 18:39 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 16:52 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 12:15 net-next 61f96e684edd a2ada0e7 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/07 09:43 net-next 61f96e684edd 1c65791e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/04 23:39 net-next 61f96e684edd 1c4febdb .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-kasan-gce possible deadlock in team_vlan_rx_kill_vid
2025/04/12 23:19 linux-next 01c6df60d5d4 0bd6db41 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root possible deadlock in team_vlan_rx_kill_vid
* Struck through repros no longer work on HEAD.