KASAN: use-after-free Read in vhost_work_queue

Status: fixed on 2018/12/18 11:30
Subsystems: kvm net virt
[Documentation on labels]
Reported-by: syzbot+d5a0a170c5069658b141@syzkaller.appspotmail.com
Fix commit: 834e772c8db0 vhost/vsock: fix use-after-free in network stack callers
First crash: 2892d, last: 2788d
▶ ▼ Discussions (5)
Title Replies (including bot) Last reply
[PATCH 4.19 000/118] 4.19.9-stable review 132 (132) 2018/12/17 08:30
[PATCH 4.14 00/67] 4.14.88-stable review 73 (73) 2018/12/12 18:50
[PATCH 4.9 00/51] 4.9.145-stable review 56 (56) 2018/12/12 18:49
[PULL] virtio/vhost: last minute fixes 1 (1) 2018/12/07 21:53
KASAN: use-after-free Read in vhost_work_queue 2 (4) 2018/09/22 06:01

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in vhost_work_queue+0xc3/0xe0 drivers/vhost/vhost.c:258
Read of size 8 at addr ffff8801b07a5228 by task syz-executor0/16635

CPU: 1 PID: 16635 Comm: syz-executor0 Not tainted 4.19.0-rc7+ #282
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1c4/0x2b4 lib/dump_stack.c:113
 print_address_description.cold.8+0x9/0x1ff mm/kasan/report.c:256
 kasan_report_error mm/kasan/report.c:354 [inline]
 kasan_report.cold.9+0x242/0x309 mm/kasan/report.c:412
 __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433
 vhost_work_queue+0xc3/0xe0 drivers/vhost/vhost.c:258
 vhost_transport_send_pkt+0x28a/0x380 drivers/vhost/vsock.c:227
 virtio_transport_send_pkt_info+0x31d/0x460 net/vmw_vsock/virtio_transport_common.c:190
 virtio_transport_connect+0x17c/0x220 net/vmw_vsock/virtio_transport_common.c:588
 vsock_stream_connect+0x4ed/0xe40 net/vmw_vsock/af_vsock.c:1200
 __sys_connect+0x37d/0x4c0 net/socket.c:1664
 __do_sys_connect net/socket.c:1675 [inline]
 __se_sys_connect net/socket.c:1672 [inline]
 __x64_sys_connect+0x73/0xb0 net/socket.c:1672
 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x457569
Code: fd b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b3 fb ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007f1b2b17ec78 EFLAGS: 00000246 ORIG_RAX: 000000000000002a
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000457569
RDX: 0000000000000010 RSI: 0000000020000200 RDI: 0000000000000008
RBP: 000000000072bf00 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007f1b2b17f6d4
R13: 00000000004bdb06 R14: 00000000004cc658 R15: 00000000ffffffff

Allocated by task 16635:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 kasan_kmalloc+0xc7/0xe0 mm/kasan/kasan.c:553
 __do_kmalloc_node mm/slab.c:3682 [inline]
 __kmalloc_node+0x47/0x70 mm/slab.c:3689
 kmalloc_node include/linux/slab.h:555 [inline]
 kvmalloc_node+0xb9/0xf0 mm/util.c:423
 kvmalloc include/linux/mm.h:577 [inline]
 vhost_vsock_dev_open+0xa2/0x5a0 drivers/vhost/vsock.c:511
 misc_open+0x3ca/0x560 drivers/char/misc.c:141
 chrdev_open+0x25a/0x710 fs/char_dev.c:417
 do_dentry_open+0x499/0x1250 fs/open.c:771
 vfs_open+0xa0/0xd0 fs/open.c:880
 do_last fs/namei.c:3418 [inline]
 path_openat+0x12bf/0x5160 fs/namei.c:3534
 do_filp_open+0x255/0x380 fs/namei.c:3564
 do_sys_open+0x568/0x700 fs/open.c:1063
 __do_sys_openat fs/open.c:1090 [inline]
 __se_sys_openat fs/open.c:1084 [inline]
 __x64_sys_openat+0x9d/0x100 fs/open.c:1084
 do_syscall_64+0x1b9/0x820 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 16634:
 save_stack+0x43/0xd0 mm/kasan/kasan.c:448
 set_track mm/kasan/kasan.c:460 [inline]
 __kasan_slab_free+0x102/0x150 mm/kasan/kasan.c:521
 kasan_slab_free+0xe/0x10 mm/kasan/kasan.c:528
 __cache_free mm/slab.c:3498 [inline]
 kfree+0xcf/0x230 mm/slab.c:3813
 kvfree+0x61/0x70 mm/util.c:452
 vhost_vsock_free drivers/vhost/vsock.c:499 [inline]
 vhost_vsock_dev_release+0x4f4/0x720 drivers/vhost/vsock.c:604
 __fput+0x385/0xa30 fs/file_table.c:278
 ____fput+0x15/0x20 fs/file_table.c:309
 task_work_run+0x1e8/0x2a0 kernel/task_work.c:113
 tracehook_notify_resume include/linux/tracehook.h:193 [inline]
 exit_to_usermode_loop+0x318/0x380 arch/x86/entry/common.c:166
 prepare_exit_to_usermode arch/x86/entry/common.c:197 [inline]
 syscall_return_slowpath arch/x86/entry/common.c:268 [inline]
 do_syscall_64+0x6be/0x820 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

The buggy address belongs to the object at ffff8801b07a5180
 which belongs to the cache kmalloc-65536 of size 65536
The buggy address is located 168 bytes inside of
 65536-byte region [ffff8801b07a5180, ffff8801b07b5180)
The buggy address belongs to the page:
page:ffffea0006c1e800 count:1 mapcount:0 mapping:ffff8801da802500 index:0x0 compound_mapcount: 0
flags: 0x2fffc0000008100(slab|head)
raw: 02fffc0000008100 ffffea0006c13808 ffffea0006c00808 ffff8801da802500
raw: 0000000000000000 ffff8801b07a5180 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff8801b07a5100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
 ffff8801b07a5180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff8801b07a5200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                  ^
 ffff8801b07a5280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff8801b07a5300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (30):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2018/10/14 06:23 upstream 7ec21823634d caf12900 .config console log report syz ci-upstream-kasan-gce-root
2018/10/13 15:11 upstream bab5c80b2110 caf12900 .config console log report syz ci-upstream-kasan-gce
2018/10/20 20:38 upstream 270b77a0f30e ecb386fe .config console log report syz ci-upstream-kasan-gce-386
2018/09/28 02:23 linux-next 9e27e2c2d003 0c2fa87b .config console log report syz ci-upstream-linux-next-kasan-gce-root
2018/09/22 06:00 linux-next 46c163a036b4 37079712 .config console log report syz ci-upstream-linux-next-kasan-gce-root
2018/12/02 11:08 upstream 4b78317679c4 e0d8c853 .config console log report ci-upstream-kasan-gce-root
2018/12/01 00:16 upstream 94f371cb7394 ade12e91 .config console log report ci-upstream-kasan-gce
2018/11/26 10:08 upstream 2e6e902d1850 ac912200 .config console log report ci-upstream-kasan-gce-root
2018/11/22 00:29 upstream 92b419289cee 9db828b5 .config console log report ci-upstream-kasan-gce-smack-root
2018/11/14 08:29 upstream ccda4af0f4b9 5f5f6d14 .config console log report ci-upstream-kasan-gce
2018/11/13 09:41 upstream ccda4af0f4b9 5f5f6d14 .config console log report ci-upstream-kasan-gce-selinux-root
2018/11/13 04:52 upstream ccda4af0f4b9 74dbb806 .config console log report ci-upstream-kasan-gce-smack-root
2018/11/07 18:53 upstream e09d51adfbb1 e85d2a61 .config console log report ci-upstream-kasan-gce-selinux-root
2018/10/29 00:07 upstream dad4f140edaa 9ca2afa1 .config console log report ci-upstream-kasan-gce-selinux-root
2018/10/28 14:04 upstream 69d5b97c5973 6f9b225a .config console log report ci-upstream-kasan-gce-smack-root
2018/10/26 01:39 upstream bd6bf7c10484 a8292de9 .config console log report ci-upstream-kasan-gce-smack-root
2018/10/14 13:12 upstream 3a27203102eb caf12900 .config console log report ci-upstream-kasan-gce-root
2018/10/13 12:34 upstream bab5c80b2110 caf12900 .config console log report ci-upstream-kasan-gce-smack-root
2018/10/11 17:16 upstream 9dcd936c5312 5f818b4b .config console log report ci-upstream-kasan-gce-root
2018/10/03 07:46 upstream 1d2ba7fee28b 0f3e0261 .config console log report ci-upstream-kasan-gce-root
2018/09/27 23:37 upstream c127e59bee3e 0c2fa87b .config console log report ci-upstream-kasan-gce
2018/09/10 05:14 upstream 9a5682765a2e 6b5120a4 .config console log report ci-upstream-kasan-gce-smack-root
2018/11/27 19:03 upstream ef78e5ec9214 4b6d14f2 .config console log report ci-upstream-kasan-gce-386
2018/11/10 06:23 upstream 3541833fd1f2 f9815aaf .config console log report ci-upstream-kasan-gce-386
2018/08/24 08:56 upstream 33e17876ea4e 95b5c82b .config console log report ci-upstream-kasan-gce-386
2018/12/06 06:05 linux-next 442b8cea2477 764b42c4 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/28 20:42 linux-next 442b8cea2477 4b6d14f2 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/11/20 23:02 linux-next 442b8cea2477 9aca6b52 .config console log report ci-upstream-linux-next-kasan-gce-root
2018/10/30 07:26 linux-next 6201f31a39f8 2f1090da .config console log report ci-upstream-linux-next-kasan-gce-root
2018/09/22 05:08 linux-next 46c163a036b4 37079712 .config console log report ci-upstream-linux-next-kasan-gce-root
* Struck through repros no longer work on HEAD.