KMSAN: uninit-value in tipc_nl_compat_link_set (3)

Status: fixed on 2019/04/12 08:05
Subsystems: tipc
[Documentation on labels]
Reported-by: syzbot+de00a87b8644a582ae79@syzkaller.appspotmail.com
Fix commit: 8c63bf9ab4be tipc: check link name with right length in tipc_nl_compat_link_set
First crash: 2690d, last: 2667d
▶ ▼ Discussions (7)
Title Replies (including bot) Last reply
[PATCH 4.4 000/266] 4.4.180-stable review 282 (282) 2019/05/17 09:42
[PATCH 5.0 00/89] 5.0.11-stable review 106 (106) 2019/05/03 11:48
[PATCH 4.19 000/100] 4.19.38-stable review 108 (108) 2019/05/02 05:30
[PATCH 4.14 00/53] 4.14.115-stable review 59 (59) 2019/05/01 16:44
[PATCH 4.9 00/41] 4.9.172-stable review 47 (47) 2019/05/01 16:43
[PATCH net 0/3] tipc: a batch of uninit-value fixes for netlink_compat 6 (6) 2019/03/31 23:46
KMSAN: uninit-value in tipc_nl_compat_link_set (3) 1 (2) 2019/03/30 16:11
▶ ▼ Similar bugs (2)
Kernel Title Rank 🛈 Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KMSAN: uninit-value in tipc_nl_compat_link_set tipc 7 syz 5 2822d 2831d 0/29 closed as invalid on 2018/11/16 15:38
upstream KMSAN: uninit-value in tipc_nl_compat_link_set (2) tipc 7 C 13 2735d 2776d 11/29 fixed on 2019/03/06 07:43

Sample crash report:
==================================================================
BUG: KMSAN: uninit-value in memchr+0xce/0x110 lib/string.c:961
CPU: 1 PID: 10538 Comm: syz-executor101 Not tainted 5.0.0+ #12
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x173/0x1d0 lib/dump_stack.c:113
 kmsan_report+0x12e/0x2a0 mm/kmsan/kmsan.c:600
 __msan_warning+0x82/0xf0 mm/kmsan/kmsan_instr.c:313
 memchr+0xce/0x110 lib/string.c:961
 string_is_valid net/tipc/netlink_compat.c:176 [inline]
 tipc_nl_compat_link_set+0x121/0x1550 net/tipc/netlink_compat.c:770
 __tipc_nl_compat_doit net/tipc/netlink_compat.c:321 [inline]
 tipc_nl_compat_doit+0x3aa/0xaf0 net/tipc/netlink_compat.c:354
 tipc_nl_compat_handle net/tipc/netlink_compat.c:1162 [inline]
 tipc_nl_compat_recv+0x1ae7/0x2750 net/tipc/netlink_compat.c:1265
 genl_family_rcv_msg net/netlink/genetlink.c:601 [inline]
 genl_rcv_msg+0x185f/0x1a60 net/netlink/genetlink.c:626
 netlink_rcv_skb+0x431/0x620 net/netlink/af_netlink.c:2477
 genl_rcv+0x63/0x80 net/netlink/genetlink.c:637
 netlink_unicast_kernel net/netlink/af_netlink.c:1310 [inline]
 netlink_unicast+0xf3e/0x1020 net/netlink/af_netlink.c:1336
 netlink_sendmsg+0x127f/0x1300 net/netlink/af_netlink.c:1917
 sock_sendmsg_nosec net/socket.c:622 [inline]
 sock_sendmsg net/socket.c:632 [inline]
 ___sys_sendmsg+0xdb9/0x11b0 net/socket.c:2115
 __sys_sendmsg net/socket.c:2153 [inline]
 __do_sys_sendmsg net/socket.c:2162 [inline]
 __se_sys_sendmsg+0x305/0x460 net/socket.c:2160
 __x64_sys_sendmsg+0x4a/0x70 net/socket.c:2160
 do_syscall_64+0xbc/0xf0 arch/x86/entry/common.c:291
 entry_SYSCALL_64_after_hwframe+0x63/0xe7
RIP: 0033:0x440259
Code: 18 89 d0 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 fb 13 fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007ffcb435a248 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000004002c8 RCX: 0000000000440259
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000003
RBP: 00000000006ca018 R08: 0000000000000000 R09: 00000000004002c8
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401ae0
R13: 0000000000401b70 R14: 0000000000000000 R15: 0000000000000000

Uninit was created at:
 kmsan_save_stack_with_flags mm/kmsan/kmsan.c:205 [inline]
 kmsan_internal_poison_shadow+0x92/0x150 mm/kmsan/kmsan.c:159
 kmsan_kmalloc+0xa6/0x130 mm/kmsan/kmsan_hooks.c:176
 kmsan_slab_alloc+0xe/0x10 mm/kmsan/kmsan_hooks.c:185
 slab_post_alloc_hook mm/slab.h:445 [inline]
 slab_alloc_node mm/slub.c:2773 [inline]
 __kmalloc_node_track_caller+0xe9e/0xff0 mm/slub.c:4398
 __kmalloc_reserve net/core/skbuff.c:140 [inline]
 __alloc_skb+0x309/0xa20 net/core/skbuff.c:208
 alloc_skb include/linux/skbuff.h:1012 [inline]
 netlink_alloc_large_skb net/netlink/af_netlink.c:1182 [inline]
 netlink_sendmsg+0xb82/0x1300 net/netlink/af_netlink.c:1892
 sock_sendmsg_nosec net/socket.c:622 [inline]
 sock_sendmsg net/socket.c:632 [inline]
 ___sys_sendmsg+0xdb9/0x11b0 net/socket.c:2115
 __sys_sendmsg net/socket.c:2153 [inline]
 __do_sys_sendmsg net/socket.c:2162 [inline]
 __se_sys_sendmsg+0x305/0x460 net/socket.c:2160
 __x64_sys_sendmsg+0x4a/0x70 net/socket.c:2160
 do_syscall_64+0xbc/0xf0 arch/x86/entry/common.c:291
 entry_SYSCALL_64_after_hwframe+0x63/0xe7
==================================================================

Crashes (15):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2019/03/14 05:07 https://github.com/google/kmsan.git master c530a275757b 2881fc25 .config console log report syz C ci-upstream-kmsan-gce
2019/04/06 15:14 https://github.com/google/kmsan.git master 46200eb9666d c34fde03 .config console log report ci-upstream-kmsan-gce
2019/04/04 08:00 https://github.com/google/kmsan.git master 5c1f56d4e7fd d6fc4177 .config console log report ci-upstream-kmsan-gce
2019/03/27 14:13 https://github.com/google/kmsan.git master 3c26d882e695 4e668495 .config console log report ci-upstream-kmsan-gce
2019/03/27 13:44 https://github.com/google/kmsan.git master 3c26d882e695 4e668495 .config console log report ci-upstream-kmsan-gce
2019/03/21 17:51 https://github.com/google/kmsan.git master c10a026b8dee dce6e62f .config console log report ci-upstream-kmsan-gce
2019/03/21 17:48 https://github.com/google/kmsan.git master c10a026b8dee dce6e62f .config console log report ci-upstream-kmsan-gce
2019/03/20 19:55 https://github.com/google/kmsan.git master c10a026b8dee a664c187 .config console log report ci-upstream-kmsan-gce
2019/03/19 09:24 https://github.com/google/kmsan.git master 43cfd3b1484f 46264c32 .config console log report ci-upstream-kmsan-gce
2019/03/17 12:28 https://github.com/google/kmsan.git master 43cfd3b1484f ba18afea .config console log report ci-upstream-kmsan-gce
2019/03/17 12:24 https://github.com/google/kmsan.git master 43cfd3b1484f ba18afea .config console log report ci-upstream-kmsan-gce
2019/03/17 12:23 https://github.com/google/kmsan.git master 43cfd3b1484f ba18afea .config console log report ci-upstream-kmsan-gce
2019/03/16 23:22 https://github.com/google/kmsan.git master 43cfd3b1484f bab43553 .config console log report ci-upstream-kmsan-gce
2019/03/15 22:54 https://github.com/google/kmsan.git master 63fd07faa48c bab43553 .config console log report ci-upstream-kmsan-gce
2019/03/14 01:36 https://github.com/google/kmsan.git master c530a275757b 2881fc25 .config console log report ci-upstream-kmsan-gce
* Struck through repros no longer work on HEAD.