general protection fault in virtio_transport

general protection fault in virtio_transport_release
Status: fixed on 2019/12/13 00:31
Reported-by: syzbot+e2e5c07bf353b2f79daa@syzkaller.appspotmail.com
Fix commit: 039fcccaed33 vsock: avoid to assign transport if its initialization fails
First crash: 916d, last: 911d

Cause bisection: introduced by (bisect log) :
commit f366cd2a2e510b155e18b21a2d149332aa08eb61
Author: Vadim Pasternak <vadimp@mellanox.com>
Date: Mon Oct 21 10:30:30 2019 +0000

mlxsw: reg: Add macro for getting QSFP module EEPROM page number

Crash: general protection fault in process_one_work (log)
Repro: C syz .config

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2019/11/20 22:03	17m	sgarzare@redhat.com		https://github.com/stefano-garzarella/linux.git fix-syzbot-e2e5c07bf353b2f79daa	OK
2019/11/20 15:25	10m	sgarzare@redhat.com		https://github.com/stefano-garzarella/linux.git fix-syzbot-e2e5c07bf353b2f79daa	report log

Sample crash report:

RDX: 0000000000000010 RSI: 00000000200000c0 RDI: 0000000000000004
RBP: 0000000000000005 R08: 0000000000000001 R09: 00007ffd5b250031
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000401e00
R13: 0000000000401e90 R14: 0000000000000000 R15: 0000000000000000
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 8862 Comm: syz-executor079 Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:virtio_transport_release+0x13b/0xcb0 net/vmw_vsock/virtio_transport_common.c:826
Code: e8 aa e6 2b fa 66 41 83 fd 01 0f 84 34 02 00 00 e8 3a e5 2b fa 48 8b 95 30 ff ff ff 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 22 0a 00 00 48 8b bb 98 00 00 00 48 b8 00 00 00
RSP: 0018:ffff888092dbfaf0 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff87474aa0
RDX: 0000000000000013 RSI: ffffffff874747d6 RDI: 0000000000000001
RBP: ffff888092dbfc00 R08: ffff88809245a380 R09: fffffbfff1555fe1
R10: fffffbfff1555fe0 R11: 0000000000000003 R12: ffff888092dbfbd8
R13: 0000000000000007 R14: 0000000000000007 R15: 0000000000000000
FS:  0000000000000000(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00000000200000c4 CR3: 0000000008e6d000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __vsock_release+0x80/0x2d0 net/vmw_vsock/af_vsock.c:733
 vsock_release+0x35/0xa0 net/vmw_vsock/af_vsock.c:806
 __sock_release+0xce/0x280 net/socket.c:590
 sock_close+0x1e/0x30 net/socket.c:1268
 __fput+0x2ff/0x890 fs/file_table.c:280
 ____fput+0x16/0x20 fs/file_table.c:313
 task_work_run+0x145/0x1c0 kernel/task_work.c:113
 exit_task_work include/linux/task_work.h:22 [inline]
 do_exit+0x904/0x2e60 kernel/exit.c:817
 do_group_exit+0x135/0x360 kernel/exit.c:921
 __do_sys_exit_group kernel/exit.c:932 [inline]
 __se_sys_exit_group kernel/exit.c:930 [inline]
 __x64_sys_exit_group+0x44/0x50 kernel/exit.c:930
 do_syscall_64+0xfa/0x760 arch/x86/entry/common.c:290
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x43f1d8
Code: Bad RIP value.
RSP: 002b:00007ffd5b25f838 EFLAGS: 00000246 ORIG_RAX: 00000000000000e7
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 000000000043f1d8
RDX: 0000000000000000 RSI: 000000000000003c RDI: 0000000000000000
RBP: 00000000004befa8 R08: 00000000000000e7 R09: ffffffffffffffd0
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000001
R13: 00000000006d1180 R14: 0000000000000000 R15: 0000000000000000
Modules linked in:
---[ end trace 4b9b883ea3ab661f ]---
RIP: 0010:virtio_transport_release+0x13b/0xcb0 net/vmw_vsock/virtio_transport_common.c:826
Code: e8 aa e6 2b fa 66 41 83 fd 01 0f 84 34 02 00 00 e8 3a e5 2b fa 48 8b 95 30 ff ff ff 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 22 0a 00 00 48 8b bb 98 00 00 00 48 b8 00 00 00
RSP: 0018:ffff888092dbfaf0 EFLAGS: 00010202
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff87474aa0
RDX: 0000000000000013 RSI: ffffffff874747d6 RDI: 0000000000000001
RBP: ffff888092dbfc00 R08: ffff88809245a380 R09: fffffbfff1555fe1
R10: fffffbfff1555fe0 R11: 0000000000000003 R12: ffff888092dbfbd8
R13: 0000000000000007 R14: 0000000000000007 R15: 0000000000000000
FS:  00000000009db880(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000000043f1ae CR3: 0000000008e6d000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Crashes (7):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro
ci-upstream-net-kasan-gce	2019/11/17 07:51	net-next	1e8795b1b20d	d5696d51	.config	log	report	syz	C
ci-upstream-net-kasan-gce	2019/11/15 12:41	net-next	a98cdaf73e32	79248ee8	.config	log	report	syz
ci-upstream-net-kasan-gce	2019/11/15 11:53	net-next	a98cdaf73e32	79248ee8	.config	log	report	syz
ci-upstream-net-kasan-gce	2019/11/17 07:29	net-next	1e8795b1b20d	d5696d51	.config	log	report
ci-upstream-net-kasan-gce	2019/11/15 12:25	net-next	a98cdaf73e32	79248ee8	.config	log	report
ci-upstream-net-kasan-gce	2019/11/15 11:33	net-next	a98cdaf73e32	79248ee8	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2019/11/20 19:39	linux-next	5d1131b4d61e	f4b7ed07	.config	log	report