syzbot


possible deadlock in sock_map_update_common (2)

Status: upstream: reported C repro on 2024/05/28 10:24
Subsystems: bpf net
[Documentation on labels]
Reported-by: syzbot+ec4e4d5b7c4c6e654865@syzkaller.appspotmail.com
First crash: 21d, last: 7d02h
Cause bisection: introduced by (bisect log) :
commit 68ca5d4eebb8c4de246ee5f634eee26bc689562d
Author: Andrii Nakryiko <andrii@kernel.org>
Date: Tue Mar 19 23:38:50 2024 +0000

  bpf: support BPF cookie in raw tracepoint (raw_tp, tp_btf) programs

Crash: inconsistent lock state in sock_map_delete_elem (log)
Repro: C syz .config
  
Discussions (1)
Title Replies (including bot) Last reply
[syzbot] [bpf?] [net?] possible deadlock in sock_map_update_common (2) 0 (1) 2024/05/28 10:24
Similar bugs (2)
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
linux-6.1 possible deadlock in sock_map_update_common origin:upstream C 11 11d 77d 0/3 upstream: reported C repro on 2024/03/29 17:11
linux-5.15 possible deadlock in sock_map_update_common origin:upstream missing-backport C done 9 10h05m 62d 0/3 upstream: reported C repro on 2024/04/13 07:12

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.9.0-syzkaller-12162-gf85af9d955ac #0 Not tainted
------------------------------------------------------
syz-executor328/5090 is trying to acquire lock:
ffff88801f22e2b0 (&psock->link_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88801f22e2b0 (&psock->link_lock){+...}-{2:2}, at: sock_map_add_link net/core/sock_map.c:146 [inline]
ffff88801f22e2b0 (&psock->link_lock){+...}-{2:2}, at: sock_map_update_common+0x31c/0x5b0 net/core/sock_map.c:515

but task is already holding lock:
ffff88802aa4fa20 (&stab->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88802aa4fa20 (&stab->lock){+.-.}-{2:2}, at: sock_map_update_common+0x1b6/0x5b0 net/core/sock_map.c:505

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&stab->lock){+.-.}-{2:2}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       __sock_map_delete net/core/sock_map.c:429 [inline]
       sock_map_delete_elem+0x175/0x250 net/core/sock_map.c:461
       bpf_prog_330576d32f01b34b+0x63/0x67
       bpf_dispatcher_nop_func include/linux/bpf.h:1243 [inline]
       __bpf_prog_run include/linux/filter.h:691 [inline]
       bpf_prog_run include/linux/filter.h:698 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2403 [inline]
       bpf_trace_run2+0x2ec/0x540 kernel/trace/bpf_trace.c:2444
       trace_kfree include/trace/events/kmem.h:94 [inline]
       kfree+0x2bb/0x360 mm/slub.c:4544
       sk_psock_free_link include/linux/skmsg.h:423 [inline]
       sock_map_del_link net/core/sock_map.c:170 [inline]
       sock_map_unref+0x3ac/0x5e0 net/core/sock_map.c:192
       sock_hash_update_common+0x915/0xa30 net/core/sock_map.c:1048
       sock_map_update_elem_sys+0x5a4/0x910 net/core/sock_map.c:596
       map_update_elem+0x53a/0x6f0 kernel/bpf/syscall.c:1654
       __sys_bpf+0x76f/0x810 kernel/bpf/syscall.c:5697
       __do_sys_bpf kernel/bpf/syscall.c:5816 [inline]
       __se_sys_bpf kernel/bpf/syscall.c:5814 [inline]
       __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5814
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&psock->link_lock){+...}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869
       __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       sock_map_add_link net/core/sock_map.c:146 [inline]
       sock_map_update_common+0x31c/0x5b0 net/core/sock_map.c:515
       sock_map_update_elem_sys+0x55f/0x910 net/core/sock_map.c:594
       map_update_elem+0x53a/0x6f0 kernel/bpf/syscall.c:1654
       __sys_bpf+0x76f/0x810 kernel/bpf/syscall.c:5697
       __do_sys_bpf kernel/bpf/syscall.c:5816 [inline]
       __se_sys_bpf kernel/bpf/syscall.c:5814 [inline]
       __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5814
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&stab->lock);
                               lock(&psock->link_lock);
                               lock(&stab->lock);
  lock(&psock->link_lock);

 *** DEADLOCK ***

3 locks held by syz-executor328/5090:
 #0: ffff8880203c5258 (sk_lock-AF_UNIX){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1602 [inline]
 #0: ffff8880203c5258 (sk_lock-AF_UNIX){+.+.}-{0:0}, at: sock_map_sk_acquire net/core/sock_map.c:129 [inline]
 #0: ffff8880203c5258 (sk_lock-AF_UNIX){+.+.}-{0:0}, at: sock_map_update_elem_sys+0x1cc/0x910 net/core/sock_map.c:590
 #1: ffffffff8e333e60 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
 #1: ffffffff8e333e60 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:781 [inline]
 #1: ffffffff8e333e60 (rcu_read_lock){....}-{1:2}, at: sock_map_sk_acquire net/core/sock_map.c:130 [inline]
 #1: ffffffff8e333e60 (rcu_read_lock){....}-{1:2}, at: sock_map_update_elem_sys+0x1d8/0x910 net/core/sock_map.c:590
 #2: ffff88802aa4fa20 (&stab->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
 #2: ffff88802aa4fa20 (&stab->lock){+.-.}-{2:2}, at: sock_map_update_common+0x1b6/0x5b0 net/core/sock_map.c:505

stack backtrace:
CPU: 1 PID: 5090 Comm: syz-executor328 Not tainted 6.9.0-syzkaller-12162-gf85af9d955ac #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869
 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:356 [inline]
 sock_map_add_link net/core/sock_map.c:146 [inline]
 sock_map_update_common+0x31c/0x5b0 net/core/sock_map.c:515
 sock_map_update_elem_sys+0x55f/0x910 net/core/sock_map.c:594
 map_update_elem+0x53a/0x6f0 kernel/bpf/syscall.c:1654
 __sys_bpf+0x76f/0x810 kernel/bpf/syscall.c:5697
 __do_sys_bpf kernel/bpf/syscall.c:5816 [inline]
 __se_sys_bpf kernel/bpf/syscall.c:5814 [inline]
 __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5814
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f34bd8e71b9
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 c1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffe389a5e98 EFLAGS: 00000246 ORIG_RAX: 0000000000000141
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f34bd8e71b9
RDX: 0000000000000020 RSI: 00000000200000c0 RDI: 0000000000000002
RBP: 0000000000000000 R08: 0000000000000006 R09: 0000000000000006
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 0000000000000001 R15: 0000000000000001
 </TASK>

Crashes (12):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2024/06/08 02:03 bpf-next f85af9d955ac 82c05ab8 .config strace log report syz / log C [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/26 04:27 bpf-next f980f13e4eb2 a10a183e .config strace log report syz C [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/27 21:00 net 52a2f0608366 f550015e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-net-this-kasan-gce possible deadlock in sock_map_update_common
2024/05/25 02:49 bpf 44382b3ed6b2 a10a183e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-kasan-gce possible deadlock in sock_map_update_common
2024/05/24 10:15 bpf 4b377b4868ef 8f98448e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-kasan-gce possible deadlock in sock_map_update_common
2024/06/03 21:17 bpf-next 96a27ee76f0e 0aba2352 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/29 23:51 bpf-next fbe3e8473f39 34889ee3 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/28 09:17 bpf-next e245ef8a0b06 f550015e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/26 01:07 bpf-next f980f13e4eb2 a10a183e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/25 12:47 bpf-next 2c1713a8f1c9 a10a183e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/24 22:23 bpf-next 6f130e4d4a5f 8f98448e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
2024/05/24 20:15 bpf-next 6f130e4d4a5f 8f98448e .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-bpf-next-kasan-gce possible deadlock in sock_map_update_common
* Struck through repros no longer work on HEAD.