syzbot


WARNING: locking bug in dev_mc_seq_show

Status: fixed on 2020/07/17 17:58
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+f3a0e80c34b3fc28ac5e@syzkaller.appspotmail.com
Fix commit: 845e0ebb4408 net: change addr_list_lock back to static key
First crash: 1467d, last: 1453d
Cause bisection: introduced by (bisect log) :
commit 75a1a607bb7e6d918be3aca11ec2214a275392f4
Author: Daniel Borkmann <daniel@iogearbox.net>
Date: Fri Nov 1 23:17:57 2019 +0000

  uaccess: Add strict non-pagefault kernel-space read function

Crash: general protection fault in process_one_work (log)
Repro: C syz .config
  
Discussions (2)
Title Replies (including bot) Last reply
[Patch net] net: change addr_list_lock back to static key 17 (17) 2020/06/18 22:53
WARNING: locking bug in dev_mc_seq_show 0 (1) 2020/05/26 17:14

Sample crash report:
------------[ cut here ]------------
DEBUG_LOCKS_WARN_ON(1)
WARNING: CPU: 0 PID: 7235 at kernel/locking/lockdep.c:183 hlock_class kernel/locking/lockdep.c:183 [inline]
WARNING: CPU: 0 PID: 7235 at kernel/locking/lockdep.c:183 check_wait_context kernel/locking/lockdep.c:4029 [inline]
WARNING: CPU: 0 PID: 7235 at kernel/locking/lockdep.c:183 __lock_acquire+0x1aab/0x2c30 kernel/locking/lockdep.c:4305
Kernel panic - not syncing: panic_on_warn set ...
CPU: 0 PID: 7235 Comm: syz-executor379 Not tainted 5.7.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1e9/0x30e lib/dump_stack.c:118
 panic+0x264/0x7a0 kernel/panic.c:221
 __warn+0x209/0x210 kernel/panic.c:582
 report_bug+0x1ac/0x2d0 lib/bug.c:195
 fixup_bug arch/x86/kernel/traps.c:175 [inline]
 do_error_trap+0xca/0x1c0 arch/x86/kernel/traps.c:267
 do_invalid_op+0x32/0x40 arch/x86/kernel/traps.c:286
 invalid_op+0x23/0x30 arch/x86/entry/entry_64.S:1027
RIP: 0010:hlock_class kernel/locking/lockdep.c:183 [inline]
RIP: 0010:check_wait_context kernel/locking/lockdep.c:4029 [inline]
RIP: 0010:__lock_acquire+0x1aab/0x2c30 kernel/locking/lockdep.c:4305
Code: 13 08 00 0f 85 8d ea ff ff 31 db 48 c7 c7 99 82 e5 88 48 c7 c6 d3 4f ea 88 31 c0 e8 7f d6 ec ff 48 ba 00 00 00 00 00 fc ff df <0f> 0b e9 81 ea ff ff 31 db e9 70 ea ff ff 48 c7 c1 30 ed 55 8b 80
RSP: 0018:ffffc90001ad74f0 EFLAGS: 00010046
RAX: 43109e3dc9d77000 RBX: 0000000000000000 RCX: ffff888096498280
RDX: dffffc0000000000 RSI: 0000000000000001 RDI: ffffffff815cd136
RBP: ffffc90001ad7658 R08: ffffffff817912a6 R09: fffffbfff125cd0b
R10: fffffbfff125cd0b R11: 0000000000000000 R12: ffff888096498bb8
R13: 1ffff11012c93177 R14: 0000000000000607 R15: 0000000000000000
 lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:135 [inline]
 _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:175
 spin_lock_bh include/linux/spinlock.h:358 [inline]
 netif_addr_lock_bh include/linux/netdevice.h:4172 [inline]
 dev_mc_seq_show+0x40/0x220 net/core/net-procfs.c:325
 seq_read+0x950/0xce0 fs/seq_file.c:247
 pde_read fs/proc/inode.c:292 [inline]
 proc_reg_read+0x27f/0x3a0 fs/proc/inode.c:304
 do_loop_readv_writev fs/read_write.c:715 [inline]
 do_iter_read+0x44b/0x550 fs/read_write.c:936
 vfs_readv+0xc2/0x120 fs/read_write.c:1054
 kernel_readv fs/splice.c:365 [inline]
 default_file_splice_read+0x579/0xa40 fs/splice.c:422
 do_splice_to fs/splice.c:892 [inline]
 splice_direct_to_actor+0x3c1/0xb40 fs/splice.c:971
 do_splice_direct+0x201/0x340 fs/splice.c:1080
 do_sendfile+0x809/0xfe0 fs/read_write.c:1521
 __do_sys_sendfile64 fs/read_write.c:1582 [inline]
 __se_sys_sendfile64 fs/read_write.c:1568 [inline]
 __x64_sys_sendfile64+0x164/0x1a0 fs/read_write.c:1568
 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295
 entry_SYSCALL_64_after_hwframe+0x49/0xb3
RIP: 0033:0x448b99
Code: e8 cc 14 03 00 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 ab 0e fc ff c3 66 2e 0f 1f 84 00 00 00 00
RSP: 002b:00007feaf3cdbd18 EFLAGS: 00000246 ORIG_RAX: 0000000000000028
RAX: ffffffffffffffda RBX: 00000000006dec58 RCX: 0000000000448b99
RDX: 0000000000000000 RSI: 0000000000000008 RDI: 0000000000000007
RBP: 00000000006dec50 R08: 65732f636f72702f R09: 65732f636f72702f
R10: 000000000000edc0 R11: 0000000000000246 R12: 00000000006dec5c
R13: 00007feaf3cdbd20 R14: 00007feaf3cdbd20 R15: 00000000006dec5c
Kernel Offset: disabled
Rebooting in 86400 seconds..

Crashes (3):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2020/05/23 12:07 upstream 444565650a5f 9682898d .config console log report syz C ci-upstream-kasan-gce-smack-root
2020/06/06 17:38 upstream 7ae77150d94d e6b89e4e .config console log report ci-upstream-kasan-gce
2020/06/02 16:25 upstream f359287765c0 52fd7b7d .config console log report ci-upstream-kasan-gce-smack-root
* Struck through repros no longer work on HEAD.