syzbot


KASAN: slab-use-after-free Read in devlink_alloc_ns

Status: closed as dup on 2023/04/03 05:24
Subsystems: net
[Documentation on labels]
Reported-by: syzbot+fd68fb37f3c482540964@syzkaller.appspotmail.com
First crash: 366d, last: 366d
Duplicate of
Title Repro Cause bisect Fix bisect Count Last Reported
KASAN: slab-use-after-free Read in class_register usb C done 13 363d 362d

Sample crash report:
hsr_slave_1: entered promiscuous mode
debugfs: Directory 'hsr0' with parent 'hsr' already present!
Cannot create hsr debugfs directory
==================================================================
BUG: KASAN: slab-use-after-free in lockdep_register_key+0x396/0x410 kernel/locking/lockdep.c:1231
Read of size 8 at addr ffff88802f8a0b60 by task syz-executor.3/19181

CPU: 1 PID: 19181 Comm: syz-executor.3 Not tainted 6.3.0-rc4-next-20230328-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 print_address_description.constprop.0+0x2c/0x3c0 mm/kasan/report.c:351
 print_report mm/kasan/report.c:462 [inline]
 kasan_report+0x11c/0x130 mm/kasan/report.c:572
 lockdep_register_key+0x396/0x410 kernel/locking/lockdep.c:1231
 devlink_alloc_ns+0x792/0xac0 net/devlink/core.c:229
 nsim_drv_probe+0xba/0x13d0 drivers/net/netdevsim/dev.c:1533
 call_driver_probe drivers/base/dd.c:579 [inline]
 really_probe+0x240/0xca0 drivers/base/dd.c:658
 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:795
 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:825
 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:953
 bus_for_each_drv+0x149/0x1d0 drivers/base/bus.c:457
 __device_attach+0x1e4/0x4b0 drivers/base/dd.c:1025
 bus_probe_device+0x17c/0x1c0 drivers/base/bus.c:532
 device_add+0x11c4/0x1c50 drivers/base/core.c:3611
 nsim_bus_dev_new drivers/net/netdevsim/bus.c:290 [inline]
 new_device_store+0x40e/0x690 drivers/net/netdevsim/bus.c:167
 bus_attr_store+0x76/0xa0 drivers/base/bus.c:170
 sysfs_kf_write+0x114/0x170 fs/sysfs/file.c:136
 kernfs_fop_write_iter+0x3f1/0x600 fs/kernfs/file.c:334
 call_write_iter include/linux/fs.h:1854 [inline]
 new_sync_write fs/read_write.c:491 [inline]
 vfs_write+0x9f6/0xe20 fs/read_write.c:584
 ksys_write+0x12b/0x250 fs/read_write.c:637
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7fccfb23de7f
Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 99 fd ff ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 cc fd ff ff 48
RSP: 002b:00007ffffbc4e7d0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007fccfb23de7f
RDX: 0000000000000003 RSI: 00007ffffbc4e820 RDI: 0000000000000005
RBP: 0000000000000005 R08: 0000000000000000 R09: 00007ffffbc4e770
R10: 0000000000000000 R11: 0000000000000293 R12: 00007fccfb2e7772
R13: 00007ffffbc4e820 R14: 0000000000000000 R15: 00007ffffbc4eef0
 </TASK>

Allocated by task 12154:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 kasan_set_track+0x25/0x30 mm/kasan/common.c:52
 ____kasan_kmalloc mm/kasan/common.c:374 [inline]
 ____kasan_kmalloc mm/kasan/common.c:333 [inline]
 __kasan_kmalloc+0xa2/0xb0 mm/kasan/common.c:383
 kasan_kmalloc include/linux/kasan.h:196 [inline]
 __do_kmalloc_node mm/slab_common.c:966 [inline]
 __kmalloc_node_track_caller+0x5f/0x1a0 mm/slab_common.c:986
 kmalloc_reserve+0xf0/0x270 net/core/skbuff.c:535
 __alloc_skb+0x129/0x330 net/core/skbuff.c:604
 __netdev_alloc_skb+0x74/0x410 net/core/skbuff.c:668
 __netdev_alloc_skb_ip_align include/linux/skbuff.h:3201 [inline]
 netdev_alloc_skb_ip_align include/linux/skbuff.h:3211 [inline]
 batadv_iv_ogm_aggregate_new+0x106/0x4e0 net/batman-adv/bat_iv_ogm.c:558
 batadv_iv_ogm_queue_add net/batman-adv/bat_iv_ogm.c:670 [inline]
 batadv_iv_ogm_schedule_buff+0xea2/0x1520 net/batman-adv/bat_iv_ogm.c:849
 batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:868 [inline]
 batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:861 [inline]
 batadv_iv_send_outstanding_bat_ogm_packet+0x333/0x960 net/batman-adv/bat_iv_ogm.c:1712
 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405
 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552
 kthread+0x33e/0x440 kernel/kthread.c:379
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

Freed by task 5415:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 kasan_set_track+0x25/0x30 mm/kasan/common.c:52
 kasan_save_free_info+0x2e/0x40 mm/kasan/generic.c:521
 ____kasan_slab_free mm/kasan/common.c:236 [inline]
 ____kasan_slab_free+0x160/0x1c0 mm/kasan/common.c:200
 kasan_slab_free include/linux/kasan.h:162 [inline]
 slab_free_hook mm/slub.c:1781 [inline]
 slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1807
 slab_free mm/slub.c:3787 [inline]
 __kmem_cache_free+0xaf/0x2d0 mm/slub.c:3800
 skb_kfree_head net/core/skbuff.c:856 [inline]
 skb_free_head+0x108/0x1a0 net/core/skbuff.c:868
 skb_release_data+0x57a/0x820 net/core/skbuff.c:897
 skb_release_all net/core/skbuff.c:962 [inline]
 __kfree_skb net/core/skbuff.c:976 [inline]
 consume_skb net/core/skbuff.c:1189 [inline]
 consume_skb+0xd0/0x170 net/core/skbuff.c:1183
 batadv_forw_packet_free+0x1f0/0x270 net/batman-adv/send.c:471
 batadv_iv_send_outstanding_bat_ogm_packet+0x2b0/0x960 net/batman-adv/bat_iv_ogm.c:1718
 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405
 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552
 kthread+0x33e/0x440 kernel/kthread.c:379
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

Last potentially related work creation:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 __kasan_record_aux_stack+0xbc/0xd0 mm/kasan/generic.c:491
 insert_work+0x48/0x360 kernel/workqueue.c:1365
 __queue_work+0x5c6/0xfb0 kernel/workqueue.c:1526
 queue_work_on+0xf2/0x110 kernel/workqueue.c:1554
 ops_exit_list+0xb0/0x170 net/core/net_namespace.c:170
 setup_net+0x7fb/0xc50 net/core/net_namespace.c:362
 copy_net_ns+0x4ee/0x8e0 net/core/net_namespace.c:491
 create_new_namespaces+0x3f6/0xb20 kernel/nsproxy.c:110
 copy_namespaces+0x410/0x500 kernel/nsproxy.c:179
 copy_process+0x31ae/0x76b0 kernel/fork.c:2415
 kernel_clone+0xeb/0x890 kernel/fork.c:2831
 __do_sys_clone3+0x1cd/0x2f0 kernel/fork.c:3132
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Second to last potentially related work creation:
 kasan_save_stack+0x22/0x40 mm/kasan/common.c:45
 __kasan_record_aux_stack+0xbc/0xd0 mm/kasan/generic.c:491
 kvfree_call_rcu+0x70/0xad0 kernel/rcu/tree.c:3331
 neigh_destroy+0x433/0x660 net/core/neighbour.c:910
 neigh_release include/net/neighbour.h:447 [inline]
 neigh_cleanup_and_release net/core/neighbour.c:103 [inline]
 neigh_flush_dev+0x695/0x930 net/core/neighbour.c:421
 __neigh_ifdown.isra.0+0x54/0x400 net/core/neighbour.c:438
 neigh_ifdown+0x1f/0x30 net/core/neighbour.c:456
 rt6_disable_ip+0x14d/0x9e0 net/ipv6/route.c:4894
 addrconf_ifdown.isra.0+0x11a/0x1940 net/ipv6/addrconf.c:3755
 addrconf_notify+0x106/0x19f0 net/ipv6/addrconf.c:3678
 notifier_call_chain+0xb6/0x3c0 kernel/notifier.c:93
 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1937
 call_netdevice_notifiers_extack net/core/dev.c:1975 [inline]
 call_netdevice_notifiers net/core/dev.c:1989 [inline]
 dev_close_many+0x309/0x630 net/core/dev.c:1530
 unregister_netdevice_many_notify+0x414/0x1910 net/core/dev.c:10816
 unregister_netdevice_many net/core/dev.c:10899 [inline]
 default_device_exit_batch+0x451/0x5b0 net/core/dev.c:11352
 ops_exit_list+0x125/0x170 net/core/net_namespace.c:175
 cleanup_net+0x4ee/0xb10 net/core/net_namespace.c:614
 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405
 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552
 kthread+0x33e/0x440 kernel/kthread.c:379
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308

The buggy address belongs to the object at ffff88802f8a0800
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 864 bytes inside of
 freed 1024-byte region [ffff88802f8a0800, ffff88802f8a0c00)

The buggy address belongs to the physical page:
page:ffffea0000be2800 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x2f8a0
head:ffffea0000be2800 order:3 entire_mapcount:0 nr_pages_mapped:0 pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
page_type: 0xffffffff()
raw: 00fff00000010200 ffff888012441dc0 ffffea0000b0d800 dead000000000002
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0x1f2820(GFP_ATOMIC|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC|__GFP_MEMALLOC|__GFP_HARDWALL), pid 5439, tgid 5439 (kworker/u4:11), ts 1588998699752, free_ts 1588925214951
 prep_new_page mm/page_alloc.c:1729 [inline]
 get_page_from_freelist+0xf75/0x2aa0 mm/page_alloc.c:3493
 __alloc_pages+0x1cb/0x4a0 mm/page_alloc.c:4759
 alloc_pages+0x1aa/0x270 mm/mempolicy.c:2283
 alloc_slab_page mm/slub.c:1851 [inline]
 allocate_slab+0x28e/0x380 mm/slub.c:1998
 new_slab mm/slub.c:2051 [inline]
 ___slab_alloc+0xa91/0x1400 mm/slub.c:3193
 __slab_alloc.constprop.0+0x56/0xa0 mm/slub.c:3292
 __slab_alloc_node mm/slub.c:3345 [inline]
 slab_alloc_node mm/slub.c:3442 [inline]
 __kmem_cache_alloc_node+0x136/0x320 mm/slub.c:3491
 __do_kmalloc_node mm/slab_common.c:965 [inline]
 __kmalloc_node_track_caller+0x4f/0x1a0 mm/slab_common.c:986
 kmalloc_reserve+0xf0/0x270 net/core/skbuff.c:535
 __alloc_skb+0x129/0x330 net/core/skbuff.c:604
 __netdev_alloc_skb+0x74/0x410 net/core/skbuff.c:668
 __netdev_alloc_skb_ip_align include/linux/skbuff.h:3201 [inline]
 netdev_alloc_skb_ip_align include/linux/skbuff.h:3211 [inline]
 batadv_iv_ogm_aggregate_new+0x106/0x4e0 net/batman-adv/bat_iv_ogm.c:558
 batadv_iv_ogm_queue_add net/batman-adv/bat_iv_ogm.c:670 [inline]
 batadv_iv_ogm_schedule_buff+0x9b2/0x1520 net/batman-adv/bat_iv_ogm.c:833
 batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:868 [inline]
 batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:861 [inline]
 batadv_iv_send_outstanding_bat_ogm_packet+0x333/0x960 net/batman-adv/bat_iv_ogm.c:1712
 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405
 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552
page last free stack trace:
 reset_page_owner include/linux/page_owner.h:24 [inline]
 free_pages_prepare mm/page_alloc.c:1302 [inline]
 free_unref_page_prepare+0x4d8/0xb80 mm/page_alloc.c:2555
 free_unref_page+0x33/0x370 mm/page_alloc.c:2650
 __folio_put_large mm/swap.c:119 [inline]
 __folio_put+0x109/0x140 mm/swap.c:127
 folio_put include/linux/mm.h:1467 [inline]
 put_page include/linux/mm.h:1536 [inline]
 __skb_frag_unref include/linux/skbuff.h:3411 [inline]
 skb_release_data+0x522/0x820 net/core/skbuff.c:891
 skb_release_all net/core/skbuff.c:962 [inline]
 __kfree_skb net/core/skbuff.c:976 [inline]
 skb_attempt_defer_free+0x329/0x410 net/core/skbuff.c:6823
 tcp_eat_recv_skb net/ipv4/tcp.c:1640 [inline]
 tcp_recvmsg_locked+0x124e/0x22e0 net/ipv4/tcp.c:2636
 tcp_recvmsg+0x117/0x620 net/ipv4/tcp.c:2682
 inet_recvmsg+0x114/0x640 net/ipv4/af_inet.c:859
 sock_recvmsg_nosec net/socket.c:1017 [inline]
 sock_recvmsg+0xe2/0x160 net/socket.c:1038
 sock_read_iter+0x2bd/0x3b0 net/socket.c:1116
 call_read_iter include/linux/fs.h:1848 [inline]
 new_sync_read fs/read_write.c:389 [inline]
 vfs_read+0x803/0x940 fs/read_write.c:470
 ksys_read+0x1ec/0x250 fs/read_write.c:613
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

Memory state around the buggy address:
 ffff88802f8a0a00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88802f8a0a80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88802f8a0b00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                                                       ^
 ffff88802f8a0b80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88802f8a0c00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (2):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2023/03/28 16:38 linux-next a6faf7ea9fcb 48c74771 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: slab-use-after-free Read in devlink_alloc_ns
2023/03/28 15:29 linux-next a6faf7ea9fcb 48c74771 .config console log report info [disk image] [vmlinux] [kernel image] ci-upstream-linux-next-kasan-gce-root KASAN: slab-use-after-free Read in devlink_alloc_ns
* Struck through repros no longer work on HEAD.