syzbot


KASAN: use-after-free Write in mini_qdisc_pair_swap (2)

Status: internal: reported on 2022/01/31 05:52
Reported-by: syzbot+@syzkaller.appspotmail.com
Fix commit: 04c2a47ffb13 net: sched: fix use-after-free in tc_new_tfilter()
Patched on: [ci-qemu-upstream ci-qemu-upstream-386 ci-qemu2-arm32 ci-qemu2-arm64 ci-qemu2-arm64-compat ci-qemu2-arm64-mte ci-upstream-bpf-kasan-gce ci-upstream-bpf-next-kasan-gce ci-upstream-gce-leak ci-upstream-kasan-gce ci-upstream-kasan-gce-386 ci-upstream-kasan-gce-root ci-upstream-kasan-gce-selinux-root ci-upstream-kasan-gce-smack-root ci-upstream-kmsan-gce ci-upstream-kmsan-gce-386 ci-upstream-linux-next-kasan-gce-root ci-upstream-net-kasan-gce ci-upstream-net-this-kasan-gce ci2-upstream-kcsan-gce ci2-upstream-usb], missing on: [ci-qemu2-riscv64]
First crash: 146d, last: 6d21h
similar bugs (1):
Kernel Title Repro Cause bisect Fix bisect Count Last Reported Patched Status
upstream KASAN: use-after-free Write in mini_qdisc_pair_swap 1 236d 236d 0/22 closed as invalid on 2022/01/11 13:43

Sample crash report:
==================================================================
BUG: KASAN: use-after-free in mini_qdisc_pair_swap+0x1b9/0x1f0 net/sched/sch_generic.c:1576
Write of size 8 at addr ffff88807e5afb08 by task syz-executor.3/10012

CPU: 0 PID: 10012 Comm: syz-executor.3 Not tainted 5.18.0-syzkaller-12234-g50fd82b3a9a9 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 print_address_description.constprop.0.cold+0xeb/0x495 mm/kasan/report.c:313
 print_report mm/kasan/report.c:429 [inline]
 kasan_report.cold+0xf4/0x1c6 mm/kasan/report.c:491
 mini_qdisc_pair_swap+0x1b9/0x1f0 net/sched/sch_generic.c:1576
 tcf_chain_head_change_item net/sched/cls_api.c:389 [inline]
 tcf_chain0_head_change.isra.0+0xb9/0x120 net/sched/cls_api.c:403
 tcf_chain_tp_insert net/sched/cls_api.c:1677 [inline]
 tcf_chain_tp_insert_unique net/sched/cls_api.c:1726 [inline]
 tc_new_tfilter+0x1d5b/0x2200 net/sched/cls_api.c:2107
 rtnetlink_rcv_msg+0x946/0xc90 net/core/rtnetlink.c:6080
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:734
 ____sys_sendmsg+0x334/0x810 net/socket.c:2492
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546
 __sys_sendmmsg+0x195/0x470 net/socket.c:2632
 __do_sys_sendmmsg net/socket.c:2661 [inline]
 __se_sys_sendmmsg net/socket.c:2658 [inline]
 __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2658
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x46/0xb0
RIP: 0033:0x7fb034489109
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb0333fe168 EFLAGS: 00000246 ORIG_RAX: 0000000000000133
RAX: ffffffffffffffda RBX: 00007fb03459bf60 RCX: 00007fb034489109
RDX: 040000000000009f RSI: 00000000200002c0 RDI: 0000000000000006
RBP: 00007fb0344e308d R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb034acfb1f R14: 00007fb0333fe300 R15: 0000000000022000
 </TASK>

Allocated by task 10013:
 kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
 kasan_set_track mm/kasan/common.c:45 [inline]
 set_alloc_info mm/kasan/common.c:436 [inline]
 ____kasan_kmalloc mm/kasan/common.c:515 [inline]
 ____kasan_kmalloc mm/kasan/common.c:474 [inline]
 __kasan_kmalloc+0xa9/0xd0 mm/kasan/common.c:524
 kmalloc_node include/linux/slab.h:623 [inline]
 kzalloc_node include/linux/slab.h:744 [inline]
 qdisc_alloc+0xac/0xa10 net/sched/sch_generic.c:941
 qdisc_create.constprop.0+0xce/0x10f0 net/sched/sch_api.c:1211
 tc_modify_qdisc+0x4c5/0x1a00 net/sched/sch_api.c:1660
 rtnetlink_rcv_msg+0x43a/0xc90 net/core/rtnetlink.c:6089
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:734
 ____sys_sendmsg+0x334/0x810 net/socket.c:2492
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546
 __sys_sendmmsg+0x195/0x470 net/socket.c:2632
 __do_sys_sendmmsg net/socket.c:2661 [inline]
 __se_sys_sendmmsg net/socket.c:2658 [inline]
 __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2658
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x46/0xb0

Freed by task 15:
 kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
 kasan_set_track+0x21/0x30 mm/kasan/common.c:45
 kasan_set_free_info+0x20/0x30 mm/kasan/generic.c:370
 ____kasan_slab_free mm/kasan/common.c:366 [inline]
 ____kasan_slab_free+0x166/0x1a0 mm/kasan/common.c:328
 kasan_slab_free include/linux/kasan.h:200 [inline]
 slab_free_hook mm/slub.c:1727 [inline]
 slab_free_freelist_hook+0x8b/0x1c0 mm/slub.c:1753
 slab_free mm/slub.c:3507 [inline]
 kfree+0xd6/0x4d0 mm/slub.c:4555
 rcu_do_batch kernel/rcu/tree.c:2578 [inline]
 rcu_core+0x7b1/0x1880 kernel/rcu/tree.c:2838
 __do_softirq+0x29b/0x9c2 kernel/softirq.c:571

Last potentially related work creation:
 kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
 __kasan_record_aux_stack+0xbe/0xd0 mm/kasan/generic.c:348
 call_rcu+0x99/0x790 kernel/rcu/tree.c:3126
 qdisc_put_unlocked+0x6f/0x90 net/sched/sch_generic.c:1101
 tcf_block_release+0x86/0x90 net/sched/cls_api.c:1255
 tc_new_tfilter+0xa46/0x2200 net/sched/cls_api.c:2169
 rtnetlink_rcv_msg+0x946/0xc90 net/core/rtnetlink.c:6080
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:734
 ____sys_sendmsg+0x334/0x810 net/socket.c:2492
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546
 __sys_sendmmsg+0x195/0x470 net/socket.c:2632
 __do_sys_sendmmsg net/socket.c:2661 [inline]
 __se_sys_sendmmsg net/socket.c:2658 [inline]
 __x64_sys_sendmmsg+0x99/0x100 net/socket.c:2658
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x46/0xb0

Second to last potentially related work creation:
 kasan_save_stack+0x1e/0x40 mm/kasan/common.c:38
 __kasan_record_aux_stack+0xbe/0xd0 mm/kasan/generic.c:348
 kvfree_call_rcu+0x74/0x990 kernel/rcu/tree.c:3647
 neigh_destroy+0x431/0x630 net/core/neighbour.c:888
 neigh_release include/net/neighbour.h:452 [inline]
 neigh_cleanup_and_release+0x1fd/0x340 net/core/neighbour.c:103
 neigh_del net/core/neighbour.c:225 [inline]
 neigh_remove_one+0x37d/0x460 net/core/neighbour.c:246
 neigh_forced_gc net/core/neighbour.c:276 [inline]
 neigh_alloc net/core/neighbour.c:423 [inline]
 ___neigh_create+0x18b1/0x2990 net/core/neighbour.c:618
 ip6_finish_output2+0xfb8/0x1520 net/ipv6/ip6_output.c:125
 __ip6_finish_output net/ipv6/ip6_output.c:195 [inline]
 ip6_finish_output+0x844/0x1170 net/ipv6/ip6_output.c:206
 NF_HOOK_COND include/linux/netfilter.h:296 [inline]
 ip6_output+0x1ed/0x540 net/ipv6/ip6_output.c:227
 dst_output include/net/dst.h:451 [inline]
 NF_HOOK include/linux/netfilter.h:307 [inline]
 ndisc_send_skb+0xa81/0x17e0 net/ipv6/ndisc.c:507
 ndisc_send_ns+0xa6/0x120 net/ipv6/ndisc.c:665
 addrconf_dad_work+0xbf9/0x12d0 net/ipv6/addrconf.c:4171
 process_one_work+0x996/0x1610 kernel/workqueue.c:2289
 worker_thread+0x665/0x1080 kernel/workqueue.c:2436
 kthread+0x2e9/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:302

The buggy address belongs to the object at ffff88807e5af800
 which belongs to the cache kmalloc-1k of size 1024
The buggy address is located 776 bytes inside of
 1024-byte region [ffff88807e5af800, ffff88807e5afc00)

The buggy address belongs to the physical page:
page:ffffea0001f96a00 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x7e5a8
head:ffffea0001f96a00 order:3 compound_mapcount:0 compound_pincount:0
flags: 0xfff00000010200(slab|head|node=0|zone=1|lastcpupid=0x7ff)
raw: 00fff00000010200 dead000000000100 dead000000000122 ffff888010c41dc0
raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000
page dumped because: kasan: bad access detected
page_owner tracks the page as allocated
page last allocated via order 3, migratetype Unmovable, gfp_mask 0xd20c0(__GFP_IO|__GFP_FS|__GFP_NOWARN|__GFP_NORETRY|__GFP_COMP|__GFP_NOMEMALLOC), pid 3622, tgid 3622 (syz-executor.0), ts 54605454427, free_ts 54572418843
 prep_new_page mm/page_alloc.c:2456 [inline]
 get_page_from_freelist+0x1290/0x3b70 mm/page_alloc.c:4198
 __alloc_pages+0x1c7/0x510 mm/page_alloc.c:5426
 alloc_pages+0x1aa/0x310 mm/mempolicy.c:2272
 alloc_slab_page mm/slub.c:1797 [inline]
 allocate_slab+0x26c/0x3c0 mm/slub.c:1942
 new_slab mm/slub.c:2002 [inline]
 ___slab_alloc+0x985/0xd90 mm/slub.c:3002
 __slab_alloc.constprop.0+0x4d/0xa0 mm/slub.c:3089
 slab_alloc_node mm/slub.c:3180 [inline]
 __kmalloc_node_track_caller+0x2cb/0x360 mm/slub.c:4950
 kmalloc_reserve net/core/skbuff.c:354 [inline]
 __alloc_skb+0xde/0x340 net/core/skbuff.c:426
 alloc_skb include/linux/skbuff.h:1426 [inline]
 nlmsg_new include/net/netlink.h:953 [inline]
 rtmsg_fib+0x120/0x500 net/ipv4/fib_semantics.c:519
 fib_table_insert+0x770/0x1bd0 net/ipv4/fib_trie.c:1399
 fib_magic+0x455/0x540 net/ipv4/fib_frontend.c:1098
 fib_add_ifaddr+0x16b/0x540 net/ipv4/fib_frontend.c:1120
 fib_inetaddr_event+0x162/0x2a0 net/ipv4/fib_frontend.c:1434
 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
 blocking_notifier_call_chain kernel/notifier.c:382 [inline]
 blocking_notifier_call_chain+0x67/0x90 kernel/notifier.c:370
 __inet_insert_ifa+0x919/0xbd0 net/ipv4/devinet.c:554
page last free stack trace:
 reset_page_owner include/linux/page_owner.h:24 [inline]
 free_pages_prepare mm/page_alloc.c:1371 [inline]
 free_pcp_prepare+0x549/0xd20 mm/page_alloc.c:1421
 free_unref_page_prepare mm/page_alloc.c:3343 [inline]
 free_unref_page+0x19/0x6a0 mm/page_alloc.c:3438
 qlink_free mm/kasan/quarantine.c:168 [inline]
 qlist_free_all+0x6a/0x170 mm/kasan/quarantine.c:187
 kasan_quarantine_reduce+0x180/0x200 mm/kasan/quarantine.c:294
 __kasan_slab_alloc+0xa2/0xc0 mm/kasan/common.c:446
 kasan_slab_alloc include/linux/kasan.h:224 [inline]
 slab_post_alloc_hook mm/slab.h:750 [inline]
 slab_alloc_node mm/slub.c:3214 [inline]
 slab_alloc mm/slub.c:3222 [inline]
 kmem_cache_alloc_trace+0x26d/0x3f0 mm/slub.c:3253
 kmalloc include/linux/slab.h:600 [inline]
 kzalloc include/linux/slab.h:733 [inline]
 nsim_fib6_rt_create drivers/net/netdevsim/fib.c:545 [inline]
 nsim_fib6_rt_insert drivers/net/netdevsim/fib.c:750 [inline]
 nsim_fib6_event drivers/net/netdevsim/fib.c:854 [inline]
 nsim_fib_event drivers/net/netdevsim/fib.c:887 [inline]
 nsim_fib_event_work+0x1115/0x2710 drivers/net/netdevsim/fib.c:1478
 process_one_work+0x996/0x1610 kernel/workqueue.c:2289
 process_scheduled_works kernel/workqueue.c:2352 [inline]
 worker_thread+0x854/0x1080 kernel/workqueue.c:2438
 kthread+0x2e9/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:302

Memory state around the buggy address:
 ffff88807e5afa00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807e5afa80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88807e5afb00: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                      ^
 ffff88807e5afb80: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88807e5afc00: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc
==================================================================

Crashes (17):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce 2022/06/03 03:12 upstream 50fd82b3a9a9 5783034f .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-kasan-gce 2022/05/29 03:11 upstream 9d004b2f4fea a46af346 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-kasan-gce 2022/05/20 02:16 upstream b015dcd62b86 cb1ac2e7 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-kasan-gce 2022/05/14 02:32 upstream ec7f49619d8e 107f6434 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-this-kasan-gce 2022/02/03 00:13 net 3aa430d33b8d 4ebb2798 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/06/19 14:10 net-next 9776fe0f424b 8f633d84 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/06/18 02:53 net-next 4875d94c69d5 cb58b3b2 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/06/11 15:38 net-next e10b02ee5b6c 0d5abf15 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/06/01 00:31 net-next 7e062cda7d90 3666edfe .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/05/06 07:01 net-next 949dfdcf343c efeff0a5 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/05/05 09:39 net-next fa728505f3e7 02ba4ad6 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/05/04 04:42 net-next 2201124dbbad dc9e5259 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/05/03 21:22 net-next 2b68abf93365 dc9e5259 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/04/28 09:29 net-next 03fa8fc93e44 8a1f1f07 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/04/27 22:09 net-next 03fa8fc93e44 8a1f1f07 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/04/06 12:11 net-next 0b5c21bbc01e 86b4b7f8 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap
ci-upstream-net-kasan-gce 2022/01/31 05:51 net-next ff58831fa02d 495e00c5 .config log report info KASAN: use-after-free Write in mini_qdisc_pair_swap