syzbot

EXT4-fs: Journaled quota options ignored when QUOTA feature is enabled
EXT4-fs (loop0): orphan cleanup on readonly fs
======================================================
WARNING: possible circular locking dependency detected
6.3.0-rc3-syzkaller-00012-g17214b70a159 #0 Not tainted
------------------------------------------------------
syz-executor403/5223 is trying to acquire lock:
ffff88807527d768 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_commit+0x51/0x570 fs/quota/dquot.c:479

but task is already holding lock:
ffff88807525dcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0xd50/0x1340 fs/ext4/inode.c:4337

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&ei->i_data_sem/2){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       ext4_map_blocks+0x267/0x18d0 fs/ext4/inode.c:574
       ext4_getblk+0x61f/0x850 fs/ext4/inode.c:863
       ext4_bread+0x2e/0x190 fs/ext4/inode.c:919
       ext4_quota_write+0x218/0x620 fs/ext4/super.c:7135
       write_blk+0x12e/0x220 fs/quota/quota_tree.c:64
       get_free_dqblk+0x104/0x2f0 fs/quota/quota_tree.c:130
       do_insert_tree+0x3c5/0x12d0 fs/quota/quota_tree.c:340
       do_insert_tree+0x696/0x12d0 fs/quota/quota_tree.c:375
       do_insert_tree+0x696/0x12d0 fs/quota/quota_tree.c:375
       do_insert_tree+0x696/0x12d0 fs/quota/quota_tree.c:375
       dq_insert_tree fs/quota/quota_tree.c:401 [inline]
       qtree_write_dquot+0x3b4/0x570 fs/quota/quota_tree.c:420
       v2_write_dquot+0x120/0x250 fs/quota/quota_v2.c:358
       dquot_acquire+0x3d1/0x6c0 fs/quota/dquot.c:444
       ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6770
       dqget+0x67d/0x1080 fs/quota/dquot.c:914
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492
       ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5509 [inline]
       ext4_fill_super+0x9630/0xad90 fs/ext4/super.c:5637
       get_tree_bdev+0x444/0x760 fs/super.c:1303
       vfs_get_tree+0x8d/0x350 fs/super.c:1510
       do_new_mount fs/namespace.c:3042 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3372
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount fs/namespace.c:3571 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&s->s_dquot.dqio_sem){++++}-{3:3}:
       down_read+0x3d/0x50 kernel/locking/rwsem.c:1520
       v2_read_dquot+0x4d/0x120 fs/quota/quota_v2.c:332
       dquot_acquire+0x1b3/0x6c0 fs/quota/dquot.c:435
       ext4_acquire_dquot+0x2b1/0x3d0 fs/ext4/super.c:6770
       dqget+0x67d/0x1080 fs/quota/dquot.c:914
       __dquot_initialize+0x560/0xbe0 fs/quota/dquot.c:1492
       ext4_process_orphan+0x47/0x410 fs/ext4/orphan.c:329
       ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5509 [inline]
       ext4_fill_super+0x9630/0xad90 fs/ext4/super.c:5637
       get_tree_bdev+0x444/0x760 fs/super.c:1303
       vfs_get_tree+0x8d/0x350 fs/super.c:1510
       do_new_mount fs/namespace.c:3042 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3372
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount fs/namespace.c:3571 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #0 (&dquot->dq_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3098 [inline]
       check_prevs_add kernel/locking/lockdep.c:3217 [inline]
       validate_chain kernel/locking/lockdep.c:3832 [inline]
       __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
       lock_acquire kernel/locking/lockdep.c:5669 [inline]
       lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634
       __mutex_lock_common kernel/locking/mutex.c:603 [inline]
       __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
       dquot_commit+0x51/0x570 fs/quota/dquot.c:479
       ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6754
       ext4_mark_dquot_dirty fs/ext4/super.c:6802 [inline]
       ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6796
       mark_dquot_dirty fs/quota/dquot.c:346 [inline]
       mark_all_dquot_dirty fs/quota/dquot.c:384 [inline]
       __dquot_free_space+0x773/0xaf0 fs/quota/dquot.c:1907
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6044 [inline]
       ext4_free_blocks+0x1132/0x20d0 fs/ext4/mballoc.c:6173
       ext4_remove_blocks fs/ext4/extents.c:2545 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2710 [inline]
       ext4_ext_remove_space+0x1ec4/0x4210 fs/ext4/extents.c:2958
       ext4_ext_truncate+0x34b/0x400 fs/ext4/extents.c:4416
       ext4_truncate+0xdb5/0x1340 fs/ext4/inode.c:4342
       ext4_process_orphan+0x158/0x410 fs/ext4/orphan.c:339
       ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474
       __ext4_fill_super fs/ext4/super.c:5509 [inline]
       ext4_fill_super+0x9630/0xad90 fs/ext4/super.c:5637
       get_tree_bdev+0x444/0x760 fs/super.c:1303
       vfs_get_tree+0x8d/0x350 fs/super.c:1510
       do_new_mount fs/namespace.c:3042 [inline]
       path_mount+0x1342/0x1e40 fs/namespace.c:3372
       do_mount fs/namespace.c:3385 [inline]
       __do_sys_mount fs/namespace.c:3594 [inline]
       __se_sys_mount fs/namespace.c:3571 [inline]
       __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &dquot->dq_lock --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ei->i_data_sem/2);
                               lock(&s->s_dquot.dqio_sem);
                               lock(&ei->i_data_sem/2);
  lock(&dquot->dq_lock);

 *** DEADLOCK ***

4 locks held by syz-executor403/5223:
 #0: ffff88807a9200e0 (&type->s_umount_key#27/1){+.+.}-{3:3}, at: alloc_super+0x22e/0xb60 fs/super.c:228
 #1: ffff88807525de48 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #1: ffff88807525de48 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: ext4_process_orphan+0x109/0x410 fs/ext4/orphan.c:337
 #2: ffff88807525dcd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_truncate+0xd50/0x1340 fs/ext4/inode.c:4337
 #3: ffffffff8c989aa8 (dquot_srcu){....}-{0:0}, at: i_dquot fs/quota/dquot.c:939 [inline]
 #3: ffffffff8c989aa8 (dquot_srcu){....}-{0:0}, at: __dquot_free_space+0x1a8/0xaf0 fs/quota/dquot.c:1880

stack backtrace:
CPU: 1 PID: 5223 Comm: syz-executor403 Not tainted 6.3.0-rc3-syzkaller-00012-g17214b70a159 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178
 check_prev_add kernel/locking/lockdep.c:3098 [inline]
 check_prevs_add kernel/locking/lockdep.c:3217 [inline]
 validate_chain kernel/locking/lockdep.c:3832 [inline]
 __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056
 lock_acquire kernel/locking/lockdep.c:5669 [inline]
 lock_acquire+0x1af/0x520 kernel/locking/lockdep.c:5634
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
 dquot_commit+0x51/0x570 fs/quota/dquot.c:479
 ext4_write_dquot+0x25f/0x330 fs/ext4/super.c:6754
 ext4_mark_dquot_dirty fs/ext4/super.c:6802 [inline]
 ext4_mark_dquot_dirty+0x115/0x1b0 fs/ext4/super.c:6796
 mark_dquot_dirty fs/quota/dquot.c:346 [inline]
 mark_all_dquot_dirty fs/quota/dquot.c:384 [inline]
 __dquot_free_space+0x773/0xaf0 fs/quota/dquot.c:1907
 dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
 dquot_free_space include/linux/quotaops.h:384 [inline]
 dquot_free_block include/linux/quotaops.h:395 [inline]
 ext4_mb_clear_bb fs/ext4/mballoc.c:6044 [inline]
 ext4_free_blocks+0x1132/0x20d0 fs/ext4/mballoc.c:6173
 ext4_remove_blocks fs/ext4/extents.c:2545 [inline]
 ext4_ext_rm_leaf fs/ext4/extents.c:2710 [inline]
 ext4_ext_remove_space+0x1ec4/0x4210 fs/ext4/extents.c:2958
 ext4_ext_truncate+0x34b/0x400 fs/ext4/extents.c:4416
 ext4_truncate+0xdb5/0x1340 fs/ext4/inode.c:4342
 ext4_process_orphan+0x158/0x410 fs/ext4/orphan.c:339
 ext4_orphan_cleanup+0x6e5/0x1110 fs/ext4/orphan.c:474
 __ext4_fill_super fs/ext4/super.c:5509 [inline]
 ext4_fill_super+0x9630/0xad90 fs/ext4/super.c:5637
 get_tree_bdev+0x444/0x760 fs/super.c:1303
 vfs_get_tree+0x8d/0x350 fs/super.c:1510
 do_new_mount fs/namespace.c:3042 [inline]
 path_mount+0x1342/0x1e40 fs/namespace.c:3372
 do_mount fs/namespace.c:3385 [inline]
 __do_sys_mount fs/namespace.c:3594 [inline]
 __se_sys_mount fs/namespace.c:3571 [inline]
 __x64_sys_mount+0x283/0x300 fs/namespace.c:3571
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9b2ffa1e7a
Code: 48 c7 c2 c0 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 a8 00 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd09dcfad8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f9b2ffa1e7a
RDX: 0000000020000040 RSI: 0000000020000500 RDI: 00007ffd09dcfae0
RBP: 00007ffd09dcfae0 R08: 00007ffd09dcfb20 R09: 00000000000004a1
R10: 0000000000000047 R11: 0000000000000246 R12: 0000000000000004
R13: 00005555559192c0 R14: 00007ffd09dcfb20 R15: 0000000000000000
 </TASK>
EXT4-fs (loop0): 1 truncate cleaned up