syzbot


possible deadlock in j1939_session_activate

Status: upstream: reported on 2021/10/22 11:52
Reported-by: syzbot+f32cbede7fd867ce0d56@syzkaller.appspotmail.com
First crash: 472d, last: 10d

Sample crash report:
======================================================
WARNING: possible circular locking dependency detected
6.1.0-rc8-syzkaller-00018-g479174d402bc #0 Not tainted
------------------------------------------------------
ksoftirqd/1/21 is trying to acquire lock:
ffff88807b5dd088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff88807b5dd088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
ffff88807b5dd088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1561

but task is already holding lock:
ffff8880735ed5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
ffff8880735ed5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x5f/0x450 net/can/j1939/socket.c:207

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275
       j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379
       notifier_call_chain+0xb5/0x200 kernel/notifier.c:87
       call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1945
       call_netdevice_notifiers_extack net/core/dev.c:1983 [inline]
       call_netdevice_notifiers net/core/dev.c:1997 [inline]
       __dev_notify_flags+0x1de/0x2c0 net/core/dev.c:8583
       dev_change_flags+0x116/0x170 net/core/dev.c:8619
       do_setlink+0x9f1/0x3bb0 net/core/rtnetlink.c:2788
       __rtnl_newlink+0xd6a/0x17e0 net/core/rtnetlink.c:3547
       rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3594
       rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6091
       netlink_rcv_skb+0x157/0x430 net/netlink/af_netlink.c:2540
       netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
       netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1345
       netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1921
       sock_sendmsg_nosec net/socket.c:714 [inline]
       sock_sendmsg+0xd3/0x120 net/socket.c:734
       ____sys_sendmsg+0x712/0x8c0 net/socket.c:2482
       ___sys_sendmsg+0x110/0x1b0 net/socket.c:2536
       __sys_sendmsg+0xf7/0x1c0 net/socket.c:2565
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

-> #1 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081
       __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1132
       j1939_tp_rxtimer.cold+0x1f6/0x24f net/can/j1939/transport.c:1257
       __run_hrtimer kernel/time/hrtimer.c:1685 [inline]
       __hrtimer_run_queues+0x690/0xfb0 kernel/time/hrtimer.c:1749
       hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766
       __do_softirq+0x1fb/0xadc kernel/softirq.c:571
       invoke_softirq kernel/softirq.c:445 [inline]
       __irq_exit_rcu+0x123/0x180 kernel/softirq.c:650
       irq_exit_rcu+0x9/0x20 kernel/softirq.c:662
       sysvec_apic_timer_interrupt+0x97/0xc0 arch/x86/kernel/apic/apic.c:1107
       asm_sysvec_apic_timer_interrupt+0x1a/0x20 arch/x86/include/asm/idtentry.h:649
       arch_atomic_read arch/x86/include/asm/atomic.h:29 [inline]
       rcu_dynticks_curr_cpu_in_eqs include/linux/context_tracking.h:121 [inline]
       rcu_is_watching+0x6d/0xb0 kernel/rcu/tree.c:719
       rcu_read_unlock include/linux/rcupdate.h:767 [inline]
       batadv_iv_ogm_slide_own_bcast_window net/batman-adv/bat_iv_ogm.c:772 [inline]
       batadv_iv_ogm_schedule_buff+0x741/0x1430 net/batman-adv/bat_iv_ogm.c:826
       batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:869 [inline]
       batadv_iv_ogm_schedule net/batman-adv/bat_iv_ogm.c:862 [inline]
       batadv_iv_send_outstanding_bat_ogm_packet+0x744/0x910 net/batman-adv/bat_iv_ogm.c:1713
       process_one_work+0x9bf/0x1710 kernel/workqueue.c:2289
       worker_thread+0x669/0x1090 kernel/workqueue.c:2436
       kthread+0x2e8/0x3a0 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

-> #0 (&priv->active_session_list_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3097 [inline]
       check_prevs_add kernel/locking/lockdep.c:3216 [inline]
       validate_chain kernel/locking/lockdep.c:3831 [inline]
       __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
       lock_acquire kernel/locking/lockdep.c:5668 [inline]
       lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:355 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1561
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208
       j1939_session_deactivate_activate_next net/can/j1939/transport.c:1109 [inline]
       j1939_session_completed+0x19a/0x1f0 net/can/j1939/transport.c:1222
       j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1392 [inline]
       j1939_xtp_rx_eoma+0x2a1/0x5e0 net/can/j1939/transport.c:1407
       j1939_tp_cmd_recv net/can/j1939/transport.c:2096 [inline]
       j1939_tp_recv+0x71c/0xcd0 net/can/j1939/transport.c:2141
       j1939_can_recv net/can/j1939/main.c:112 [inline]
       j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38
       deliver net/can/af_can.c:573 [inline]
       can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:607
       can_receive+0x31d/0x580 net/can/af_can.c:664
       can_rcv+0x166/0x1a0 net/can/af_can.c:688
       __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5489
       __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5603
       process_backlog+0x3e4/0x810 net/core/dev.c:5931
       __napi_poll+0xb8/0x770 net/core/dev.c:6498
       napi_poll net/core/dev.c:6565 [inline]
       net_rx_action+0xa00/0xde0 net/core/dev.c:6676
       __do_softirq+0x1fb/0xadc kernel/softirq.c:571
       run_ksoftirqd kernel/softirq.c:934 [inline]
       run_ksoftirqd+0x31/0x60 kernel/softirq.c:926
       smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164
       kthread+0x2e8/0x3a0 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

other info that might help us debug this:

Chain exists of:
  &priv->active_session_list_lock --> &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&jsk->sk_session_queue_lock);
                               lock(&priv->j1939_socks_lock);
                               lock(&jsk->sk_session_queue_lock);
  lock(&priv->active_session_list_lock);

 *** DEADLOCK ***

3 locks held by ksoftirqd/1/21:
 #0: ffffffff8c58fbc0 (rcu_read_lock){....}-{1:2}, at: __skb_unlink include/linux/skbuff.h:2324 [inline]
 #0: ffffffff8c58fbc0 (rcu_read_lock){....}-{1:2}, at: __skb_dequeue include/linux/skbuff.h:2339 [inline]
 #0: ffffffff8c58fbc0 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x38f/0x810 net/core/dev.c:5929
 #1: ffffffff8c58fbc0 (rcu_read_lock){....}-{1:2}, at: can_receive+0x1ef/0x580 net/can/af_can.c:654
 #2: ffff8880735ed5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline]
 #2: ffff8880735ed5c8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_activate_next+0x5f/0x450 net/can/j1939/socket.c:207

stack backtrace:
CPU: 1 PID: 21 Comm: ksoftirqd/1 Not tainted 6.1.0-rc8-syzkaller-00018-g479174d402bc #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106
 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177
 check_prev_add kernel/locking/lockdep.c:3097 [inline]
 check_prevs_add kernel/locking/lockdep.c:3216 [inline]
 validate_chain kernel/locking/lockdep.c:3831 [inline]
 __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055
 lock_acquire kernel/locking/lockdep.c:5668 [inline]
 lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:355 [inline]
 j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
 j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1561
 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
 j1939_sk_queue_activate_next+0x1b6/0x450 net/can/j1939/socket.c:208
 j1939_session_deactivate_activate_next net/can/j1939/transport.c:1109 [inline]
 j1939_session_completed+0x19a/0x1f0 net/can/j1939/transport.c:1222
 j1939_xtp_rx_eoma_one net/can/j1939/transport.c:1392 [inline]
 j1939_xtp_rx_eoma+0x2a1/0x5e0 net/can/j1939/transport.c:1407
 j1939_tp_cmd_recv net/can/j1939/transport.c:2096 [inline]
 j1939_tp_recv+0x71c/0xcd0 net/can/j1939/transport.c:2141
 j1939_can_recv net/can/j1939/main.c:112 [inline]
 j1939_can_recv+0x78e/0xa30 net/can/j1939/main.c:38
 deliver net/can/af_can.c:573 [inline]
 can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:607
 can_receive+0x31d/0x580 net/can/af_can.c:664
 can_rcv+0x166/0x1a0 net/can/af_can.c:688
 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5489
 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5603
 process_backlog+0x3e4/0x810 net/core/dev.c:5931
 __napi_poll+0xb8/0x770 net/core/dev.c:6498
 napi_poll net/core/dev.c:6565 [inline]
 net_rx_action+0xa00/0xde0 net/core/dev.c:6676
 __do_softirq+0x1fb/0xadc kernel/softirq.c:571
 run_ksoftirqd kernel/softirq.c:934 [inline]
 run_ksoftirqd+0x31/0x60 kernel/softirq.c:926
 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164
 kthread+0x2e8/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
 </TASK>

Crashes (47):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets Title
ci-upstream-kasan-gce 2022/12/08 01:35 upstream 479174d402bc d88f3abb .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/11/30 01:40 upstream 01f856ae6d0c 05dc7993 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-root 2022/11/18 05:58 upstream 81ac25651a62 4ba8ab94 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/11/15 09:58 upstream e01d50cbd6ee 97de9cfc .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/09/01 23:29 upstream 2880e1a175b9 86c46e46 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/03/05 03:37 upstream 38f80f42147f 45a13a73 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/02/09 09:45 upstream e6251ab4551f 0b33604d .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/30 00:19 upstream f8c7e4ede46f 495e00c5 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/28 06:22 upstream 23a46422c561 495e00c5 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/27 21:46 upstream 626b2dda7651 64a8e201 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/27 17:41 upstream 626b2dda7651 64a8e201 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-smack-root 2022/01/26 05:54 upstream 0280e3c58f92 2cbffd88 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-root 2022/01/12 07:03 upstream 6f38be8f2ccd 44d1319a .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/11 21:57 upstream 6f38be8f2ccd 44d1319a .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2022/01/09 11:33 upstream 4634129ad9fd 2ca0d385 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce 2021/11/23 23:55 upstream 5d9f4cf36721 545ab074 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/06/18 09:16 upstream 4b35035bcf80 8f633d84 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/02/04 12:16 upstream dcb85f85fa6f a3e470b2 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/02/02 23:03 upstream 27bb0b18c208 4ebb2798 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/28 20:56 upstream 8157f4707360 495e00c5 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/27 21:43 upstream 626b2dda7651 64a8e201 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/24 20:43 upstream dd81e1c7d5fb 2cbffd88 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/22 18:39 upstream 0809edbae347 214351e1 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/20 16:58 upstream fa2e1ba3e9e3 b838eb76 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/19 22:39 upstream 1d1df41c5a33 5da9499f .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/18 08:58 upstream e3a8b6a1e70c 731a2d23 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/18 07:01 upstream e3a8b6a1e70c 731a2d23 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/18 06:08 upstream e3a8b6a1e70c 731a2d23 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-kasan-gce-386 2022/01/15 05:14 upstream 112450df61b7 723cfaf0 .config console log report info possible deadlock in j1939_session_activate
ci-qemu-upstream-386 2022/01/07 03:38 upstream b2b436ec0205 6acc789a .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-this-kasan-gce 2022/08/04 08:52 net 8eaa1d110800 1c9013ac .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-this-kasan-gce 2022/07/27 16:10 net b5177ed92bf6 da9d0366 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-this-kasan-gce 2022/07/09 21:24 net 72a0b329114b b5765a15 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-this-kasan-gce 2021/10/18 11:48 net fac3cb82a54a 0c5d9412 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2023/01/23 00:10 net-next a7b87d2a31dc 559a440a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2023/01/06 18:24 net-next 6bd4755c7c49 1dac8c7a .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2022/12/10 04:18 net-next 1933ea365aa7 67be1ae7 .config console log report info [disk image] [vmlinux] [kernel image] possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2022/07/12 12:14 net-next 2afe46474ba3 da3d6955 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2021/11/28 13:59 net-next d40ce48cb3a6 63eeac02 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2021/11/12 14:43 net-next 5833291ab6de 75b04091 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-net-kasan-gce 2021/11/06 01:24 net-next cc0356d6a02e 4c1be0be .config console log report info possible deadlock in j1939_session_activate
ci-upstream-linux-next-kasan-gce-root 2022/08/11 07:32 linux-next 6c8f479764eb a6201f11 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-linux-next-kasan-gce-root 2022/04/13 07:19 linux-next c97e430ab553 faabdb86 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-linux-next-kasan-gce-root 2022/01/10 19:23 linux-next 57c149e506d5 ddb0ab8c .config console log report info possible deadlock in j1939_session_activate
ci-upstream-linux-next-kasan-gce-root 2022/01/10 09:16 linux-next 57c149e506d5 2ca0d385 .config console log report info possible deadlock in j1939_session_activate
ci-upstream-gce-arm64 2022/10/15 01:54 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci bbed346d5a96 67cb024c .config console log report info [disk image] [vmlinux] possible deadlock in j1939_session_activate
ci-upstream-gce-arm64 2022/09/22 16:06 git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-kernelci aa49f95768a9 0042f2b4 .config console log report info [disk image] [vmlinux] possible deadlock in j1939_session_activate
* Struck through repros no longer work on HEAD.