WARNING: refcount bug in sk

WARNING: refcount bug in sk_alloc (2)
Status: upstream: reported syz repro on 2020/03/10 22:25
Reported-by: syzbot+b1212b1215db82ff9211@syzkaller.appspotmail.com
First crash: 503d, last: 27d

Cause bisection: introduced by (bisect log) :
commit b78e9d63a3b6307b6b786e6ba189d3978b60ceb5
Author: Thomas Bogendoerfer <tbogendoerfer@suse.de>
Date: Thu Jan 9 12:33:40 2020 +0000

MIPS: SGI-IP27: use asm/sn/agent.h for including HUB related stuff

Crash: WARNING: refcount bug in sk_alloc (log)
Repro: syz .config

Fix bisection: failed (bisect log)

similar bugs (1):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
upstream	WARNING: refcount bug in sk_alloc				46	1116d	1136d	0/22	auto-closed as invalid on 2019/02/22 10:22

Sample crash report:

------------[ cut here ]------------
refcount_t: addition on 0; use-after-free.
WARNING: CPU: 1 PID: 8676 at lib/refcount.c:25 refcount_warn_saturate+0x169/0x1e0 lib/refcount.c:25
Modules linked in:
CPU: 0 PID: 8676 Comm: syz-executor.0 Not tainted 5.12.0-rc6-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:refcount_warn_saturate+0x169/0x1e0 lib/refcount.c:25
Code: 09 31 ff 89 de e8 77 36 ab fd 84 db 0f 85 36 ff ff ff e8 ba 2f ab fd 48 c7 c7 60 d8 c1 89 c6 05 c4 27 e8 09 01 e8 c3 86 f9 04 <0f> 0b e9 17 ff ff ff e8 9b 2f ab fd 0f b6 1d a9 27 e8 09 31 ff 89
RSP: 0018:ffffc90001fffd40 EFLAGS: 00010282
RAX: 0000000000000000 RBX: 0000000000000000 RCX: 0000000000000000
RDX: ffff88801b3e1c40 RSI: ffffffff815c4d15 RDI: fffff520003fff9a
RBP: 0000000000000002 R08: 0000000000000000 R09: 0000000000000000
R10: ffffffff815bdaae R11: 0000000000000000 R12: ffff88801d2d1000
R13: ffff88801884814c R14: 0000000000000010 R15: ffffffff8d66b640
FS:  00007fae2ad6d700(0000) GS:ffff8880b9c00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f1903a02000 CR3: 0000000018aa1000 CR4: 00000000001506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 __refcount_add include/linux/refcount.h:199 [inline]
 __refcount_inc include/linux/refcount.h:250 [inline]
 refcount_inc include/linux/refcount.h:267 [inline]
 get_net include/net/net_namespace.h:240 [inline]
 sk_alloc+0xb20/0xbd0 net/core/sock.c:1768
 __netlink_create+0x63/0x2f0 net/netlink/af_netlink.c:638
 netlink_create+0x3a1/0x5d0 net/netlink/af_netlink.c:701
 __sock_create+0x3de/0x780 net/socket.c:1408
 sock_create net/socket.c:1459 [inline]
 __sys_socket+0xef/0x200 net/socket.c:1501
 __do_sys_socket net/socket.c:1510 [inline]
 __se_sys_socket net/socket.c:1508 [inline]
 __x64_sys_socket+0x6f/0xb0 net/socket.c:1508
 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
 entry_SYSCALL_64_after_hwframe+0x44/0xae
RIP: 0033:0x466459
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fae2ad6d188 EFLAGS: 00000246
 ORIG_RAX: 0000000000000029
RAX: ffffffffffffffda RBX: 000000000056bf60 RCX: 0000000000466459
RDX: 0000000000000000 RSI: 0000000000000003 RDI: 0000000000000010
RBP: 00000000004bf9fb R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf60
R13: 00007fff7252ed2f R14: 00007fae2ad6d300 R15: 0000000000022000

Crashes (31):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	VM info	Title
ci-upstream-net-this-kasan-gce	2021/04/13 01:03	net	6628ddfe	bfeda1b1	.config	log	report	syz		WARNING: refcount bug in sk_alloc
ci-upstream-net-kasan-gce	2021/04/13 03:09	net-next	c82eaa40	bfeda1b1	.config	log	report	syz		WARNING: refcount bug in sk_alloc
ci-upstream-kasan-gce-smack-root	2020/04/02 18:56	upstream	919dce24	a34e2c33	.config	log	report	syz
ci-upstream-net-this-kasan-gce	2020/03/15 12:08	net	0d1c3530	749688d2	.config	log	report	syz
ci-upstream-net-this-kasan-gce	2020/02/27 06:42	net	6132c1d9	59b57593	.config	log	report	syz
ci-upstream-net-kasan-gce	2020/03/15 00:14	net-next	94229d45	749688d2	.config	log	report	syz
ci-upstream-net-kasan-gce	2020/02/27 05:44	net-next	c3e042f5	59b57593	.config	log	report	syz
ci-upstream-linux-next-kasan-gce-root	2020/03/15 16:53	linux-next	770fbb32	749688d2	.config	log	report	syz
ci-upstream-net-this-kasan-gce	2021/04/10 22:11	net	4e04e751	bfeda1b1	.config	log	report		info	WARNING: refcount bug in sk_alloc
ci-upstream-linux-next-kasan-gce-root	2021/04/10 22:15	linux-next	e99d8a84	bfeda1b1	.config	log	report		info	WARNING: refcount bug in sk_alloc
ci-upstream-kasan-gce-smack-root	2020/03/08 04:43	upstream	61a09258	2e9971bb	.config	log	report
ci-upstream-kasan-gce	2020/03/07 22:19	upstream	63849c8f	2e9971bb	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/03/07 21:38	upstream	63849c8f	2e9971bb	.config	log	report
ci-upstream-kasan-gce	2020/03/07 18:43	upstream	63849c8f	2e9971bb	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/03/07 01:38	upstream	fb279f4e	fd2a5f28	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/03/04 18:24	upstream	63623fd4	c88c7b75	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/03/04 04:08	upstream	63623fd4	c88c7b75	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/02/27 03:44	upstream	f8788d86	59b57593	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/02/24 18:00	upstream	f8788d86	59b57593	.config	log	report
ci-upstream-kasan-gce	2020/02/21 12:37	upstream	ca7e1fd1	bd2a74a3	.config	log	report
ci-upstream-kasan-gce-root	2020/02/19 16:22	upstream	0a44cac8	b690a6e3	.config	log	report
ci-upstream-kasan-gce-root	2020/02/19 14:30	upstream	0a44cac8	135c18aa	.config	log	report
ci-upstream-kasan-gce-selinux-root	2020/02/19 14:25	upstream	0a44cac8	135c18aa	.config	log	report
ci-upstream-kasan-gce-386	2020/03/07 22:08	upstream	63849c8f	2e9971bb	.config	log	report
ci-upstream-kasan-gce-386	2020/02/19 14:15	upstream	0a44cac8	135c18aa	.config	log	report
ci-upstream-net-this-kasan-gce	2020/03/07 22:02	net	aeaa925b	2e9971bb	.config	log	report
ci-upstream-net-kasan-gce	2020/03/14 14:01	net-next	1d343579	749688d2	.config	log	report
ci-upstream-net-kasan-gce	2020/02/19 14:14	net-next	00796b92	135c18aa	.config	log	report
ci-upstream-net-kasan-gce	2020/01/23 16:29	net-next	fd786fb1	3334d684	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/01/11 17:40	linux-next	6c09d7db	4c04afaa	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2019/12/24 12:36	linux-next	7ddd09fc	be5c2c81	.config	log	report