syzbot


possible deadlock in tcp_close

Status: closed as invalid on 2025/03/17 11:18
Subsystems: net
[Documentation on labels]
First crash: 196d, last: 196d

Sample crash report:
virt_wifi0 speed is unknown, defaulting to 1000
virt_wifi0 speed is unknown, defaulting to 1000
iwpm_register_pid: Unable to send a nlmsg (client = 2)
======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc1-syzkaller-00034-g92514ef226f5 #0 Not tainted
------------------------------------------------------
syz.5.919/11160 is trying to acquire lock:
ffff88802a969bd8 (sk_lock-AF_INET){+.+.}-{0:0}, at: lock_sock include/net/sock.h:1624 [inline]
ffff88802a969bd8 (sk_lock-AF_INET){+.+.}-{0:0}, at: tcp_close+0x1d/0x120 net/ipv4/tcp.c:3220

but task is already holding lock:
ffffffff8fb6d1c8 (lock#8){+.+.}-{4:4}, at: cma_add_one+0x674/0xdd0 drivers/infiniband/core/cma.c:5370

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (lock#8){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       cma_init+0x1d/0x150 drivers/infiniband/core/cma.c:5454
       do_one_initcall+0x128/0x700 init/main.c:1257
       do_initcall_level init/main.c:1319 [inline]
       do_initcalls init/main.c:1335 [inline]
       do_basic_setup init/main.c:1354 [inline]
       kernel_init_freeable+0x5c7/0x900 init/main.c:1568
       kernel_init+0x1c/0x2b0 init/main.c:1457
       ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:148
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #2 (rtnl_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       start_sync_thread+0x134/0x28e0 net/netfilter/ipvs/ip_vs_sync.c:1761
       do_ip_vs_set_ctl+0x452/0x11c0 net/netfilter/ipvs/ip_vs_ctl.c:2732
       nf_setsockopt+0x8a/0xf0 net/netfilter/nf_sockopt.c:101
       ip_setsockopt+0xcb/0xf0 net/ipv4/ip_sockglue.c:1424
       tcp_setsockopt+0xa4/0x100 net/ipv4/tcp.c:4030
       smc_setsockopt+0x1b4/0xa00 net/smc/af_smc.c:3081
       do_sock_setsockopt+0x222/0x480 net/socket.c:2298
       __sys_setsockopt+0x1a0/0x230 net/socket.c:2323
       __do_sys_setsockopt net/socket.c:2329 [inline]
       __se_sys_setsockopt net/socket.c:2326 [inline]
       __x64_sys_setsockopt+0xbd/0x160 net/socket.c:2326
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&smc->clcsock_release_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xb10 kernel/locking/mutex.c:730
       smc_switch_to_fallback+0x2d/0xa00 net/smc/af_smc.c:903
       smc_sendmsg+0x13d/0x520 net/smc/af_smc.c:2781
       sock_sendmsg_nosec net/socket.c:713 [inline]
       __sock_sendmsg net/socket.c:728 [inline]
       __sys_sendto+0x488/0x4f0 net/socket.c:2182
       __do_sys_sendto net/socket.c:2189 [inline]
       __se_sys_sendto net/socket.c:2185 [inline]
       __x64_sys_sendto+0xe0/0x1c0 net/socket.c:2185
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sk_lock-AF_INET){+.+.}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain kernel/locking/lockdep.c:3906 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
       lock_sock_nested+0x3a/0xf0 net/core/sock.c:3645
       lock_sock include/net/sock.h:1624 [inline]
       tcp_close+0x1d/0x120 net/ipv4/tcp.c:3220
       inet_release+0x13c/0x280 net/ipv4/af_inet.c:435
       __sock_release+0x1cf/0x270 net/socket.c:642
       sock_release net/socket.c:670 [inline]
       __sock_create+0x27a/0x8d0 net/socket.c:1579
       siw_create_listen+0x9c2/0x1370 drivers/infiniband/sw/siw/siw_cm.c:1770
       iw_cm_listen+0x16a/0x1f0 drivers/infiniband/core/iwcm.c:585
       cma_iw_listen drivers/infiniband/core/cma.c:2684 [inline]
       rdma_listen+0x7ef/0xe30 drivers/infiniband/core/cma.c:3969
       cma_listen_on_dev+0x4dc/0x810 drivers/infiniband/core/cma.c:2743
       cma_add_one+0x78b/0xdd0 drivers/infiniband/core/cma.c:5373
       add_client_context+0x3dd/0x590 drivers/infiniband/core/device.c:711
       enable_device_and_get+0x1d5/0x3f0 drivers/infiniband/core/device.c:1322
       ib_register_device drivers/infiniband/core/device.c:1433 [inline]
       ib_register_device+0x880/0xdf0 drivers/infiniband/core/device.c:1379
       siw_device_register drivers/infiniband/sw/siw/siw_main.c:72 [inline]
       siw_newlink drivers/infiniband/sw/siw/siw_main.c:431 [inline]
       siw_newlink+0xb60/0xd70 drivers/infiniband/sw/siw/siw_main.c:413
       nldev_newlink+0x38e/0x660 drivers/infiniband/core/nldev.c:1795
       rdma_nl_rcv_msg+0x388/0x6e0 drivers/infiniband/core/netlink.c:195
       rdma_nl_rcv_skb.constprop.0.isra.0+0x2e6/0x450 drivers/infiniband/core/netlink.c:239
       netlink_unicast_kernel net/netlink/af_netlink.c:1322 [inline]
       netlink_unicast+0x53c/0x7f0 net/netlink/af_netlink.c:1348
       netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1892
       sock_sendmsg_nosec net/socket.c:713 [inline]
       __sock_sendmsg net/socket.c:728 [inline]
       ____sys_sendmsg+0xaaf/0xc90 net/socket.c:2568
       ___sys_sendmsg+0x135/0x1e0 net/socket.c:2622
       __sys_sendmsg+0x16e/0x220 net/socket.c:2654
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sk_lock-AF_INET --> rtnl_mutex --> lock#8

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(lock#8);
                               lock(rtnl_mutex);
                               lock(lock#8);
  lock(sk_lock-AF_INET);

 *** DEADLOCK ***

6 locks held by syz.5.919/11160:
 #0: ffffffff9ac050f8 (&rdma_nl_types[idx].sem){.+.+}-{4:4}, at: rdma_nl_rcv_msg+0x16a/0x6e0 drivers/infiniband/core/netlink.c:164
 #1: ffffffff8fb54ad0 (link_ops_rwsem){++++}-{4:4}, at: nldev_newlink+0x2d3/0x660 drivers/infiniband/core/nldev.c:1785
 #2: ffffffff8fb40ed0 (devices_rwsem){++++}-{4:4}, at: enable_device_and_get+0x104/0x3f0 drivers/infiniband/core/device.c:1312
 #3: ffffffff8fb40d90 (clients_rwsem){++++}-{4:4}, at: enable_device_and_get+0x163/0x3f0 drivers/infiniband/core/device.c:1320
 #4: ffff8880477605e0 (&device->client_data_rwsem){++++}-{4:4}, at: add_client_context+0x3a9/0x590 drivers/infiniband/core/device.c:709
 #5: ffffffff8fb6d1c8 (lock#8){+.+.}-{4:4}, at: cma_add_one+0x674/0xdd0 drivers/infiniband/core/cma.c:5370

stack backtrace:
CPU: 2 UID: 0 PID: 11160 Comm: syz.5.919 Not tainted 6.14.0-rc1-syzkaller-00034-g92514ef226f5 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain kernel/locking/lockdep.c:3906 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851
 lock_sock_nested+0x3a/0xf0 net/core/sock.c:3645
 lock_sock include/net/sock.h:1624 [inline]
 tcp_close+0x1d/0x120 net/ipv4/tcp.c:3220
 inet_release+0x13c/0x280 net/ipv4/af_inet.c:435
 __sock_release+0x1cf/0x270 net/socket.c:642
 sock_release net/socket.c:670 [inline]
 __sock_create+0x27a/0x8d0 net/socket.c:1579
 siw_create_listen+0x9c2/0x1370 drivers/infiniband/sw/siw/siw_cm.c:1770
 iw_cm_listen+0x16a/0x1f0 drivers/infiniband/core/iwcm.c:585
 cma_iw_listen drivers/infiniband/core/cma.c:2684 [inline]
 rdma_listen+0x7ef/0xe30 drivers/infiniband/core/cma.c:3969
 cma_listen_on_dev+0x4dc/0x810 drivers/infiniband/core/cma.c:2743
 cma_add_one+0x78b/0xdd0 drivers/infiniband/core/cma.c:5373
 add_client_context+0x3dd/0x590 drivers/infiniband/core/device.c:711
 enable_device_and_get+0x1d5/0x3f0 drivers/infiniband/core/device.c:1322
 ib_register_device drivers/infiniband/core/device.c:1433 [inline]
 ib_register_device+0x880/0xdf0 drivers/infiniband/core/device.c:1379
 siw_device_register drivers/infiniband/sw/siw/siw_main.c:72 [inline]
 siw_newlink drivers/infiniband/sw/siw/siw_main.c:431 [inline]
 siw_newlink+0xb60/0xd70 drivers/infiniband/sw/siw/siw_main.c:413
 nldev_newlink+0x38e/0x660 drivers/infiniband/core/nldev.c:1795
 rdma_nl_rcv_msg+0x388/0x6e0 drivers/infiniband/core/netlink.c:195
 rdma_nl_rcv_skb.constprop.0.isra.0+0x2e6/0x450 drivers/infiniband/core/netlink.c:239
 netlink_unicast_kernel net/netlink/af_netlink.c:1322 [inline]
 netlink_unicast+0x53c/0x7f0 net/netlink/af_netlink.c:1348
 netlink_sendmsg+0x8b8/0xd70 net/netlink/af_netlink.c:1892
 sock_sendmsg_nosec net/socket.c:713 [inline]
 __sock_sendmsg net/socket.c:728 [inline]
 ____sys_sendmsg+0xaaf/0xc90 net/socket.c:2568
 ___sys_sendmsg+0x135/0x1e0 net/socket.c:2622
 __sys_sendmsg+0x16e/0x220 net/socket.c:2654
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f5c2ab8cde9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f5c2b910038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f5c2ada5fa0 RCX: 00007f5c2ab8cde9
RDX: 0000000000000000 RSI: 0000200000000300 RDI: 0000000000000004
RBP: 00007f5c2ac0e2a0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f5c2ada5fa0 R15: 00007ffc9650a7e8
 </TASK>
infiniband syz0: RDMA CMA: cma_listen_on_dev, error -2
virt_wifi0 speed is unknown, defaulting to 1000
virt_wifi0 speed is unknown, defaulting to 1000

Crashes (1):
Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Assets (help?) Manager Title
2025/02/06 02:35 upstream 92514ef226f5 577d049b .config console log report info [disk image (non-bootable)] [vmlinux] [kernel image] ci-qemu-upstream possible deadlock in tcp_close
* Struck through repros no longer work on HEAD.