syzbot

         option from the mount to silence this warning.
=======================================================
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.17/6063 is trying to acquire lock:
ffff888061af06f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_init_acl+0x2fc/0x7d0 fs/ocfs2/acl.c:366

but task is already holding lock:
ffff888034a68950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x5e4/0x1410 fs/jbd2/transaction.c:444

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x5ea/0x1410 fs/jbd2/transaction.c:444
       jbd2__journal_start+0x394/0x6a0 fs/jbd2/transaction.c:501
       jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:540
       ocfs2_start_trans+0x3b9/0x970 fs/ocfs2/journal.c:374
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x4a2/0x4910 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x52c/0xc70 fs/ocfs2/suballoc.c:984
       ocfs2_init_xattr_set_ctxt fs/ocfs2/xattr.c:3277 [inline]
       ocfs2_xattr_set+0x184c/0x2a80 fs/ocfs2/xattr.c:3634
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x5a7/0x930 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       filename_setxattr+0x16b/0x1d0 fs/xattr.c:665
       path_setxattrat+0x1de/0x2a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
       ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372
       ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline]
       ocfs2_reserve_suballoc_bits+0x4a2/0x4910 fs/ocfs2/suballoc.c:834
       ocfs2_reserve_new_metadata_blocks+0x52c/0xc70 fs/ocfs2/suballoc.c:984
       ocfs2_init_xattr_set_ctxt fs/ocfs2/xattr.c:3277 [inline]
       ocfs2_xattr_set+0x184c/0x2a80 fs/ocfs2/xattr.c:3634
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x5a7/0x930 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       filename_setxattr+0x16b/0x1d0 fs/xattr.c:665
       path_setxattrat+0x1de/0x2a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#2){.+.+}-{0:0}:
       percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline]
       percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline]
       __sb_start_write include/linux/fs.h:1799 [inline]
       sb_start_intwrite include/linux/fs.h:1982 [inline]
       ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370
       ocfs2_xattr_set+0x12f2/0x2a80 fs/ocfs2/xattr.c:3643
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x5a7/0x930 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       filename_setxattr+0x16b/0x1d0 fs/xattr.c:665
       path_setxattrat+0x1de/0x2a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       down_write+0x92/0x200 kernel/locking/rwsem.c:1590
       inode_lock include/linux/fs.h:870 [inline]
       ocfs2_reserve_suballoc_bits+0x11c/0x4910 fs/ocfs2/suballoc.c:788
       ocfs2_reserve_new_metadata_blocks+0x52c/0xc70 fs/ocfs2/suballoc.c:984
       ocfs2_init_xattr_set_ctxt fs/ocfs2/xattr.c:3277 [inline]
       ocfs2_xattr_set+0x184c/0x2a80 fs/ocfs2/xattr.c:3634
       ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254
       ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286
       set_posix_acl+0x25f/0x320 fs/posix_acl.c:954
       vfs_set_acl+0x5a7/0x930 fs/posix_acl.c:1133
       do_set_acl+0xd9/0x1a0 fs/posix_acl.c:1278
       do_setxattr+0xeb/0x180 fs/xattr.c:633
       filename_setxattr+0x16b/0x1d0 fs/xattr.c:665
       path_setxattrat+0x1de/0x2a0 fs/xattr.c:713
       __do_sys_setxattr fs/xattr.c:747 [inline]
       __se_sys_setxattr fs/xattr.c:743 [inline]
       __x64_sys_setxattr+0xc6/0x140 fs/xattr.c:743
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       check_prev_add kernel/locking/lockdep.c:3165 [inline]
       check_prevs_add kernel/locking/lockdep.c:3284 [inline]
       validate_chain kernel/locking/lockdep.c:3908 [inline]
       __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237
       lock_acquire kernel/locking/lockdep.c:5868 [inline]
       lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
       down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
       ocfs2_init_acl+0x2fc/0x7d0 fs/ocfs2/acl.c:366
       ocfs2_mknod+0xd5c/0x2540 fs/ocfs2/namei.c:413
       ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:676
       lookup_open.isra.0+0x11d3/0x1580 fs/namei.c:3708
       open_last_lookups fs/namei.c:3807 [inline]
       path_openat+0x893/0x2cb0 fs/namei.c:4043
       do_filp_open+0x20b/0x470 fs/namei.c:4073
       do_sys_openat2+0x11b/0x1d0 fs/open.c:1435
       do_sys_open fs/open.c:1450 [inline]
       __do_sys_openat fs/open.c:1466 [inline]
       __se_sys_openat fs/open.c:1461 [inline]
       __x64_sys_openat+0x174/0x210 fs/open.c:1461
       do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
       do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.17/6063:
 #0: ffff88802a598428 (sb_writers#12){.+.+}-{0:0}, at: open_last_lookups fs/namei.c:3796 [inline]
 #0: ffff88802a598428 (sb_writers#12){.+.+}-{0:0}, at: path_openat+0x1f0f/0x2cb0 fs/namei.c:4043
 #1: ffff888061af09c0 (&type->i_mutex_dir_key#8){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:870 [inline]
 #1: ffff888061af09c0 (&type->i_mutex_dir_key#8){+.+.}-{4:4}, at: open_last_lookups fs/namei.c:3804 [inline]
 #1: ffff888061af09c0 (&type->i_mutex_dir_key#8){+.+.}-{4:4}, at: path_openat+0x1534/0x2cb0 fs/namei.c:4043
 #2: ffff888061af89c0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:870 [inline]
 #2: ffff888061af89c0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4910 fs/ocfs2/suballoc.c:788
 #3: ffff888061af6d80 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:870 [inline]
 #3: ffff888061af6d80 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x11c/0x4910 fs/ocfs2/suballoc.c:788
 #4: ffff888061afa640 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:870 [inline]
 #4: ffff888061afa640 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0xee/0xc60 fs/ocfs2/localalloc.c:636
 #5: ffff88802a598618 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xc19/0x2540 fs/ocfs2/namei.c:364
 #6: ffff888041bb54e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372
 #7: ffff888034a68950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x5e4/0x1410 fs/jbd2/transaction.c:444

stack backtrace:
CPU: 1 UID: 0 PID: 6063 Comm: syz.0.17 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/18/2025
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2043
 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3165 [inline]
 check_prevs_add kernel/locking/lockdep.c:3284 [inline]
 validate_chain kernel/locking/lockdep.c:3908 [inline]
 __lock_acquire+0x12a6/0x1ce0 kernel/locking/lockdep.c:5237
 lock_acquire kernel/locking/lockdep.c:5868 [inline]
 lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5825
 down_read+0x9b/0x480 kernel/locking/rwsem.c:1537
 ocfs2_init_acl+0x2fc/0x7d0 fs/ocfs2/acl.c:366
 ocfs2_mknod+0xd5c/0x2540 fs/ocfs2/namei.c:413
 ocfs2_create+0x17c/0x460 fs/ocfs2/namei.c:676
 lookup_open.isra.0+0x11d3/0x1580 fs/namei.c:3708
 open_last_lookups fs/namei.c:3807 [inline]
 path_openat+0x893/0x2cb0 fs/namei.c:4043
 do_filp_open+0x20b/0x470 fs/namei.c:4073
 do_sys_openat2+0x11b/0x1d0 fs/open.c:1435
 do_sys_open fs/open.c:1450 [inline]
 __do_sys_openat fs/open.c:1466 [inline]
 __se_sys_openat fs/open.c:1461 [inline]
 __x64_sys_openat+0x174/0x210 fs/open.c:1461
 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline]
 do_syscall_64+0xcd/0x4e0 arch/x86/entry/syscall_64.c:94
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f880af8eec9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffd9fdbaa48 EFLAGS: 00000246 ORIG_RAX: 0000000000000101
RAX: ffffffffffffffda RBX: 00007f880b1e5fa0 RCX: 00007f880af8eec9
RDX: 0000000000101042 RSI: 0000200000000040 RDI: ffffffffffffff9c
RBP: 00007f880b011f91 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f880b1e5fa0 R14: 00007f880b1e5fa0 R15: 0000000000000004
 </TASK>