memory leak in inet

memory leak in inet_create (2)
Status: upstream: reported syz repro on 2020/04/27 13:48
Reported-by: syzbot+bb7ba8dd62c3cb6e3c78@syzkaller.appspotmail.com
First crash: 40d, last: 24d

similar bugs (1):
Kernel	Title	Repro	Bisected	Count	Last	Reported	Patched	Status
upstream	memory leak in inet_create	C		2	364d	378d	13/17	fixed on 2019/06/18 17:49

Sample crash report:

2020/05/09 23:39:51 executed programs: 3
2020/05/09 23:39:57 executed programs: 5
2020/05/09 23:40:03 executed programs: 7
BUG: memory leak
unreferenced object 0xffff8881179752c0 (size 2200):
  comm "syz-executor.0", pid 6875, jiffies 4294946718 (age 13.410s)
  hex dump (first 32 bytes):
    ac 14 14 bb ac 14 14 0a 0a 65 4a 12 40 01 00 00  .........eJ.@...
    02 00 07 40 00 00 00 00 00 00 00 00 00 00 00 00  ...@............
  backtrace:
    [<0000000058276056>] sk_prot_alloc+0x3c/0x170 net/core/sock.c:1598
    [<00000000d69fe168>] sk_alloc+0x30/0x330 net/core/sock.c:1658
    [<0000000000801138>] inet_create net/ipv4/af_inet.c:321 [inline]
    [<0000000000801138>] inet_create+0x119/0x450 net/ipv4/af_inet.c:247
    [<0000000025f19a44>] __sock_create+0x14a/0x220 net/socket.c:1433
    [<000000009b7ddd5b>] sock_create net/socket.c:1484 [inline]
    [<000000009b7ddd5b>] __sys_socket+0x60/0x110 net/socket.c:1526
    [<00000000b632b15b>] __do_sys_socket net/socket.c:1535 [inline]
    [<00000000b632b15b>] __se_sys_socket net/socket.c:1533 [inline]
    [<00000000b632b15b>] __x64_sys_socket+0x1a/0x20 net/socket.c:1533
    [<000000005341c88a>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<00000000b70d208d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88811b6807c0 (size 32):
  comm "syz-executor.0", pid 6875, jiffies 4294946718 (age 13.410s)
  hex dump (first 32 bytes):
    02 00 00 00 00 00 00 00 c0 5a 4e 14 81 88 ff ff  .........ZN.....
    01 00 00 00 00 00 00 00 10 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000d67fdc57>] kmalloc include/linux/slab.h:555 [inline]
    [<00000000d67fdc57>] kzalloc include/linux/slab.h:669 [inline]
    [<00000000d67fdc57>] selinux_sk_alloc_security+0x43/0xa0 security/selinux/hooks.c:5126
    [<0000000081fc008e>] security_sk_alloc+0x42/0x70 security/security.c:2120
    [<00000000aabdc4f0>] sk_prot_alloc+0x9c/0x170 net/core/sock.c:1607
    [<00000000d69fe168>] sk_alloc+0x30/0x330 net/core/sock.c:1658
    [<0000000000801138>] inet_create net/ipv4/af_inet.c:321 [inline]
    [<0000000000801138>] inet_create+0x119/0x450 net/ipv4/af_inet.c:247
    [<0000000025f19a44>] __sock_create+0x14a/0x220 net/socket.c:1433
    [<000000009b7ddd5b>] sock_create net/socket.c:1484 [inline]
    [<000000009b7ddd5b>] __sys_socket+0x60/0x110 net/socket.c:1526
    [<00000000b632b15b>] __do_sys_socket net/socket.c:1535 [inline]
    [<00000000b632b15b>] __se_sys_socket net/socket.c:1533 [inline]
    [<00000000b632b15b>] __x64_sys_socket+0x1a/0x20 net/socket.c:1533
    [<000000005341c88a>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<00000000b70d208d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff8881144e5ac0 (size 64):
  comm "syz-executor.0", pid 6875, jiffies 4294946718 (age 13.410s)
  hex dump (first 32 bytes):
    15 00 00 01 00 00 00 00 80 b5 6d 1b 81 88 ff ff  ..........m.....
    00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
  backtrace:
    [<0000000058f0e924>] kmalloc include/linux/slab.h:555 [inline]
    [<0000000058f0e924>] kzalloc include/linux/slab.h:669 [inline]
    [<0000000058f0e924>] netlbl_secattr_alloc include/net/netlabel.h:382 [inline]
    [<0000000058f0e924>] selinux_netlbl_sock_genattr+0x48/0x180 security/selinux/netlabel.c:76
    [<00000000237fa126>] selinux_netlbl_socket_post_create+0x41/0xb0 security/selinux/netlabel.c:398
    [<000000007f930e69>] selinux_socket_post_create+0x182/0x390 security/selinux/hooks.c:4541
    [<00000000032c09c3>] security_socket_post_create+0x54/0x80 security/security.c:2032
    [<0000000034895694>] __sock_create+0x1cc/0x220 net/socket.c:1449
    [<000000009b7ddd5b>] sock_create net/socket.c:1484 [inline]
    [<000000009b7ddd5b>] __sys_socket+0x60/0x110 net/socket.c:1526
    [<00000000b632b15b>] __do_sys_socket net/socket.c:1535 [inline]
    [<00000000b632b15b>] __se_sys_socket net/socket.c:1533 [inline]
    [<00000000b632b15b>] __x64_sys_socket+0x1a/0x20 net/socket.c:1533
    [<000000005341c88a>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<00000000b70d208d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88811b6db580 (size 32):
  comm "syz-executor.0", pid 6875, jiffies 4294946718 (age 13.410s)
  hex dump (first 32 bytes):
    6b 65 72 6e 65 6c 5f 74 00 73 79 73 74 65 6d 5f  kernel_t.system_
    72 3a 6b 65 72 6e 65 6c 5f 74 3a 73 30 00 00 00  r:kernel_t:s0...
  backtrace:
    [<00000000dbc3681a>] kstrdup+0x36/0x70 mm/util.c:60
    [<000000003fd9b30d>] security_netlbl_sid_to_secattr+0x97/0x100 security/selinux/ss/services.c:3739
    [<0000000040a8b7af>] selinux_netlbl_sock_genattr+0x67/0x180 security/selinux/netlabel.c:79
    [<00000000237fa126>] selinux_netlbl_socket_post_create+0x41/0xb0 security/selinux/netlabel.c:398
    [<000000007f930e69>] selinux_socket_post_create+0x182/0x390 security/selinux/hooks.c:4541
    [<00000000032c09c3>] security_socket_post_create+0x54/0x80 security/security.c:2032
    [<0000000034895694>] __sock_create+0x1cc/0x220 net/socket.c:1449
    [<000000009b7ddd5b>] sock_create net/socket.c:1484 [inline]
    [<000000009b7ddd5b>] __sys_socket+0x60/0x110 net/socket.c:1526
    [<00000000b632b15b>] __do_sys_socket net/socket.c:1535 [inline]
    [<00000000b632b15b>] __se_sys_socket net/socket.c:1533 [inline]
    [<00000000b632b15b>] __x64_sys_socket+0x1a/0x20 net/socket.c:1533
    [<000000005341c88a>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<00000000b70d208d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

BUG: memory leak
unreferenced object 0xffff88811cb69400 (size 512):
  comm "syz-executor.0", pid 6875, jiffies 4294946718 (age 13.410s)
  hex dump (first 32 bytes):
    c0 52 97 17 81 88 ff ff 00 00 00 00 00 00 00 00  .R..............
    00 00 00 00 00 00 00 00 03 00 00 00 00 00 00 00  ................
  backtrace:
    [<00000000cf95277a>] kmalloc_node include/linux/slab.h:573 [inline]
    [<00000000cf95277a>] kzalloc_node include/linux/slab.h:680 [inline]
    [<00000000cf95277a>] sk_psock_init+0x2a/0x180 net/core/skmsg.c:496
    [<00000000d05c8c89>] sock_map_link.isra.0+0x469/0x4f0 net/core/sock_map.c:236
    [<0000000005a7c312>] sock_map_update_common+0xa1/0x3c0 net/core/sock_map.c:451
    [<00000000ce8b8466>] sock_map_update_elem+0x1e9/0x220 net/core/sock_map.c:552
    [<00000000777e7fb0>] bpf_map_update_value.isra.0+0x141/0x2f0 kernel/bpf/syscall.c:169
    [<0000000011818d7b>] map_update_elem kernel/bpf/syscall.c:1098 [inline]
    [<0000000011818d7b>] __do_sys_bpf+0x15e0/0x1f60 kernel/bpf/syscall.c:3696
    [<000000005341c88a>] do_syscall_64+0x6e/0x220 arch/x86/entry/common.c:295
    [<00000000b70d208d>] entry_SYSCALL_64_after_hwframe+0x44/0xa9

Crashes (9):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	Maintainers
ci-upstream-gce-leak	2020/05/09 23:43	upstream	1d3962ae	88cb3e92	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/05/04 10:23	upstream	0e698dfa	58ae5e18	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/05/02 18:23	upstream	690e2aba	58da4c35	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/05/01 15:20	upstream	c45e8bcc	a4d01b80	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/05/01 09:29	upstream	c45e8bcc	a4d01b80	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/04/29 00:37	upstream	3f777e19	e3ecea2e	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/04/25 22:39	upstream	5ef58e29	b8bb8e5f	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/04/24 12:03	upstream	c578ddb3	2e44d63e	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org
ci-upstream-gce-leak	2020/04/23 13:38	upstream	c578ddb3	2e44d63e	.config	log	report	syz	andriin@fb.com, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, davem@davemloft.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@chromium.org, kuba@kernel.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, yhs@fb.com, yoshfuji@linux-ipv6.org