KASAN: use-after-free Read in macvlan_dev_get

KASAN: use-after-free Read in macvlan_dev_get_iflink
Status: upstream: reported C repro on 2020/06/28 02:47
Reported-by: syzbot+95eec132c4bd9b1d8430@syzkaller.appspotmail.com
First crash: 264d, last: 46d

Cause bisection: introduced by (bisect log) :
commit 1a33e10e4a95cb109ff1145098175df3113313ef
Author: Cong Wang <xiyou.wangcong@gmail.com>
Date: Sun May 3 05:22:19 2020 +0000

  net: partially revert dynamic lockdep key changes

Crash: WARNING in print_bfs_bug (log)
Repro: C syz .config

Fix bisection: the fix commit could be any of (bisect log):
  6b643a07a7e4 x86/entry, ubsan, objtool: Whitelist __ubsan_handle_*()
  8e8bb06d199a x86/entry, bug: Comment the instrumentation_begin() usage for WARN()
  14d3b376b6c3 x86/entry, cpumask: Provide non-instrumented variant of cpu_is_offline()
  33aea07f30c2 compiler_attributes.h: Support no_sanitize_undefined check with GCC 4
  5144f8a8dfd7 compiler_types.h: Add __no_sanitize_{address,undefined} to noinstr
  acf7b0bf7dcf kasan: Fix required compiler version
  734d099ba644 objtool: Don't consider vmlinux a C-file
  7b861a53e46b kasan: Bump required compiler version
  5ddbc4082e10 x86, kcsan: Add __no_kcsan to noinstr
  e3a9e681adb7 x86/entry: Fixup bad_iret vs noinstr
  c7aadc09321d x86/entry: Increase entry_stack size to a full page
  e79302ae8c8c kcsan: Remove __no_kcsan_or_inline
  145a773aef83 x86/entry: Fix #UD vs WARN more
  e82587336695 x86, kcsan: Remove __no_kcsan_or_inline usage
  2c92d787cc9f Merge branch 'linus' into x86/entry, to resolve conflicts

similar bugs (2):
Kernel	Title	Repro	Cause bisect	Fix bisect	Count	Last	Reported	Patched	Status
linux-4.14	KASAN: use-after-free Read in macvlan_dev_get_iflink	C		error	55	24d	366d	0/1	upstream: reported C repro on 2020/03/06 01:40
linux-4.19	KASAN: use-after-free Read in macvlan_dev_get_iflink	C			48	1d20h	366d	0/1	upstream: reported C repro on 2020/03/06 01:52

Patch testing requests:
Created	Duration	User	Patch	Repo	Result
2020/07/24 02:00	16m	xiyou.wangcong@gmail.com		https://github.com/congwang/linux.git net	OK
2020/07/23 20:08	10m	xiyou.wangcong@gmail.com		https://github.com/congwang/linux.git net	report log

Sample crash report:

==================================================================
BUG: KASAN: use-after-free in macvlan_dev_get_iflink+0x6a/0x70 drivers/net/macvlan.c:1137
Read of size 4 at addr ffff88808b62a100 by task syz-executor984/7033

CPU: 0 PID: 7033 Comm: syz-executor984 Not tainted 5.8.0-rc2-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1f0/0x31e lib/dump_stack.c:118
 print_address_description+0x66/0x5a0 mm/kasan/report.c:383
 __kasan_report mm/kasan/report.c:513 [inline]
 kasan_report+0x132/0x1d0 mm/kasan/report.c:530
 macvlan_dev_get_iflink+0x6a/0x70 drivers/net/macvlan.c:1137
 default_operstate net/core/link_watch.c:41 [inline]
 rfc2863_policy+0x11f/0x2a0 net/core/link_watch.c:53
 linkwatch_do_dev+0x3a/0x160 net/core/link_watch.c:160
 netdev_wait_allrefs net/core/dev.c:9678 [inline]
 netdev_run_todo+0x2c8/0xc90 net/core/dev.c:9774
 rtnl_unlock net/core/rtnetlink.c:112 [inline]
 rtnetlink_rcv_msg+0x890/0xd40 net/core/rtnetlink.c:5461
 netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x786/0x940 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0xa57/0xd70 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg net/socket.c:672 [inline]
 ____sys_sendmsg+0x519/0x800 net/socket.c:2352
 ___sys_sendmsg net/socket.c:2406 [inline]
 __sys_sendmsg+0x2b1/0x360 net/socket.c:2439
 do_syscall_64+0x73/0xe0 arch/x86/entry/common.c:359
 entry_SYSCALL_64_after_hwframe+0x44/0xa9
RIP: 0033:0x446e69
Code: Bad RIP value.
RSP: 002b:00007f7fa3a46d98 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00000000006dbc98 RCX: 0000000000446e69
RDX: 0000000000000000 RSI: 0000000020000080 RDI: 0000000000000006
RBP: 00000000006dbc90 R08: 0000000000000000 R09: 0000000000000000
R10: 000000000000000a R11: 0000000000000246 R12: 00000000006dbc9c
R13: 0000000000000000 R14: 0000000000000000 R15: 0705001000000048

Allocated by task 7001:
 save_stack mm/kasan/common.c:48 [inline]
 set_track mm/kasan/common.c:56 [inline]
 __kasan_kmalloc+0x103/0x140 mm/kasan/common.c:494
 kmalloc_node include/linux/slab.h:578 [inline]
 kvmalloc_node+0x81/0x110 mm/util.c:574
 kvmalloc include/linux/mm.h:753 [inline]
 kvzalloc include/linux/mm.h:761 [inline]
 alloc_netdev_mqs+0x86/0xf90 net/core/dev.c:9938
 rtnl_create_link+0x242/0x9c0 net/core/rtnetlink.c:3067
 __rtnl_newlink net/core/rtnetlink.c:3329 [inline]
 rtnl_newlink+0x12a2/0x1bf0 net/core/rtnetlink.c:3397
 rtnetlink_rcv_msg+0x889/0xd40 net/core/rtnetlink.c:5460
 netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x786/0x940 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0xa57/0xd70 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg net/socket.c:672 [inline]
 ____sys_sendmsg+0x519/0x800 net/socket.c:2352
 ___sys_sendmsg net/socket.c:2406 [inline]
 __sys_sendmsg+0x2b1/0x360 net/socket.c:2439
 do_syscall_64+0x73/0xe0 arch/x86/entry/common.c:359
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Freed by task 7001:
 save_stack mm/kasan/common.c:48 [inline]
 set_track mm/kasan/common.c:56 [inline]
 kasan_set_free_info mm/kasan/common.c:316 [inline]
 __kasan_slab_free+0x114/0x170 mm/kasan/common.c:455
 __cache_free mm/slab.c:3426 [inline]
 kfree+0x10a/0x220 mm/slab.c:3757
 device_release+0x70/0x1a0 drivers/base/core.c:1555
 kobject_cleanup lib/kobject.c:693 [inline]
 kobject_release lib/kobject.c:722 [inline]
 kref_put include/linux/kref.h:65 [inline]
 kobject_put+0x15b/0x220 lib/kobject.c:739
 netdev_run_todo+0xb17/0xc90 net/core/dev.c:9797
 rtnl_unlock net/core/rtnetlink.c:112 [inline]
 rtnetlink_rcv_msg+0x890/0xd40 net/core/rtnetlink.c:5461
 netlink_rcv_skb+0x190/0x3a0 net/netlink/af_netlink.c:2469
 netlink_unicast_kernel net/netlink/af_netlink.c:1303 [inline]
 netlink_unicast+0x786/0x940 net/netlink/af_netlink.c:1329
 netlink_sendmsg+0xa57/0xd70 net/netlink/af_netlink.c:1918
 sock_sendmsg_nosec net/socket.c:652 [inline]
 sock_sendmsg net/socket.c:672 [inline]
 ____sys_sendmsg+0x519/0x800 net/socket.c:2352
 ___sys_sendmsg net/socket.c:2406 [inline]
 __sys_sendmsg+0x2b1/0x360 net/socket.c:2439
 do_syscall_64+0x73/0xe0 arch/x86/entry/common.c:359
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

The buggy address belongs to the object at ffff88808b62a000
 which belongs to the cache kmalloc-4k of size 4096
The buggy address is located 256 bytes inside of
 4096-byte region [ffff88808b62a000, ffff88808b62b000)
The buggy address belongs to the page:
page:ffffea00022d8a80 refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 head:ffffea00022d8a80 order:1 compound_mapcount:0
flags: 0xfffe0000010200(slab|head)
raw: 00fffe0000010200 ffffea0002a12288 ffffea0002462c08 ffff8880aa402000
raw: 0000000000000000 ffff88808b62a000 0000000100000001 0000000000000000
page dumped because: kasan: bad access detected

Memory state around the buggy address:
 ffff88808b62a000: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808b62a080: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
>ffff88808b62a100: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
                   ^
 ffff88808b62a180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
 ffff88808b62a200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb
==================================================================

Crashes (56):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	C repro	VM info	Title
ci-upstream-kasan-gce-smack-root	2020/06/28 02:46	upstream	1590a2e1	ffec44b5	.config	log	report	syz	C
ci-upstream-kasan-gce-smack-root	2021/01/20 03:12	upstream	1e2a199f	63631df1	.config	log	report			info	KASAN: use-after-free Read in macvlan_dev_get_iflink
ci-upstream-kasan-gce	2021/01/06 18:08	upstream	9f1abbe9	c104d4a3	.config	log	report			info
ci-upstream-kasan-gce-root	2020/11/16 17:18	upstream	09162bc3	1bf9a662	.config	log	report			info
ci-upstream-kasan-gce-smack-root	2020/10/08 16:28	upstream	c85fb28b	92390980	.config	log	report			info
ci-upstream-kasan-gce-smack-root	2020/09/11 05:36	upstream	7fe10096	409809d8	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/09/08 17:53	upstream	f4d51dff	abf9ba4f	.config	log	report
ci-upstream-kasan-gce	2020/08/31 23:55	upstream	f75aef39	d5a3ae1f	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/08/31 09:06	upstream	dcc5c6f0	d5a3ae1f	.config	log	report
ci-upstream-kasan-gce-root	2020/08/28 04:48	upstream	15bc20c6	816e0689	.config	log	report
ci-upstream-kasan-gce-root	2020/08/23 02:45	upstream	c3d8f220	1da71ab0	.config	log	report
ci-upstream-kasan-gce-selinux-root	2020/08/22 14:04	upstream	f873db9a	6436ce4b	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/08/06 01:11	upstream	fffe3ae0	0487ea6f	.config	log	report
ci-upstream-kasan-gce-root	2020/08/04 18:44	upstream	c0842fbc	80a06902	.config	log	report
ci-upstream-kasan-gce-root	2020/07/31 13:59	upstream	83bdc727	8df85ed9	.config	log	report
ci-upstream-kasan-gce-root	2020/07/26 02:51	upstream	23ee3e4e	1f7cc1ca	.config	log	report
ci-upstream-kasan-gce-root	2020/07/21 10:29	upstream	4fa640dc	d88894e6	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/07/18 16:13	upstream	6a70f89c	9c812472	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/07/18 00:44	upstream	88825726	9c812472	.config	log	report
ci-upstream-kasan-gce	2020/07/18 00:35	upstream	88825726	9c812472	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/07/14 05:24	upstream	0dc589da	ce4c95b3	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/07/12 10:44	upstream	0aea6d5c	115e1930	.config	log	report
ci-upstream-kasan-gce	2020/07/12 10:40	upstream	0aea6d5c	115e1930	.config	log	report
ci-upstream-kasan-gce-root	2020/07/10 18:40	upstream	42f82040	edf162e8	.config	log	report
ci-upstream-kasan-gce-selinux-root	2020/07/10 18:18	upstream	42f82040	edf162e8	.config	log	report
ci-qemu-upstream	2020/07/08 03:05	upstream	719fdd32	08fc4ef1	.config	log	report
ci-upstream-kasan-gce	2020/07/01 16:57	upstream	7c30b859	39acb39d	.config	log	report
ci-upstream-kasan-gce-selinux-root	2020/06/30 00:14	upstream	4e99b321	a2cdad9d	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/06/28 16:24	upstream	4e99b321	a2cdad9d	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/06/28 01:32	upstream	1590a2e1	ffec44b5	.config	log	report
ci-upstream-kasan-gce-smack-root	2020/06/16 13:32	upstream	7ae77150	baca2611	.config	log	report
ci-upstream-kasan-gce-386	2020/09/04 15:32	upstream	e28f0104	abf9ba4f	.config	log	report
ci-upstream-net-this-kasan-gce	2020/10/14 09:26	net	254941f3	fc7735a2	.config	log	report			info
ci-upstream-net-this-kasan-gce	2020/09/05 07:16	net	c70672d8	abf9ba4f	.config	log	report
ci-upstream-net-this-kasan-gce	2020/08/15 23:55	net	4ca0d9ac	424dd8e7	.config	log	report
ci-upstream-net-this-kasan-gce	2020/08/15 01:26	net	7fca4dee	424dd8e7	.config	log	report
ci-upstream-net-this-kasan-gce	2020/07/23 10:36	net	26cb7085	340ea530	.config	log	report
ci-upstream-net-this-kasan-gce	2020/07/14 01:22	net	1df0d896	f90ec899	.config	log	report
ci-upstream-net-this-kasan-gce	2020/07/09 09:19	net	1412bb2b	bc238812	.config	log	report
ci-upstream-net-kasan-gce	2020/10/13 00:11	net-next	15f5e48f	d32b0bbf	.config	log	report			info
ci-upstream-net-kasan-gce	2020/09/06 18:14	net-next	be239c4d	abf9ba4f	.config	log	report
ci-upstream-net-kasan-gce	2020/08/09 02:00	net-next	bfdd5aaa	f721e4a0	.config	log	report
ci-upstream-net-kasan-gce	2020/07/21 16:42	net-next	71d4364a	21f1765e	.config	log	report
ci-upstream-net-kasan-gce	2020/07/21 03:19	net-next	4f1b4da5	d88894e6	.config	log	report
ci-upstream-net-kasan-gce	2020/07/20 16:05	net-next	7dce80c2	4285ffa3	.config	log	report
ci-upstream-net-kasan-gce	2020/07/16 08:53	net-next	8635764b	f3bec699	.config	log	report
ci-upstream-net-kasan-gce	2020/07/13 03:15	net-next	94339443	9ebcc5b1	.config	log	report
ci-upstream-net-kasan-gce	2020/07/12 09:26	net-next	71930d61	115e1930	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/08/21 14:43	linux-next	494d311a	6436ce4b	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/07/21 14:22	linux-next	ab8be66e	d88894e6	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/07/18 16:08	linux-next	4c43049f	9c812472	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/07/02 16:13	linux-next	aab20039	bed10395	.config	log	report
ci-upstream-linux-next-kasan-gce-root	2020/07/02 05:02	linux-next	aab20039	bed10395	.config	log	report