syzbot

usb 1-1: reset high-speed USB device number 2 using dummy_hcd
usb 1-1: device descriptor read/64, error -71
usb 1-1: unable to get BOS descriptor or descriptor too short
zd1211rw 1-1:129.166: phy1
zd1211rw 1-1:129.51: error ioread32(CR_REG1): -11
============================================
WARNING: possible recursive locking detected
6.4.0-rc1-syzkaller-00001-g986866c3dfb0 #0 Not tainted
--------------------------------------------
kworker/1:2/564 is trying to acquire lock:
ffff888122f3dfd0 (&chip->mutex){+.+.}-{3:3}, at: zd_chip_disable_rxtx+0x20/0x50 drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1465

but task is already holding lock:
ffff88810e7edfd0 (&chip->mutex){+.+.}-{3:3}, at: pre_reset+0x213/0x290 drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1503

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&chip->mutex);
  lock(&chip->mutex);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

6 locks held by kworker/1:2/564:
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline]
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: arch_atomic_long_set include/linux/atomic/atomic-long.h:41 [inline]
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: atomic_long_set include/linux/atomic/atomic-instrumented.h:1324 [inline]
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:643 [inline]
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:670 [inline]
 #0: ffff88810ca70538 ((wq_completion)usb_hub_wq){+.+.}-{0:0}, at: process_one_work+0x883/0x15e0 kernel/workqueue.c:2376
 #1: ffffc90001c7fdb0 ((work_completion)(&hub->events)){+.+.}-{0:0}, at: process_one_work+0x8b7/0x15e0 kernel/workqueue.c:2380
 #2: ffff88810570d190 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:837 [inline]
 #2: ffff88810570d190 (&dev->mutex){....}-{3:3}, at: hub_event+0x1c0/0x4ed0 drivers/usb/core/hub.c:5739
 #3: ffff88810cb21190 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:837 [inline]
 #3: ffff88810cb21190 (&dev->mutex){....}-{3:3}, at: __device_attach+0x76/0x4b0 drivers/base/dd.c:1005
 #4: ffff88810cb26160 (&dev->mutex){....}-{3:3}, at: device_lock include/linux/device.h:837 [inline]
 #4: ffff88810cb26160 (&dev->mutex){....}-{3:3}, at: __device_attach+0x76/0x4b0 drivers/base/dd.c:1005
 #5: ffff88810e7edfd0 (&chip->mutex){+.+.}-{3:3}, at: pre_reset+0x213/0x290 drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1503

stack backtrace:
CPU: 1 PID: 564 Comm: kworker/1:2 Not tainted 6.4.0-rc1-syzkaller-00001-g986866c3dfb0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023
Workqueue: usb_hub_wq hub_event
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 print_deadlock_bug kernel/locking/lockdep.c:3001 [inline]
 check_deadlock kernel/locking/lockdep.c:3044 [inline]
 validate_chain kernel/locking/lockdep.c:3829 [inline]
 __lock_acquire+0x13b3/0x5df0 kernel/locking/lockdep.c:5074
 lock_acquire kernel/locking/lockdep.c:5691 [inline]
 lock_acquire+0x1b1/0x520 kernel/locking/lockdep.c:5656
 __mutex_lock_common kernel/locking/mutex.c:603 [inline]
 __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747
 zd_chip_disable_rxtx+0x20/0x50 drivers/net/wireless/zydas/zd1211rw/zd_chip.c:1465
 zd_op_stop+0x64/0x1a0 drivers/net/wireless/zydas/zd1211rw/zd_mac.c:343
 zd_usb_stop drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1478 [inline]
 pre_reset+0x199/0x290 drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1501
 usb_reset_device+0x41b/0xac0 drivers/usb/core/hub.c:6180
 probe+0x119/0x930 drivers/net/wireless/zydas/zd1211rw/zd_usb.c:1370
 usb_probe_interface+0x30f/0x960 drivers/usb/core/driver.c:396
 call_driver_probe drivers/base/dd.c:579 [inline]
 really_probe+0x240/0xca0 drivers/base/dd.c:658
 __driver_probe_device+0x1df/0x4b0 drivers/base/dd.c:800
 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:830
 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:958
 bus_for_each_drv+0x149/0x1d0 drivers/base/bus.c:457
 __device_attach+0x1e4/0x4b0 drivers/base/dd.c:1030
 bus_probe_device+0x17c/0x1c0 drivers/base/bus.c:532
 device_add+0x112d/0x1a40 drivers/base/core.c:3625
 usb_set_configuration+0x1196/0x1bc0 drivers/usb/core/message.c:2211
 usb_generic_driver_probe+0xcf/0x130 drivers/usb/core/generic.c:238
 usb_probe_device+0xd8/0x2c0 drivers/usb/core/driver.c:293
 call_driver_probe drivers/base/dd.c:579 [inline]
 really_probe+0x240/0xca0 drivers/base/dd.c:658
 __driver_probe_device+0x1df/0x4b0 drivers/base/dd.c:800
 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:830
 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:958
 bus_for_each_drv+0x149/0x1d0 drivers/base/bus.c:457
 __device_attach+0x1e4/0x4b0 drivers/base/dd.c:1030
 bus_probe_device+0x17c/0x1c0 drivers/base/bus.c:532
 device_add+0x112d/0x1a40 drivers/base/core.c:3625
 usb_new_device+0xcb2/0x19d0 drivers/usb/core/hub.c:2575
 hub_port_connect drivers/usb/core/hub.c:5407 [inline]
 hub_port_connect_change drivers/usb/core/hub.c:5551 [inline]
 port_event drivers/usb/core/hub.c:5711 [inline]
 hub_event+0x2e3d/0x4ed0 drivers/usb/core/hub.c:5793
 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405
 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552
 kthread+0x344/0x440 kernel/kthread.c:379
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308
 </TASK>
zd1211rw 1-1:129.166: error ioread32(CR_REG1): -11
usb 1-1: reset high-speed USB device number 2 using dummy_hcd
usb 1-1: device descriptor read/64, error -71
usb 1-1: unable to get BOS descriptor or descriptor too short
ieee80211 phy2: Selected rate control algorithm 'minstrel_ht'
zd1211rw 1-1:129.36: phy2
zd1211rw 1-1:129.51: error ioread32(CR_REG1): -11
zd1211rw 1-1:129.166: error ioread32(CR_REG1): -11
zd1211rw 1-1:129.36: error ioread32(CR_REG1): -11
usb 1-1: reset high-speed USB device number 2 using dummy_hcd
usb 1-1: device descriptor read/64, error -71
usb 1-1: unable to get BOS descriptor or descriptor too short
ieee80211 phy3: Selected rate control algorithm 'minstrel_ht'
zd1211rw 1-1:129.5: phy3
usb 1-1: USB disconnect, device number 2
usb 1-1: new high-speed USB device number 3 using dummy_hcd
usb 1-1: unable to get BOS descriptor or descriptor too short
usb 1-1: config 129 has an invalid interface number: 51 but max is 3
usb 1-1: config 129 has an invalid interface association descriptor of length 2, skipping
usb 1-1: config 129 has an invalid interface number: 166 but max is 3
usb 1-1: config 129 has an invalid interface descriptor of length 2, skipping
usb 1-1: config 129 has an invalid interface number: 36 but max is 3
usb 1-1: config 129 has an invalid interface number: 5 but max is 3
usb 1-1: config 129 contains an unexpected descriptor of type 0x2, skipping
usb 1-1: config 129 has no interface number 0
usb 1-1: config 129 has no interface number 1
usb 1-1: config 129 has no interface number 2
usb 1-1: config 129 has no interface number 3
usb 1-1: config 129 interface 51 altsetting 128 endpoint 0x5 has invalid maxpacket 512, setting to 64
usb 1-1: config 129 interface 51 altsetting 128 has a duplicate endpoint with address 0x1, skipping
usb 1-1: config 129 interface 166 altsetting 9 endpoint 0xD has invalid maxpacket 59363, setting to 64
usb 1-1: config 129 interface 166 altsetting 9 endpoint 0xC has invalid maxpacket 512, setting to 64
usb 1-1: config 129 interface 166 altsetting 9 endpoint 0xF has an invalid bInterval 129, changing to 11
usb 1-1: config 129 interface 166 altsetting 9 has an invalid endpoint with address 0x80, skipping
usb 1-1: config 129 interface 166 altsetting 9 endpoint 0x2 has an invalid bInterval 129, changing to 7
usb 1-1: config 129 interface 166 altsetting 9 has 5 endpoint descriptors, different from the interface descriptor's value: 8
usb 1-1: config 129 interface 36 altsetting 3 has a duplicate endpoint with address 0xC, skipping
usb 1-1: config 129 interface 36 altsetting 3 has an invalid endpoint with address 0x0, skipping
usb 1-1: config 129 interface 36 altsetting 3 has a duplicate endpoint with address 0x2, skipping
usb 1-1: config 129 interface 36 altsetting 3 endpoint 0x3 has an invalid bInterval 160, changing to 11
usb 1-1: config 129 interface 36 altsetting 3 has a duplicate endpoint with address 0xB, skipping
usb 1-1: config 129 interface 36 altsetting 3 has a duplicate endpoint with address 0x2, skipping
usb 1-1: config 129 interface 36 altsetting 3 has an invalid endpoint descriptor of length 2, skipping
usb 1-1: config 129 interface 36 altsetting 3 endpoint 0x9 has invalid maxpacket 1024, setting to 64
usb 1-1: config 129 interface 36 altsetting 3 has a duplicate endpoint with address 0x3, skipping
usb 1-1: config 129 interface 36 altsetting 3 has 11 endpoint descriptors, different from the interface descriptor's value: 10
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0x5, skipping
usb 1-1: config 129 interface 5 altsetting 1 endpoint 0x8 has an invalid bInterval 252, changing to 11
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0x5, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0xD, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0xF, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0xF, skipping
usb 1-1: config 129 interface 5 altsetting 1 has an invalid endpoint with address 0x16, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0xF, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0x9, skipping
usb 1-1: config 129 interface 5 altsetting 1 has an invalid endpoint with address 0x0, skipping
usb 1-1: config 129 interface 5 altsetting 1 has a duplicate endpoint with address 0x9, skipping
usb 1-1: config 129 interface 5 altsetting 1 endpoint 0x7 has invalid maxpacket 495, setting to 64
usb 1-1: config 129 interface 51 has no altsetting 0
usb 1-1: config 129 interface 166 has no altsetting 0
usb 1-1: config 129 interface 36 has no altsetting 0
usb 1-1: config 129 interface 5 has no altsetting 0
usb 1-1: string descriptor 0 read error: -22
usb 1-1: New USB device found, idVendor=129b, idProduct=1667, bcdDevice=1f.c4
usb 1-1: New USB device strings: Mfr=1, Product=2, SerialNumber=3