INFO: trying to register non-static key in __icmp

INFO: trying to register non-static key in __icmp_send
Status: upstream: reported syz repro on 2019/03/06 03:02
Reported-by: syzbot+f09d845ad631ed93737b@syzkaller.appspotmail.com
First crash: 356d, last: 28d

Cause bisection: failed (bisect log)

Sample crash report:

INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.1.0-rc2+ #37
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x172/0x1f0 lib/dump_stack.c:113
 assign_lock_key kernel/locking/lockdep.c:786 [inline]
 register_lock_class+0x167e/0x1860 kernel/locking/lockdep.c:1095
 __lock_acquire+0xf9/0x3fb0 kernel/locking/lockdep.c:3582
 lock_acquire+0x16f/0x3f0 kernel/locking/lockdep.c:4211
 __raw_spin_trylock include/linux/spinlock_api_smp.h:90 [inline]
 _raw_spin_trylock+0x62/0x80 kernel/locking/spinlock.c:128
 spin_trylock include/linux/spinlock.h:339 [inline]
 icmp_xmit_lock net/ipv4/icmp.c:219 [inline]
 __icmp_send+0x553/0x1400 net/ipv4/icmp.c:666
 icmp_send include/net/icmp.h:47 [inline]
 __udp4_lib_rcv+0x1fb6/0x2c50 net/ipv4/udp.c:2323
 udp_rcv+0x22/0x30 net/ipv4/udp.c:2482
 ip_protocol_deliver_rcu+0x60/0x8f0 net/ipv4/ip_input.c:208
 ip_local_deliver_finish+0x23b/0x390 net/ipv4/ip_input.c:234
 NF_HOOK include/linux/netfilter.h:289 [inline]
 NF_HOOK include/linux/netfilter.h:283 [inline]
 ip_local_deliver+0x1e9/0x520 net/ipv4/ip_input.c:255
 dst_input include/net/dst.h:450 [inline]
 ip_rcv_finish+0x1e1/0x300 net/ipv4/ip_input.c:414
 NF_HOOK include/linux/netfilter.h:289 [inline]
 NF_HOOK include/linux/netfilter.h:283 [inline]
 ip_rcv+0xe8/0x3f0 net/ipv4/ip_input.c:524
 __netif_receive_skb_one_core+0x115/0x1a0 net/core/dev.c:4973
 __netif_receive_skb+0x2c/0x1c0 net/core/dev.c:5083
 process_backlog+0x206/0x750 net/core/dev.c:5923
 napi_poll net/core/dev.c:6346 [inline]
 net_rx_action+0x4fa/0x1070 net/core/dev.c:6412
 __do_softirq+0x266/0x95a kernel/softirq.c:293
 run_ksoftirqd kernel/softirq.c:655 [inline]
 run_ksoftirqd+0x8e/0x110 kernel/softirq.c:647
 smpboot_thread_fn+0x6ab/0xa10 kernel/smpboot.c:164
 kthread+0x357/0x430 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
kasan: CONFIG_KASAN_INLINE enabled
kasan: GPF could be caused by NULL-ptr deref or user memory access
general protection fault: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.1.0-rc2+ #37
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
RIP: 0010:__ip_append_data.isra.0+0x2e6/0x2dd0 net/ipv4/ip_output.c:898
Code: c7 85 cc fe ff ff 00 00 00 00 0f 85 28 13 00 00 e8 1f 58 93 fb 48 8b 95 38 ff ff ff 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 73 28 00 00 48 8b 85 38 ff ff ff 48 8b 18 48 b8
RSP: 0018:ffff8880aa26f2a0 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff85dd18e1
RDX: 0000000000000000 RSI: ffffffff85dd1961 RDI: 0000000000000001
RBP: ffff8880aa26f410 R08: ffff8880aa25c240 R09: ffffffff85ed76a0
R10: ffff8880aa26f580 R11: ffff888085e15343 R12: ffff8880a660efb0
R13: ffff8880a660f450 R14: 0000000000000000 R15: dead4ead00000000
FS:  0000000000000000(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fcf645a3000 CR3: 0000000090177000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 ip_append_data.part.0+0xf2/0x170 net/ipv4/ip_output.c:1220
 ip_append_data+0x6e/0x90 net/ipv4/ip_output.c:1209
 icmp_push_reply+0x189/0x510 net/ipv4/icmp.c:375
 __icmp_send+0xaa1/0x1400 net/ipv4/icmp.c:737
 icmp_send include/net/icmp.h:47 [inline]
 __udp4_lib_rcv+0x1fb6/0x2c50 net/ipv4/udp.c:2323
 udp_rcv+0x22/0x30 net/ipv4/udp.c:2482
 ip_protocol_deliver_rcu+0x60/0x8f0 net/ipv4/ip_input.c:208
 ip_local_deliver_finish+0x23b/0x390 net/ipv4/ip_input.c:234
 NF_HOOK include/linux/netfilter.h:289 [inline]
 NF_HOOK include/linux/netfilter.h:283 [inline]
 ip_local_deliver+0x1e9/0x520 net/ipv4/ip_input.c:255
 dst_input include/net/dst.h:450 [inline]
 ip_rcv_finish+0x1e1/0x300 net/ipv4/ip_input.c:414
 NF_HOOK include/linux/netfilter.h:289 [inline]
 NF_HOOK include/linux/netfilter.h:283 [inline]
 ip_rcv+0xe8/0x3f0 net/ipv4/ip_input.c:524
 __netif_receive_skb_one_core+0x115/0x1a0 net/core/dev.c:4973
 __netif_receive_skb+0x2c/0x1c0 net/core/dev.c:5083
 process_backlog+0x206/0x750 net/core/dev.c:5923
 napi_poll net/core/dev.c:6346 [inline]
 net_rx_action+0x4fa/0x1070 net/core/dev.c:6412
 __do_softirq+0x266/0x95a kernel/softirq.c:293
 run_ksoftirqd kernel/softirq.c:655 [inline]
 run_ksoftirqd+0x8e/0x110 kernel/softirq.c:647
 smpboot_thread_fn+0x6ab/0xa10 kernel/smpboot.c:164
 kthread+0x357/0x430 kernel/kthread.c:253
 ret_from_fork+0x3a/0x50 arch/x86/entry/entry_64.S:352
Modules linked in:
---[ end trace 61c85886a360a6a0 ]---
RIP: 0010:__ip_append_data.isra.0+0x2e6/0x2dd0 net/ipv4/ip_output.c:898
Code: c7 85 cc fe ff ff 00 00 00 00 0f 85 28 13 00 00 e8 1f 58 93 fb 48 8b 95 38 ff ff ff 48 b8 00 00 00 00 00 fc ff df 48 c1 ea 03 <80> 3c 02 00 0f 85 73 28 00 00 48 8b 85 38 ff ff ff 48 8b 18 48 b8
RSP: 0018:ffff8880aa26f2a0 EFLAGS: 00010246
RAX: dffffc0000000000 RBX: 0000000000000000 RCX: ffffffff85dd18e1
RDX: 0000000000000000 RSI: ffffffff85dd1961 RDI: 0000000000000001
RBP: ffff8880aa26f410 R08: ffff8880aa25c240 R09: ffffffff85ed76a0
R10: ffff8880aa26f580 R11: ffff888085e15343 R12: ffff8880a660efb0
R13: ffff8880a660f450 R14: 0000000000000000 R15: dead4ead00000000
FS:  0000000000000000(0000) GS:ffff8880ae800000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fcf645a3000 CR3: 0000000008871000 CR4: 00000000001406f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400

Fix bisection attempts:
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro
ci-upstream-kasan-gce-smack-root	2020/01/28 00:57	upstream	b1dba247	55684ce1	.config	log	report	syz
ci-upstream-kasan-gce	2019/12/18 21:22	upstream	80a0c2e5	acbc5b7d	.config	log	report	syz
ci-upstream-kasan-gce-smack-root	2019/11/09 19:13	upstream	00aff683	55684ce1	.config	log	report	syz
ci-upstream-kasan-gce-smack-root	2019/08/19 23:54	upstream	a3ac7917	55684ce1	.config	log	report	syz

Crashes (6):
Manager	Time	Kernel	Commit	Syzkaller	Config	Log	Report	Syz repro	Maintainers
ci-upstream-kasan-gce-smack-root	2019/03/26 11:53	upstream	a3ac7917	55684ce1	.config	log	report	syz	davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci-upstream-kasan-gce	2019/03/24 10:41	upstream	1bdd3dbf	acbc5b7d	.config	log	report	syz	davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci-upstream-kasan-gce-386	2019/03/06 01:45	upstream	63bdf428	16559f86	.config	log	report	syz	davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci-upstream-kasan-gce-root	2019/03/18 14:05	upstream	9e98c678	4656beca	.config	log	report		davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci-upstream-net-kasan-gce	2019/06/11 16:51	net-next	48debfd7	5b5826d0	.config	log	report		davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
ci-upstream-net-kasan-gce	2019/03/09 14:15	net-next	d9862cfb	12365b99	.config	log	report		davem@davemloft.net, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, yoshfuji@linux-ipv6.org