syzbot


WARNING: suspicious RCU usage in hsr_node_get_first

Status: upstream: reported C repro on 2022/04/26 02:08
Reported-by: syzbot+d4de7030f60c07837e60@syzkaller.appspotmail.com
First crash: 156d, last: 94d

Cause bisection: introduced by (bisect log) [merge commit]:
commit d589ae0d44607a0af65b83113e4cfba1a8af7eb3
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date: Fri Apr 1 23:20:00 2022 +0000

  Merge tag 'for-5.18/block-2022-04-01' of git://git.kernel.dk/linux-block

Crash: WARNING: suspicious RCU usage in hsr_node_get_first (log)
Repro: C syz .config

Fix bisection: fixed by (bisect log) :
commit f856373e2f31ffd340e47e2b00027bd4070f74b3
Author: Felix Fietkau <nbd@nbd.name>
Date: Tue May 31 19:08:24 2022 +0000

  wifi: mac80211: do not wake queues on a vif that is being stopped

Patch testing requests:
Created Duration User Patch Repo Result
2022/04/26 05:08 14m hdanton@sina.com patch https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/ 22da5264abf4 OK

Sample crash report:
netlink: 'syz-executor371': attribute type 2 has an invalid length.
netlink: 194488 bytes leftover after parsing attributes in process `syz-executor371'.
=============================
WARNING: suspicious RCU usage
5.19.0-rc3-syzkaller-00336-g0840a7914caa #0 Not tainted
-----------------------------
net/hsr/hsr_framereg.c:41 suspicious rcu_dereference_check() usage!

other info that might help us debug this:


rcu_scheduler_active = 2, debug_locks = 1
3 locks held by syz-executor371/3608:
 #0: ffffffff8d629d30 (cb_lock){++++}-{3:3}, at: genl_rcv+0x15/0x40 net/netlink/genetlink.c:802
 #1: ffffffff8d629de8 (genl_mutex){+.+.}-{3:3}, at: genl_lock net/netlink/genetlink.c:33 [inline]
 #1: ffffffff8d629de8 (genl_mutex){+.+.}-{3:3}, at: genl_rcv_msg+0x3e0/0x580 net/netlink/genetlink.c:790
 #2: ffffffff8bd86660 (rcu_read_lock){....}-{1:2}, at: hsr_get_node_list+0xcb/0xa80 net/hsr/hsr_netlink.c:425

stack backtrace:
CPU: 0 PID: 3608 Comm: syz-executor371 Not tainted 5.19.0-rc3-syzkaller-00336-g0840a7914caa #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
 hsr_node_get_first+0xc7/0xe0 net/hsr/hsr_framereg.c:41
 hsr_get_next_node+0x1d0/0x320 net/hsr/hsr_framereg.c:608
 hsr_get_node_list+0x333/0xa80 net/hsr/hsr_netlink.c:461
 genl_family_rcv_msg_doit+0x228/0x320 net/netlink/genetlink.c:731
 genl_family_rcv_msg net/netlink/genetlink.c:775 [inline]
 genl_rcv_msg+0x328/0x580 net/netlink/genetlink.c:792
 netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2501
 genl_rcv+0x24/0x40 net/netlink/genetlink.c:803
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x917/0xe10 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg+0xcf/0x120 net/socket.c:734
 ____sys_sendmsg+0x6eb/0x810 net/socket.c:2492
 ___sys_sendmsg+0xf3/0x170 net/socket.c:2546
 __sys_sendmsg net/socket.c:2575 [inline]
 __do_sys_sendmsg net/socket.c:2584 [inline]
 __se_sys_sendmsg net/socket.c:2582 [inline]
 __x64_sys_sendmsg+0x132/0x220 net/socket.c:2582
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x35/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x46/0xb0
RIP: 0033:0x7f03e40528d9
Code: 28 c3 e8 4a 15 00 00 66 2e 0f 1f 84 00 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fffb7765468 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007fffb7765478 RCX: 00007f03e40528d9
RDX: 0000000000000000 RSI: 0000000020000000 RDI: 0000000000000003
RBP: 0000000000000003 R08: bb1414ac00000000 R09: bb1414ac00000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fffb7765480
R13: 00007fffb7765474 R14: 0000000000000003 R15: 0000000000000000
 </TASK>

Crashes (7):
Manager Time Kernel Commit Syzkaller Config Log Report Syz repro C repro VM info Title
ci-upstream-kasan-gce-root 2022/06/26 14:17 upstream 0840a7914caa a371c43c .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-kasan-gce 2022/04/24 19:12 upstream 22da5264abf4 131df97d .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-net-this-kasan-gce 2022/04/24 19:11 net 165e3e17fe8f 131df97d .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-net-kasan-gce 2022/04/24 19:07 net-next cfc1d91a7d78 131df97d .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-bpf-next-kasan-gce 2022/04/24 19:04 bpf-next fd0493a1e49e 131df97d .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-linux-next-kasan-gce-root 2022/04/24 18:45 linux-next f1244c81da13 131df97d .config log report syz C WARNING: suspicious RCU usage in hsr_node_get_first
ci-upstream-linux-next-kasan-gce-root 2022/04/24 18:33 linux-next f1244c81da13 131df97d .config log report info WARNING: suspicious RCU usage in hsr_node_get_first
* Struck through repros no longer work on HEAD.